summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/frame
Commit message (Collapse)AuthorAgeFilesLines
* Hook up "clear browsing data" dialog. It looks like ass right now. The ↵ben@chromium.org2009-06-181-1/+2
| | | | | | | | | | intent is to be able to debug problems with NativeControls under Gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/131027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when closing an incognito window with a downloadpaul@chromium.org2009-06-162-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | shelf visible. We explicitly remove the download shelf view from the browser view hierarchy during a window close operation. This avoids calling back into the partially deleted view hierarchy with download deleted observer notifications. Explicitly removing the shelf allows the observer notifications to run first while the views are still valid. To reproduce: 1. Launch Chrome 2. Open an incognito window 3. Download something in the incognito window 4. The download shelf should become visible with one entry 5. Close the incognito window 6. Crash BUG=13681 (http://crbug.com/13681) Review URL: http://codereview.chromium.org/126082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18458 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting Rev 18383 since it brings down the performance of single core page ↵mad@chromium.org2009-06-151-2/+1
| | | | | | cyclers too much... git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18385 0039d316-1c4b-4281-b951-d872f2087c98
* This is to thest the page cycler performance without the resize corner, to ↵mad@chromium.org2009-06-151-1/+2
| | | | | | | | | | | | | see if these paint optimizations are worth it. I will revert these changes as needed... You may revert them yourself if they cause you trouble before I get to revert them. I have tested these changes on two different linux configuration, but there are more code paths that I couldn't verify myself, though agl gave me the OK anyway. These changes have already been reviewed here: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18383 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-133-0/+3
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Menu object, converting all the remaining callers to use Menu2. ↵ben@chromium.org2009-06-121-1/+14
| | | | | | | | | | | I'll rename Menu2->Menu afterwards. TEST=none BUG=none Review URL: http://codereview.chromium.org/122027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18315 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-122-6/+10
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Revert mad's backing store changes, it completely hosed Linux painting.deanm@chromium.org2009-06-111-4/+6
| | | | | | | | | This was r18090, reverted in r18092, recommitted without review in 18130. Review URL: http://codereview.chromium.org/122034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18158 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser window crash on windows.thakis@chromium.org2009-06-111-0/+8
| | | | | | | | | | | | | BUG=13681 (http://crbug.com/13681) TEST=Follow these steps -Ctrl+Shift+N to Incognito window. -Download a file -Close the Incognito window after download is finished. Review URL: http://codereview.chromium.org/120001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18151 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding reverted patch 18090.mad@google.com2009-06-111-6/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18130 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18090jrg@chromium.org2009-06-101-4/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18092 0039d316-1c4b-4281-b951-d872f2087c98
* To help resolve the performance issue introduced when enabling the resize ↵mad@google.com2009-06-101-6/+4
| | | | | | | | corner, we now keep all non-intersecting rects separately and send an array of invalidation bitmaps via IPC as opposed to a single unionized rect :-) Review URL: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18090 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Menu2Delegate interface and fold methods onto Menu2Model instead.ben@chromium.org2009-06-092-12/+6
| | | | | | | | | | | | | Enhance SimpleMenuModel::Delegate interface to support additional options required by the above. Make MenuHostWindow process WM_MENUCOMMAND and WM_MENUSELECT - the first so we can determine which index was selected, the second so we can track highlight changes within a menu. Convert Tab's context menu back to the windows native menu. This will make my life easier when I upgrade chrome_menu.cc to the new API if only the bookmarks menus/context menus are using it. BUG=none TEST=page, app menus again, context menu for tabs. open a bunch of tabs, open this page: http://bengoodger.dreamhosters.com/software/chrome/cxmenutest.html, close that tab then right click on the menu quickly. should not crash! Review URL: http://codereview.chromium.org/118426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17996 0039d316-1c4b-4281-b951-d872f2087c98
* Convert toolbar page and app menus over to use the new system.ben@chromium.org2009-06-082-120/+142
| | | | | | | TEST=test page and app menus thoroughly. Review URL: http://codereview.chromium.org/119291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17897 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BrowserToolbarView->ToolbarView to match file name.ben@chromium.org2009-06-062-11/+11
| | | | | | | | | Reorganize functions in CC to match header and related OCD activities. No logic changes. Review URL: http://codereview.chromium.org/118352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17809 0039d316-1c4b-4281-b951-d872f2087c98
* More theme bits for the NTP and window frame.glen@chromium.org2009-06-051-0/+12
| | | | | | | | | BUG=12768,13352 TEST=Verify that a theme with attribution works on the NTP and a theme with an overlay shows up Review URL: http://codereview.chromium.org/119227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17773 0039d316-1c4b-4281-b951-d872f2087c98
* Make the inactive tab background line up with the parent without using magic ↵glen@chromium.org2009-06-041-0/+2
| | | | | | | | | | | numbers. BUG=12761 TEST=Verify that the inactive tab background lines up with the frame image in maximized and unmaximized mode - you will need a heavily patterned theme to test with. Review URL: http://codereview.chromium.org/118221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for DWM crash.glen@chromium.org2009-06-041-1/+2
| | | | | | | | | | BUG=13075 TBR=ben TEST=On XP, verify that Chrome doesn't crash when a theme is installed or reset. Review URL: http://codereview.chromium.org/118252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17652 0039d316-1c4b-4281-b951-d872f2087c98
* Allow WindowGtks to be moved and sized when the mouse is over the caption or ↵ben@chromium.org2009-06-041-9/+8
| | | | | | | | | | sizing border. BUG=none TEST=none Review URL: http://codereview.chromium.org/118218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17608 0039d316-1c4b-4281-b951-d872f2087c98
* Move download shelf from per-tab to per-window. Also disable auto-hiding ofthakis@chromium.org2009-06-042-31/+42
| | | | | | | | | | | | | | the shelf. BUG=9025 TEST=Download file in one tab, open new tab, and check that download shelf is still open. Also try the shelf's close button and the "show all downloads" link. When saving a file, the download animation should not show up. Review URL: http://codereview.chromium.org/115740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of dragging extensions on the shelf. This part was just about ↵erikkay@google.com2009-06-031-1/+3
| | | | | | | | getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release. Review URL: http://codereview.chromium.org/119103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux views build.jcampan@chromium.org2009-06-031-0/+1
| | | | | | | | | BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/118184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17548 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-031-0/+1
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the blue tab titles on GTK by hooking up the browser theme provider to thebrettw@chromium.org2009-06-022-0/+14
| | | | | | | | browser frame. Review URL: http://codereview.chromium.org/118088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17428 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the text of the in-progress download dialog better by special-casing ↵jcampan@chromium.org2009-06-021-5/+24
| | | | | | | | | | the single download case. BUG=11278 TEST=Start a big download, close Chrome. A dialog warning that a download is in progress should be shown. Check that the main text and button text use singular when referring to the download. Start several big downloads. Close Chrome, check the text now uses plural. Review URL: http://codereview.chromium.org/119009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix opaque app mode display.glen@chromium.org2009-06-021-8/+10
| | | | | | | | | | | Changed the app corner images to be the same size as the center image. BUG=12541 TEST=In an opaque app-frame window, verify that the top edge doesn't have a frame-colored space between the drop shadow and the content area. Review URL: http://codereview.chromium.org/118058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17378 0039d316-1c4b-4281-b951-d872f2087c98
* Use the right frame type on startup, do proper swapping of frames when ↵glen@chromium.org2009-05-312-2/+2
| | | | | | | | | | | themes change. Leave the native frame decision up to the ThemeProvider. BUG=12890 TEST=In Aero, unstall a theme, reset to default, install again, restart, reset theme to default. Make sure that the Aero frame changes to the themed frame and back again appropriately. Review URL: http://codereview.chromium.org/118053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by fixing defines not to include windows.ben@chromium.org2009-05-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17286 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-301-0/+6
| | | | | | | | | | | TBR=sky BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17271 Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17285 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17271.ben@chromium.org2009-05-301-6/+0
| | | | | | Review URL: http://codereview.chromium.org/118040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17274 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-301-0/+6
| | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17271 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the status bar size to adapt to the size of the font,mirandac@chromium.org2009-05-291-3/+3
| | | | | | | | | | | | | instead of being a const. BUG= http://crbug.com/1275 TEST=Set Windows XP font size to large or extra-large. Open Chrome. Hover over a link to bring up the status bubble. Text should sit comfortably in bubble, without being squeezed. Review URL: http://codereview.chromium.org/113490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17262 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-292-2/+2
| | | | | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. TBR=finnur Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17257 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a slew of random link/compile errors for views on gtk.sky@chromium.org2009-05-291-1/+9
| | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Revision 17224glen@chromium.org2009-05-292-2/+2
| | | | | | | | | BUG=none TEST=non Review URL: http://codereview.chromium.org/115951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-292-6/+9
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Really theme the find bar. We were previously getting the ↵glen@chromium.org2009-05-292-2/+2
| | | | | | | | | | | DefaultThemeProvider (whose accessor was mistakenly named 'getDIALOGthemeprovider') BUG=11702 TEST=Install a theme and verify that the find bar matches it. Review URL: http://codereview.chromium.org/115729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17224 0039d316-1c4b-4281-b951-d872f2087c98
* This CL is a clean-up of the app_modal_dialog_queue.cc in an attempt to fix ↵jcampan@chromium.org2009-05-281-2/+2
| | | | | | | | | | | | | | a bug 10699. Not sure what is causing the crasher. Hopefully after this clean-up we'll get a different stack-trace that might help. BUG=10699 TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box works. Same with a background browser. Review URL: http://codereview.chromium.org/113932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17078 0039d316-1c4b-4281-b951-d872f2087c98
* Turn BrowserView::GetBrowserViewForNativeView() into ↵davemoore@chromium.org2009-05-282-2/+3
| | | | | | | | | | | GetBrowserViewForNativeWindow() This simplifies things on linux where the native window is not the same type as the native view. Review URL: http://codereview.chromium.org/115830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17043 0039d316-1c4b-4281-b951-d872f2087c98
* Shift maximized mode tabstrip up by 1 px to avoid empty pixel at screen top.pkasting@chromium.org2009-05-282-11/+15
| | | | | | | BUG=12042 Review URL: http://codereview.chromium.org/115838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17042 0039d316-1c4b-4281-b951-d872f2087c98
* Add BrowserView to the Linux build, it now compiles. This also includes a smallbrettw@chromium.org2009-05-271-0/+1
| | | | | | | | namespace change to window_sizer_mac which I noticed when doing a previous change. Review URL: http://codereview.chromium.org/113910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17002 0039d316-1c4b-4281-b951-d872f2087c98
* Removes WidgetWin dependency from StatusBubbleViews so that it can compile ↵ben@chromium.org2009-05-261-1/+1
| | | | | | | | | | | | | | | | on Linux. Requires: - making SetOpacity a cross platform method on Widget, replacing SetLayeredAlpha. - moving Window::SetBounds to Widget - replacing usage of MoveWindow in StatusBubbleViews with call to new SetBounds method. BUG=none TEST=make sure transparency still works for floating widgets like - status bubble, full screen exit bubble, dragged tabs Review URL: http://codereview.chromium.org/113846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16948 0039d316-1c4b-4281-b951-d872f2087c98
* Fleshes out more of BrowserFrameGtk.sky@chromium.org2009-05-268-22/+77
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113873 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16945 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last bits leftover from my frame window experiment.brettw@chromium.org2009-05-261-9/+0
| | | | | | Review URL: http://codereview.chromium.org/113863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16930 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more compilation errors in browser_view.cc and an error I introduced in abrettw@chromium.org2009-05-261-1/+1
| | | | | | | previous change that used the wrong parent variable when showing HTML dialogs. Review URL: http://codereview.chromium.org/113864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16929 0039d316-1c4b-4281-b951-d872f2087c98
* Make most of browser_view compile on Linux.brettw@chromium.org2009-05-261-5/+26
| | | | | | Review URL: http://codereview.chromium.org/115786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16918 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes BrowserView::GetBrowserViewForNativeView on linux.sky@chromium.org2009-05-261-2/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16901 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BrowserView::GetBrowserViewForHWND tosky@chromium.org2009-05-262-9/+21
| | | | | | | | | | | | | GetBrowserViewForNativeView and implements the GTK side. I could have went with NativeWindow here, but we end up with more flexibility if we keep this as NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/113842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16882 0039d316-1c4b-4281-b951-d872f2087c98
* Make hwnd_notification_source portable by making it use NativeWindow (andbrettw@chromium.org2009-05-231-2/+2
| | | | | | | renaming it accordingly). Review URL: http://codereview.chromium.org/115730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16839 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TabContentsContainerView into TabContentsContainer and associated ↵ben@chromium.org2009-05-222-10/+16
| | | | | | | | | | | platform-specific inner classes. BUG=none TEST=make sure web page focus cycling in and out of the content area still works. Review URL: http://codereview.chromium.org/113784 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16810 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 09:46:32 +0000