summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/frame
Commit message (Collapse)AuthorAgeFilesLines
* Make sure the tabstrip doesn't have the chin above it in maximized view in aero.beng@google.com2008-09-111-1/+2
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/2414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grab bag of AeroGlassFrame issues:beng@google.com2008-09-105-21/+22
| | | | | | | | | | | | - better names and documentation for varions kOnstants in the AeroGlassNonClientView - AeroGlassFrame now uses the actual bounds of the tabstrip to adjust the DWM frame, rather than hard-coding constants. - fix bug in hit testing that meant that tabs weren't selectable... wrong coordinate system used for one function call... not sure how this didn't affect XP?!! B=1031854 Review URL: http://codereview.chromium.org/1882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1996 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of quick TODO and other cleanups.beng@google.com2008-09-084-13/+1
| | | | | | | | B=1031854 Review URL: http://codereview.chromium.org/1624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
* Support WM_APPCOMMAND on Window. Make it just pass through to ↵beng@google.com2008-09-082-0/+47
| | | | | | | | | | | | WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it. This allows my mouse's back and forward buttons to work on the new frames. B=1031854 Review URL: http://codereview.chromium.org/1620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1849 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser is destroyed during DestroyBrowser because EndSession ↵beng@google.com2008-09-081-1/+9
| | | | | | | | | handling needs it to be synchronously deleted, rather than by the Window's destruction. B=1031854 Review URL: http://codereview.chromium.org/452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1832 0039d316-1c4b-4281-b951-d872f2087c98
* Readding UI test I pulled yesterday; hopefully the bots will like it more ↵finnur@google.com2008-09-054-0/+29
| | | | | | | | now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. Review URL: http://codereview.chromium.org/473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1809 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the polymorphic WindowResources class and FramePartBitmap enum.maruel@google.com2008-09-042-47/+8
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1710 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include order in aero_glass_frame.cc. This was causing issues with ↵maruel@google.com2008-09-041-2/+2
| | | | | | | | WPO enabled. Review URL: http://codereview.chromium.org/430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1703 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the new frames' BrowserView2::TabSelectedAt calls ↵beng@google.com2008-09-031-1/+5
| | | | | | | | | TabContents::DidBecomeSelected, like Browser::TabSelectedAt does for the old frames. This was causing tab-restore related features (undo close tab, duplicate tab) to result in sad tab being shown when using the magic_browzR switch. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1698 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Google Chrome specific strings from common resources file and use ↵rahulk@google.com2008-08-272-0/+4
| | | | | | | | | them from new resources file that is specific to only Google Chrome. BUG=1110882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1473 0039d316-1c4b-4281-b951-d872f2087c98
* The positioning of detached dragged tabs was wrong with the new frames, ↵beng@google.com2008-08-271-1/+1
| | | | | | | | because I wasn't initializing the value I was passing to RestoreWindowPosition with the specified initial bounds. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1448 0039d316-1c4b-4281-b951-d872f2087c98
* Make the system menu for frames have submenus for encoding and text zoombeng@google.com2008-08-262-11/+40
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1413 0039d316-1c4b-4281-b951-d872f2087c98
* Make the AeroGlassFrame better:beng@google.com2008-08-259-175/+253
| | | | | | | | | | | - client edge rendering is now pixel-perfect for all BrowserTypes. - fix NCCALCSIZE handling that was making our top-right corner less than perfectly round - make system menu work - remove some unnecessary functions B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1340 0039d316-1c4b-4281-b951-d872f2087c98
* Make the window icon the app icon by default for popups and app windows ↵beng@google.com2008-08-241-6/+2
| | | | | | | | | | unless the page specifies a favicon. This ensures that we don't show the default favicon for the window icon. (This is only appropriate for tab icons). Also make sure popup windows opened from app windows are themselves app windows (and don't show the URL bar) B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1293 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-2414-455/+119
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Unrollback r1158.rahulk@google.com2008-08-212-6/+21
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1170 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 1158 as it is breaking ui_testsrahulk@google.com2008-08-212-21/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1165 0039d316-1c4b-4281-b951-d872f2087c98
* Do not display "Google" in titlebar of Chromium builds. rahulk@google.com2008-08-212-6/+21
| | | | | | | | - Create a new resource file that will contain Google Chrome specific resources. Ideally this new resource file should not be in the Chromium project at all but there doesnt seem to be any way to do conditional includes in vcproj files. So we ifdef its contents. - Make distributor logo optional. If we do not find it, we do not try to paint/layout logo. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1158 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popups using the new frames to be sized correctly. This involved a ↵beng@google.com2008-08-201-4/+42
| | | | | | | | | slight tweak to how RestoreWindowPosition on Window works - if the window is opened with specified bounds, we still ask the delegate to try and restore the position. The delegate can use the provided bounds as a hint (in the popup case the bounds aren't the true layout bounds of the window, rather the rect contains the window position and content area size) to return the actual bounds of the window. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1117 0039d316-1c4b-4281-b951-d872f2087c98
* Make the otr avatar icon not show in detached OTR popup windows.beng@google.com2008-08-195-28/+29
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1038 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the window icon for app windows, with a throbber etc.beng@google.com2008-08-188-37/+170
| | | | | | Also add support for OTR icon.B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@992 0039d316-1c4b-4281-b951-d872f2087c98
* Large patch set (159 files total) to cleanup the includes.maruel@google.com2008-08-151-0/+4
| | | | | | | | | | - Slightly reduce the size of the generated .lib files ~3%. - Reduce the number of implicit and explicit atl and windows includes. hooray! - Help incremental build by reducing the number of unnecessary included files. - Split some template class in two, one base class for the common code and the specialization that inherits from the base class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the system menu in new frames.erg@google.com2008-08-144-1/+121
| | | | | | BUG=1319684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@908 0039d316-1c4b-4281-b951-d872f2087c98
* Add End-session handling and app modal dialog handling to BrowserView2/New ↵beng@google.com2008-08-146-8/+80
| | | | | | | | | Frames. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@879 0039d316-1c4b-4281-b951-d872f2087c98
* Copy contents of FrameView into BrowserView2. Once the old frames retire, we ↵beng@google.com2008-08-132-1/+127
| | | | | | | | won't need this separate class. B=1031852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@818 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to remove a pixel gap between the client edge of the toolbars and ↵beng@google.com2008-08-111-7/+11
| | | | | | | | | the client edge of the content area. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@668 0039d316-1c4b-4281-b951-d872f2087c98
* Another Frame Grab-Bagbeng@google.com2008-08-1110-122/+90
| | | | | | | | | | | | | | | - makes more stuff in Browser object only happen if you're using the old frames- rename BrowserWindow::Update to BrowserWindow::UpdateToolbar since that's what it does - add window position save/restore handling to Browser- remove BrowserWindow::BrowserDidPaint - relic from HaloFrame days- remove BrowserWindow::GetRootView - unused and exposes impl details- remove BrowserWindow::DetachFromBrowser - unused - store BrowserView2* on HWND's property list so infobubbles can access it later- both frames (Opaque and AeroGlass) notify the BrowserView2 when they're moved so BrowserView2 can reposition the status bubble and close the autocomplete popup - remove BrowserView2::ShowTabContents - no longer used - remove BrowserView2::ShelfVisibilityChanged - no longer used - remove BrowserView2::SetWindowTitle - never used - remove BrowserView2::ProfileChanged - now called from TabSelectedAt- properly unhook infobars etc when a tab is detached B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@660 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the window icon to be shown in the task bar, Alt+Tab etc.beng@google.com2008-08-091-8/+10
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@614 0039d316-1c4b-4281-b951-d872f2087c98
* Even more tweaks.beng@google.com2008-08-095-11/+51
| | | | | | | | | | - make window icon and title work on app windows - make window title updating sync with the task bar - make Aero Glass frame respect app mode settings - move title formatting routine from TabRenderer into Browser (a more central location) - appearance adjustments for app windows with info bars git-svn-id: svn://svn.chromium.org/chrome/trunk/src@612 0039d316-1c4b-4281-b951-d872f2087c98
* More tweaks to the frames. Provide proper layout for the title bar in app mode.beng@google.com2008-08-084-21/+33
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@605 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to make the opaque frame look better including adding support for app ↵beng@google.com2008-08-087-43/+169
| | | | | | | | windows. Document the constants in the non-client view. Make the OTR frame work. Add a check to browser process that we use to check if we're using the new frames so we can disable various functionality that isn't appropriate. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@573 0039d316-1c4b-4281-b951-d872f2087c98
* More improvements to the frames. Consolidate some of the optional bar ↵beng@google.com2008-08-074-29/+341
| | | | | | | | | (bookmark, info, download) showing/layout, add a notion of supported window features, hook up some accelerator handling goop etc. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@529 0039d316-1c4b-4281-b951-d872f2087c98
* Grab bag of random cleanups, implementation of some more methods, etc. I'm ↵beng@google.com2008-08-059-6/+134
| | | | | | | | going to become more methodical about this soon, I promise. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@377 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustagebeng@google.com2008-08-054-1/+36
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@360 0039d316-1c4b-4281-b951-d872f2087c98
* Add the TabStrip to the BrowserView2. (hooked up for OpaqueFrame only at ↵beng@google.com2008-08-057-3/+94
| | | | | | | | this point). Make non-client hittest logic mostly work. Window is somewhat interactive again. Yay! B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@359 0039d316-1c4b-4281-b951-d872f2087c98
* Add the AeroGlassFrame and AeroGlassNonClientView for Vista.beng@google.com2008-08-056-41/+490
| | | | | | | | Note that AeroGlassFrame needs a NonClientView as well - even though Windows draws most of the frame and its borders, we do some custom rendering in the non-client area, such as the distributor logo, the client edge and toolbar backgrounds. This necessitated allowing Window to support an optional NonClientView. I just jimmied this in for now... can clean up that API later if desired. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@352 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up the new frame (opaque version for XP only, for now).beng@google.com2008-08-048-10/+1675
| | | | | | | | | | | | I've hidden this frame behind a command line switch (--magic_browzR) so as not to destabilize the main browser UI any further. Note that running with this switch is likely buggy, incomplete, crashy, etc. In order to make this work without disrupting a lot of existing code, I've had to make another BrowserView class (temporary) - BrowserView2. This also has to be a BrowserWindow implementor since that's the interface Browser uses to communicate with the UI. BrowserView2 and OpaqueNonClientView are the major new files in this CL, but BrowserView2 is pretty similar to BrowserView. OpaqueNonClientView is the view that renders the titlebar/borders/etc. It's layout/painting routines are a bit simpler than XPFrame's! B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@329 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the BrowserView to the XPFrame/VistaFrame, and moves the ↵beng@google.com2008-08-013-43/+167
| | | | | | | | | | | | | | | | | | | | BrowserToolbarView and StatusBubble into it. Also restructures the creation of the Frame. This is significant! The Browser now constructs a frame via a new static BrowserWindow::CreateBrowserWindow method (see browser_window_factory.cc). Recall the diagram in the architectural overview doc - the BrowserView object is the one that implements the interface that the Browser object uses to communicate with the UI. The Browser object communicates to the BrowserView directly through this interface, but not directly to the frame. What actually happens right now in CreateBrowserWindow is that an XP/VistaFrame is constructed, but this is _not_ the object returned to the Browser, rather when the XP/VistaFrame is init'ed, it constructs a BrowserView that also implements BrowserWindow. This is the object that's returned to the Browser. Since both BrowserView and XP/VistaFrame implement BrowserWindow, I am now able to gradually migrate functionality from the frames to BrowserView. During this process BrowserWindow functions not handled yet by BrowserView will be forwarded to the appropriate frame. Modifies the Accessibility UI tests to account for this extra level of indirection (should only be temporary while I'm moving things around). This does actually pass the UI tests. See the whiteboard in my office for a diagram. This is a bit confusing right now since there's so much going on. Sadly the only way to get where we need to go incrementally is to make a mess on the way. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserView implement the BrowserWindow interface so we can start ↵beng@google.com2008-08-012-1/+201
| | | | | | | | moving frame functionality into it. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out the files to be used for the new browser frame.beng@google.com2008-07-3111-0/+629
B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 21:29:50 +0000