summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/jsmessage_box_dialog.h
Commit message (Collapse)AuthorAgeFilesLines
* views: Rename JavaScriptMessageBoxDialog to JSModalDialogViews so it matches ↵tfarina@chromium.org2010-09-291-63/+0
| | | | | | | | | | | | | with cocoa and gtk. In the refactor in http://codereview.chromium.org/3398015 it seems that was missed. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3384036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60906 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialog to more clearly isolate platform specific UI pieces ↵ben@chromium.org2010-09-281-15/+15
| | | | | | | | | | | and eliminate the dependency on individual frontends from cross platform code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3398015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* windows: Move mouse pointer automatically to the default button in a dialog box.tfarina@chromium.org2010-05-301-4/+5
| | | | | | | | | | BUG=2811 TEST=open gmail account, click on "Empty trash messages", the mouse should goes automatically to the default "OK" button. Review URL: http://codereview.chromium.org/1550009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48577 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r44125aa@chromium.org2010-04-091-0/+1
| | | | | | | | BUG=40439 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44132 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt fix for crash bug when alert closes while owning hostaa@chromium.org2010-04-091-1/+0
| | | | | | | | | | | | is invalid. I can't actually repro this bug, but I think this should fix it. BUG=40439 Review URL: http://codereview.chromium.org/1540024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44125 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored out JS specific part of modal dialog stack into its own class, ↵zelidrag@chromium.org2010-02-051-17/+12
| | | | | | | | | | | exposed cookie/storage prompt as a modal dialog. BUG=32719 TEST=none, requires Darin to hook this with his code. Review URL: http://codereview.chromium.org/560030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38268 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window.alert() and its cousins for extensions.pam@chromium.org2009-11-061-3/+3
| | | | | | | | | | | | Second try, now with fixed observer. BUG=12126 TEST=put a window.prompt() in a background page, a browser action, and a page action. Make sure it gets the result back correctly. Also make sure it still works when called from a web page. Review URL: http://codereview.chromium.org/373006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31110 - Implement window.alert() and its cousins for extensions.ben@chromium.org2009-11-051-3/+3
| | | | | | | | | | | | | BUG=12126 TEST=put a window.prompt() in a background page, a browser action, and a page action. Make sure it gets the result back correctly. Also make sure it still works when called from a web page. Review URL: http://codereview.chromium.org/341089 TBR=pam@chromium.org Review URL: http://codereview.chromium.org/360063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31126 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window.alert() and its cousins for extensions.pam@chromium.org2009-11-051-3/+3
| | | | | | | | | | BUG=12126 TEST=put a window.prompt() in a background page, a browser action, and a page action. Make sure it gets the result back correctly. Also make sure it still works when called from a web page. Review URL: http://codereview.chromium.org/341089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31110 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying consecutive alerts from plugins should not hang the browser. The ↵ananta@chromium.org2009-05-151-0/+1
| | | | | | | | | | | | | | | | | | plugins display alerts via the NPN_Evaluate API. The browser signals an event handle to ensure that the plugin starts peeking for messages while waiting for the NPN_Evaluate call to return. When the dialog is dismissed by the user, windows does send some messages to the plugin window underneath, like activation messages, etc. These don't get dispatched as the event is reset when the dialog is dismissed, i.e. much before the window is actually destroyed. The fix is to reset the event handle after the window is actually destroyed. To achieve this I added an OnClose virtual function to the DialogDelegate interface, which is overridden by the JavascriptMessageBoxDialog class which eventually ensures that the event is reset. This fixes http://code.google.com/p/chromium/issues/detail?id=10799 I updated the AlertInWindowMessage npapi test to display two alerts instead of one. Bug=10799 Review URL: http://codereview.chromium.org/113464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16172 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-3/+3
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r14146 which refactors DialogButton into cross platformtc@google.com2009-04-211-1/+2
| | | | | | | | | | code. This is the same as the last change except I renamed class MessageBox to class MessageBoxFlags to avoid conflicting with the same name in windows.h. Review URL: http://codereview.chromium.org/87065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-211-2/+1
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-211-1/+2
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.tc@google.com2009-04-071-0/+64
JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac. AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view. The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text. Review URL: http://codereview.chromium.org/63033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 03:52:26 +0000