summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/options
Commit message (Collapse)AuthorAgeFilesLines
* Renaming the class ShelfItemDialog to URLPicker, and ShelfItemDialogDelegate ↵thakis@chromium.org2009-08-102-7/+6
| | | | | | | | | | | to URLPickerDelegate. BUG=None TEST=None Review URL: http://codereview.chromium.org/164149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22895 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sync options group from "user Data" tab to "Personal Stuff" tab and ↵munjal@chromium.org2009-08-075-287/+190
| | | | | | | | | | | remove the "User Data" tab. BUG=none TEST=none Review URL: http://codereview.chromium.org/165105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22742 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-061-2/+2
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-061-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include path for header file to fix sync build.tim@chromium.org2009-08-051-1/+1
| | | | | | | I'll hold off committing until Idan lets me know I didn't butcher anything else, too :) Review URL: http://codereview.chromium.org/165004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22546 0039d316-1c4b-4281-b951-d872f2087c98
* Add files to browser/sync and tweak includes.tim@chromium.org2009-08-053-4/+278
| | | | | | | | | | | | | Create browser/sync/glue and /engine. Create sync watchlist and add a few folks. No GYP change here so no build changes should occur. chrome.gyp CL is coming shortly, as well as live_sync tests. Review URL: http://codereview.chromium.org/160598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22454 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Get Themes" button to gtk options dialog.estade@chromium.org2009-07-311-11/+3
| | | | | | | | BUG=17641 Review URL: http://codereview.chromium.org/160416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22174 0039d316-1c4b-4281-b951-d872f2087c98
* Fix running default browser check/setting in UI thread on Linux.mattm@chromium.org2009-07-282-132/+14
| | | | | | | | | | | | Rename shell_integration.cc to shell_integration_win.cc, so shell_integration.cc can be used for cross-platform stuff. Move DefaultBrowserWorker from GeneralPageView to ShellIntegration. BUG=17179 Review URL: http://codereview.chromium.org/160218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21794 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor out language models for linux gtk views preparationmhm@chromium.org2009-07-281-155/+2
| | | | | | | | | | | There are models and an language array that are needed for the linux gtk views afaik. So extracting the classes from the windows specific code into separate files would allow code reusabiliy. BUG=13524 TEST=Windows Language Dialog functions properly. Review URL: http://codereview.chromium.org/151138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21787 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to themes gallery.glen@chromium.org2009-07-242-5/+29
| | | | | | | | | BUG=16381 TEST=Go to second page of options, verify that the 'Get themes' button opens a new tab and takes you to the themes gallery. Review URL: http://codereview.chromium.org/160081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21510 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk cookie manager part 1.mattm@chromium.org2009-07-221-219/+1
| | | | | | | | | | | | (Doesn't display cookie details, otherwise working.) BUG=11507 TEST=All cookie manager functions should work as expected, other than viewing the cookie details. Review URL: http://codereview.chromium.org/159187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21307 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view.jcampan@chromium.org2009-07-217-10/+15
| | | | | | | | BUG=None TEST=Make sure the Options dialog still works as expected (tab selection, focus traversal...) Review URL: http://codereview.chromium.org/155668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21189 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetAllLogins to GetAllBlacklistLogins.stuartmorgan@google.com2009-07-202-6/+4
| | | | | | | | | BUG=none TEST=accessing the list of passwords and password blacklists should still work. Review URL: http://codereview.chromium.org/149778 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21100 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ResolveMetricsReportingEnabled logic to OptionsUtil, make gtk ↵mattm@chromium.org2009-07-151-24/+2
| | | | | | | | | | | | | | | options use it. Only show the reporting checkbox in Google Chrome builds. Show the restart required message box when changing the reporting setting. BUG=11507 TEST=on Chromium build, option should not show up. On Google Chrome build in should show up, and enable both crash reporting and metrics settings. Review URL: http://codereview.chromium.org/149665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20796 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a message box to confirm if the user really wants to delete all storedhclam@chromium.org2009-07-141-1/+11
| | | | | | | | | | | passwords. Original CL: http://codereview.chromium.org/155291 Patch contributed by: thiago.farina@gmail.com Review URL: http://codereview.chromium.org/155513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20658 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for tfarinaglen@chromium.org2009-07-121-3/+7
| | | | | | | | | | | | | | | | | | | Original CL: http://codereview.chromium.org/155060 This patch changes the behavior of clear search button in cookies_view to work as in firefox. When the dialog is launched the clear search button in the old cookie_view the state of this button is enabled, but the text field is empty, so the correct behavior is make the button disabled. Only when the user start typing in the text field, the clear button will be enabled. BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20470 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for tfarinaglen@chromium.org2009-07-122-8/+23
| | | | | | | | | | | | | | | | Original CL: http://codereview.chromium.org/155059 A patch to make the grid column (table_view) of the passwords_page_view and exceptions_page_view have the same size. Without this, the table_view of exceptions_page_view has a width bigger than the passwords_page_view. BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20469 0039d316-1c4b-4281-b951-d872f2087c98
* Add the rest of the password manager API to PasswordStore, and move clientsstuartmorgan@chromium.org2009-07-104-51/+35
| | | | | | | | | | | | off of WebDataService. The methods are unimplemented on the Mac for the moment, and do passthroughs to WDS on Windows as with the rest of the Windows PasswordStore interface. BUG=none TEST=Saving, viewing, and deleting password should still work on Windows. Review URL: http://codereview.chromium.org/155259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20441 0039d316-1c4b-4281-b951-d872f2087c98
* Removing an unused variable from cookies_view.hdeanm@chromium.org2009-07-081-5/+4
| | | | | | | | | Patch by Thiago Farina. Review URL: http://codereview.chromium.org/155078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20141 0039d316-1c4b-4281-b951-d872f2087c98
* Change the use of typedef Language in Spell Check files back to std::string. ↵sidchat@google.com2009-07-071-1/+1
| | | | | | | | | | It is unnecessary, and is conflicting with enum Language definition for compact language detection library. BUG=none TEST=none Review URL: http://codereview.chromium.org/150139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20042 0039d316-1c4b-4281-b951-d872f2087c98
* move the ResetToDefault function for prefs to chrome/browser/options_utilmattm@chromium.org2009-06-261-54/+2
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19390 0039d316-1c4b-4281-b951-d872f2087c98
* Replace std:;wstring with std::string and string16 in locale-name related APIs.jshin@chromium.org2009-06-243-13/+15
| | | | | | | | | | | | | | | 1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly. 2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring. This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. BUG=8647 (http://crbug.com/8647) TEST=Pass l10n_util_unittest and other unit tests Review URL: http://codereview.chromium.org/126223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
* We were hitting a DCHECK when removing a password in the password option panel.jcampan@chromium.org2009-06-241-4/+6
| | | | | | | | | | | This is a regression introduced by a recent change that fixed another bug. The problem was that we were not dealing with the empty selection case in the password table. BUG=http://crbug.com/15215 TEST=Open the "show saved password" dialog in the options. Move the selection around. Delete a password. Show a password, then move the selection, the password should not be shown anymore. Review URL: http://codereview.chromium.org/147104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19176 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Thiago Farina bug fix for the saved password dialog.jcampan@chromium.org2009-06-222-6/+18
| | | | | | | | | | | See http://codereview.chromium.org/125239 BUG=7863 TEST=See bug TBR=ben Review URL: http://codereview.chromium.org/142001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18918 0039d316-1c4b-4281-b951-d872f2087c98
* Fonts and Languages Linux GTK Preparationmhm@chromium.org2009-06-222-8/+45
| | | | | | | | | | | Rearranged the windows and mac ports to use the cross platform interfaces. Updated windows fonts and languages to use those interfaces. As well, created stubs for mac platform. BUG=13524 (http://crbug.com/13524) TEST=Open a webpage with a textfield, right click and choose Spell checker options > Language Settings. Tested this on windows as well. Review URL: http://codereview.chromium.org/140043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18900 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Personal Stuff options tab pagemhm@chromium.org2009-06-161-5/+0
| | | | | | | | | | | The popup variable declarations are not needed anymore since they were removed . BUG=none TEST=page functions correctly Review URL: http://codereview.chromium.org/126102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18530 0039d316-1c4b-4281-b951-d872f2087c98
* Move TableModel out of views/ and into app/.estade@chromium.org2009-06-169-54/+51
| | | | | | | | | Remove stub implementation in temp_scaffolding_stubs.h Use l10n_util collator helper function in TableModel::Compare Review URL: http://codereview.chromium.org/126184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18518 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-163-3/+6
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Removed mixed content options. Turns out extremely few users changed the ↵abarth@chromium.org2009-06-161-95/+1
| | | | | | | | | | | | default. R=beng BUG=None TEST=Go to options dialog and notice that the mixed content option is gone. Review URL: http://codereview.chromium.org/126106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18479 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-132-0/+2
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a layout bug in the fonts and languages dialog wheretc@google.com2009-06-111-13/+7
| | | | | | | | | | | | | | | buttons get cut off on the right side of the dialog. Instead of sizing the label text based on a constant from the localized resources, use the default text size (no-multiline text). I also tightened up the font preview box to just use the size of the text + a constant padding on all sides. BUG=13366 Review URL: http://codereview.chromium.org/125013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18217 0039d316-1c4b-4281-b951-d872f2087c98
* Implement different radio groups for Options > Personal Stuffmhm@chromium.org2009-06-092-8/+9
| | | | | | | | | | | | | | Passwords and Form autofill share the same group, they need to be treated separately. It did not work correctly, when "password" radio option was chosen,two of "form autofill" radio option both change to blank(not selected). This patch will properly create different radio groups for passwords and autofill. BUG=13222 (http://crbug.com/13222) TEST=Radio buttons now function propertly TBR=ben Review URL: http://codereview.chromium.org/119347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17932 0039d316-1c4b-4281-b951-d872f2087c98
* Form Autofil Options should be a radio groupmhm@chromium.org2009-06-092-84/+64
| | | | | | | | | | | | The Form Autofil is currently just a checkbox. To fit the chomium design, we prefer radios for single questions because it a bit clearer which choice you choose. As well, we merged import data and clear browsing data into browsing data since the page was getting a bit long. BUG=13222 (http://crbug.com/13222) TEST=Tested the options pane, the form autofil worked as expected. Review URL: http://codereview.chromium.org/119146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17926 0039d316-1c4b-4281-b951-d872f2087c98
* UI Support for Auto Spell Correct. Currently, it is still under the command ↵sidchat@google.com2009-06-032-1/+37
| | | | | | | | line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box. Review URL: http://codereview.chromium.org/119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17528 0039d316-1c4b-4281-b951-d872f2087c98
* Make Combobox portableben@chromium.org2009-06-029-93/+92
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113991 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17382 0039d316-1c4b-4281-b951-d872f2087c98
* Now that themes are enabled by default, the option should be visible by default.glen@chromium.org2009-05-311-9/+4
| | | | | | | | | BUG=none TEST=Verify that you can see the option to reset your theme in the second tab of the options dialog. Review URL: http://codereview.chromium.org/112079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17302 0039d316-1c4b-4281-b951-d872f2087c98
* Split out the views table functions into separate header files. Many users onlybrettw@chromium.org2009-05-318-3/+16
| | | | | | | | | | | | | | need either the view or model observers and that's it. I moved the model constructors to a .cc file so we don't have to include l10n_util.h for everybody. A surprising number of files were getting l10n_util from the table code, so I had to add it in a bunch of places. There should be no code change except I made the table column cosntructors take wstring references instead of copies. Review URL: http://codereview.chromium.org/115969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17295 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "User Data" tab to the options, remove the "minor tweaks" tabmhm@chromium.org2009-05-303-378/+487
| | | | | | | | | | | | Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. RELANDING http://codereview.chromium.org/113896 TBR=ben Review URL: http://codereview.chromium.org/115971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 17288 - Test failures.mhm@chromium.org2009-05-303-489/+378
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/115968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17289 0039d316-1c4b-4281-b951-d872f2087c98
* Create a "User data" tab and remove the "minor tweaks" tab. The mockup is ↵mhm@chromium.org2009-05-303-378/+489
| | | | | | | | | | | | | included in the issue. Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. BUG=11435 (http://crbug.com/11435) TEST=Opened the option dialog and checked if functional. Review URL: http://codereview.chromium.org/113896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17288 0039d316-1c4b-4281-b951-d872f2087c98
* Add general options page. Options are working with the following exceptions:tc@google.com2009-05-282-46/+3
| | | | | | | | | | | | | | | | | | | Custom start urls and default search options widgets aren't hooked up. Home page settings work, but are overridden by the linux start page settings. Default browser checking/setting functions are not implemented, so the option isn't useful yet. Refactors some common code out of browser/views/options/options_page_view.* into browser/options_page_base.{cc,h} BUG=11507 Patch by Matt Mueller (mattm@google.com). Review URL: http://codereview.chromium.org/113967 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17115 0039d316-1c4b-4281-b951-d872f2087c98
* Make Textfield more portable.ben@chromium.org2009-05-282-3/+3
| | | | | | | | | | | | | Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface. The APIs aren't perfectly tidy yet but this is a good first pass. BUG=none TEST=make sure you can still edit text fields, run the view unit tests. Review URL: http://codereview.chromium.org/113940 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17112 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove DevTools from options UI.pfeldman@chromium.org2009-05-281-74/+0
| | | | | | Review URL: http://codereview.chromium.org/113951 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17073 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_field.cc and rename the class to Textfield in preparation for porting.ben@chromium.org2009-05-277-51/+49
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17014 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide ↵pfeldman@chromium.org2009-05-271-5/+76
| | | | | | | | developer tools by default. Review URL: http://codereview.chromium.org/117003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16984 0039d316-1c4b-4281-b951-d872f2087c98
* Show Unicode IDNs for "On startup" setting and "Add page" dialog for it.jungshik@google.com2009-05-271-1/+4
| | | | | | | | | | | | | | | | | TEST=visit an IDN URL, and open the "Basics" tab of the "Options" dialog, select "Open the following pages", press "Add..." button, select the IDN URL, and confirm that the URL field is shown in Unicode, or paste a Punycode URL to the URL field of the "Add page" dialog, press "Add" button, and confirm that the "Open the followig pages" list shows the Unicode URL. http://crbug.com/3991 Patch by tkent Original review: http://codereview.chromium.org/115759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16974 0039d316-1c4b-4281-b951-d872f2087c98
* Move more dialog showing routines to browser_dialogs.h to reduce dependenciesbrettw@chromium.org2009-05-221-0/+9
| | | | | | | and make this file easier to port. Review URL: http://codereview.chromium.org/113778 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16798 0039d316-1c4b-4281-b951-d872f2087c98
* - Passing correct window handle to CreateChromeWindow(). We should pass thehbono@chromium.org2009-05-227-18/+10
| | | | | | | | | | | | | | | | | | | | handle of "Fonts and Languages" window to the function, but currently, a handle of a widget inside the window is passed. - Remove GetRootWindow() method from options_page_view.h since the function returns HWND and thus isn't portable. We can simply use GetWindow()->GetNativeWindow() instead. BUG=10923 TEST=Open "Languages" dialog (Options - Minor Tweaks - Change font and language settings - Languages tab - Add), then press Alt+Tab to switch to an another application, press Alt+Tab again to switch back to chromium, press "Cancel" on the dialog and verify that the "Fonts and Languages" window is focused. Original patch created by Yusuke Sato. http://codereview.chromium.org/93097 R=me,ben Review URL: http://codereview.chromium.org/115687 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16749 0039d316-1c4b-4281-b951-d872f2087c98
* Make views/ depend only on images from app/resources.ben@chromium.org2009-05-212-2/+2
| | | | | | | | | | Trying this again. All compile issues should be addressed, ui and unit tests now pass. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16677 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make TextField::Controller implementors cross-platform by abstractingbrettw@chromium.org2009-05-214-17/+11
| | | | | | | | | | | | | | away the keystroke message that is passed. It turns out implementoars only ever check for enter and escape messages, so I wrote two functions in TextField that will decode the new Keyboard event. This design is not optimal. Ideally we would have something more like the WebInputEvent so that callers can check for anything in a cross-platform way. This was branched off from the original review: http://codereview.chromium.org/113639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16577 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 06:05:22 +0000