summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/tabs
Commit message (Collapse)AuthorAgeFilesLines
* Merge two TabContents::InvalidateTypes types and properly update tab ↵estade@chromium.org2009-05-061-5/+1
| | | | | | | | | | | | download icon. INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code. TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear. Review URL: http://codereview.chromium.org/109050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15387 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-062-4/+4
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
* move chrome_font to app/gfxben@chromium.org2009-05-061-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15367 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome_canvas to app/gfxben@chromium.org2009-05-066-6/+6
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15361 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-053-3/+3
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Move *Animation to app/ben@chromium.org2009-05-054-6/+6
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-051-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-054-4/+4
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression that the sad tab favicon is not displayed when a tab crashes.brettw@chromium.org2009-05-041-1/+5
| | | | | | | | | | | | | | This regressed in my favicon/title updating change because the crashed state is not updated on the codepath, since it comes from the tab. The other approach would have been to make this call through the "update everything" codepath for tbe state changing, but that's executed on a timer, and it's nice to show the tab crash right away since the check is very inexpensive. BUG=http://crbug.com/10756 Review URL: http://codereview.chromium.org/99341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-042-2/+2
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r15177ben@chromium.org2009-05-041-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15182.ben@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/101024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15186 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix:ben@chromium.org2009-05-041-1/+1
| | | | | | | | | | Add back these files which I removed earlier since Linux is using them. The resources are duplicate until I collapse them into src/app/ later this week. Review URL: http://codereview.chromium.org/100320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15182 0039d316-1c4b-4281-b951-d872f2087c98
* Extract all views resources into:ben@chromium.org2009-05-041-0/+1
| | | | | | | | | | | | | views_strings.[grd,vcproj] views_resources.[grd,vcproj] Moves views images (.png files) from app/theme to views/resources dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
* People should just use GetWindow() instead of calling GetWidget()->GetWindow()ben@chromium.org2009-05-013-7/+5
| | | | | | Review URL: http://codereview.chromium.org/102020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15022 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this, it was missing the Mac unit-test change, that was breaking ↵jcampan@chromium.org2009-04-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | the build. TBR=ben Closing the last tab with a download in-progress would cause the tab to be closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/100210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14948.jcampan@chromium.org2009-04-301-2/+0
| | | | | | | | | Broke the Mac build. TBR=ben Review URL: http://codereview.chromium.org/99224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14949 0039d316-1c4b-4281-b951-d872f2087c98
* Closing the last tab with a download in-progress would cause the tab to bejcampan@chromium.org2009-04-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/99195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14948 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in dragging tabs. Specifically if you only have one windowsky@chromium.org2009-04-291-1/+1
| | | | | | | | | | | | | | | with one tab, drag the tab, and while dragging click and release the right mouse button we get all confused. This is because we get two OnMousePressed events in a row, which results in cancelling out the current drag which doesn't work well when only one tab with one window is left. BUG=10800 TEST=see bug Review URL: http://codereview.chromium.org/100169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14870 0039d316-1c4b-4281-b951-d872f2087c98
* Two changes:sky@chromium.org2009-04-293-5/+7
| | | | | | | | | | | | . Removes MoveToFront on Widget. . CHanges AsWindow to GetWindow. BUG=none TEST=none Review URL: http://codereview.chromium.org/99133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14868 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Tab1Tab2, as it's flaky.evan@chromium.org2009-04-281-1/+2
| | | | | | | | BUG=10941 Review URL: http://codereview.chromium.org/99138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14751 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tabs.createWindow extension api call. Required: (a) new ↵rafaelw@chromium.org2009-04-282-0/+12
| | | | | | | | | | | RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h BUG=11092: R=aa,mpComplete,darin,pkasting Review URL: http://codereview.chromium.org/79070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14710 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the use of Windows-specific types for accessibility roles and states ↵klink@chromium.org2009-04-284-8/+6
| | | | | | | | in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation. Review URL: http://codereview.chromium.org/93085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14689 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a gcc-4.3 warning in tab_strip_gtk.cc.jhawkins@chromium.org2009-04-271-9/+1
| | | | | | | | | | | | | | | | | | | Also factorizes some code in tab_strip.cc and tab_strip_gtk.cc. One of the inlined call to GenerateStartAndEndWidths with end_tab_count = start_tab_count - 1 caused line 164 to be rewritten as: if (start_tab_count < start_tab_count - 1 && which raised the following warning with gcc-4.3: tab_strip_gtk.cc:164: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false patch by vincent.zanotti@gmail.com <http://codereview.chromium.org/99031> R=me Review URL: http://codereview.chromium.org/100045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14613 0039d316-1c4b-4281-b951-d872f2087c98
* Use the NotificationRegistrar for the remaining TAB_CONTENTS_DESTROYEDbrettw@chromium.org2009-04-242-9/+10
| | | | | | | notifications to see if it can fix a crash. Review URL: http://codereview.chromium.org/92129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14433 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TabDraggingTest.Tab1Tab3 due to flakiness.dglazkov@chromium.org2009-04-241-1/+2
| | | | | | | | | | TBR=ben BUG=10941 TEST=0 Review URL: http://codereview.chromium.org/93098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14425 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-181-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-181-2/+2
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 5729 - RTL: TabStrip context menu should be positioned ↵xji@chromium.org2009-04-161-1/+4
| | | | | | | | | | | | | properly, If window is not maxmized. (http://crbug.com/5729). The fix is to popup tabstrip context menu from the left of the click in RTL UI. Without the fix, tabstrip context menu always popup from the right of the click. Review URL: http://codereview.chromium.org/73021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13888 0039d316-1c4b-4281-b951-d872f2087c98
* ad an argument to MoveTabContentsAt() that switches whether the moved tab is ↵rafaelw@chromium.org2009-04-161-2/+3
| | | | | | | | set as the selected tab, or if the selected tab is left selected (but possibly moved). Review URL: http://codereview.chromium.org/63153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13823 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContnetsType from everywhere.brettw@chromium.org2009-04-152-45/+9
| | | | | | | | I also removed the notion of the "active" tab contents since there is only one per tab now, and all the messages to replace them. Review URL: http://codereview.chromium.org/67173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13808 0039d316-1c4b-4281-b951-d872f2087c98
* For some Indian locales, the automatic font fallback by Windows UI ↵jungshik@google.com2009-04-151-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale). It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch). For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used. For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150. When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY. While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner. The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac. TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same. 2.UI test in en-US locale should pass. 3. Running UI tests under Purify should not have any new leak. BUG=7319 Review URL: http://codereview.chromium.org/62064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98
* Added undo tab closing item to Tab menu.idanan@chromium.org2009-04-141-0/+2
| | | | | | Review URL: http://codereview.chromium.org/62151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13662 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land popup routing fix for browser.ben@chromium.org2009-04-071-1/+1
| | | | | | | | | | Just the bugfix + test now. Test is disabled pending a working framework. http://crbug.com/8472 Review URL: http://codereview.chromium.org/59007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13282 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify the documentation for loading_only on TabRenderer::UpdateData.brettw@chromium.org2009-04-071-3/+3
| | | | | | Review URL: http://codereview.chromium.org/63029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13256 0039d316-1c4b-4281-b951-d872f2087c98
* Make the throbber throb sooner after you navigate. This fixes the new tab page,brettw@chromium.org2009-04-045-14/+23
| | | | | | | | | | | | | | which would not start throbbing until the load committed. I think this was always broken, but switching the tab contents types covered it up. Now I have a flag that goes along with the tab updating that indicates if it's a load update or a full update. This is necessary to avoid updating the title to the page's URL until it does actually commit. BUG=9310 Review URL: http://codereview.chromium.org/60066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13131 0039d316-1c4b-4281-b951-d872f2087c98
* Record new tab button presses.glen@chromium.org2009-03-311-1/+3
| | | | | | Review URL: http://codereview.chromium.org/56049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12896 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in automation. Remove WaitForTabCountToChange.phajdan.jr@chromium.org2009-03-301-19/+7
| | | | | | | | | | WaitForTabCountToBecome is easier to use and more reliable. Also removed Windows2000-specific code from accessibility unit tests. Review URL: http://codereview.chromium.org/45070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12774 0039d316-1c4b-4281-b951-d872f2087c98
* Allow live tabs to be dragged out of a window. Change TabStripModel such thatpinkerton@chromium.org2009-03-261-2/+4
| | | | | | | the caller must now explicitly show the newly created browser rather than it happening automatically. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12550 0039d316-1c4b-4281-b951-d872f2087c98
* Move controls into their own dir under chrome/views/controlsben@chromium.org2009-03-175-8/+8
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
* Move windowing related objects into chrome/views/window subdir.ben@chromium.org2009-03-172-4/+4
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/42272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
* Move widget related files into views/widgetben@chromium.org2009-03-176-7/+8
| | | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11811 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the Button API to be saner in preparation for NativeControl ↵ben@chromium.org2009-03-166-33/+37
| | | | | | | | rejiggering.BaseButton->Button, CustomButtonButton->ImageButtonToggleButton->ToggleImageButtonRemoving SetListener (buttons take listener through ctor)Tidy up source files. No functionality changes, just naming and organization.Look at the button classes first, then everything else. Review URL: http://codereview.chromium.org/46096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11799 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-161-1/+0
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-142-3/+6
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/46079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11699 0039d316-1c4b-4281-b951-d872f2087c98
* rollback againben@chromium.org2009-03-142-6/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11696 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-142-3/+6
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11695 0039d316-1c4b-4281-b951-d872f2087c98
* revertben@chromium.org2009-03-132-6/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11671 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-132-3/+6
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11668 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 19:53:15 +0000