summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/tabs
Commit message (Collapse)AuthorAgeFilesLines
* Nukes changing the size of the icon on hover, and instead changessky@chromium.org2010-03-161-13/+10
| | | | | | | | | | | | the size of the icon when the tab is in the background and the title changes. BUG=37333 TEST=none Review URL: http://codereview.chromium.org/974003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41767 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-148-9/+9
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by removing unused variableben@chromium.org2010-03-101-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41127 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Correct shapes for side tabs.ben@chromium.org2010-03-107-26/+188
| | | | | | | | | | | | | 2. Adjust transparency of background tabs a little. 3. Implement loading animation for side tabs. 4. Deeper shadow for side tabstrip between browser view and side tabstrip. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/610002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41125 0039d316-1c4b-4281-b951-d872f2087c98
* Replace lots of "int x, int y" with gfx::Point. Also use gfx::Size and ↵pkasting@chromium.org2010-03-083-12/+12
| | | | | | | | | | gfx::Rect in a few more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/669130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
* Implements mini-tab support for linux.sky@chromium.org2010-03-051-0/+1
| | | | | | | | | BUG=36797 TEST=make sure pinned tabs work on linux. Review URL: http://codereview.chromium.org/669163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40767 0039d316-1c4b-4281-b951-d872f2087c98
* Removes tab overview related classes and renames TabOverviewTypes tosky@chromium.org2010-02-2216-2774/+0
| | | | | | | | | | | WmIpc. BUG=none TEST=none Review URL: http://codereview.chromium.org/646079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39604 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this. The first attempt failed becausesky@chromium.org2010-02-194-59/+107
| | | | | | | | | | | | | | | | | | View::MirroredX is defined inline in the .cc, which apparently means gcc won't export it for callers outside of view.cc. Changes the rendering of mini-tabs slightly: . the icons of mini-tabs scales up to 24x24 on mouse over. . phantom tabs are rendered in their own layer behind other tabs at 40% opacity. The icon for phantom tabs are rendered at 60% opactiy. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/650066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39489 - Changes the rendering of minitabs slightly:sky@chromium.org2010-02-194-107/+59
| | | | | | | | | | | | | | | | . the icons of minitabs scales up to 24x24 on mouse over. . phantom tabs are rendered in their own layer behind other tabs at 40% opacity. The icon for phantom tabs are rendered at 60% opactiy. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/646067 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/650062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39490 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the rendering of mini-tabs slightly:sky@chromium.org2010-02-194-59/+107
| | | | | | | | | | | | | . the icons of mini-tabs scales up to 24x24 on mouse over. . phantom tabs are rendered in their own layer behind other tabs at 40% opacity. The icon for phantom tabs are rendered at 60% opactiy. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/646067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39489 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-1/+1
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-193-0/+3
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Re-init IPC code when window manager starts.derat@chromium.org2010-02-173-1/+40
| | | | | | | | | | | | | | | | | | Chrome's code to look up the WM's window and notify it about which version of the IPC protocol Chrome supports stopped firing at the correct time, probably due to the login manager change. Additionally, this code wasn't getting re-run if the window manager crashed and was restarted. This change makes us watch for MANAGER ClientMessage events on the root window so that we can reinitialize as needed. BUG=none TEST=checked that panel-dragging works after logging in and after killing chromeos-wm Review URL: http://codereview.chromium.org/610004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39229 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Replace WM_FOCUS_WINDOW with _NET_ACTIVE_WINDOW.derat@chromium.org2010-02-162-10/+5
| | | | | | | | | | | | | | | | The Chrome OS window manager previously gave Chrome two ways to tell it to focus a window; I'm trying to cut that down to one. Note that I'm pretty sure that this is all dead code in Chrome at this point -- the tab summary ("tab overview" here) doesn't get displayed now that the window manager is using the new overview mode. BUG=chromium-os:1495 TEST=compiled Review URL: http://codereview.chromium.org/598023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39149 0039d316-1c4b-4281-b951-d872f2087c98
* Use TabContents::GetDefaultTitle() everywhere we need a title for an ↵pkasting@chromium.org2010-02-121-6/+4
| | | | | | | | | | untitled tab/page. This will let us remove a couple of duplicate strings. BUG=none TEST=none Review URL: http://codereview.chromium.org/604021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38902 0039d316-1c4b-4281-b951-d872f2087c98
* Make clicking on side tabs to select them work. ben@chromium.org2010-02-116-22/+181
| | | | | | | | | | | | Use a simple round rect for the visual treatment. Add some rect conversion utils. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/597012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38856 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38828 - Make clicking on side tabs to select them work.ben@chromium.org2010-02-116-182/+23
| | | | | | | | | | | | | | Use a simple round rect for the visual treatment. Add some rect conversion utils. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/597012 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38834 0039d316-1c4b-4281-b951-d872f2087c98
* Make clicking on side tabs to select them work.ben@chromium.org2010-02-116-23/+182
| | | | | | | | | | | | Use a simple round rect for the visual treatment. Add some rect conversion utils. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/597012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38828 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-092-2/+4
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TabStrip's drop indicator not to allow dropping onsky@chromium.org2010-02-081-1/+2
| | | | | | | | | | | mini-tabs. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/587005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38395 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Animation::CurrentValueBetween and gets rid of a bunch ofsky@chromium.org2010-02-074-64/+44
| | | | | | | | | | | duplicate code. BUG=none TEST=none Review URL: http://codereview.chromium.org/570055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38330 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-02-061-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38316 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-02-061-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38314 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS Bustage: Use string16 instead of wstring.ben@chromium.org2010-02-065-6/+6
| | | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/573048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38313 0039d316-1c4b-4281-b951-d872f2087c98
* Make basic side tabs actually appear.ben@chromium.org2010-02-066-9/+256
| | | | | | | | | http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/572041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38312 0039d316-1c4b-4281-b951-d872f2087c98
* Makes mini-tabs work on the UI side (at least for views). I still havesky@chromium.org2010-02-0610-399/+423
| | | | | | | | | | | a handful of things to resolve before I turn on pinning. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/579011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more tab strip model changes. I'm hoping this is the last ofsky@chromium.org2010-02-051-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | it. I'm now going with: // . Mini-tab. Mini tabs are locked to the left side of the tab strip and // rendered differently (small tabs with only a favicon). The model makes // sure all mini-tabs are at the beginning of the tab strip. For example, // if a non-mini tab is added it is forced to be with non-mini tabs. Requests // to move tabs outside the range of the tab type are ignored. For example, // a request to move a mini-tab after non-mini-tabs is ignored. // You'll notice there is no explcit api for making a tab a mini-tab, rather // there are two tab types that are implicitly mini-tabs: // . App. Corresponds to an extension that wants an app tab. App tabs are // identified by TabContents::is_app(). // . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed. // Non-app tabs whose pinned state is changed are moved to be with other // mini-tabs or non-mini tabs. I'm going with a more neutral name like mini-tabs so that we can change the meaning if we need to without changing around all the UI code. I'll convert the UI code next. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/570043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38237 0039d316-1c4b-4281-b951-d872f2087c98
* Make the side tabstrip participate in the layout of the BrowserView.ben@chromium.org2010-02-051-1/+1
| | | | | | | | | | | | Turn on the side tabstrip by default when --enable-vertical-tabs is specified, for ease of testing/debugging. Adjust glass rendering in this mode. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/570029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38160 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new base class BaseTabStrip that is the intermediary between ↵ben@chromium.org2010-02-046-43/+130
| | | | | | | | | | | | | BrowserView/etc and the specific active TabStrip implementation in use. This simplifies things a lot. I don't need separate view IDs etc. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/571002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38110 0039d316-1c4b-4281-b951-d872f2087c98
* Start making a vertical tabstrip. Does nothing right now.ben@chromium.org2010-02-044-0/+162
| | | | | | | | | | | | | | | The option to enable the vertical tabstrip will appear when Chrome is run with: --enable-vertical-tabs and a pref is set. There is presently no UI to set this pref. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/561004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38076 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts tab strip model to deal with app tabs. There were a couple ofsky@chromium.org2010-02-025-206/+11
| | | | | | | | | | | | | places where I left them using the variable with pinned when it should be app because those places need to be radically whacked. I'll do that next. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/555173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure the phantom state of a tab is updated correctly.sky@chromium.org2010-01-222-0/+6
| | | | | | | | | BUG=25309 TEST=none Review URL: http://codereview.chromium.org/551118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36873 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for phantom tabs. A pinned tab becomes a phantom tab whensky@chromium.org2010-01-226-9/+25
| | | | | | | | | | | | | | | | | it is closed, and effectively unloads the renderer and replaces it with a new TabContents that loads when selected. A phantom tab is currently rendered without a border. Phantom tabs do not prevent a window from closing. Long term only pinned app tabs will have the ability to be made phantom, but this allows us to test the feature until app support is all wired in. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to reduce chromeos dependency in chrome.oshima@chromium.org2010-01-184-40/+10
| | | | | | | | | | | | | | | * renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager. * Added factory method to create chromeos specific tab/tabstrip and layoutmanagers. * Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36452 Review URL: http://codereview.chromium.org/543095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36485 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactoring to reduce chromeos dependency in chrome."oshima@chromium.org2010-01-164-10/+40
| | | | | | | | | | | | This reverts commit 8ae39b4c6290397c03661b59619e125f416a9af8. TBR=sky@chromium.org BUG=none TEST=interactive_ui_tests on windows should pass with revert. Review URL: http://codereview.chromium.org/542098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36461 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to reduce chromeos dependency in chrome.oshima@chromium.org2010-01-164-40/+10
| | | | | | | | | | | | | * renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager. * Added factory method to create chromeos specific tab/tabstrip and layoutmanagers. * Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them. BUG=none TEST=none Review URL: http://codereview.chromium.org/543095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 memcheck errorsoshima@chromium.org2010-01-161-1/+1
| | | | | | | | | | | | * TabData.blocked is not initialized. * logo_icon_ was leaking because it's not added to the view tree. BUG=none TEST=valgrind failure for these two should be gone with this patch. Review URL: http://codereview.chromium.org/553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36446 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-154-0/+23
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* Removes debugging code that proved unnecessary.sky@chromium.org2010-01-151-13/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/552005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36355 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in placement of new tab button.sky@chromium.org2010-01-131-1/+1
| | | | | | | | | | BUG=32159 TEST=see bug TBR=ben@chromium.org Review URL: http://codereview.chromium.org/543043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36125 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the new tab button extend to the top of the tab strip on chromeos.sky@chromium.org2010-01-121-4/+15
| | | | | | | | | CROS_BUG=310 TEST=see bug Review URL: http://codereview.chromium.org/550020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36058 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in dragging a tab out in overview mode. This regressionsky@chromium.org2010-01-121-16/+3
| | | | | | | | | | | | was introduced when adding the views/gtk support. As we don't need non-views/gtk support anymore, I'm nuking the defines in this file. BUG=32057 TEST=see bug Review URL: http://codereview.chromium.org/546019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36032 0039d316-1c4b-4281-b951-d872f2087c98
* Use dropdown bar for compact location bar.oshima@chromium.org2010-01-111-1/+3
| | | | | | | | | | | | | | | | | | | | * Refactored CompactLocationBar to Host/View to use DropdownBarHost/View. * Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar. Following features are not implemented yet. * Window cripping while animating. * Adjust location when toolbar is shown (it's always under tab) * clipping autocomplete dropdown. Timer code is no longer used right now, but is left intentionally as we may put it back. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35674 Review URL: http://codereview.chromium.org/525018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35929 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chrome OS build to support panel-dragging change.derat@chromium.org2010-01-092-9/+55
| | | | | | | | | | | | | | The window manager side of this change (already committed) is described at http://codereview.chromium.org/527005. This change also makes Chrome report the version of the IPC messages that it's using to the window manager at startup. TEST=built and tested that panel-dragging works as expected BUG=none Review URL: http://codereview.chromium.org/521070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35862 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r35674: "Use dropdown bar for compact location bar."rsesek@chromium.org2010-01-071-3/+1
| | | | | | Review URL: http://codereview.chromium.org/525081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35686 0039d316-1c4b-4281-b951-d872f2087c98
* Use dropdown bar for compact location bar.oshima@chromium.org2010-01-071-1/+3
| | | | | | | | | | | | | | | | | | * Refactored CompactLocationBar to Host/View to use DropdownBarHost/View. * Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar. Following features are not implemented yet. * Window cripping while animating. * Adjust location when toolbar is shown (it's always under tab) * clipping autocomplete dropdown. Timer code is no longer used right now, but is left intentionally as we may put it back. BUG=None TEST=None Review URL: http://codereview.chromium.org/525018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35674 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Rename panel content window enum.derat@chromium.org2010-01-021-2/+2
| | | | | | | | | | | | This is just to match up with http://codereview.chromium.org/525001 , a change to make some of the window manager code a bit clearer. TEST=sent to try servers BUG=none Review URL: http://codereview.chromium.org/517026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35438 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug on removing last pinned tab that left new tab buttonsky@chromium.org2009-12-221-0/+8
| | | | | | | | | | | | | | | | indented too much. When a tab is removed we don't actually remove the tab until the animation is done. This means the value returned by GetTabHOffset isn't correct until after the tab is removed. I'm fixing by forcing layout when done, which triggers calling GetTabHOffset. The bug exists on both gtk and views, this fixes both. BUG=22934 TEST=see bug Review URL: http://codereview.chromium.org/505071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35175 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in closing window. The sequence when closing asky@chromium.org2009-12-221-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | window ends like: ~TabStrip ~View ~Tab ~Tab::TabContextMenuContents ~TabStrip::TabContextMenuContents TabStrip::StopAllHighlighting This is problematic as StopAllHighlighting references objects whose destructor has already run. This crashes on Linux, but not on windows (probably because of different implementation of stl). I've fixed this by deleting all child views from ~TabStrip so that if they end up calling into the TabStrip every is still valid. BUG=none TEST=create a couple of tabs, bring up the context menu for each, close the context menu, close the window and make sure you don't get a crash. Be sure and test this on both windows and Chrome OS. Review URL: http://codereview.chromium.org/505066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35151 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 10:09:50 +0000