summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views/toolbar_view.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove the stubbed out headers in chrome/browser/views.msw@chromium.org2011-01-101-12/+0
| | | | | | | | | | | | | | | | | Update references to use headers in chrome/browser/ui/views. Update copyright dates in affected files. /chrome/browser/ui/views/constrained_html_delegate_win.cc Add space before 'private' label (presubmit warning) /chrome/browser/ui/views/toolbar_view.cc Add space before 'cleanup' label (presubmit warning) BUG=69082 TEST=Compiling... Review URL: http://codereview.chromium.org/6204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Feedback button from the status bar and add it to the toolbar.rkc@chromium.org2010-11-221-2/+1
| | | | | | | | | | | | | | Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message BUG=chromium-os:5361 TEST=Verified visually that the status bar icon is gone and the toolbar icon is there; tested the toolbar icon to verify functionality. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65582 Review URL: http://codereview.chromium.org/4546002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67023 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65582 - Remove Feedback button from the status bar and add it to the ↵rvargas@google.com2010-11-091-1/+2
| | | | | | | | | | | | | | | | toolbar. Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message BUG=chromium-os:5361 TEST=Verified visually that the status bar icon is gone and the toolbar icon is there; tested the toolbar icon to verify functionality. Review URL: http://codereview.chromium.org/4546002 TBR=rkc@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65587 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Feedback button from the status bar and add it to the toolbar.rkc@chromium.org2010-11-091-2/+1
| | | | | | | | | | | | Side effect: Changed all instances of IDC_REPORT_BUG to IDC_FEEDBACK to correctly indicate the message BUG=chromium-os:5361 TEST=Verified visually that the status bar icon is gone and the toolbar icon is there; tested the toolbar icon to verify functionality. Review URL: http://codereview.chromium.org/4546002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65582 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser/views to browser/ui/viewsben@chromium.org2010-11-091-226/+3
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/4694005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65508 0039d316-1c4b-4281-b951-d872f2087c98
* First cut of the about:conflicts page, listing all DLLs loaded in the Chrome ↵finnur@chromium.org2010-11-081-7/+10
| | | | | | | | | | | process. BUG=http://crbug.com/51105, http://crbug.com/57239 TEST=Unit tests included. Review URL: http://codereview.chromium.org/4524002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
* Add --disable-domui-menu switchoshima@chromium.org2010-10-211-8/+6
| | | | | | | | | | | I used label/goto in ToolkitView::RunMenu. It sucks, but probably better because the change is smaller than other approach (for branch). Please let me know if you have better idea. BUG=chromium-os:6497 TEST=none Review URL: http://codereview.chromium.org/4046001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63376 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Downloads Shelf keyboard-accessible (via F6) and accessible todmazzoni@chromium.org2010-10-211-8/+9
| | | | | | | | | | | | | screenreaders. Rename AccessibleToolbarView to AccessiblePaneView to reflect that it covers more than just toolbars. Also add infobars to the F6 pane traversal. BUG=372 TEST=none Review URL: http://codereview.chromium.org/3722004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63358 0039d316-1c4b-4281-b951-d872f2087c98
* Wait calling OnMenuOpened until the domui menu is ready to accept input.oshima@chromium.org2010-10-121-3/+6
| | | | | | | | | | | | | * Call OnMenuOpened when the window is mapped. This is necessary as DOMUI menu doesn't show the popup window until page is renderred. * Moved listners to Menu2 as Menu2 manages MenuListeners. BUG=chromium-os:7642 TEST=TestMenuKeyboardAccess,TestAltMenuKeyboardAccess passes with this fix. Review URL: http://codereview.chromium.org/3678005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62355 0039d316-1c4b-4281-b951-d872f2087c98
* Switch WrenchMenu to use domui.oshima@chromium.org2010-10-121-0/+10
| | | | | | | | | | | | | | | | | | | | | * Add WrenchMenu class that implements zoom/edit commands. * changed toolkit_view to use domui menu. * Add accelerator support. * allow subclass to have its own css. this also addresses comments on * removed clearTimeout * move init code to decorate as much as possible * changed init:config to setter * use 'hidden' rule to hide it, instead of not adding it. * I didn't change addHandler as now target and menuitem does not necessary the same. BUG=6497 TEST= Review URL: http://codereview.chromium.org/3601021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62244 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing Alt once should focus the app menu, but pressing it again shoulddmazzoni@chromium.org2010-10-061-0/+3
| | | | | | | | | | | | restore focus back to the previous location. BUG=53906 BUG=51574 TEST=manual Review URL: http://codereview.chromium.org/3618005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61656 0039d316-1c4b-4281-b951-d872f2087c98
* Renames and moves match preview classes to instant. This doesn'tsky@chromium.org2010-10-051-1/+1
| | | | | | | | | | | | contain any changes other than renaming/moving, as such I'm TBRing. BUG=54833 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3602015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in wrench menu where closing with menu open could triggersky@chromium.org2010-10-051-1/+2
| | | | | | | | | | | crash. BUG=56842 TEST=see bug Review URL: http://codereview.chromium.org/3552008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61474 0039d316-1c4b-4281-b951-d872f2087c98
* Send a notification when upgrades have been downloaded, and hookzork@chromium.org2010-10-011-0/+3
| | | | | | | | | | | the indicator up to the OS updater on Chrome OS. BUG=chromium-os:6526 TEST=Connect to a dev server with a newer version, and check that the display appears. Review URL: http://codereview.chromium.org/3607001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61152 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-141-0/+1
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply menu model cleanups, with WrenchMenuModel being a SimpleMenuModel.erg@google.com2010-08-251-8/+5
| | | | | | | | | BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3184021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57384 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate." ↵erg@google.com2010-08-241-5/+7
| | | | | | | | | | (r57119) TBR=rsesek Review URL: http://codereview.chromium.org/3163035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57128 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate.erg@google.com2010-08-231-7/+5
| | | | | | | | | | | This removes copy-pasted code in each platform implementation. BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3163023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57119 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar layout changes for M6 theme.pkasting@chromium.org2010-07-281-1/+8
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3033036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54049 0039d316-1c4b-4281-b951-d872f2087c98
* Swap reload and home back to how they were in Chrome <= 5.pkasting@chromium.org2010-07-281-1/+1
| | | | | | | | BUG=50107 TEST=Reload should be left of home Review URL: http://codereview.chromium.org/3056023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53887 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove dead code (was only called when we had app + page menus). ↵pkasting@chromium.org2010-07-271-11/+0
| | | | | | | | | | Nicer indenting. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53739 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme change notifications auto-propagate through the view hierarchy, ↵pkasting@chromium.org2010-07-271-1/+1
| | | | | | | | | | | | instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change. Make naming for theme and locale changes consistent and clear. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/2878055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Attemp 2 at:sky@chromium.org2010-07-211-5/+0
| | | | | | | | | | | | | | | | Makes the toolbar visible for apps again. Here's the set of patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566) If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none TBR=finnur Review URL: http://codereview.chromium.org/3056003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53062 - Makes the toolbar visible for apps again. Here's the set of ↵pinkerton@chromium.org2010-07-201-0/+5
| | | | | | | | | | | | | | | | | | patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53073 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the toolbar visible for apps again. Here's the set of patches Isky@chromium.org2010-07-201-5/+0
| | | | | | | | | | | | | | reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53062 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-201-17/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* Put sidetab menu back to wrench menu (confirmed with sky)oshima@chromium.org2010-07-201-3/+0
| | | | | | | | | | | | Removed OpenTanMode (confirmed with cole) Removed ToolbarView::SetAppMenuModel BUG=49229 TEST=none. Review URL: http://codereview.chromium.org/2832058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52968 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the bookmark menu.pkasting@chromium.org2010-07-011-2/+0
| | | | | | | | BUG=none TEST=--bookmark-menu no longer does anything Review URL: http://codereview.chromium.org/2853024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
* Provides a single place to test whether the new wrench menu issky@chromium.org2010-06-241-1/+1
| | | | | | | | | | | | enabled. I'm doing this as I'm ready to turn it on for views and want a single place to turn it off should we decided to do that. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2813032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50722 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing the following. This differs from the first insky@chromium.org2010-06-231-0/+4
| | | | | | | | | | | | | | | | that I wasn't setting a field in a default: of a switch where I have a NOTREACHED. Moves cut/copy/paste and increment/descrement/fullscreen into buttons on views. BUG=45734 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2868029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50613 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50604 - Moves cut/copy/paste and increment/descrement/fullscreen into ↵mrossetti@chromium.org2010-06-231-4/+0
| | | | | | | | | | | | | | | | buttons on views. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2803013 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2829021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50608 0039d316-1c4b-4281-b951-d872f2087c98
* Moves cut/copy/paste and increment/descrement/fullscreen into buttonssky@chromium.org2010-06-231-0/+4
| | | | | | | | | | | on views. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2803013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50604 0039d316-1c4b-4281-b951-d872f2087c98
* Small tweaks to improve toolbar keyboard accessibility: Put focus rectsdmazzoni@chromium.org2010-06-221-2/+6
| | | | | | | | | | | | | around more controls (including location bar, only when in full keyboard access mode). Fix accessible names. Fix spacebar to activate menu buttons. Remove methods for child focus, they're not needed anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/2817022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50462 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-181-42/+14
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
* Detach reload from omnibox, combine with stop, and eliminate go.pkasting@chromium.org2010-06-111-4/+3
| | | | | | | | | | This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch. BUG=45745,45762,45763 TEST=Reload and stop should be combined; go should be gone. Review URL: http://codereview.chromium.org/2677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
* Views: Respond to the --new-wrench-menu flag on windows.erg@chromium.org2010-06-101-1/+1
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2748006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49469 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out the multiprofile implementation.erg@chromium.org2010-06-101-2/+2
| | | | | | | | | | | Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial. BUG=27177 TEST=none Review URL: http://codereview.chromium.org/2736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49440 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up bits of the toolbar code.pkasting@chromium.org2010-06-091-7/+2
| | | | | | | | | | The reason I'm collapsing all the "create left/center/right sections" functions into one is because in the upcoming patch that moves "stop" from "go" onto "reload", I'll need to reorder bits within this unified block, and that change will be easier to review if this mechanical change lands first. BUG=none TEST=none Review URL: http://codereview.chromium.org/2781003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49315 0039d316-1c4b-4281-b951-d872f2087c98
* Implement upgrade notifications.finnur@chromium.org2010-05-261-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we detect that the installed version is newer than the version you are running we show a little throbbing orange dot over the wrench menu. If you open the wrench menu and close it again, the throbbing will stop. However, if you look at the contents of the wrench menu you'll notice that the About box menu item has been removed and in its place is a menu item "Update Chrome Now" with a bright orange icon to draw your attention to it. Clicking on the icon shows a dialog box asking whether you want to restart Chrome. If you do, the browser restarts with your session restored (even if you have Session Restore turned off). Known issues: - Currently this is Windows only. We'll have to port this to Linux and do something differnet for Mac (which doesn't have the wrench menu). - Showing an icon in front of Update Chrome causes the checkbox for the bookmark bar menu to go away. Given that we will soon redesign the menus I'm not going to spend much time trying to fix it. BUG=27941 TEST=Wait for Chrome to be upgraded in the background, an orange dot should appear over the wrench menu and if you select Update Chrome your session should be retained. Review URL: http://codereview.chromium.org/2225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48318 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the Omnibox is hidden when toolbar is collapsed.finnur@chromium.org2010-05-131-1/+1
| | | | | | | | | BUG=None TEST=Visual inspection. The Omnibox should never become visible for tabs with a collapsed toolbar (app tabs). F11 twice should not show the Omnibox. Review URL: http://codereview.chromium.org/2032015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47119 0039d316-1c4b-4281-b951-d872f2087c98
* Collapse toolbars in app tabs.aa@chromium.org2010-05-081-0/+5
| | | | | | Review URL: http://codereview.chromium.org/2016002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46775 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding http://codereview.chromium.org/1746009/showjcivelli@chromium.org2010-04-291-1/+2
| | | | | | | | | | | | | | | | | | (fixed the ChromeOS build). The app launcher now uses the location bar (instead of the autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1792010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45957 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45936 - The app launcher now uses the location bar (instead of the ↵jcivelli@chromium.org2010-04-291-2/+1
| | | | | | | | | | | | | | | | | | | | autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every innerclass gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1746009 TBR=jcivelli@google.com Review URL: http://codereview.chromium.org/1737021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45937 0039d316-1c4b-4281-b951-d872f2087c98
* The app launcher now uses the location bar (instead of the autocomplete ↵jcivelli@google.com2010-04-291-1/+2
| | | | | | | | | | | | | | | | | edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1746009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45936 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if the window hosting a menu was closed while thesky@chromium.org2010-04-231-0/+7
| | | | | | | | | | | | | menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=none TEST=Use the test case in 25563, but instead of opening a bookmark menu open either the page or wrench menus. Review URL: http://codereview.chromium.org/1739002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45518 0039d316-1c4b-4281-b951-d872f2087c98
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-231-22/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-221-2/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* Shift omnibox dropdown in and up on Windows, and square off the top, so it ↵pkasting@chromium.org2010-04-121-6/+1
| | | | | | | | | | | | connects to the location bar. Also fix info bubble positioning against location bar icons to put the arrow "up against the icon edge" (fixes the arrow overlapping some page action icons). Remove BubblePositioner, which is now no longer needed. BUG=27570,40730 TEST=Omnibox dropdown should line up with editable area edges, icons and text should line up with icon and text in the omnibox. Info bubbles should still be positioned correctly Review URL: http://codereview.chromium.org/1578021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44268 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 10:17:31 +0000