summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-165-1146/+0
| | | | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29258.akalin@chromium.org2009-10-165-0/+1146
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-165-1146/+0
| | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29255.akalin@chromium.org2009-10-165-0/+1146
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29256 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-165-1146/+0
| | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29255 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29253.akalin@chromium.org2009-10-165-0/+1146
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29254 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-165-1146/+0
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29253 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nick@chromium.orgakalin@chromium.org2009-10-165-0/+1146
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29240 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-165-1146/+0
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29239 0039d316-1c4b-4281-b951-d872f2087c98
* Facelifts to sync UItim@chromium.org2009-10-1510-34/+186
| | | | | | | | BUG=23136,24858,21596 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/270081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
* Tracks the amount of memory SQLite is using in the browser processjamesr@chromium.org2009-10-151-0/+10
| | | | | | | | | | | | | This patch adds support for SQLite memory use tracking in the task manager and enables it for the browser process. SQLite can get into the 10s of MB of memory pretty easily and it is nice to see exactly how much of a 'fat' browser process it is responsible for. SQLite is also used in the renderer process for web databases, but since those are behind a flag and off by default I haven't added support for them yet. TEST=none BUG=none Review URL: http://codereview.chromium.org/276009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29173 0039d316-1c4b-4281-b951-d872f2087c98
* didn't mean to add this file.ben@chromium.org2009-10-151-457/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29168 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2009-10-152-1/+458
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29167 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole category of frame switching bugs relating to the window z-order ↵ben@chromium.org2009-10-152-10/+34
| | | | | | | | | | | | | | | | | | | | | | | | | being screwed up screwed up when DWM is toggled or themes are installed or reset. The first part of the fix was to remove the hack I put in to hide then show the window while the frame type change occurs. The hack was to work around the fact that upon returning to glass from non-glass, the area identified by BrowserFrameWin::OnNCCalcSize as client was filled with solid black vs. transparent black. I don't know why this fix works, but returning a client size for the opaque frame as 1 pixel different to the window rect causes the blackness bug to not occur, so that's what I did (in addition to removing the hack). I also had to put in a couple of fixes to accommodate the pixel turd we gain in the opaque frame. I renamed ChangeSize to LayoutRootView. When we're using the opaque frame, since the views system is rendering the entire content of the window all the time I always size the widget to the window rect rather than the client rect. http://crbug.com/15424 TEST=change the frame type by: - turning on/off aero glass - installing a theme, then resetting - running an app that forces the DWM off, e.g. the O3D plugin The frame should appear correct after the transition in either direction, and window z-order should be preserved. Review URL: http://codereview.chromium.org/266013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29164 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Make badge drawing code cross platform so linux (and eventually ↵estade@chromium.org2009-10-151-1/+1
| | | | | | | | | | | | | mac) can use it. I will switch Windows over to the common function in a follow-up patch. BUG=23882 TEST=gmail browser action sample extension Review URL: http://codereview.chromium.org/279008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29152 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of isolating a crasher. From thesky@chromium.org2009-10-152-1/+32
| | | | | | | | | | | | crash it appears that we're starting a drag for an index beyond that of the model. BUG=24132 TEST=none Review URL: http://codereview.chromium.org/275023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29144 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug: browser action button disappears when loading a new extension. This ↵sidchat@chromium.org2009-10-151-0/+10
| | | | | | | | | | was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing Layout() after SetBounds() in ToolbarView. BUG=23593 TEST=none Review URL: http://codereview.chromium.org/276033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29143 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pieces of syncapi that aren't implemented on Linux.zork@chromium.org2009-10-151-0/+14
| | | | | | Review URL: http://codereview.chromium.org/242141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29134 0039d316-1c4b-4281-b951-d872f2087c98
* Show "Loading" bubble while loading a theme.avi@chromium.org2009-10-154-19/+46
| | | | | | | | | BUG=http://crbug.com/22219 TEST=load a theme, see "Loading..." Review URL: http://codereview.chromium.org/267031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29121 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Stack autocomplete popup window directly on top of the browser's ↵suzhe@chromium.org2009-10-152-2/+18
| | | | | | | | | | | toplevel window. BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM" TEST=Please refer to the bug report for how to test. Review URL: http://codereview.chromium.org/274046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r29095 (removes wrench integration foraa@chromium.org2009-10-153-58/+27
| | | | | | | | | | | | browser actions). Test failure was a fluke. I forgot that changing resources always makes the first bot run fail. TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r29095 (removes wrench integration foraa@chromium.org2009-10-153-27/+58
| | | | | | | | | browser actions). TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit wrench menu items for browser actions.aa@chromium.org2009-10-153-58/+27
| | | | | | | | | | | Also, allow browser actions with no initial icons, and add some better tests. BUG=24379,24671 Review URL: http://codereview.chromium.org/276010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
* Update browser actions api to be like new design doc.aa@chromium.org2009-10-151-3/+2
| | | | | | | | | BUG=23879 TEST=Install sample gmail browser action sample. Review URL: http://codereview.chromium.org/264046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29068 0039d316-1c4b-4281-b951-d872f2087c98
* Hides the control buttons for browser when maximized on chromesky@chromium.org2009-10-142-11/+39
| | | | | | | | | | | | os. maximized is the default state on chrome os, so this effectively gives us no window controls just as we have now. BUG=none TEST=none Review URL: http://codereview.chromium.org/273055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29061 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "Reset to Default Theme" button in Google Chrome Options / Personal ↵mirandac@chromium.org2009-10-142-0/+7
| | | | | | | | | | | Stuff when the default theme is already set, Windows side. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Review URL: http://codereview.chromium.org/279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29050 0039d316-1c4b-4281-b951-d872f2087c98
* Gets the full screen bubble to work on views/gtk.sky@chromium.org2009-10-144-32/+67
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/264059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29027 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeOS controls to BrowserViewoshima@chromium.org2009-10-142-3/+33
| | | | | | | | | | | | * Added BrowserExtender class to isolate ChromeOS specific controls from BrowserView * Extender currently adds main menu and status area view only. * System menu is not enabled because using SetContextMenuController on NonClientFrameView didn't work. I need to investigate how. * PanelController support will be added in next CL. Review URL: http://codereview.chromium.org/269078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29021 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menu button. I converted a call from GetWidget tosky@chromium.org2009-10-141-2/+2
| | | | | | | | | | | | | GetWindow, the problem is in certain scenarios GetWindow can return null. I've changed the code back to GetWidget and converted Screen from taking a NativeWindow to a NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/269076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28986 0039d316-1c4b-4281-b951-d872f2087c98
* A patch from contributor Thiago Farina:finnur@chromium.org2009-10-141-1/+12
| | | | | | | | | | | | | | | | | [Windows] Improve the usage of "Open the following pages:" table. - Allow multiple selection. - Select the next row after the last row deleted or nothing when the row doesn't have any items. - Select the item in table when the user add an url. BUG=19150 TEST=add a bunch of urls, remove them, in different orders, should work fine. Review URL: http://codereview.chromium.org/267094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28976 0039d316-1c4b-4281-b951-d872f2087c98
* Port Browser Actions browsertest to linux.estade@chromium.org2009-10-141-0/+2
| | | | | | | | | BUG=23882 TEST=run it Review URL: http://codereview.chromium.org/274025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28941 0039d316-1c4b-4281-b951-d872f2087c98
* Remove hot tracked toolbar button when toolbar removes focus.mhm@chromium.org2009-10-141-0/+6
| | | | | | | | | | | WillLooseFocus needs to check if acc_focused_view is set, if it is, then it will properly remove it. BUG=3510 TEST=ALT+SHIFT+T all the way to the menu button, select options/about chromium menu option and hit enter to select one of them. The menu will be not hottracked. Review URL: http://codereview.chromium.org/270072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28938 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browser test for extensions autoupdate.asargent@chromium.org2009-10-141-1/+4
| | | | | | | | | BUG=17826,19403 TEST=none Review URL: http://codereview.chromium.org/270019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28923 0039d316-1c4b-4281-b951-d872f2087c98
* Update page action manifest parsing to match the new format.mpcomplete@chromium.org2009-10-131-2/+2
| | | | | | | | | | Preserves backwards compatability with the old manifest format. BUG=24635 Review URL: http://codereview.chromium.org/275007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28912 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 of getting blocked popups to work on views/gtk. My first attempt was ↵sky@chromium.org2009-10-134-130/+213
| | | | | | | | | | | | | | | | | | | | | | | | not deleting the blocked popup container view views, which resulted in a reliability crash. This differs from the first patch in that BlockedPopupContainerViewViews::Destroy now does a delete this. From the original patch: I had to fix a couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/274019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28903 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of views/gtk tweaks:sky@chromium.org2009-10-132-0/+6
| | | | | | | | | | | | | . Adds accelerator to list of files compiled on views/gtk. . Adds function to Screen to get monitor bounds from a window. . Adds BrowserFrameGtk::GetAccelerator to match windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/275005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28902 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct theme color for bookmark bar "drag things here" empty helper text.pkasting@chromium.org2009-10-132-22/+22
| | | | | | | | BUG=23536 TEST=With an empty bookmark bar and any theme, the helper text color should match the "other bookmarks" color. Review URL: http://codereview.chromium.org/276005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28899 0039d316-1c4b-4281-b951-d872f2087c98
* Use predefined color names where possible for clarity. Also use ↵pkasting@chromium.org2009-10-133-5/+5
| | | | | | | | | | "SkColorSetARGB(0, 0, 0, 0)" in place of "NULL" since it's not obvious what the latter means as a color. BUG=none TEST=none Review URL: http://codereview.chromium.org/273042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28874 0039d316-1c4b-4281-b951-d872f2087c98
* Shorten the generated file name to be less than MAX_PATH (on Windows).kuchhal@chromium.org2009-10-131-2/+4
| | | | | | | | BUG=24591 Review URL: http://codereview.chromium.org/267063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28845 0039d316-1c4b-4281-b951-d872f2087c98
* WidgetWin was an accelerator target, it does not need to.jcampan@chromium.org2009-10-134-11/+5
| | | | | | | | BUG=None TEST=make sure Esc still works in the bookmark bubble and that accelerators work as expected. Review URL: http://codereview.chromium.org/271067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28842 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flashing issue when hitting escape while find bar is active.mhm@chromium.org2009-10-132-0/+15
| | | | | | | | | | | When the View try's to focus to the last focused component, it can't, because ToolBarView is not Focusable, hence overriding IsFocusable will fix the flashing, but will create a focusable ring around the whole toolbar. BUG=15228 TEST=ALT+SHIFT+T press left arrow until page menu, and select find in page. Press ESC numerous times, no more flashing issues for the find bar. Review URL: http://codereview.chromium.org/265056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28789 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28716 - Gets blocked popups to work on views/gtk. I had to fix a ↵nsylvain@chromium.org2009-10-134-212/+130
| | | | | | | | | | | | | | | | | | | | | | | couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/267069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed lame typo.oshima@chromium.org2009-10-131-2/+2
| | | | | | | | | | | | Doh, I forgot that linux try bot does not compile this file. BUG=None TEST=compiled with chromeos=1 TBR=sky Review URL: http://codereview.chromium.org/269061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28767 0039d316-1c4b-4281-b951-d872f2087c98
* include CHROMEOS files and defintions in TOOLKIT_VEIWS build.oshima@chromium.org2009-10-123-2/+43
| | | | | | | | | | | | | | | | | * changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1 * changed to define OS_CHROMEOS when toolkit_views==1 * changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1 I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow from xid. Looks like I need to register it somewhere Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine. BUG=none TEST=run views unit test and browser. Review URL: http://codereview.chromium.org/262027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
* Converts some uses of native_view to native_window. This is necessitatedsky@chromium.org2009-10-1213-53/+39
| | | | | | | | | | | | by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Review URL: http://codereview.chromium.org/270067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
* Gets blocked popups to work on views/gtk. I had to fix a couple ofsky@chromium.org2009-10-124-130/+212
| | | | | | | | | | | | | | | | | additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28716 0039d316-1c4b-4281-b951-d872f2087c98
* Forwards mouse leave to renderer for views/gtk.sky@chromium.org2009-10-121-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/269051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28710 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-122-0/+2
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-118-8/+8
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28645 - "Render sync code inactive..."tim@chromium.org2009-10-101-0/+7
| | | | | | | | Vive le sync! Review URL: http://codereview.chromium.org/269044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28649 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 07:30:00 +0000