| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In vista we designate the main frame border as a part
of non-client area. This is similar to a popup window having resizing
border. The default logic to maximize such a window, stretches the
borders outside of the screen and the client area occupies the entire
work area. As a result windows taskbar treats it as a 'full screen'
application and hides itself in an auto-hide mode.
An XP-like fix for this, that is to reduce client area vertically by
one pixel, would most likely involve overriding WM_SYSCOMMAND of
SC_MAXIMIZE. Hence, this is a cheap, although a bit ugly fix in
WM_GETMINMAXINFO handling.
BUG=20
Review URL: http://codereview.chromium.org/9305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
fixed.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- automation provider was moving mouse pointer to position in client coords, not
screen coords as required.
- TabStrip was allowing drags to occur in invalid conditions.
This doesn't completely fix the underlying broken-ness of the SimulateDrag
function, however I've not yet been able to get a version of it using SendInput
working.
http://crbug.com/4067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Explicitly set_delegate(NULL) before releasing a TabContents. (I think
the order messages are getting handled is different from XP; this only
seems neccessary under Vista.)
- r4523 and someone elses change added entries to theme_resources.rc at
roughly the same time, causing happy fun crashes.
- Roll in sgk's SConscript fix.
Review URL: http://codereview.chromium.org/9373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Pressing enter when more than one folder is selected opens them all.
. Show in folder is only enabled when it makes sense: you've selected a
bookmark in the table and the table is showing recently bookmarked
or search results.
BUG=4034 4044
TEST=see bugs
Review URL: http://codereview.chromium.org/9367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Forward declarations can't simply use "class $namespace::$class;" syntax. Instead one needs to use "namespace $namespace { class $class; }" syntax.
Review URL: http://codereview.chromium.org/8722
Patch from James Vega.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/9042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we restore the window if minimized/iconified and give focus to
the search field.
BUG=4038 4044
TEST=see bugs
Review URL: http://codereview.chromium.org/9069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests.
Review URL: http://codereview.chromium.org/8782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds a menu button on the bookmark manager. If I finish up import
I'll add a second one for importing.
. Creating new page/folder from menu items selects new item in table.
. I changed around the FolderBookmarkTableModel to copy the contents
into a vector (now extends VectorBackedTabledModel). This is
necessitated by TableView not providing a moved notification. The
problem with previous approach is that I sent out ModelChanged on
any change, which loses selection and causes things to snap around.
I considered adding a moved method to TableView, but it's too much
work at this time.
. Added persisting of divider location in bookmark manager.
. When focus is on table pressing enter on a folder descends into the
folder, and pressing backspace goes back up a folder.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/8967
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
my earlier experiment.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move params to "distribution" group
- Add "import_search_engine", "show_welcome_page" params
- Now the welcome page and the bubble actually work
- Some cleanup
BUG=1394863
Review URL: http://codereview.chromium.org/9207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3961
Review URL: http://codereview.chromium.org/8983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1208
Review URL: http://codereview.chromium.org/8991
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More comprehensive changes will be made for post 1.0.
This is good enough for 1.0.
TBR=sidchat
BUG=1723
TEST=In Accept-Language menu, Germain (Switzerland), French(Canada), etc are listed.
Review URL: http://codereview.chromium.org/9027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/9002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the dragged tab container.
http://crbug.com/3939
Review URL: http://codereview.chromium.org/8800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- skip or not first run dialgos
- on skip import silently search provider only
BUG=1394863
Review URL: http://codereview.chromium.org/8758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view, overidding the focus set from the DialogDelegate.
We now only rely on the dialog delegate.
Also changed dialog delegate so the default button is also the focused button.
BUG=98
TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default.
Review URL: http://codereview.chromium.org/8786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
right-click menu, specifically on the toolbar's back/forward buttons.
Review URL: http://codereview.chromium.org/8942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dangerous download warning cause an overlap with the label
for that download's URL.
We now use a locale-specific pixel value which changes the
height of each download's view on the download page so that
this overlap no longer happens.
BUG=3824 (http://code.google.com/p/chromium/issues/detail?id=3824)
Review URL: http://codereview.chromium.org/8933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The link 'learn more' now points to a yet-to-be-created article in the help center. I moved it also, so that it appears to the right of the label (instead of below the label).
And finally, I added missing definitions for the Bookmark Manager, which I noticed while I was changing this.
Review URL: http://codereview.chromium.org/8777
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
understandable stack traces. Destroy the dragged representation immediately, not after returning to the message loop.
Review URL: http://codereview.chromium.org/8926
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I used the BiDiLineIterator, which I moved out of the AutocompletePopup and into the l10n_util file. I also added a wrapper function around ubidi_getLogicalRun.
Review URL: http://codereview.chromium.org/8727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open the 'Clear browsing data' dialog, there should be a check box for from data. Open the options dialogue, 2nd tab, there should be an option for autofill.
Review URL: http://codereview.chromium.org/8740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8921
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes other recent additions, and doesn't fix everything,
but gets significant pieces back on track:
* New/additional library dependencies in various test executables
(too many to be worth listing).
* Portability: put library base names in $LIBS instead of explicitly
listing .lib files.
* Have interactive_ui re-use various object files from test/ui
instead of (re-)listing the .cc files.
* Add new files:
chrome\browser\bookmarks\bookmark_drag_data.cc
chrome\browser\bookmarks\bookmark_drag_utils.cc
chrome\browser\bookmarks\bookmark_table_model.cc
chrome\browser\browser_trial.cc
chrome\browser\download\download_request_manager_unittest.cc
chrome\browser\greasmonkey_master.cc
chrome\browser\spellcheck_unittest.cc
chrome\browser\views\find_bar_view.cc
chrome\browser\views\find_bar_win.cc
chrome\renderer\greasemonkey_slave.cc
* Remove old files:
chrome\browser\find_in_page_controller.cc
chrome\browser\find_in_page_view.cc
chrome\renderer\spellcheck_unittest.cc
* Remove relative reference to ../../app/google_update_settings$OBJSUFFIX.
* Get rid of by-hand /IMPLIB and /MAP flags.
* Prefix / suffix portability in the jscre library.
* Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources.
* Add $CHROME_DIR/app/resources to CPPPATH.
* Add icu38 directories to CPPPATH for building chrome/views files.
Review URL: http://codereview.chromium.org/8742
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Meiryo font.This issue is caused by a font whose text metric |tmAveCharWidth| is not precise as noted in Microsoft Knowledge Base 145994 (*1) To handle this case, this change uses the ChromeFont::horizontal_dlus_to_pixels() function instead of the ChromeFont::ave_char_width() function.(*1) http://support.microsoft.com/kb/145994BUG=2918
Review URL: http://codereview.chromium.org/8051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8730
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recent additions (doesn't fix everything, but gets significant
pieces back on track).
* New/additional library dependencies in various test executables
(too many to be worth listing).
* Portability: put library base names in $LIBS instead of explicitly
listing .lib files.
* Have interactive_ui re-use various object files from test/ui
instead of (re-)listing the .cc files.
* Add new files:
chrome\browser\bookmarks\bookmark_drag_data.cc
chrome\browser\bookmarks\bookmark_drag_utils.cc
chrome\browser\bookmarks\bookmark_table_model.cc
chrome\browser\browser_trial.cc
chrome\browser\download\download_request_manager_unittest.cc
chrome\browser\greasmonkey_master.cc
chrome\browser\spellcheck_unittest.cc
chrome\browser\views\find_bar_view.cc
chrome\browser\views\find_bar_win.cc
chrome\renderer\greasemonkey_slave.cc
* Remove old files:
chrome\browser\find_in_page_controller.cc
chrome\browser\find_in_page_view.cc
chrome\renderer\spellcheck_unittest.cc
* Remove relative reference to ../../app/google_update_settings$OBJSUFFIX.
* Get rid of by-hand /IMPLIB and /MAP flags.
* Prefix / suffix portability in the jscre library.
* Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources.
* Add $CHROME_DIR/app/resources to CPPPATH.
* Add icu38 directories to CPPPATH for building chrome/views files.
Review URL: http://codereview.chromium.org/8725
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rough edges, but I'm at a good point where I want to land what I
have. Here's what is left:
. Flicker on show, likely the result of restoring window placement.
. tree flickers when dragging splitter.
. table/tree need to autoscroll when drop cursor held at bottom of view.
. prompts for deleting.
. When you move an item the table snaps to the top, this is because
I'm sending out model changed. need a better notification.
. Operations in menu to add need to change selection.
. Remember split location.
I would have preferred to split this up into a couple of reviews, but
everything is intertwined now. Sorry.
BUG=674
TEST=don't test the bookmark manager yet, but make sure bookmark bar
still works.
Review URL: http://codereview.chromium.org/8197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8723
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2835
Review URL: http://codereview.chromium.org/8195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- moving the window while a tab is animating to its final resting position disembodies the tab
- it's possible to make a tab disappear while clicking on another tab while a tab is animating to its final resting position
http://crbug.com/2388
http://crbug.com/1142
Review URL: http://codereview.chromium.org/8689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter.
Issue = 120
Review URL: http://codereview.chromium.org/7935
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change 6053 involved making the PasswordManagerView's table model contain a vector
of stack-allocated PasswordRow that owned a heap allocated PasswordForm, but
std::vector creates temp PasswordRow's internally (on the stack) that were deleting the
PasswordForm in their dtor. This accidental vector-internal delete caused subsequent
operations on saved_signons_ to blow up.
My fix is to make PasswordRows a vector of heap allocated PasswordRow instead, and
have a STLElementDeleter member handle cleanup.
Review URL: http://codereview.chromium.org/8651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The Google Bookmarks bookmarklet opens a popup window that allows you to bookmark a page. When the window closes we crash because we dereference a NULL TabContents pointer the we get from GetSelectedTabContents(). This fixes that.
Review URL: http://codereview.chromium.org/8185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3224
Caveats:
* Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer.
* Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.)
* Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version.
Review URL: http://codereview.chromium.org/8186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Revert keyword dialog to being unsorted by default, which is appropriate for users looking at search engines -- users looking for keywords can always click the column header to sort things.
BUG=3219,1358883
Review URL: http://codereview.chromium.org/8802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes:Renamed ContentSection to WebContentSection to reflect changes that have already been made to the UI (prior to this change list).Renamed GeneralSection to PrivacySectionMoved various checkboxes that appear in other categories in the "Under the hood"-tab to appear under the new PrivacySection.Moved the checkbox "Use a suggestion service" from Edit Search Engines to the PrivacySection, since we don't want it in two different places. - If you check the "Use Suggest" but have a provider that doesn't support it, it will just not perform Suggest queries.The mock I was following has the Learn More link right after the text blurb, but this version has the link below the text. We need to figure out what we want to do here.
Review URL: http://codereview.chromium.org/7985
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
states caused the window border not to be shown.
Review URL: http://codereview.chromium.org/4044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Checking in for external contributer Arthur Lussos <developer0420@gmail.com>, who is already listed in AUTHORS)
Reviewed at http://codereview.chromium.org/7946
Review URL: http://codereview.chromium.org/7993
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1015,1156722
Review URL: http://codereview.chromium.org/7907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as it looks like some users get NULL when they ask for bitmap resource.
BUG=1432071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
class that I can use in the bookmark manager.
BUG=674
TEST=make sure drag and drop on the bookmark bar still works,
especially when moving folders around.
Review URL: http://codereview.chromium.org/8115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3896 0039d316-1c4b-4281-b951-d872f2087c98
|