summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Remove ExtensionProcessManager and move its functionality ontompcomplete@google.com2009-04-161-2/+1
| | | | | | | | | | | ExtensionsService. Also add "chrome-extension" to the list of schemes that BrowsingInstance groups per-site, instead of per-tab. This means that navigating to an extension URL will use the same process as a running extension toolstrip. Review URL: http://codereview.chromium.org/77002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13887 0039d316-1c4b-4281-b951-d872f2087c98
* Adds notification for when info bubble is created.sky@chromium.org2009-04-161-0/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/75022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13843 0039d316-1c4b-4281-b951-d872f2087c98
* ad an argument to MoveTabContentsAt() that switches whether the moved tab is ↵rafaelw@chromium.org2009-04-161-2/+3
| | | | | | | | set as the selected tab, or if the selected tab is left selected (but possibly moved). Review URL: http://codereview.chromium.org/63153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13823 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContnetsType from everywhere.brettw@chromium.org2009-04-157-83/+12
| | | | | | | | I also removed the notion of the "active" tab contents since there is only one per tab now, and all the messages to replace them. Review URL: http://codereview.chromium.org/67173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13808 0039d316-1c4b-4281-b951-d872f2087c98
* Use tab to group "Show saved passwords" and "Exceptions"hclam@chromium.org2009-04-1514-658/+622
| | | | | | | | | | | BUG=9026 "Show saved passwords" and "Exceptions" were splited into 2 dialogs, group together in one single dialog with different pages by tabbing. Review URL: http://codereview.chromium.org/67055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13786 0039d316-1c4b-4281-b951-d872f2087c98
* Make the omnibox popup look nicer. Add dropshadow images (not final). ↵ben@chromium.org2009-04-156-32/+274
| | | | | | | | | | | | Experiment with some effects. Adds a positioner interface that allows the popup to size itself to the width of the edit view + the width of the star and go buttons. (Basically the toolbar needs to help the popup position itself). No results yet! Review URL: http://codereview.chromium.org/68011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13784 0039d316-1c4b-4281-b951-d872f2087c98
* For some Indian locales, the automatic font fallback by Windows UI ↵jungshik@google.com2009-04-156-30/+32
| | | | | | | | | | | | | | | | | | | | | | | | | components leads to too tiny glyphs for UI strings. Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale). It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch). For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used. For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150. When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY. While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner. The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac. TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same. 2.UI test in en-US locale should pass. 3. Running UI tests under Purify should not have any new leak. BUG=7319 Review URL: http://codereview.chromium.org/62064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression I introduced where Stop/Go button would toggle state ↵pkasting@chromium.org2009-04-154-41/+18
| | | | | | | | | | | instantly instead of having protections against accidental user actions while the mouse was hovering the button. I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple. BUG=9843 Review URL: http://codereview.chromium.org/67156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13761 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in painting info bubble. This is the result ofsky@chromium.org2009-04-151-9/+10
| | | | | | | | | | | | | changes to DrawRectInt. Previously a width/height of 0 was treated as a 1 pixel line, where as now nothing gets drawn. I've special cased this again. BUG=9931 TEST=see bug Review URL: http://codereview.chromium.org/67149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13742 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up icon loader/manager in preparation for porting.estade@chromium.org2009-04-141-4/+3
| | | | | | | | Remove a bunch of unused functions and change wstrings to filepaths and remove an obsolete enum. Review URL: http://codereview.chromium.org/73007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13718 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the usage of GetLastActiveBrowserWindowhuanr@chromium.org2009-04-141-1/+1
| | | | | | | | | | as the function is flakey. BUG=10501 Review URL: http://codereview.chromium.org/67139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13709 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for the Find box forwarding scroll messages to the page when it shouldn't.finnur@chromium.org2009-04-143-23/+35
| | | | | | | | TEST=Open Find on a page with scrollbars, type in 'nomatch', scroll to the middle of the page, set the cursor at the end of the Find text field and add '!', '(' and ')' to the search string. Make sure the page doesn't scroll. BUG=10509 Review URL: http://codereview.chromium.org/67135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13696 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reserve space for an auto-hide taskbar that's not always-on-top. ↵pkasting@chromium.org2009-04-141-4/+4
| | | | | | | | | Windows native behavior is to cover these. BUG=9976 Review URL: http://codereview.chromium.org/66055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status bubble shadow being opaque, which made the bubble appear to be ↵pkasting@chromium.org2009-04-143-43/+38
| | | | | | | | | off by one pixel. This reverts Brett's fix for issue 8651 and instead fixes that issue by ensuring the text bounding box does not overlap the status bubble shadow. This also makes kShadowThickness (renamed for consistency with the browser frame) a class-scoped constant so the browser view can access it, eliminating a magic number. BUG=9928 Review URL: http://codereview.chromium.org/67059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13670 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the omnibox show past searches and suggestions for keywords.sky@chromium.org2009-04-141-1/+1
| | | | | | | | | | | | | | | We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Review URL: http://codereview.chromium.org/66073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13668 0039d316-1c4b-4281-b951-d872f2087c98
* Added undo tab closing item to Tab menu.idanan@chromium.org2009-04-141-0/+2
| | | | | | Review URL: http://codereview.chromium.org/62151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13662 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the DOMUIHost. It is not used by any code.brettw@chromium.org2009-04-131-1/+1
| | | | | | | This also does a minor fix for forward-declares of RenderViewHostFactory. Review URL: http://codereview.chromium.org/66046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13637 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up a bit more plumbing to ExtensionView which should allow popup ↵erikkay@google.com2009-04-132-3/+5
| | | | | | | | windows and widgets to work.Add in a quick hack that lets you bring up the web inspector. Review URL: http://codereview.chromium.org/67029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13595 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring; switch the |filter| parameter into something that is more ↵avi@chromium.org2009-04-124-32/+70
| | | | | | | | | | amenable to cross-platform implementation. BUG=9852 Review URL: http://codereview.chromium.org/63093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98
* Allow a different omnibox popup to be enabled via the command line ↵ben@chromium.org2009-04-103-0/+144
| | | | | | | | | | | | (--enable-omnibox2). This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX. Also adds new images from Nicholas. Review URL: http://codereview.chromium.org/67035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13538 0039d316-1c4b-4281-b951-d872f2087c98
* The dialog delegate for the in-progress download warning was deleted twice. ↵jcampan@chromium.org2009-04-101-5/+3
| | | | | | | | | | | | | | It is the content view for the dialog and as such is automatically deleted when the dialog is closed. So it does not need to delete itself on the DeleteDelegate() callback. We were also leaking the label_. BUG=9959 TEST=Start a big download, close the browser while the download is in progress. A dialog pops-up. Try the close button. The browser should close (and not crash!). Try again but this time with "Wait for donwloads to finish". Review URL: http://codereview.chromium.org/66038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13515 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a confirmation box when closing the browser with in-progress ↵jcampan@chromium.org2009-04-092-0/+77
| | | | | | | | | | downloads. BUG=1028 TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode. Review URL: http://codereview.chromium.org/62131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98
* Introducing ExtensionProcessManager. This manages the ExtensionViews tompcomplete@google.com2009-04-093-10/+22
| | | | | | | | | | | ensure there is only 1 process per extension. I also changed ExtensionMessageService from singleton to one instance per Profile. This means messages can only be passed to extensions and scripts within the same profile. Review URL: http://codereview.chromium.org/62132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13447 0039d316-1c4b-4281-b951-d872f2087c98
* Find window keyboard forwarding, part 2.finnur@chromium.org2009-04-091-0/+5
| | | | | | | | | Also prevent Ctrl+Home and Ctrl+End from being eaten by the Find window. Review URL: http://codereview.chromium.org/62180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13446 0039d316-1c4b-4281-b951-d872f2087c98
* Implement stop/go button for Linux.willchan@chromium.org2009-04-092-6/+6
| | | | | | | | | | | | | Refactored code out of CustomDrawButton into CustomDrawButtonBase to be shared with GoButtonGtk. Replaced the existing non-togglable go button with GoButtonGtk. Note that tooltip support isn't done yet, as it changes based on the state of the location bar and the go/stop state. Add a simple test. Fix some minor lint errors. BUG=9381 Review URL: http://codereview.chromium.org/62154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13409 0039d316-1c4b-4281-b951-d872f2087c98
* Distributor logo and " - App Name" shouldn't be shown on app frame windows.ben@chromium.org2009-04-083-4/+12
| | | | | | | | http://crbug.com/6138 Review URL: http://codereview.chromium.org/62167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13393 0039d316-1c4b-4281-b951-d872f2087c98
* When the Find bar has focus it eats keypresses such as PageUp, PageDown and ↵finnur@chromium.org2009-04-0818-59/+100
| | | | | | | | | | | | | | | Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar. This patch forwards those selected keypresses to the page for its perusal. Known issues: Just like Firefox, the page doesn't scroll if it has frames. SONG=I like to fixit fixit. I like to fixit fixit. BUG=7079 TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F. Review URL: http://codereview.chromium.org/62129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13389 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure the previous/next button don't get focused when clicked.jcampan@chromium.org2009-04-081-0/+5
| | | | | | | | | | We keep the button focusable so they can be tab traversed. BUG=9772 TEST=See bug Review URL: http://codereview.chromium.org/62144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13364 0039d316-1c4b-4281-b951-d872f2087c98
* Added restore and add tab to the system menu so that these operationsidanan@chromium.org2009-04-081-3/+12
| | | | | | | | | | can be done from there. BUG=2144 Review URL: http://codereview.chromium.org/62113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13348 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land popup routing fix for browser.ben@chromium.org2009-04-071-1/+1
| | | | | | | | | | Just the bugfix + test now. Test is disabled pending a working framework. http://crbug.com/8472 Review URL: http://codereview.chromium.org/59007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13282 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.tc@google.com2009-04-073-0/+194
| | | | | | | | | | | | JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac. AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view. The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text. Review URL: http://codereview.chromium.org/63033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
* Disables the download item on the download-shelf when the file is opened.jcampan@chromium.org2009-04-072-10/+63
| | | | | | | | | | | This is to mitigate against multiple clicks when a file takes some time to show anything to the user when opened (typically a setup.exe). By changing the title and disabling the button, we indicate to the user that an action was taken. BUG=7264 TEST=Download a file (image for example). In the download shelf, press the download item. The download item text should change to "Opening..." and it should be disabled (not responsive to clicks/drag and drops). Review URL: http://codereview.chromium.org/58014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13273 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "Save page as..." functionality. Fix by Roland Steiner.avi@google.com2009-04-071-1/+5
| | | | | | | http://codereview.chromium.org/63045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13260 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify the documentation for loading_only on TabRenderer::UpdateData.brettw@chromium.org2009-04-071-3/+3
| | | | | | Review URL: http://codereview.chromium.org/63029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13256 0039d316-1c4b-4281-b951-d872f2087c98
* Make the RenderViewHostFactory a global. This prevents us from having to passbrettw@chromium.org2009-04-071-2/+1
| | | | | | | | | a factory pointer around all the time. Removing TestTabContents will require making the Browser object keep track of the Factory pointer as well, so I think the global is the best approach and cleans some things up. Review URL: http://codereview.chromium.org/62044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13255 0039d316-1c4b-4281-b951-d872f2087c98
* Switching things to FilePath:phajdan.jr@chromium.org2009-04-071-3/+4
| | | | | | | | | | | | | | | | Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Review URL: http://codereview.chromium.org/63011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of refactoring dialogs.avi@chromium.org2009-04-067-59/+64
| | | | | | Review URL: http://codereview.chromium.org/60110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the Find bar ownership to the Browser object for portability and ↵finnur@chromium.org2009-04-055-81/+58
| | | | | | | | testability purposes.BUG=None.TEST=No new functionality, just moving stuff around and as such it is covered by pre-existing tests. Review URL: http://codereview.chromium.org/60105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13134 0039d316-1c4b-4281-b951-d872f2087c98
* Make the throbber throb sooner after you navigate. This fixes the new tab page,brettw@chromium.org2009-04-045-14/+23
| | | | | | | | | | | | | | which would not start throbbing until the load committed. I think this was always broken, but switching the tab contents types covered it up. Now I have a flag that goes along with the tab updating that indicates if it's a load update or a full update. This is necessary to avoid updating the title to the page's URL until it does actually commit. BUG=9310 Review URL: http://codereview.chromium.org/60066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13131 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in dragging bookmark bar. The bookmark bar would notsky@chromium.org2009-04-031-2/+3
| | | | | | | | | | | allow drags when on the new tab page. BUG=9674 TEST=see bug, but make sure dragging from bookmark bar works in all modes. Review URL: http://codereview.chromium.org/60096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13106 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add devtools messages into the about:ipc dialog.pfeldman@chromium.org2009-04-031-1/+15
| | | | | | Review URL: http://codereview.chromium.org/60090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13082 0039d316-1c4b-4281-b951-d872f2087c98
* Move code to allow dns queries (and accompanyingaa@chromium.org2009-04-031-14/+0
| | | | | | | | | | | TODO) from each in-process ui test into the base class, since it is really the base class that is initiating these queries (by way of starting the browser). Review URL: http://codereview.chromium.org/56173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13069 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTML dialogs out of their own tab contents type. Moved functions to newbrettw@chromium.org2009-04-036-43/+45
| | | | | | | | | | | | | file html_dialog_ui.* Move WebContents view creation into the constructor, which makes a bunch of extra calls to CreateView unnecessary. Remove unused CallJavascriptFunction() functions in DOMUI. Review URL: http://codereview.chromium.org/56065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13065 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move IPC code to ipc/"agl@chromium.org2009-04-032-2/+2
| | | | | | | This reverts commit r13062 which, unsurprisingly, broke the build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13063 0039d316-1c4b-4281-b951-d872f2087c98
* Move IPC code to ipc/agl@chromium.org2009-04-032-2/+2
| | | | | | | (No review URL: Rietvelt couldn't cope) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13062 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-011-475/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix distributor logo placement on glass frame when window is restored from ↵ben@chromium.org2009-04-012-0/+10
| | | | | | | | | | | | fullscreen. Force a layout in WM_NCCALCSIZE since NC metrics can change as a result of handling this message. http://crbug.com/8511 Review URL: http://codereview.chromium.org/56086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12930 0039d316-1c4b-4281-b951-d872f2087c98
* Record new tab button presses.glen@chromium.org2009-03-311-1/+3
| | | | | | Review URL: http://codereview.chromium.org/56049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12896 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanic change based on comment from previous code review.huanr@chromium.org2009-03-311-1/+1
| | | | | | | | | Rename RunCommand to RunCommandAsync and RunCommandSync to RunCommand. Review URL: http://codereview.chromium.org/57039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows "Save As" dialogs from Save Page code.In this change:- ↵paulg@google.com2009-03-307-45/+76
| | | | | | | | convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691) Review URL: http://codereview.chromium.org/45048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 05:39:37 +0000