| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
TabStripModel to minimize how many places I call to is_app and
pinned.
BUG=49013
TEST=none
Review URL: http://codereview.chromium.org/2877024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the sync options dialog.
BUG=48844
TEST=open Personal Stuff on any platform, see dashboard link.
Review URL: http://codereview.chromium.org/2827055
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/2881021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also added inferred labels implementation. Label inferred from the person name + differences in other fields to distinguish entries.
BUG=47120,46634,46635,47435,48881,47430
TEST=in the mocks: http://folder/roma/design/chrome/autofill/ and unit tested.
Review URL: http://codereview.chromium.org/2801020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's hard to find things in the download directory. DownloadFile and DownloadFileManager
were bundled together. Similarly for DownloadItem and DownloadManager, which was much less
intuitive. Some 3-5 line structs were also in one bag with something else. I extracted them
to their own small file.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/2806054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
options dialog.
BUG=48844
TEST=open Personal Stuff on any platform, see dashboard link.
Review URL: http://codereview.chromium.org/2827055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the implementation of each platform under its respective source directory.
- Rename the classes to match with pattern used in the chrome source.
- In the gtk side, use the gtk signal macros for the callback events.
BUG=None
TEST=open the bookmark editor dialog, everything should works as before on windows and linux.
Review URL: http://codereview.chromium.org/2832028
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2835043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the implementation of each platform under its respective source directory.
- Rename the classes to match with pattern used in the chrome source.
- In the gtk side, use the gtk signal macros for the callback events.
BUG=None
TEST=open the bookmark editor dialog, everything should works as before on windows and linux.
Review URL: http://codereview.chromium.org/2832028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CompactNavigationBar
this feature has been discontinued
* BrowserStatusAreaView
status area used to have a menu, but it's gone and this
class no longer needed.
* BrowserExtender
used to implement chromeos specific feature,
which has been replaced by chromeos/browser_view
BUG=49229
TEST=no functional chagne. all test should pass.
Review URL: http://codereview.chromium.org/3035004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wizard is started from options.
BUG=19776
TEST=manually tested
Review URL: http://codereview.chromium.org/2976009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium-os/issues/detail?id=3929
BUG=chromium-os:3929
TEST=manual (hover over close button, should fade in/out same as other hover behavior)
Review URL: http://codereview.chromium.org/2809054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=48332
TEST=make sure the wrench menu has the decrement zoom button before
the increment zoom button.
Review URL: http://codereview.chromium.org/3008004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Search Engine Dialog, otherwise search engine is set to Google or silently imported, depending on master_preferences. (see go/chromefirstrun for details).
I also removed a no-longer-used SearchSelectObserver from FirstRunSearchView.
BUG=42612
TEST=First run import works as intended (see go/chromefirstrun). master_preferences file can still turn off import of history, search engine, and home page.
Review URL: http://codereview.chromium.org/2934011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because gtk generates a notification when the text is set
programatically it would end up highlighting the text even
after the find UI was dismissed. Also switch back and forth
between 2 tabs would progress the currently found item each time.
BUG=46876
TEST=On chromeos:
- Open tab 1, browse to first page
- Open tab 2, browse to different page
- Switch back to tab 1, open find UI
- Type a character that occurs in page 1
- Switch to tab 2, open find UI
- Type a character that occurs in page 2
- Switch back to page 1. Confirm that the currently selected
found text doesn't change.
- Close the find UI
- Switch back and forth between tabs 1 & 2...tab 1 shouldn't show
any highlights.
Review URL: http://codereview.chromium.org/3005007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContentsView::SizeContents is invoked with the same size then
SetWindowPos won't generate a WM_POSCHANGED and we won't size the
contents. If the contents don't have the correct size (perhaps because
it was created in the background) then we'll get visual garbage next
time you switch to the tab.
BUG=48882
TEST=see bug
Review URL: http://codereview.chromium.org/2842052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/3034007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the DevTools window is closed, it gets opened, and the Inspect Element tool is enabled. If the DevTools window is opened, the inspected tab remains focused with the Inspect Element tool enabled.
If the Inspect Element tool is enabled, it gets turned off.
The shortcut is Ctrl-Shift-C for Win/Linux, Cmd-Shift-C for Mac
BUG=29532
TEST=manual
Review URL: http://codereview.chromium.org/3011002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Options dialog, in the Under the Personal Stuff section.
xib changes: added an enabled binding to the policy-controlled checkboxes in the "Personal Stuff" preference pane so that they can be disabled when their value is overridden by policy. The methods for the bindings are in the preference window controller.
BUG=44395
TEST=ConfigurationPolicyPrefStoreTest.* and ConfigurationPolicyProviderWinTest.* Manual tests: Set the policy externally. Check that the radio buttons and the "Show saved passwords" button in Options/Personal Stuff/Passwords are disabled. Also check that the check box is set/unset as done by the policy.
Review URL: http://codereview.chromium.org/2848039
Patch from Jean-Luc Brouillet <jeanluc@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
balloon to the new content url; this is the last piece for replace-id support in notifications.
BUG=none
TEST=use replaceId feature for notifications
Review URL: http://codereview.chromium.org/2955009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
search icon.
I refactored the extension menu manager to separate the icon-specific bits.
BUG=46479
TEST=load the chrome search extension at
src/chrome/common/extensions/docs/examples/extensions/chrome_search/
and type "src foo" into the omnibox. You should see the extension icon instead of the magnifying glass. Switch back and forth between the "src" keyword result, other results, and other keywords and the icons should update properly.
Review URL: http://codereview.chromium.org/2973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
close button under your mouse; don't reposition them to the normal place until the mouse has left the balloon collection
BUG=47333
TEST=make notifications of different sizes, try to close them all; the X should remain under your mouse
Review URL: http://codereview.chromium.org/2915003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/2907003
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3016003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously committed as r52349 and r52336. Related commits: r52367, r52364
and r52343.
Rerunning trybots due to previous trybot breakage.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2965015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already have too many classes named Manager in the download code.
This also contains some minor cleanup changes like comment updates.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3011001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/2907003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only disable those homepage-related gui controls, that are explicitly overridden by policies.
This is a different solution than the expected behavior described in the bug below. The main point is that it avoids the ambiguous state, when the user has HomepageIsNewTabPage=true selected, and the policies only specify the HomepageLocation URL.
BUG=46486
TEST=manual
Review URL: http://codereview.chromium.org/2843022
Patch from Gabor Feher <gfeher@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48470
TEST=Configure policy, check advanced page of preferences dialog.
Review URL: http://codereview.chromium.org/2908007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a layouting problem that resulted in the "Stop syncing this account"
button not being sized properly after setting up sync.
BUG=48807
TEST=Open options dialog in non-synced state, configure sync, check "Stop syncing this account" button after setup.
Review URL: http://codereview.chromium.org/2980005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
label from the strings that can be displayed. The old approach
resulted in too small a width and clipping.
BUG=chromium-os:4406
TEST=see bug
Review URL: http://codereview.chromium.org/2993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2982009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(I accidentally committed a previous version of the patch (the fixed version
was in codereview since I had switched to my mac to address this exact compile
failure.)
BUG=none
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/2937010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Some cleanup to url_request.h
- Remove task.h from headers that don't need it.
- Remove histogram.h from message_loop.h
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2986002
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2969006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Some cleanup to url_request.h
- Remove task.h from headers that don't need it.
- Remove histogram.h from message_loop.h
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2986002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
non-incognito normal browser, in which case, the window also cannot be closed. if the last normal browser is closeable and user closes it or the last tab in it, if it's a incognito browser, a new non-incognito browser will be opened, else the browser stays opened with all tabs closed and a NTP opened. before-unload-handlers are also taken care of.
BUG=chromium-os:2711,chromium-os:3479,chromium-os:2568
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/2069002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
block.
BUG=48941
TEST=none
Review URL: http://codereview.chromium.org/2963006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45316
TEST=Configure SyncDisabled policy and check the UI.
Review URL: http://codereview.chromium.org/2905003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/4552
TEST=See the bug report.
Review URL: http://codereview.chromium.org/2925009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible; also fixes problems in chrome.gyp and theme_resources.grd that were causing "toolkit_views" to not be properly handled here, so this won't cause problems
* Scope things only used by views under an appropriate conditional
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2987003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:45927,chromium-os:3860
TEST=none
Review URL: http://codereview.chromium.org/2963005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible
* Scope things only used by views under an appropriate conditional
Reverting becasue it definitely causes ExtensionBrowserTest.Toolstrip to crash,
and apparently causes crashes in the startup_tests too.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2953005
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2897012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Alphabetize a couple entries
* Move things to theme_resources.grd where possible
* Scope things only used by views under an appropriate conditional
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2953005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Right click a tab, "Close opened by" should not be in the context menu.
Review URL: http://codereview.chromium.org/2903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it can be synced.
BUG=40483
Review URL: http://codereview.chromium.org/2964003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48844
TEST=Open options > Personal Stuff, see link to dashboard.
Review URL: http://codereview.chromium.org/2934010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicate the tab being dragged is getting deleted between the time we
detach from the model and update the DraggedTabView. This could happen
if the animation were canceled (as could happen if a layout
happened). I don't see how that could happen though. None-the-less
it's easy to deal with the tab going away as it isn't needed when
dragging. This may end up shifting the crash around though, we'll see.
I'm also removing some dead code in the DraggedTabView that is no
longer needed as we only used DraggedTabView for the detached state.
BUG=48365
TEST=make sure tab dragging on windows still works.
Review URL: http://codereview.chromium.org/2924003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
run after it.
BUG=48717
TEST=none
TBR=dmazzoni
Review URL: http://codereview.chromium.org/2923004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previously disabled in ChromeOS.
BUG=chrome-os:4073
TEST=open about:system, right mouse click and pick Save As menu item
Review URL: http://codereview.chromium.org/2880009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44620
TEST=none
Review URL: http://codereview.chromium.org/2920004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for windows, linux platforms resp.
BUG=48597
TEST=None
Review URL: http://codereview.chromium.org/2958002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Allow users to use any name or extension they want, and only append the "desired" extension when the user's name doesn't have any known extension. Original patch by Jared Wein (see http://codereview.chromium.org/2825010 ), r=me.
BUG=7499
TEST=Right-click on link, choose "Save link as...", leave the file type as the default but change the file name to have a different extension. Ensure that the browser doesn't append the original extension.
Review URL: http://codereview.chromium.org/2893001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51870 0039d316-1c4b-4281-b951-d872f2087c98
|