summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix --kiosk to work regardless of the startup pref setting or supplied URLs. pkasting@chromium.org2010-08-031-0/+11
| | | | | | | | | | This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message. BUG=none TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble). Review URL: http://codereview.chromium.org/2847090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54643 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Don't give some downloads duplicate extensions like .arj.arjthakis@chromium.org2010-08-022-2/+29
| | | | | | | | | BUG=49621 TEST=See bug. Also unittests. Review URL: http://codereview.chromium.org/3069018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54625 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where border highlight was drawn wrong forsky@chromium.org2010-08-021-3/+8
| | | | | | | | | | | increment/decrement button in wrench menu. BUG=50959 TEST=see bug Review URL: http://codereview.chromium.org/3056039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54610 0039d316-1c4b-4281-b951-d872f2087c98
* When dropping a tab torn from a maximized window, inherit the restored size ↵pkasting@chromium.org2010-08-021-5/+4
| | | | | | | | | | and maximized state, instead of creating a restored window at the maximized size. BUG=22154 TEST=Drag a tab from a maximized window and drop it; it should create a maximized window. Review URL: http://codereview.chromium.org/3032039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54607 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some code that seems unnecessary now that the distributor logo is dead.pkasting@chromium.org2010-08-021-18/+1
| | | | | | | | BUG=none TEST=Window frame still looks OK after switching themes or resizing Review URL: http://codereview.chromium.org/3053025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54587 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where toggling side tabs wouldn't do a Layout. This was asky@chromium.org2010-08-022-1/+9
| | | | | | | | | | | result of recent changes to View::Layout BUG=chromium-os:4637 TEST=see bug Review URL: http://codereview.chromium.org/3056017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54581 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54560 - nick@chromium.org2010-08-023-18/+11
| | | | | | | | | | | | | | | | Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 TBR=twiz@google.com Review URL: http://codereview.chromium.org/3012042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54565 0039d316-1c4b-4281-b951-d872f2087c98
* Change removing method, GetBrowser from TabContentsDelegate, as this was ↵twiz@google.com2010-08-023-11/+18
| | | | | | | | | | | | | breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54560 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity 12013: Uninitialized member in LocationBarViewfinnur@chromium.org2010-08-021-0/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3018028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54545 0039d316-1c4b-4281-b951-d872f2087c98
* notifications: Convert some std::wstring over to string16.tfarina@chromium.org2010-08-011-7/+7
| | | | | | | | | | | BUG=43899 TEST=compiles, trybots. Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3010028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54484 0039d316-1c4b-4281-b951-d872f2087c98
* Disable mutliple tests that never worked.nsylvain@chromium.org2010-07-311-9/+25
| | | | | | | | bug:50864 TBR:dtseng Review URL: http://codereview.chromium.org/2808084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54471 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the default for the cookie prompt to disabled.jochen@chromium.org2010-07-311-2/+2
| | | | | | | | | BUG=50083 TEST=none Review URL: http://codereview.chromium.org/3030033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54461 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-315-5/+14
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad license header under chrome/ directory.tfarina@chromium.org2010-07-311-3/+3
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/2847091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54450 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-3141-50/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit errors part 2.tfarina@chromium.org2010-07-311-3/+2
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3064026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54420 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Add more logging to BrowserKeyboardAccessibility testphajdan.jr@chromium.org2010-07-301-0/+18
| | | | | | | | | | | | | | to help debug hangs and crashes. Using LOG(ERROR) to make sure the output will be always visible and captured on Windows. We need the logs. The issue is hard to reproduce. TEST=BrowserKeyboardAccessibility BUG=50663 Review URL: http://codereview.chromium.org/3071011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54404 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-302-5/+6
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54074.dtseng@chromium.org2010-07-303-0/+180
| | | | | | Review URL: http://codereview.chromium.org/3010040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54334 0039d316-1c4b-4281-b951-d872f2087c98
* Command line flag to disable the cookie prompt.jochen@chromium.org2010-07-301-9/+15
| | | | | | | | | | | | | The XIB change re-introduces the cookie tab view item with the "ask" setting as additinoal tab view item. The controller deletes the one not required according to the command line flag. BUG=50083 TEST=none Review URL: http://codereview.chromium.org/3075013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54308 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r53603 - Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.tfarina@chromium.org2010-07-301-10/+0
| | | | | | | | | | | | | | | | | This reverts commit 893e3e083fe8d77949860cdb1af7fc14a371651e. It was reverted due to a LINK failure, but reverting didn't fixed either, so I'm relanding it again. BUG=39102 TEST=trybots Review URL: http://codereview.chromium.org/2805096/ TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/3057018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54259 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser/first_run* into into a subdirectory.evan@chromium.org2010-07-293-3/+3
| | | | | | | | BUG=50548 Review URL: http://codereview.chromium.org/3043030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54226 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Don't offer profiles for billing addresses that have no addressavi@chromium.org2010-07-292-21/+30
| | | | | | | | | | | data. BUG=http://crbug.com/50081 TEST=as in bug Review URL: http://codereview.chromium.org/2868078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54222 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-292-7/+7
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Capitalize "Options" in the AutoFill dialog title.jhawkins@chromium.org2010-07-291-1/+1
| | | | | | | | | BUG=50378 TEST=none Review URL: http://codereview.chromium.org/3018026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54183 0039d316-1c4b-4281-b951-d872f2087c98
* Browser actions container layout changes for M6 theme.pkasting@chromium.org2010-07-293-277/+278
| | | | | | | | | | | | | | In short, this: * Eliminates the divider on the right (the new chevron has a built-in divider) * Changes the padding between items (see updated comments in header for precise layout details) * Updates the imagery for the new theme * Makes the chevron respond to theme changes BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3057016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54174 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome OS: Prevent overlapping of title and "x" button for devtools windowdpolukhin@chromium.org2010-07-291-15/+19
| | | | | | | | | BUG=46408 TEST=Title for detached devtools window doesn't overlap with "x" button for long URLs. Review URL: http://codereview.chromium.org/2868075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).rohitrao@chromium.org2010-07-293-180/+0
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/3046031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial tests for keyboard access (tabbing in some dialogs).dtseng@chromium.org2010-07-283-0/+180
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar layout changes for M6 theme.pkasting@chromium.org2010-07-283-44/+60
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3033036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54049 0039d316-1c4b-4281-b951-d872f2087c98
* Location bar layout changes for M6 theme.pkasting@chromium.org2010-07-285-118/+126
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3067011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54048 0039d316-1c4b-4281-b951-d872f2087c98
* Fix glitch in rendering of the stroke at the bottom of the browser toolbar.ben@chromium.org2010-07-282-6/+8
| | | | | | | | | | | | | | | The code that rendered this line was doing weird things (adding/removing kClientEdgeThickness from the edges?!) so I removed this and used toolbar_bounds.right() instead of toolbar_bounds.width() which is correct given that toolbar_bounds.x() > 0. I also got rid of the use of MirroredLeftPointForRect since the flipped version of a horizontal line is... the same horizontal line. I have also updated the glass frame not to subtract a pixel from the right edge which looks glitchy as well. http://crbug.com/48134 TEST=see bug Review URL: http://codereview.chromium.org/3056022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53998 0039d316-1c4b-4281-b951-d872f2087c98
* Modified resources for M6 theme. This doesn't actually modify layout yet, ↵pkasting@chromium.org2010-07-282-2/+3
| | | | | | | | | | just images and identifier names. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3035034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53993 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Set the initial focus when the task manager first activates and shows. ↵dtseng@chromium.org2010-07-281-0/+5
| | | | | | | | | | Also, send our custom accessibility events in NativeControl's Focus() method. BUG=50401 TEST=interactive UI tests BrowserKeyboardAccessibility.TabInTaskManager Review URL: http://codereview.chromium.org/3038031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a NULL ptr dereference crash. Happens when launching an "app" with no icon.michaeln@chromium.org2010-07-281-2/+0
| | | | | | | | | BUG=none TEST=manual Review URL: http://codereview.chromium.org/2832086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53889 0039d316-1c4b-4281-b951-d872f2087c98
* Remove button masks for toolbar buttons, which will no longer be needed in ↵pkasting@chromium.org2010-07-281-11/+0
| | | | | | | | | | the new theme. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3063011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53888 0039d316-1c4b-4281-b951-d872f2087c98
* Swap reload and home back to how they were in Chrome <= 5.pkasting@chromium.org2010-07-282-26/+25
| | | | | | | | BUG=50107 TEST=Reload should be left of home Review URL: http://codereview.chromium.org/3056023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53887 0039d316-1c4b-4281-b951-d872f2087c98
* Add new search engine logos to template url data. This CL also reorganizes ↵mirandac@google.com2010-07-281-53/+2
| | | | | | | | | | | the way logos and search engine type data are stored. Because the search engine dialog is no longer an experiment running on few locales, move the data and logos into the template_url_prepopulate_data for each search engine. BUG=42612 TEST=search engine dialog works as expected. Review URL: http://codereview.chromium.org/3040022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53870 0039d316-1c4b-4281-b951-d872f2087c98
* Add "pushed" as a state a TextButton can show (alongside "normal" and "hover").pkasting@chromium.org2010-07-271-2/+2
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3058011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53847 0039d316-1c4b-4281-b951-d872f2087c98
* Mirror wrench menu corner alignment in RTL mode.pkasting@chromium.org2010-07-271-1/+2
| | | | | | | | BUG=50107 TEST=Run chrome --lang=he, click the wrench; the button and dropdown should align on the left edge, not the right. Review URL: http://codereview.chromium.org/3017033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53842 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove pointless GetInsets() override. Simplify |container_size_| ↵pkasting@chromium.org2010-07-273-370/+310
| | | | | | | | | | to just be |container_width_|. Fix indenting/alignment, especially of function parameters. L"" -> std::wstring(). Don't handle assertion violations (style guide/simplicity). Reduce indenting via early-return or simpler-path-return. Streamline code where possible. Definition order should match declaration order. EXPECT_STREQ -> EXPECT_EQ. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3076001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53841 0039d316-1c4b-4281-b951-d872f2087c98
* Add keyboard shortcuts for next/previous pane on Chrome OS, and fixdmazzoni@chromium.org2010-07-271-4/+12
| | | | | | | | | | | | alphabetization. Note that the F1 key is the "Back" key on Chrome OS, and F2 is "Forwards". BUG=none TEST=none Review URL: http://codereview.chromium.org/2878059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53827 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup:phajdan.jr@chromium.org2010-07-271-6/+2
| | | | | | | | | | | | | | - make the code more object-oriented, make the object expose less accessors - make some parts of code look more obvious, use existing helpers - make the public interfaces slightly better (less ctor parameters) - make some names slightly better TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3029025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53808 0039d316-1c4b-4281-b951-d872f2087c98
* Make the throbber and tab close button correctly respond to theme changes. ↵pkasting@chromium.org2010-07-274-137/+73
| | | | | | | | | | This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless). BUG=50107 TEST=Throbber responds to theme changes Review URL: http://codereview.chromium.org/3064006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53740 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove dead code (was only called when we had app + page menus). ↵pkasting@chromium.org2010-07-272-40/+2
| | | | | | | | | | Nicer indenting. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53739 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme change notifications auto-propagate through the view hierarchy, ↵pkasting@chromium.org2010-07-2719-26/+24
| | | | | | | | | | | | instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change. Make naming for theme and locale changes consistent and clear. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/2878055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
* Make the resize gripper invisible.pkasting@chromium.org2010-07-273-42/+28
| | | | | | | | BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-26165-0/+165
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code to handle bogus themes. We've had a theming system for a while ↵pkasting@chromium.org2010-07-261-27/+0
| | | | | | | | | | and don't care about people who manually hack the DLLs. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53715 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 19:32:09 +0000