summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-303-1/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-303-4/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile for ChromeOS by #including needed headers.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | | TBR=maruel BUG=none TEST=none Review URL: http://codereview.chromium.org/457004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33305 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the normal window's frame in maximized mode. See BUG for more detail. ↵oshima@chromium.org2009-11-304-0/+11
| | | | | | | | | | | Dan will investigate further when he has time. BUG=28580, 727 (chromeos) TEST=None Review URL: http://codereview.chromium.org/436039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33302 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-1/+3
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Show chromium os version in about paneldavemoore@chromium.org2009-11-302-0/+61
| | | | | | Review URL: http://codereview.chromium.org/440008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33293 0039d316-1c4b-4281-b951-d872f2087c98
* Patching the following CL from thiago.farina@gmail.com: ↵idana@chromium.org2009-11-252-10/+42
| | | | | | | | | | | | http://codereview.chromium.org/418044 BUG=26551 TEST=See bug description TBR=thiago.farina@gmail.com Review URL: http://codereview.chromium.org/437073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33152 0039d316-1c4b-4281-b951-d872f2087c98
* Be more paranoid when checking the default browser in Windows and return ↵mdm@chromium.org2009-11-251-1/+1
| | | | | | | | | | | | | | | "not default" rather than "can't tell" in most cases. Also undo previous fixes that worked around an incorrect return value; one of them (the infobar change) regresses the Linux version to display the infobar in cases where we would not be able to set ourselves as the default anyway (which was the original reason for the change that broke things on Windows). BUG=28429, 27403 TEST=(windows) install chrome but don't set it as the default during install, then restart it and verify that the infobar shows and chrome can still be set as the default TEST=(linux) run chrome in an unsupported desktop environment and verify that it neither displays the infobar asking to be made the default browser nor claims that it is the default browser in options Review URL: http://codereview.chromium.org/434022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33147 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky tests on linux/view/64bit builds.oshima@chromium.org2009-11-251-5/+3
| | | | | | | | | | | Also updated browser_tests to use #define instead of #if/else, like other tests. BUG=28808 TEST=None Review URL: http://codereview.chromium.org/442012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33137 0039d316-1c4b-4281-b951-d872f2087c98
* Adds back the ability to filter cookies by origin in the cookies options view.ian@chromium.org2009-11-252-13/+83
| | | | | | | | BUG=27657 TEST=Typing "google" in the search field pulls up origins containing "google" in their name Review URL: http://codereview.chromium.org/435024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33069 0039d316-1c4b-4281-b951-d872f2087c98
* Moving two tests to FLAKY tests.oshima@chromium.org2009-11-252-0/+9
| | | | | | | | | | | | TestHTTPSErrorWithNoNavEntry: fails differently on 32 and 64 bits due to timing issue. (We thought it's deterinistic, but this is apparently not) FindDisappearOnNavigate: due to asynchronous-ness on x11. BUG=28629,28098 TEST=build and run browser_tests in 64bit. Review URL: http://codereview.chromium.org/438010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33068 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-254-15/+15
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Stop opening _all_ notification location changes in a new tab. That was ↵johnnyg@chromium.org2009-11-242-20/+60
| | | | | | | | | | | | | | allowing unwanted popups from a notification with script that sets window.location=foo. Instead override some RVHDelegate::View methods to allow popups to be blocked, and new-tab links to open in new tabs; now regular links will navigate the toast. The view methods are implemented using the standard helper. BUG=28015 TEST=none Review URL: http://codereview.chromium.org/434041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32986 0039d316-1c4b-4281-b951-d872f2087c98
* Fix app icon flicker in loading animationxiyuan@chromium.org2009-11-241-1/+1
| | | | | | | | | | | | | The flicker is caused by setting window title icon while a loading animation is in progress. Fix the problem by skipping window icon update when loading animation is running. BUG=15782 TEST=Verify no flicker while web app loads per Ben's comments. Review URL: http://codereview.chromium.org/436028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix page action spacing on Linux.mattm@chromium.org2009-11-241-4/+2
| | | | | | | | | | | Use the same constant for both Linux and Windows. BUG=28660 TEST=load extensions, compare spacing Review URL: http://codereview.chromium.org/440002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32977 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the nonclientframeview for popups on views/gtk drawsky@chromium.org2009-11-241-1/+50
| | | | | | | | | | | | nothing. This is needed as we want the window manager rendering the decorations. BUG=none TEST=none Review URL: http://codereview.chromium.org/436026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32963 0039d316-1c4b-4281-b951-d872f2087c98
* Disables default browser check and exit menu for toolkit_views onsky@chromium.org2009-11-241-2/+5
| | | | | | | | | | | chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/431029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
* Sets widget created by info bubbles to a custom type so that theysky@chromium.org2009-11-242-0/+14
| | | | | | | | | | | don't get a drop shadow and centered on screen. BUG=none TEST=none Review URL: http://codereview.chromium.org/431021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32936 0039d316-1c4b-4281-b951-d872f2087c98
* Switch theme loading to use its own string.avi@google.com2009-11-241-2/+1
| | | | | | | | | BUG=http://crbug.com/24177 TEST=no visible change Review URL: http://codereview.chromium.org/361006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
* Moved common OpenSyncMyBookmarksDialog() code into SyncStatusUIHelper.akalin@chromium.org2009-11-232-15/+2
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32880 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted cleanup.estade@chromium.org2009-11-231-2/+2
| | | | | | | | process: grep for TODO(port), find cruft, clean it up Review URL: http://codereview.chromium.org/427004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
* Add platform abstraction for simple error box, and use it in a couple ↵estade@chromium.org2009-11-231-11/+0
| | | | | | | | | | | | extensions-related places. Also add a virtual destructor in some unrelated infobar. BUG=27691 Review URL: http://codereview.chromium.org/427002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
* Adding some missing accelerators to Linux toolkit views.jcampan@chromium.org2009-11-231-1/+10
| | | | | | | | BUG=28416 TEST=Tests all the accelerators found in chrome/browser/views/accelerator_table_gtk.cc work and are consistent Chrome on Windows. Review URL: http://codereview.chromium.org/426006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32824 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the position of the frame background image for ChromeOS to match gtk ↵oshima@chromium.org2009-11-231-3/+17
| | | | | | | | | | | | | | build. Gtk build is using non custom frame mode, which renders the frmae pixels 15 pixels above. I'll remove this hack once we migrate to views. BUG=28580 TEST=None Review URL: http://codereview.chromium.org/434011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32818 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts font sizes to be readable on Chrome OS.sky@chromium.org2009-11-231-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32810 0039d316-1c4b-4281-b951-d872f2087c98
* When you search for something, press F3, close the box and press F3 it would ↵finnur@chromium.org2009-11-201-0/+30
| | | | | | | | | | only open the Find box and not issue the search. This is because we set the prepopulate string to find_text and not find_text_ (the former is blank on F3). I have also changed the variable name to prevent this kind of confusion in the future. BUG=28306 TEST=Automated test added. Review URL: http://codereview.chromium.org/425003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32705 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced HungRendererDialog class with hung_renderer_dialog namespace.akalin@chromium.org2009-11-201-3/+7
| | | | | | | | | BUG= TEST=trybots Review URL: http://codereview.chromium.org/415006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32697 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionInstalledBubble border/sizing polishrafaelw@chromium.org2009-11-201-20/+28
| | | | | | | | | BUG=27921 TEST=None Review URL: http://codereview.chromium.org/413005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.close() for page action popups.erikkay@chromium.org2009-11-202-2/+40
| | | | | | | | | | | | Convert mappy to a page action popup. Also fix a bug where disabling an extension with a page action didn't cause the icon to hide. BUG=27519 TEST=none Review URL: http://codereview.chromium.org/414019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32616 0039d316-1c4b-4281-b951-d872f2087c98
* Adds popups to browser actions, completing the feature.andybons@chromium.org2009-11-201-0/+2
| | | | | | | | | | | | Adds functionality to choose between two different InfoBubbleView types: white background and gradient background. Screenshot: http://andybons.com/chrome/news_popup.png BUG=23881 TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled. Review URL: http://codereview.chromium.org/402077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32589 0039d316-1c4b-4281-b951-d872f2087c98
* Undo my revert at r32524 due to a startup test regression.mpcomplete@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | ExtensionHosts once again spawn extension processes asynchronously. However, if the process is already started, we now initialize the RenderView synchronously. This is so bug 28049 stays fixed. BUG=28049 Review URL: http://codereview.chromium.org/402101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32578 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac to using renderer spellchecker.estade@chromium.org2009-11-191-3/+4
| | | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/395007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLs out of *.pak files and put them into code. This savestony@chromium.org2009-11-192-3/+0
| | | | | | | | | | 28k of pak file size, but will make the binary a tad bit larger. BUG=28174 Review URL: http://codereview.chromium.org/407007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert old change that created an ExtensionHost's RenderView asynchronously.mpcomplete@chromium.org2009-11-191-1/+1
| | | | | | | | | | | | | With jam's recent change to spawn renderers from a background thread, ExtensionHost spawns processes asynchronously for free. Reverting this change also fixes a bug due to an extension popup closing before the next one can be created. BUG=28049 Review URL: http://codereview.chromium.org/399098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32524 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the memory purger to all the relevant locations.pkasting@chromium.org2009-11-181-10/+1
| | | | | | | | | | This removes the two-state purge/reset code (no longer necessary), and the hooks to the power monitor (not ready to turn those on without more work and testing). BUG=23400 TEST=Run Chrome with --purge-memory-button, use it for awhile, open the Task Manager, and click "Purge Memory". You should still be able to use the program normally, and hopefully we dumped some memory out too (varies by usage). Review URL: http://codereview.chromium.org/399028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32376 0039d316-1c4b-4281-b951-d872f2087c98
* Leave the 'Make Chrome Default' button enabled on Windows if not already ↵kuchhal@chromium.org2009-11-181-1/+1
| | | | | | | | | | | default. BUG=27403 TEST=As described in the bug above. Review URL: http://codereview.chromium.org/408004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32362 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes several focus issue with popup in the extensions' browser actions:jcampan@chromium.org2009-11-184-2/+24
| | | | | | | | | | | | | | | | - when opening a browser action popup, it gets the focus. - tab traversal now works in the popup - pressing esc closes the popup (if the keyboard event is not processed by the page) BUG=22654, 28087, 28086 TEST=Create an extension with a browser extension that shows a popup. Make the popup so that it has a textfield (that gets focused when the popup show) and a button. Install the extension. Open the popup, the textfield should have focus. Press tab, the focus should go to the button. Press Esc, the popup should be closed. Review URL: http://codereview.chromium.org/402036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32335 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-181-1/+2
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find bar scrolling with the page after switching back to tab.simonrad@chromium.org2009-11-181-8/+7
| | | | | | | | | | | | We need to do a BrowserView::Layout() (which updates things like the bookmarks bar and the find bar) both in between the TabContents detach/attach AND after the final attach. This way, we toggle the bookmarks bar at the right time, but we still end up setting the find bar properly. R=beng BUG=27960 TEST=Navigate to a page where you can see the vertical scroll bar. Press Ctrl+F to open the find bar. Switch to another tab and then back to the original tab. Scroll down/up the page. The find bar should stay in place, not scroll with the page or disappear. Review URL: http://codereview.chromium.org/397036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32284 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when activating a select element inside a pageaa@chromium.org2009-11-183-12/+69
| | | | | | | | | | | | | | | | action popup. With this change, select elements still don't work correctly with page actions: when you try to use them, the page action popup disappears. However, at least now, it doesn't crash. BUG=27576 TEST=Install extension in related bug. Navigate to any site and click page action. Browser should not crash. Review URL: http://codereview.chromium.org/399032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32277 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK when trying to remove multiple engines from the Manage Search ↵pkasting@chromium.org2009-11-171-1/+1
| | | | | | | | | Engines dialog. Original patch by Thiago Farina (see http://codereview.chromium.org/401013 ), r=me. BUG=5227 TEST=Select multiple engines and hit "Remove" in a debug build; should not checkfail. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32223 0039d316-1c4b-4281-b951-d872f2087c98
* Allow multiselection deletion of engines in the Manage Search Engines ↵pkasting@chromium.org2009-11-171-9/+15
| | | | | | | | | dialog. Original patch by Thiago Farina (see http://codereview.chromium.org/402020 ), r=me, tweaked. BUG=16842 TEST=Select multiple engines. "Remove" should be enabled iff the selected set does not include the default engine. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32208 0039d316-1c4b-4281-b951-d872f2087c98
* Remove new tabstrip code. Going to try doing this a different way.ben@chromium.org2009-11-1724-2221/+156
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/400005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-1719-89/+89
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web app shortcuts natively per issue 25528xiyuan@chromium.org2009-11-175-1/+599
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Implement a CreateApplicationShortcutView similar to the current Gears-based one; - Add a few profile prefs to persist user's last checked shortcut locations - Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications" in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls file_util code to creates shortcut on Windows; - Add Win7 taskbar pin/unpin support function to file_util; - Update TabContents to replace gears with new code; Note: - Gears dialog is modaless but this one is a modal dialog. - Gear's icon store is not migrated because gears icons could still be used by shortcuts created by gears and thus we could not delete them even after migration. And we are not using the local ico files in the dialog even if they exists. - New CreateApplicationShortcutView is included when TOOLKIT_VIEW is defined. However on platforms other than Windows, the actual CreateShortCut code is not implemented. Right now it calls ShellIntegration's CreateDesktopShort if OS_LINUX is defined and NOTREACHED() for other platforms. BUG=25528 TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7. Review URL: http://codereview.chromium.org/372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Hide fullscreen bubble when kiosk mode is active.mhm@chromium.org2009-11-171-2/+2
| | | | | | | | | | | When chrome is ran in kiosk mode, the fullscreen bubble should be hidden. As well, I found a major variable name mixup in browerview. BUG=27308 TEST=None Review URL: http://codereview.chromium.org/385146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32151 0039d316-1c4b-4281-b951-d872f2087c98
* amit, please review everything, jam please review the changes to the ↵ananta@chromium.org2009-11-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | tab_contents and the renderer_host sources. Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab container, which hosts ChromeFrame. This object was used to carry a custom URL request context which was used to intercept HTTP requests and cookie requests issued by external tabs. However as the life time of the automation profile class depended on the lifetime of the external tab container object this caused a number of crashes in objects which held on to the automation profile pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser instance as the profile is deleted at the very end. We can associate the automation URL request context with the underlying tab_contents which would eventually percolate down to the resource message filter. Doing this would avoid the need for the AutomationProfile class. This CL achieves that. Bug=27695,27662 Review URL: http://codereview.chromium.org/385117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32012-32017mhm@chromium.org2009-11-159-383/+315
| | | | | | | | | | | git cl dcommit somehow committed all my local changes in cygwin TBR=evan BUG=none Review URL: http://codereview.chromium.org/396006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98
* fix nitsmhm@chromium.org2009-11-154-9/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32017 0039d316-1c4b-4281-b951-d872f2087c98
* small mistakemhm@chromium.org2009-11-152-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32016 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 23:39:00 +0000