summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Convert GetPreferredSize from:beng@google.com2008-10-1581-960/+864
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Insert NULL check to fix dist crashben@chromium.org2008-10-151-5/+4
| | | | | | Review URL: http://codereview.chromium.org/7407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3399 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HitTest/GetViewForPoint to use gfx::Pointben@chromium.org2008-10-1410-30/+28
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3384 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some places I missed the renaming changes.brettw@google.com2008-10-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3382 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RenderWidgetHostHWND to RenderWidgetHostViewWin for consistency with ↵brettw@google.com2008-10-141-2/+2
| | | | | | | | | other view-related classes. No logic change. Review URL: http://codereview.chromium.org/7310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3379 0039d316-1c4b-4281-b951-d872f2087c98
* Try and find the location of crashben@chromium.org2008-10-141-0/+2
| | | | | | Review URL: http://codereview.chromium.org/7323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3367 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-1414-124/+123
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-149-82/+58
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* Move more view stuff out of WebContents. This moves context menus and infobrettw@google.com2008-10-144-9/+22
| | | | | | | | | | bars. I removed the associated functions on TabContents, and have callers call directly through to the view when the care about mucking with the info bar (which is busted, IMO). Review URL: http://codereview.chromium.org/7245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3346 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in saving pages.ben@chromium.org2008-10-131-0/+1
| | | | | | | http://crbug.com/3393 Review URL: http://codereview.chromium.org/7285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3331 0039d316-1c4b-4281-b951-d872f2087c98
* Use system title bar font for app windows, detached popups, constrained popups.ben@chromium.org2008-10-132-5/+21
| | | | | | | | http://crbug.com/3376 Review URL: http://codereview.chromium.org/7274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3307 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up throbber animation for vista detached popup windows and app windows.ben@chromium.org2008-10-136-10/+76
| | | | | | | | http://crbug.com/3296 Review URL: http://codereview.chromium.org/7261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3293 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted improvements to window maximization and flicker on Windows Vista ↵ben@chromium.org2008-10-131-3/+3
| | | | | | | | | with aero-glass disabled. http://crbug.com/2488 Review URL: http://codereview.chromium.org/7262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3292 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for the text on the About box (from bug 3360):finnur@google.com2008-10-131-1/+2
| | | | | | | | | | | | | 1. "Google Chrome is made possible by the Google Chrome open source..." should read "Google Chrome is made possible by the Chromium open source..." 2. The second link in that sentence should be "<a>open source software</a>" Currently the word "software" isn't part of the link. 3. There shouldn't be a period at the end of "Google Chrome Terms of Service." Not a sentence. Review URL: http://codereview.chromium.org/7112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3287 0039d316-1c4b-4281-b951-d872f2087c98
* Remove black line above detached poppup location barsben@chromium.org2008-10-111-1/+1
| | | | | | | http://crbug.com/3332 Review URL: http://codereview.chromium.org/7098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3265 0039d316-1c4b-4281-b951-d872f2087c98
* Add incognito icon to vista frame windows that are incognito.ben@chromium.org2008-10-112-3/+48
| | | | | | | | http://crbug.com/2471 Review URL: http://codereview.chromium.org/7250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3264 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RTL issues with opaque frame. ben@chromium.org2008-10-102-18/+12
| | | | | | | | http://crbug.com/3247 Review URL: http://codereview.chromium.org/7240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3256 0039d316-1c4b-4281-b951-d872f2087c98
* Start splitting out view-related stuff from WebContents into a new class ↵brettw@google.com2008-10-102-0/+2
| | | | | | | | WebContentsViewWin, accessed through an abstract interface WebContentsView. This is incomplete but is a good start. There are still a bunch of pass-throughs required for the TabContents overrides. These won't be able to be cleaned up until we kill TabContents. Review URL: http://codereview.chromium.org/7205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3243 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-104-78/+558
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Terms of Service don't apply to Chromium. Remove the link from the About box.finnur@google.com2008-10-101-13/+18
| | | | | | Review URL: http://codereview.chromium.org/7231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3222 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot a .h file. finnur@google.com2008-10-101-0/+2
| | | | | | | | TBR=tc Review URL: http://codereview.chromium.org/7208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3178 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the translators to chose which link appears first in the About box.finnur@google.com2008-10-101-9/+20
| | | | | | Review URL: http://codereview.chromium.org/7035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3176 0039d316-1c4b-4281-b951-d872f2087c98
* Make loading animations on app windows not call WM_SETICON on every frame. Ow.ben@chromium.org2008-10-106-11/+18
| | | | | | Review URL: http://codereview.chromium.org/7204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression with app window titles.ben@chromium.org2008-10-091-5/+2
| | | | | | Review URL: http://codereview.chromium.org/7039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3152 0039d316-1c4b-4281-b951-d872f2087c98
* Account for the distributor logo when sizing the title text bounds.ben@chromium.org2008-10-091-1/+4
| | | | | | | http://crbug.com/2711 Review URL: http://codereview.chromium.org/6387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3144 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the About box according to mockups. Basically, we now want to have ↵finnur@google.com2008-10-092-29/+265
| | | | | | | | a paragraph of text with embedded links (to the Chromium project, credits and terms of service). Review URL: http://codereview.chromium.org/6563 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3117 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back changes to the client area size calculation, since this fix didn't ↵ben@chromium.org2008-10-092-32/+27
| | | | | | work. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3087 0039d316-1c4b-4281-b951-d872f2087c98
* Move window_resources.h to chrome/views to remove bad dependency of ↵ben@chromium.org2008-10-085-36/+4
| | | | | | | | | | chrome/views on chrome/browser http://crbug.com/2395 Review URL: http://codereview.chromium.org/7002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3076 0039d316-1c4b-4281-b951-d872f2087c98
* Constrained window title text colors are inverted.ben@chromium.org2008-10-081-1/+1
| | | | | | | http://crbug.com/3249 Review URL: http://codereview.chromium.org/6367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3072 0039d316-1c4b-4281-b951-d872f2087c98
* Always position and size the toolbar view, since it's used to position other ↵ben@chromium.org2008-10-081-17/+18
| | | | | | | | | | elements. Regression from changelist earlier today. Review URL: http://codereview.chromium.org/6365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3071 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that you can resize glass windows from the bottom.ben@chromium.org2008-10-081-1/+2
| | | | | | | | http://crbug.com/2483 Review URL: http://codereview.chromium.org/6593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3038 0039d316-1c4b-4281-b951-d872f2087c98
* External contribution from developer0420@gmail.com. Pressing enter insky@google.com2008-10-081-3/+5
| | | | | | | | | | | | the bookmark bubble when focus is on the edit button should start editing. BUG=2863 TEST=Bring up the bookmark bubble, move focus to the edit button and press enter. Make sure the editor comes up. Review URL: http://codereview.chromium.org/6594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3036 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix more standard non-client painting by extending the client ↵ben@chromium.org2008-10-082-10/+14
| | | | | | | | | | area of the frame to the top of the window. http://crbug.com/3246 Review URL: http://codereview.chromium.org/6349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with popups frames when magic_browzr.erg@google.com2008-10-081-9/+18
| | | | | | | | | Some code got committed which made assumptions which were only true when magic_browzr was on. Review URL: http://codereview.chromium.org/5649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3033 0039d316-1c4b-4281-b951-d872f2087c98
* klockwork bug: variable delared in nested scopecpu@google.com2008-10-081-5/+2
| | | | | | | | BUG=3084 Review URL: http://codereview.chromium.org/6227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3018 0039d316-1c4b-4281-b951-d872f2087c98
* Enables sorting of the tables in the password editor and the URLsky@google.com2008-10-083-66/+131
| | | | | | | | | | | | picker dialog. BUG=2949 TEST=Try sorting in the password manager dialog table as well as when adding a URL to the list of URLs to open on startup. Review URL: http://codereview.chromium.org/6053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3010 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash due to lack of NULL checking in one case.beng@google.com2008-10-081-8/+5
| | | | | | http://crbug.com/3183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2991 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of excessive updating done when there is no window icon to beben@chromium.org2008-10-061-2/+4
| | | | | | | | | updated. Improves sunspider results. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2879 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more of chrome/ to Linux.deanm@google.com2008-10-023-0/+3
| | | | | | | | Original review: http://codereview.chromium.org/4247 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2793 0039d316-1c4b-4281-b951-d872f2087c98
* - Add a note about a subtle requirement of the current code (bug 2994).deanm@chromium.org2008-10-021-28/+20
| | | | | | | | - Don't statically construct the cookie icon, removing a static constructor. - Properly enable and disable the cookie text fields. Patch from Arthur Lussos. Review URL: http://codereview.chromium.org/6077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2790 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of bookmark bar bugs:sky@google.com2008-10-011-19/+75
| | | | | | | | | | | | | | | | | . The folders on the bookmark bar now fade in like urls. . You can now middle click on folders to open all URLs. . If you attempt to open a folder with more than 15 urls we'll prompt before openning. BUG=242 529 1295385 TEST=middle click on a folder on the bookmark bar and make sure it opens all tabs in the background. Try this with a folder containing more than 15 bookmarks and make sure you get a message box before asking if you really want to open them all. Review URL: http://codereview.chromium.org/6020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2756 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring for portability:mark@chromium.org2008-09-291-1/+1
| | | | | | | | | | | | | - Move chrome/common/env_util to base/sys_info - Move chrome/common/rand_util to base/rand_util (new), simplify its public interface, and fix its implementation Patch by Paweł Hajdan, Jr. <phajdan.jr@gmail.com> http://codereview.chromium.org/4079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2697 0039d316-1c4b-4281-b951-d872f2087c98
* Enables sorting of cookie views. Also fixes in bug in deletion thatsky@google.com2008-09-291-23/+43
| | | | | | | | | | | | assumed selection was always contiguous. BUG=2949 TEST=Go to options->Under the hood->Cookies and make sure sorting the columns works. Also make sure deleting deletes the appropriate rows. Review URL: http://codereview.chromium.org/4328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2678 0039d316-1c4b-4281-b951-d872f2087c98
* Catch up SCons Windows build with recent file shuffling and other changes:sgk@google.com2008-09-261-0/+17
| | | | | | | | | | | | | * New browser\download\ subdirectory. * New browser\importer\ subdirectory. * New browser\views\old_frames subdirectory. * Add common/notification_registrar.cc. * Remove title_chomper{,_unittest}.cc. * Link against sdch where empirically necessary. * No libevent.lib on Windows, comment out until Linux hits the .dll logic. Review URL: http://codereview.chromium.org/4310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2655 0039d316-1c4b-4281-b951-d872f2087c98
* Make the link in the About box clickable (Issue 657)finnur@google.com2008-09-262-13/+38
| | | | | | | | The URL in the About box was added as a last minute string addition. I have now made it clickable. I also converted the TextField for the main label into a regular label, since there is no need to copy anything anylonger. Review URL: http://codereview.chromium.org/5013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2643 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a crash in the info bubble at first runcpu@google.com2008-09-261-3/+6
| | | | | | | | | | | - Null deref in GetDefaultSearchEngineName - This is a stopgap fix Issue = 2573 Review URL: http://codereview.chromium.org/4304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2636 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize the declarations to have some grouping and logical ordering in ↵brettw@google.com2008-09-264-5/+5
| | | | | | | | | tab contents and web contents. Reorder the derived classes overrides to match, and reorder the definitions of the functions to match the order in the header file. This doesn't actually change any code. I removed a few functions that were declared but never implemented (!) as well as some that were marked vitual but were never overridden. I renamed some things to make them more consistent. Review URL: http://codereview.chromium.org/5005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2634 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to sort TableView. Contrary to what we spoke aboutsky@google.com2008-09-261-9/+17
| | | | | | | | | | | | | | | | | | | | | | | the other day I ended up doing the sorting in tableview. This makes it a heck of lot easier than having every model have to deal with it. As part of this I removed the optional non-caching logic from TableView, which was never used. Sadly though, this means there are coordinate transformations. I've only enabled sorting in the keyword editor, I have to make sure all the other places that use TableView can deal with it. For example, task manager can't deal with it currently as it expects the getters to be called only once where as when sorting they may be called multiple times. BUG=2790 TEST=This enables sorting ONLY in the keyword editor. Make sure there aren't any problems in adding/removing/changing entries in the keyword editor after this. Review URL: http://codereview.chromium.org/4276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2631 0039d316-1c4b-4281-b951-d872f2087c98
* "Make Chrome your default browser" should now appear as a checkbox at the ↵finnur@google.com2008-09-256-53/+78
| | | | | | | | | bottom of the First Run dialogs and be opt-out. Therefore I moved it from the FirstRunCustomizeView view to the FirstRunViewBase. I also moved the override function for GetDialogButtonLabel to the base class (since both dialogs should have the same label for the OK button) and aligned the "Import" label vertically to the "Import" combobox. Review URL: http://codereview.chromium.org/4244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2605 0039d316-1c4b-4281-b951-d872f2087c98
* This CL enables the Page info menu when right-clicking on a page/frame.jcampan@chromium.org2008-09-233-32/+77
| | | | | | | | | | For the frame case, the SSL info had to be added to the show menu message (as the navigation entry contains the top frame SSL info). BUG=2467 TEST=Open a page over HTTPS with multiple frames. Right-click and select shot page info. Review URL: http://codereview.chromium.org/4034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2504 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 19:29:44 +0000