summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix a bunch of header includes. I removed some unnecessary headers from abrettw@chromium.org2009-02-012-0/+2
| | | | | | | | variety of places and added ones in other files that were accidentally depending on them. Review URL: http://codereview.chromium.org/19742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9022 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-0119-68/+90
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back these tab changes since there are still issues.ben@chromium.org2009-01-311-22/+2
| | | | | | | TBR=idanan Review URL: http://codereview.chromium.org/19735 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9000 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with constrained windows and/or custom frame windows:pkasting@chromium.org2009-01-301-30/+83
| | | | | | | | | | | | | | | | | * Wrong titlebar height * Titlebars not handling custom font size properly * Drawing errors in maximized mode * One-pixel overlap glitch on bottom corners of client edges * Borders not handling custom border sizes correctly * Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip) * Wrong icon sizing (only a problem in theory, no one uses this code ATM) These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable. BUG=5054 Review URL: http://codereview.chromium.org/19484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
* Provides the ability to write a unit test that brings up a browser. Assky@google.com2009-01-302-52/+143
| | | | | | | | | | | | | | a proof of concept I converted FindInPageControllerTest.FindInPageFrames over to this. See the description in InProcessBrowserTest for how it all works. BUG=none TEST=none Review URL: http://codereview.chromium.org/19644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8934 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize DefaultNonClientView and ConstrainedWindowNonClientView to match ↵pkasting@chromium.org2009-01-291-165/+120
| | | | | | | | | | | changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation. This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes. This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.) Review URL: http://codereview.chromium.org/19684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
* Per Glen, remove the bottom border of maximized windows. I went ahead and ↵pkasting@chromium.org2009-01-294-87/+56
| | | | | | | | also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be. Review URL: http://codereview.chromium.org/19477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the option for HTTPServer to be created with a specificsky@google.com2009-01-292-10/+10
| | | | | | | | | | | | | | | MessageLoop. I'm going to need this when running ui tests in process. In this case I'll pass in the IO thread. I'll change all callers to use the new method, but before doing that wanted to make sure you're ok with it. BUG=none TEST=none Review URL: http://codereview.chromium.org/19039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
* Make the shared shell dialog not use Windows types, as well as the web contentsbrettw@chromium.org2009-01-293-4/+4
| | | | | | | code that runs it. Review URL: http://codereview.chromium.org/19666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8895 0039d316-1c4b-4281-b951-d872f2087c98
* Move kClientEdgeThickness from BrowserView to NonClientView (which makes ↵pkasting@chromium.org2009-01-294-27/+13
| | | | | | | | | more sense anyway) so I'll be able to use it in custom_frame_window.cc. Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one. Review URL: http://codereview.chromium.org/19458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect spacing/width calculation for titlebar text. I used the wrong ↵pkasting@chromium.org2009-01-292-51/+49
| | | | | | | | | constants, oops. Also some tiny reorderings and similar nonfunctional changes in order to make this class closer to its sibling NonClientView subclasses, so I can eventually refactor them all more easily. Review URL: http://codereview.chromium.org/19447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8849 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RenderWidgetHostView::GetPluginHWND to GetPluginNativeViewbrettw@chromium.org2009-01-291-4/+8
| | | | | | Review URL: http://codereview.chromium.org/19438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8846 0039d316-1c4b-4281-b951-d872f2087c98
* fix p13n build.tim@chromium.org2009-01-291-0/+3
| | | | | | Review URL: http://codereview.chromium.org/18835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8841 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8822.brettw@chromium.org2009-01-285-167/+83
| | | | | | Review URL: http://codereview.chromium.org/19439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8827 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out the common parts of the about network dialog. I will be using thisbrettw@chromium.org2009-01-285-83/+167
| | | | | | | for the about IPC dialog next. Review URL: http://codereview.chromium.org/19433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8822 0039d316-1c4b-4281-b951-d872f2087c98
* Make WebContentsView portable by using the native view types.brettw@chromium.org2009-01-281-2/+3
| | | | | | Review URL: http://codereview.chromium.org/19632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8819 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to have browser windows shown with a specificsky@google.com2009-01-282-0/+16
| | | | | | | | | | | | state. I need this for in process ui tests. I can move this to be private and make the test a friend if you prefer. BUG=none TEST=none Review URL: http://codereview.chromium.org/19404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8773 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the popup-mode location bar out into the nonclient view. This makes ↵pkasting@chromium.org2009-01-272-52/+34
| | | | | | | | | popup mode pixel perfect except for the off-by-one sizing regression caught by the interactive UI test, which I haven't figured out yet. BUG=5054 Review URL: http://codereview.chromium.org/18862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8763 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a small, subtle problem that caused an interactive_ui_test failure.pkasting@chromium.org2009-01-271-2/+8
| | | | | | | BUG=5054 Review URL: http://codereview.chromium.org/18865 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8758 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this from earlier... unit tests no longer crash.ben@chromium.org2009-01-274-36/+63
| | | | | | | | | Extract a cross platform LocationBar interface. Adds a TestLocationBar object that unit tests can use to mock the location bar (fixes NULL deref). Review URL: http://codereview.chromium.org/18851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8745 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes tab contents crash. This changes a number of things in draggedsky@google.com2009-01-271-13/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tab controller: . DraggedTabController now installs itself as the delegate of the TabContents immediately. It needs to do this so that it can stay in sync if the selected TabContents of the NavigationController changes. . DraggedTabController forwards changes to the selected TabContents to the original delegate. This needs to be done so that the original delegate can do any cleanup it needs to do. For example, Browser needs to know if the tab contents changes so that it can remove entries from its internal mapping of what TabContents need to be updated. Similarly the TabStripModel needs to install a listener on the new TabContents type. . If the tab is destroyed while dragging we shouldn't set the attached_tabstrip_ to NULL. Doing so results in invoking source_tabstrip_->DestroyDraggedSourceTab(source_tab_), which is not what should happen. These changes are subtle, so give them a good think. BUG=6369 TEST=this is covered by chrome bot tests. But be sure and exercise tab dragging in as many permutations as you can to make sure this doesn't break anything. Review URL: http://codereview.chromium.org/19026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8731 0039d316-1c4b-4281-b951-d872f2087c98
* Make popups closer to pixel-perfect. The main problem is that the toolbar ↵pkasting@chromium.org2009-01-276-65/+77
| | | | | | | | | is constrained to the width of the client area, when it actually needs to extend out two pixesl on each side into the current nonclient area. I don't have a good fix for this, hoping Ben comes up with a brilliant idea. BUG=5054 Review URL: http://codereview.chromium.org/18799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8726 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 8693 because it breaks the unit_tests.nsylvain@chromium.org2009-01-274-63/+36
| | | | | | | TBR Review URL: http://codereview.chromium.org/19009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8704 0039d316-1c4b-4281-b951-d872f2087c98
* Extract a cross-platform LocationBar interface accessible via the ↵ben@chromium.org2009-01-274-36/+63
| | | | | | | | BrowserWindow interface that the Browser object can use to do locationbar-ey things without directly depending on Views. Review URL: http://codereview.chromium.org/18826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8693 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome/browser/views/SConscript in Linux build.phajdan.jr@chromium.org2009-01-261-3/+171
| | | | | | | | And build few files from there on Linux. Review URL: http://codereview.chromium.org/18760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8661 0039d316-1c4b-4281-b951-d872f2087c98
* This change should have few user-visible effects. I think I slightly ↵pkasting@chromium.org2009-01-263-279/+304
| | | | | | | | | | | | | | | | | | | modified the window layout (by a pixel or so) in the popup window case, which I haven't tried to make pixel-perfect yet anyway. Otherwise it's all reorg. Clean up logic of nonclient view to be more consistent and coherent. Most things are now based on a small set of core functions that return various frame/nonclient thicknesses. This allows a noticeable reduction in the number of hardcoded constants, makes the code make more sense (even though a few places are longer than before), and makes it much easier to do things in the future like resizing various borders or handling system metrics better. Rename and update comments for all constants to be more descriptive and less redundant. Rename helper functions and variables for consistency, now that they've changed. Remove an unused variant of TileImageInt(). Add a new one that takes an offset into the source image. This is used to rewrite the maximized bottom border tiling call in a way that doesn't rely on someone else clipping out or painting over the overdraw from tiling "too large" a source image. Probably no visible effect. Make resize border hittest helper function able to handle borders of varying widths, and try to make parameter names more meaningful. Technically, we don't need the extra flexibility, since our bottom and side borders are the same thickness, but since there are different functions calculating that thickness on the caller side, it didn't hurt to not rely on that for the future. BUG=5054 Review URL: http://codereview.chromium.org/18804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8658 0039d316-1c4b-4281-b951-d872f2087c98
* Two of the three places that set a window mask had it wrong. Fix it.pkasting@chromium.org2009-01-261-2/+5
| | | | | | Review URL: http://codereview.chromium.org/18580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8637 0039d316-1c4b-4281-b951-d872f2087c98
* Two things:ben@chromium.org2009-01-245-0/+15
| | | | | | | | | - remove views dependencies from browser by moving profile related dialog actions into BrowserWindow. - simplify the include dependencies in TabStripModel (making it easier to bring up on mac) by implementing more of its high level functionality in the delegate. Review URL: http://codereview.chromium.org/18736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8606 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dialog box for the about:network view and kill the tab type.brettw@chromium.org2009-01-243-0/+454
| | | | | | | | | This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Review URL: http://codereview.chromium.org/18728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8604 0039d316-1c4b-4281-b951-d872f2087c98
* ===================================================xji@chromium.org2009-01-236-16/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change list fixes the following 2 chrome bugs: 2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog (http://crbug.com/2821) 6132: Strings in tables are displayed LTR when they should be RTL (http://crbug.com/6132) =================================================== Background: The above 2 bugs are related to Chrome task manager. Task manager is a TableView, which is a subclass of NativeControl. Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong. WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order. Please see the following blog for detail: http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx We need to replace the above flag with WS_EX_LAYOUTRTL only. Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text. Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow, TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view). They all need to be fixed. And the following bug is filed for tracking. http://crbug.com/6573 =================================================== The fix is based on Idan's comments on bug 6132 1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. If the text in an URL, then the returned text is explicitly marked as LTR text. Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation. =================================================== Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step. This is the first step, and there is unnecessary function introduced by this change list. 1. I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL). 2. I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually. =================================================== When wrapping text with LTR format in GetText(), ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword). I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation. Review URL: http://codereview.chromium.org/18076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8593 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for generated .vcproj files:sgk@google.com2009-01-231-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Review URL: http://codereview.chromium.org/18555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose the go and star button views directly through the BrowserWindow ↵ben@chromium.org2009-01-234-25/+32
| | | | | | | | interface (for porting). Review URL: http://codereview.chromium.org/18540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8572 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug when saving web pages that have a period in their title.paulg@google.com2009-01-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | The save dialog code attempts to generate a file extension based on the suggested name provided to it, which in the case of saving a web page is the title. If that title contains a '.' character, it treats anything that follows as the file extension and appends it to the name the user selects. For example, saving a page with the title "Google Inc. - A search engine" and the user choosing the save name as "Google" will result in the saved file being named "Google. - A search engine.htm" when it should be "Google.htm". In the case of saving a web page, we can ignore trying to figure out the file extension since we already know it will be ".htm". BUG=6105 (http://crbug.com/6105) Review URL: http://codereview.chromium.org/18699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8569 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=1007hclam@chromium.org2009-01-236-6/+369
| | | | | | | | | Added a dialog for removing exceptions of password manager Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog. Review URL: http://codereview.chromium.org/18494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8544 0039d316-1c4b-4281-b951-d872f2087c98
* Make the browser talk to the status bubble through an abstract interface to ↵ben@chromium.org2009-01-225-77/+55
| | | | | | | | remove the views dependency. Review URL: http://codereview.chromium.org/18487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8515 0039d316-1c4b-4281-b951-d872f2087c98
* (1) If you create tabs and manage to resize the window before themaruel@chromium.org2009-01-221-1/+12
| | | | | | | | | | | | | | | | | pending layout occurs, you get truncated tabs (As described in issue 6505). Upon resize therefore we reset the reserved width for tabs. (2) When inserting a tab as the second-to-last tab, the size of tabs was incorrect. This lead to shriking tabs in multiple cases (as described in issue 3258). BUG=6505 BUG=3258 Patch contributed by Itai Danan <idanana@google.com> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix messed up include path.brettw@chromium.org2009-01-221-3/+3
| | | | | | Review URL: http://codereview.chromium.org/18512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8479 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of browser and into either renderer_host or tab_contents.brettw@chromium.org2009-01-224-6/+6
| | | | | | | This also fixes a crash in the web contents unit test in a commented-out test and re-enable it. Review URL: http://codereview.chromium.org/18504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8470 0039d316-1c4b-4281-b951-d872f2087c98
* Move automation specific accessors to their own interface to make their ↵ben@chromium.org2009-01-222-14/+25
| | | | | | | | purpose clear, and make porting easier. Review URL: http://codereview.chromium.org/18481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix p13n build break due to a change in CommandLine class.munjal@chromium.org2009-01-211-1/+2
| | | | | | | | | This was not noticed since this code only builds if CHROME_PERSONALIZATION is defined. Review URL: http://codereview.chromium.org/18618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8391 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation wrappers. Move the methods from AutomationProxy to the ↵stoyan@chromium.org2009-01-213-19/+10
| | | | | | | | appropriate classes. Review URL: http://codereview.chromium.org/18335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8351 0039d316-1c4b-4281-b951-d872f2087c98
* Correct icon/title sizing/placement for varying titlebar font sizes. This ↵pkasting@chromium.org2009-01-211-23/+78
| | | | | | | | | | | matches Windows pixel-for-pixel except where we adjust things slightly in restored mode to look better with our frame shape, and in occasional cases where our scaling differs slightly, mainly because the Windows icon caching makes it almost impossible to tell what the "correct" Windows behavior actually is. This depends on my oustanding "fix scaled icon problems" change. BUG=5054 Review URL: http://codereview.chromium.org/18396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some problems with scaled icons. This allows the TabIconView to ↵pkasting@chromium.org2009-01-213-12/+42
| | | | | | | | | automatically scale the throbber and favicon to whatever size the View itself is. Notably, this does NOT change tab_renderer.cc, which _also_ draws favicons -- the former is used by app windows and the latter by standard tabs. Argh! I'm not going to bother unifying these for now even though it'd be nice, since we never scale up our tabs, just our app titlebars. BUG=5054 Review URL: http://codereview.chromium.org/18392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8348 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-211-1/+3
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the command updater to not be dependent on views::Button (needed for ↵ben@chromium.org2009-01-2010-191/+85
| | | | | | | | | porting). TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list. Review URL: http://codereview.chromium.org/18343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "revert r8217 until memory tests are fixed." This re-applies r8217.tc@google.com2009-01-202-1/+3
| | | | | | | | | | | This reverts commit r8245. TBR=ben Review URL: http://codereview.chromium.org/18410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8292 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/browser/phajdan.jr@chromium.org2009-01-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/17606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8280 0039d316-1c4b-4281-b951-d872f2087c98
* Generate all chrome .vcproj files:sgk@google.com2009-01-171-41/+192
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Path name translation (/ to \) of various MSVSTool attributes. * Explicit keyword= arguments to MSVSProject. This will likely go away eventually in favor of uniform behavior. * Add a relative_path_substitutions array that can be used to substitute in Visual Studio variable like $(OutDir). * Add a local_directory_prefix that can be set to './' to only affect files in the current directory. * Additional Keyword ordering in Tool attributes to continue to match the default order Visual Studio generates. * Add a Derived() proxy class that can wrap a File node to tell the .vcproj generation that we want the derived file, not its source(s), in the file list. * In the individual *.scons files, add the necessary files (mostly .h files) to file lists, and update MSVSProject() calls with the additional necessary information. Result is identical .vcproj files modulo the following differences: * Four locales .vcproj files (da, en-US, he and zh-TW) with source file orders that don't match the other locale .vcproj files have re-ordered file lists to match the rest. * Cosmetic XML changes (white space, ending tags) in: chrome/app/chrome_dll.vcproj chrome/app/generated_resources.vcproj net/build/net_resources.vcproj * Removal or addition of ./ prefixes from various files that don't match the other file specifications within their individual .vcproj files: chrome/installer/util/util.vcproj net/build/net.vcproj net/build/net_unittests.vcproj * Add missing empty sections (<ToolFiles>, <References>, <Globals>) for consistency with other .vcproj files: chrome/tools/test/image_diff/image_diff.vcproj third_party/libpng/libpng.vcproj third_party/zlib/zlib.vcproj * Add missing RootNameSpace attribute: chrome/test/automation/automation.vcproj testing/gtest.vcproj * Use && instead of \r\n as a command separator, to sidestep XML-generation problems: chrome/app/chrome_exe.vcproj * Remove unnecessary (?) duplicate files in the file list: chrome/browser/views/browser_views.vcproj (event_utils.cc and event_utils.h were duplicated) Review URL: http://codereview.chromium.org/17603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8217 until memory tests are fixed.ben@chromium.org2009-01-172-3/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8245 0039d316-1c4b-4281-b951-d872f2087c98
* Pull app modal dialog handling out of the BrowserList to remove the ↵ben@chromium.org2009-01-161-1/+1
| | | | | | | | | | ChromeViews dependency. (Required for porting). TEST=Open two browser windows. In one, enter "javascript:alert('Foo');" into the address bar and hit enter. Click on the other window. The modal dialog should be focused and the window it was opened over should flash in the taskbar, Review URL: http://codereview.chromium.org/18179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8234 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 08:21:34 +0000