summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Changes docking in the following ways:sky@google.com2009-03-101-140/+80
| | | | | | | | | | | | | | | . Dock icons for window docking positions could go offscreen before. . It was possible to show the maximize indicator on the wrong screen. This was because equals was not comparing the monitor bounds. . Tweaks to color, size and animation from Glen. BUG=none TEST=make sure there are no bugs with docking tabs. Review URL: http://codereview.chromium.org/42041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11391 0039d316-1c4b-4281-b951-d872f2087c98
* Move the tab images into the TabRenderer class.jhawkins@chromium.org2009-03-102-76/+86
| | | | | | Review URL: http://codereview.chromium.org/43038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11377 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests. It was crashing due to a NULL ExtensionsService ↵mpcomplete@google.com2009-03-101-1/+2
| | | | | | | | | in the unit test. TBR=sky Review URL: http://codereview.chromium.org/43042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11375 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 11294.mpcomplete@google.com2009-03-102-7/+96
| | | | | | | | | - include stub fix so that linux/mac still build. - fix DCHECK in views code. - fix unit test. Review URL: http://codereview.chromium.org/41020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11360 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight tab close button on click. Original patch by ↵pkasting@chromium.org2009-03-101-2/+4
| | | | | | | | kimworking@gmail.com, r=me; see http://codereview.chromium.org/28302 . BUG=7690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11359 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chromium windows not hide auto-hide taskbars, take 2.pkasting@chromium.org2009-03-105-32/+68
| | | | | | | | | | This is very similar to r10845, but also includes a regression fix for issue 8410, where locking and unlocking the screen would cause mispositioning of child content. BUG=20,8410 Review URL: http://codereview.chromium.org/42027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11355 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-1089-91/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* InputWindow's window delegate should pass DeleteDelegate through to its own ↵ben@chromium.org2009-03-101-0/+5
| | | | | | | | | | | | delegate to avoid crashing because of not cleaning up. http://crbug.com/8573 Review URL: http://codereview.chromium.org/40326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11311 0039d316-1c4b-4281-b951-d872f2087c98
* Make the last tab part of the client area instead of the non-client as it is ↵ben@chromium.org2009-03-092-14/+0
| | | | | | | | | | | | now. Remove some stupid code in the Tab's mouse pressed handler that was duplicating the nc-hittest handler. o_O. http://crbug.com/8519 Review URL: http://codereview.chromium.org/41018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11299 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11294.mpcomplete@google.com2009-03-092-96/+7
| | | | | | Review URL: http://codereview.chromium.org/40321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11295 0039d316-1c4b-4281-b951-d872f2087c98
* Support loading extensions into the bookmark toolbar.mpcomplete@google.com2009-03-092-7/+96
| | | | | | | | | Misc cleanup: - remove duplicate comments on Extension accessors - remove useless function in ExtensionsService Review URL: http://codereview.chromium.org/39285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11294 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the spellcheck language preference setting when UI language is ↵sidchat@google.com2009-03-091-0/+5
| | | | | | | | changed, so that spellcheck language falls back to default. Issue=7811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11289 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes session restore bug where we wouldn't necessarily correctlysky@google.com2009-03-091-1/+0
| | | | | | | | | | | | | | | restore the maximized state. The problem was we were using a boolean when we really needed three values: use the default, explicitly maximized or explicitly normal. I'm also removing a bogus DLOG in info_bubble. BUG=7930 TEST=see bug Review URL: http://codereview.chromium.org/40306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11287 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ResizeCorner. ResizeCorner was caching the BrowserViewsky@google.com2009-03-092-7/+22
| | | | | | | | | | | | | | that created it, but if a tab contained a download shelf and was dragged to a new window the ResizeCorner would be referencing the wrong BrowserView. I've changed the code to look up the ancestor BrowserView as necessary. BUG=8477 TEST=see bug Review URL: http://codereview.chromium.org/41010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11285 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r10845 because it caused too many other regressions.pkasting@chromium.org2009-03-095-65/+33
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=8345hclam@chromium.org2009-03-094-14/+63
| | | | | | | | | | | | Added a PasswordManagerTableModelObserver to listen for row count change events. PasswordManagerView and PasswordManagerExceptionsView are listening to the event. Move the |instance_| variable from static global to the respective class to avoid future misuse of the variable. Review URL: http://codereview.chromium.org/39313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11279 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if we can reduce some crashes by deferring delegate destruction ↵ben@chromium.org2009-03-0617-21/+13
| | | | | | | | until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit). Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the download shelf context menu in preparation for porting.estade@chromium.org2009-03-061-4/+63
| | | | | | | | | | | * Delete DownloadDestinationContextMenu, which is not used anywhere. * Delete the unused download menu item types from the ContextMenuCommands enum. * Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc} * Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate. Review URL: http://codereview.chromium.org/40184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11068 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing two small regressions in the Find box:finnur@chromium.org2009-03-061-3/+11
| | | | | | | | | | | | 1) If the Find textfield is populated when the Find box is shown, the FindPrevious and FindNext buttons should also be enabled. (issue 8369) 2) If you search for something that is not on the page, you get "0 of 0" in red. Press Esc and Ctrl+F and the label is gone but the red background color for the label remains (no bug on file, found during testing). BUG=8369 TEST=Open about:blank in Chrome. Press Ctrl+F, search for 'e' (get 0 of 0), close the Find box, reopen the Find box. Observe 'e' is in box, it is highlighted and no red is visible. Also, FindPrevious and FindNext buttons should be enabled. Review URL: http://codereview.chromium.org/39233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11063 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line disable-p13n and use that to disablemunjal@chromium.org2009-03-053-7/+12
| | | | | | | | p13n related features. Review URL: http://codereview.chromium.org/39029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11050 0039d316-1c4b-4281-b951-d872f2087c98
* The new history and download tab caused a regression where opening the NTP ↵jcampan@chromium.org2009-03-052-1/+5
| | | | | | | | | | | | | | | would not focus the location bar. DOM UI now by default focus the page. The NTP one focus the location bar. Also removed some unused fields from the history and download DOM UI. BUG=8356 TEST=Open NTP, focus should be on location bar Review URL: http://codereview.chromium.org/39173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11034 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-059-13/+23
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug: Scrolling the Spell-checker drop-down box adds the languages ↵sidchat@google.com2009-03-052-2/+44
| | | | | | | | | scrolled. Basically, when a spell check language changes, it is added to the accept languages list so that it is remembered later. However, when the list gets scrolled, it keeps adding all the languages it scrolled. So, I decided to fix this by adding only the latest language selected as the spell check dictionary language in the drop down. Issue=8374 Review URL: http://codereview.chromium.org/40145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11022 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the height of options on the Languages panel.mal@chromium.org2009-03-051-2/+2
| | | | | | | | | | | | | I changed two instances of kUnrelatedControlLargeVerticalSpacing to the shorter kUnrelatedControlVerticalSpacing. Tested on XP (Luna, no theme) and Vista Aero. BUG= 5511 R= ben Review URL: http://codereview.chromium.org/40148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11016 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-0530-90/+90
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark manager would show black backgroundsky@google.com2009-03-051-3/+6
| | | | | | | | | | | | when not results are found for a search string. Using your halo methods does the trick. BUG=8367 TEST=see bug Review URL: http://codereview.chromium.org/39165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r9953 since it caused regressions like: ben@chromium.org2009-03-042-0/+6
| | | | | | | | | http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Review URL: http://codereview.chromium.org/40124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential crash if the saved options tab is ever out of bounds.ben@chromium.org2009-03-041-1/+4
| | | | | | | | http://crbug.com/8342 Review URL: http://codereview.chromium.org/40090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another regression. Coordinate calculation in the ↵ben@chromium.org2009-03-041-1/+5
| | | | | | | | | | OpaqueBrowserFrameView::HitTest method was wrong. http://crbug.com/8365 Review URL: http://codereview.chromium.org/37008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10907 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r10674, which got lost during Ben's reorg of the frame code.pkasting@chromium.org2009-03-042-7/+7
| | | | | | | | | I guess CalculateWindowSizeForClientSize() disappeared in that reorg? That's the one part of the old change I can't find where to put. BUG=8151 Review URL: http://codereview.chromium.org/39074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10896 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving SupportsWindowFeature from BrowserViewtc@google.com2009-03-042-39/+11
| | | | | | | | | | | | | | | | | | to Browser. Turns out the test regression was actually caused by r10806 which removed an anonymous namespace causing the TestView class to collide with the same class in render_widget_host_unittest.cc. For now, fix by adding the TestView in the view unittest to the anon namespace. shess is going to try to re-add the namespace to render_widget_host_unittest.cc too. TBR=pkasting Review URL: http://codereview.chromium.org/40058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10873 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NavigationEntry title to string16. TabContents::GetTitle no longer needsbrettw@chromium.org2009-03-049-19/+19
| | | | | | | | | | | | | | | to be virtual, either. This also changes how the display URL is computed. Instead of doing it preemptively, we now do so lazily. This allows us to do the URL formatting correctly using the elider so that we can do IDN and unescaping. I changed string_util's singleton functions. I was worried that other code might make a singleton of string, which would give you this same value as a non-const string. This would mean our empty strings might no longer be empty. Review URL: http://codereview.chromium.org/39022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10872 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where the window caption buttons weren't clickable when ↵ben@chromium.org2009-03-042-17/+14
| | | | | | | | | | | | maximized. This is because of the nonclient frameview/clientview hierarchy changes. Make sure that the frame gets a chance to respond to GetViewForPoint before the client view if the client view does not visually overlap. http://crbug.com/8312 Review URL: http://codereview.chromium.org/40062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release-only build break.pkasting@chromium.org2009-03-041-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10848 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chromium windows not hide auto-hide taskbars.pkasting@chromium.org2009-03-045-37/+69
| | | | | | | | | | | | | | | There are a few caveats here: * On Aero glass, if the auto-hide taskbar is at the top of the screen, we get one row of nonclient pixels along the bottom of the screen (not too noticeable for light-colored pages, looks a bit odd with a dark page). I can't find a way around this. * Switching between fullscreen and normal mode can leave things a bit confused until you click another app and then reactivate Chromium. This seems to happen with other applications too (e.g. Firefox fullscreen mode) so I'm not too worried. * Chromium does not deal well with toggling the taskbar's auto-hide setting (or, I think, its position?) unless you restore and remaximize the window. I tried to fix this via modified handling of WM_SETTINGCHANGE but only made things worse and so gave up. BUG=20 Review URL: http://codereview.chromium.org/28338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10845 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeUI, HistoryTabUI, DownloadsTabUI since they've been superceded.ben@chromium.org2009-03-033-1623/+0
| | | | | | Review URL: http://codereview.chromium.org/39005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10832 0039d316-1c4b-4281-b951-d872f2087c98
* Move RemoveTabAt to the TabStrip interface from RemoveTabAnimation.jhawkins@chromium.org2009-03-032-23/+21
| | | | | | | | * This change is needed to allow a clean refactoring of TabStrip. The animation classes should be as cross-platform as possible. * RemoveTabStrip animation now requests the TabStrip to remove a tab for it. Review URL: http://codereview.chromium.org/27366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use grit to generate locale rc files and remove the old locale rc ↵tc@google.com2009-03-032-11/+39
| | | | | | | | | | | files from the tree." Revert "window_ is null during BrowserWindow creation. Assume full screen" Revert "Move SupportsWindowFeature from BrowserView to Browser so" git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
* Move SupportsWindowFeature from BrowserView to Browser sotc@google.com2009-03-032-39/+11
| | | | | | | | | | | we can share the code on all platforms. I still left a SupportsWindowFeature method in BrowserView that handles fullscreen mode which is (for now) a Windows specific feature. Review URL: http://codereview.chromium.org/27372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10804 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few comments / formatting related to the location bar.deanm@chromium.org2009-03-031-1/+2
| | | | | | | | Correct the includes, forward declare TabContents. Review URL: http://codereview.chromium.org/39011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10800 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a small issue changing back to glass frame from opaque where theben@chromium.org2009-03-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10779 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that dropdown selects don't deactivate the main frame when opened ↵ben@chromium.org2009-03-032-0/+5
| | | | | | http://crbug.com/8247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10777 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/apps/result_codes.h to chrome/common/result_codes.hthestig@chromium.org2009-03-031-2/+1
| | | | | | Review URL: http://codereview.chromium.org/28279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10761 0039d316-1c4b-4281-b951-d872f2087c98
* Support DWM switching.ben@chromium.org2009-03-0322-1032/+735
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This completes the collapsing of window types and browser frames around a single class: views::Window. CustomFrameWindow is removed with this change. The Browser window is represented by a single views::Window subclass: BrowserFrame, which replaces both AeroGlassFrame and OpaqueFrame. NonClientView is now a container of two sibling classes - the Window's ClientView (in the Browser's case, BrowserView), and a NonClientFrameView subclass, which provides the rendering for the non-client portions of the window. These Views are siblings rather than the ClientView a child of the NonClientFrameView because when the DWM is toggled, the ClientView would have to be re-parented. Many Views make the assumption they are only inserted into a View hierarchy once, and so this is problematic. By having the views be siblings, this is avoided. With this in mind, all of the former NonClientViews now become NonClientFrameView subclasses: DefaultNonClientView -> CustomFrameView (non-existent, NonClientView) -> NativeFrameView AeroGlassNonClientView -> GlassBrowserFrameView OpaqueNonClientView -> OpaqueBrowserFrameView The latter two derive from NonClientFrameView via BrowserNonClientFrameView, which adds some extras. I also had to modify the TabRenderer class to know how to drop its cache of tab background images when the theme changes since it uses different ones for Glass and non-Glass. This change also fixes a few non-client flicker issues relating to window non-client activation by using more ScopedRedrawLocks. (Touches info_bubble.cc, window.cc) Bugs fixed: http://crbug.com/153 http://crbug.com/747 http://crbug.com/2371 http://crbug.com/3264 http://crbug.com/8234 Plumbing for http://crbug.com/8247 Design docs: http://dev.chromium.org/developers/design-documents/views-windowing http://dev.chromium.org/developers/design-documents/browser-window Review URL: http://codereview.chromium.org/27317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10757 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark and menu drag images by making a halo around them. This makesbrettw@chromium.org2009-03-0212-5/+17
| | | | | | | | | | | | | the ClearType composited on the correct color to fix the semitransparent pixels into 1-bit transparency pixels. Remove some unnecessary header file dependencies on ChromeCanvas I noticed when compiling this patch. BUG=8258 Review URL: http://codereview.chromium.org/27321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10732 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the AutocompleteEditView from the cross-platform code.deanm@chromium.org2009-03-022-5/+6
| | | | | | | | | | | | Separate the platform specific AutocompleteEditView from the cross-platform model and controller. This leaves the model/controller in autocomplete_edit.{h,cc}, and moves the view into autocomplete_edit_view.h and autocomplete_edit_view_win.{h,cc}. There is now an abstract interface (AutocompleteEditView) which the model uses to talk to the view. Other views (for example, the LocationBarView) will still talk directly to the AutocompleteEditViewWin, which is the full Chrome view. This change also pulled in the Windows specific edit_drop_target code into autocomplete_edit_view_win.cc. Review URL: http://codereview.chromium.org/27327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix system menu positioning in fullscreen mode to be at the upper left ↵pkasting@chromium.org2009-02-282-8/+11
| | | | | | | | | corner of the screen. BUG=8151 Review URL: http://codereview.chromium.org/28247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10674 0039d316-1c4b-4281-b951-d872f2087c98
* Does two changes to appease chrome bot runs:sky@google.com2009-02-284-3/+14
| | | | | | | | | | | | | | | | | . Changes InfoBubble to properly initialize all fields in member initializer list and set the delegate before show on the off chance the bubble is deleted from show. This should no longer happen after the second change. . Only show the bookmark bubble if the browser window is active. I experimented with conditionally enabling the star and this turns out to be a bit error prone. BUG=none TEST=none Review URL: http://codereview.chromium.org/31016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10659 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor download shelf and prepare for porting.estade@chromium.org2009-02-283-56/+34
| | | | | | | | Side effect of removing some views dependencies from places they don't belong. Review URL: http://codereview.chromium.org/28252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10657 0039d316-1c4b-4281-b951-d872f2087c98
* When we open a popup window from an app window, we used to identify this ↵mad@chromium.org2009-02-271-3/+3
| | | | | | | | | | | | popup window as an app too. To not lose this functionality, yet fix bug 5739 about those app popup windows which would persist their window placement, I decided to add a new enum browser type item which is a bit combination of both popup and app so we can track those. bug= http://crbug.com/5739 Review URL: http://codereview.chromium.org/28271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10636 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 12:54:39 +0000