summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Remove the browser_sync flag.zork@chromium.org2009-10-277-99/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/337034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98
* Add "remember my choice" checkbox for windows external protocol dialog.estade@chromium.org2009-10-272-3/+25
| | | | | | | | BUG=24085 Review URL: http://codereview.chromium.org/332039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30225 0039d316-1c4b-4281-b951-d872f2087c98
* Page action pixel-god appeasement (better positioning and spacing for the ↵finnur@chromium.org2009-10-271-2/+8
| | | | | | | | | | | page action icons). BUG=25708 TEST=Visual inspection. See bug. Review URL: http://codereview.chromium.org/329028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30218 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes TabStrip::CanUpdateDisplay. This appears to be the culprit for asky@chromium.org2009-10-272-38/+20
| | | | | | | | | | | | couple of crashes we're getting. BUG=24132, 13707 TEST=thorougly test tab dragging on windows and make sure there are no regressions. Review URL: http://codereview.chromium.org/337013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30193 0039d316-1c4b-4281-b951-d872f2087c98
* Replace ExtensionAction with ExtensionAction2.aa@chromium.org2009-10-274-15/+15
| | | | | | | | BUG=24472 Review URL: http://codereview.chromium.org/337035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30172 0039d316-1c4b-4281-b951-d872f2087c98
* Move page actions over to ExtensionAction2 and get rid ofaa@chromium.org2009-10-273-90/+86
| | | | | | | | | | | | | extension_action.*. Final bit of refactor will be to rename ExtensionAction2 to ExtensionAction will be the next CL. BUG=24472,25844 Review URL: http://codereview.chromium.org/332021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30133 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs throb on views when the title changes.sky@chromium.org2009-10-264-14/+68
| | | | | | | | | | BUG=25308 TEST=go to gmail, pin the tab, select another tab. Have someone IM you and make sure your gmail tab throbs. Review URL: http://codereview.chromium.org/329021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30113 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit http://codereview.chromium.org/314016 with views fixedzork@chromium.org2009-10-262-8/+7
| | | | | | Review URL: http://codereview.chromium.org/338008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30106 0039d316-1c4b-4281-b951-d872f2087c98
* o Cleans up canonical extension_install_ui.cc to avoid #ifdefs when feasible.mark@chromium.org2009-10-261-1/+16
| | | | | | | | | | | | | | | o Adds Cocoa implementation of the extension installation prompt. o Added new cross-platform implementations of the extension install error prompt. o Got rid of unused extension install strings from early implementations. o Added a string to display as the header of the error dialog, since it was inline English. Patch by Andrew Bonventre <andybons@gmail.com> BUG=19654 TEST=Install an extension on any platform, observe consistent visual behavior and messaging. Review URL: http://codereview.chromium.org/333015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98
* CompactNavigationBar for toolkit views build, with some design change per ↵oshima@chromium.org2009-10-267-11/+33
| | | | | | | | | | | | | | | | | Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Review URL: http://codereview.chromium.org/329009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor widget methods to support desktop notifications, including GTK stubs.johnnyg@chromium.org2009-10-262-4/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/307030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when a page action cannot load its icon.aa@chromium.org2009-10-261-1/+2
| | | | | | | | | | | | | | | | | This can happen legitmately if the icon has been moved or corrupted on disk. I think we are hitting it too frequently for that to be the whole explanation, but since this code is moving around a lot shortly, it seems prudent to put in the quick fix and worry about what's really going on post-refactor. BUG=25601 TEST=Remove an extension's page action icon from its folder after installation. Should not crash when attempting to show page action. Review URL: http://codereview.chromium.org/339005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30069 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that when a folder is open on the bookmark bar and thesky@chromium.org2009-10-268-125/+235
| | | | | | | | | | | | mouse moves over another folder, the menu for that folder is shown. BUG=355 TEST=thorougly test all possible permutations of bookmark menus you can think of, including drag and drop to the menus. Review URL: http://codereview.chromium.org/328012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30049 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where popups and app frames lost their titlebars.ben@chromium.org2009-10-261-1/+5
| | | | | | | | | | TBR=pkasting http://crbug.com/25784 TEST=open any popup window or app frame, should have title bar to drag window. Review URL: http://codereview.chromium.org/328026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30029 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BrowserActions, and add support foraa@chromium.org2009-10-244-101/+165
| | | | | | | | | | | | | | | | | tab-specific state. Future changelists will move Page Actions over to ExtensionAction2, then replace ExtensionAction and ExtensionActionState with ExtensionAction2. Also, fix a bug in setIcon({path:...}) where it would work only the first time. BUG=24669,24472 Review URL: http://codereview.chromium.org/306044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29997 0039d316-1c4b-4281-b951-d872f2087c98
* Increase visual spacing between browser action buttons to 5px.rafaelw@chromium.org2009-10-241-1/+9
| | | | | | | | BUG=25444 Review URL: http://codereview.chromium.org/316019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29988 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Extensinos menu item to GTK.estade@chromium.org2009-10-231-6/+2
| | | | | | | | | | Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled. BUG=25424 Review URL: http://codereview.chromium.org/316017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29964 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that clicking the "Get Themes" link in the options dialog box ↵ben@chromium.org2009-10-231-3/+5
| | | | | | | | | | | activates the browser window that the themes gallery is opened in. http://crbug.com/24866 TEST=see bug Review URL: http://codereview.chromium.org/308013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29949 0039d316-1c4b-4281-b951-d872f2087c98
* Get the About panel to align its links correctly,davemoore@chromium.org2009-10-231-2/+7
| | | | | | | | but undo a previous change to the way we measure strings in pango. Review URL: http://codereview.chromium.org/338001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29943 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some #includes where possible.pkasting@chromium.org2009-10-231-18/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/335002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29915 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs on linux throb when the title changes. Isky@chromium.org2009-10-234-5/+12
| | | | | | | | | | | need to resolve with Glen/Nicholas how to handle the windows side. BUG=25308 TEST=none Review URL: http://codereview.chromium.org/314010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the RootView is sized to the correct bounds when the opaque frame ↵ben@chromium.org2009-10-232-80/+14
| | | | | | | | is maximized.It seems that now, when an opaque frame is maximized we also need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know why, it's just is.I reworked the way Widget allows subclasses to handle sizing of the RootView... I delegate responsibility for determining the RootView's bounds to a helper virtual function which BrowserFrameWin overrides. This seems cleaner to me. I make sure this handling only occurs when the window is not maximized.http://crbug.com/25227TEST=use to a theme or switch off glass on vista or use Xp. Maximize the browser window. The tabs should be entirely visible. Review URL: http://codereview.chromium.org/304007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29882 0039d316-1c4b-4281-b951-d872f2087c98
* Readding from scratch instead reverting the revert.finnur@chromium.org2009-10-231-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It kept eating the files I added, so I recreated the changelist from scratch using the raw patch downloaded from Rietveld. TBR=mpcomplete Original description: We changed the page action manifest from 'icon' -> 'default_icon' and now allow extensions to programmatically specifying an icon. However, page actions that hard-coded an icon using the 'icon' tag in the manifest (don't show an icon programmatically) now lose their icons. This causes a crash when we try to display the icon in the LocationBarView. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/334005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29875 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29861 since this fail on the interactivefinnur@chromium.org2009-10-231-10/+1
| | | | | | | | | | | | | | | | | | | | | | | | linux dbg bot, for some weird reason... Page actions that don't specify an icon (ie. have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. TBR=nsylvain BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29867 0039d316-1c4b-4281-b951-d872f2087c98
* Page actions that don't specify an icon (ie.finnur@chromium.org2009-10-231-1/+10
| | | | | | | | | | | | | | | | | have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix conflicts between accelerator keys and HTML DOM accesskeys.suzhe@chromium.org2009-10-234-14/+19
| | | | | | | | | | | | | This CL fixes conflicts between accelerator keys and HTML DOM accesskeys by suppressing Char events if corresponding RawKeyDown event was handled by the browser after returning from the renderer unhandled. This CL not only fixes this conflict issue, but also makes the behavior of handling accelerator keys similar than IE, which also suppresses a key press event if the key down event was handled as an accelerator key. BUG=21624 accesskey attributes conflict with browser shortcuts (like tab-switching) TEST=Open http://djmitche.github.com/buildbot/docs/0.7.11/ in one of opened multiple tabs, switch to another tab by pressing an alt-# key binding, then switch back to the original page to see if it's just as you left it before switching tabs. Review URL: http://codereview.chromium.org/235039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29857 0039d316-1c4b-4281-b951-d872f2087c98
* The TableViewObserver::OnKeyDown method signature was changed recently andjcampan@chromium.org2009-10-233-21/+22
| | | | | | | | | | | | | | | | | the bookmark manager view had not been properly updated and was not called anymore, breaking the keyboard shortcuts. This was broken in the TaskManager as well. Also changed the TreeView to use the base::KeyboardCode. BUG=25533 TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE, ENTER...) work in the bookmark manager. Test that in the TaskManager, pressing ENTER activates the selected tab. Review URL: http://codereview.chromium.org/322006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29854 0039d316-1c4b-4281-b951-d872f2087c98
* * Moved panel controller to chromeos directoryoshima@chromium.org2009-10-2214-978/+158
| | | | | | | | | | | | | | | | | * Include BrowserExtender to regular build to remove CHROMEOS ifdefs in BrowserView * moved browser_extender.h to chrome/browser/views/frame, and BrowserExtender methods to chrome/browser/views/frame/browser_extender.cc. * Added StandardExtender (standard_extender.cc), which is empty now. I'm going to add MainMenu support to win, which will be added vua StandardExtender with a command line flag. * factory method "Create" is now defined in standard_extender.cc and chromeos/chromeos_browser_extenders.cc. toolkit_views=1 uses chromeos_browser_extenders.cc and other build uses standard_extender BUG=None TEST=None Review URL: http://codereview.chromium.org/317001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29836 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of file path name handling.brettw@chromium.org2009-10-222-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | This started trying to cleanup DownloadManager::GenerateFilename which asserts if your system locale isn't UTF-8 (I ran into this when mine got messed up). The solution is to have GetSuggestedFilename return a FilePath rather than calling FromWStringHack. The rest of the patch is a result of trying to write GetSuggestedFilename in a reasonable way. I changed ReplaceIllegalCharacters to work on a FilePath::StringType. Some places in the code calling these functions got cleaner, some got messier. I think overall the ones that got messier are the ones doing sketchy things with paths and the ones that got cleaner are the ones doing things more properly. The only code here that gets called a nontrivial number of times is the weburlloader, and I think the new code does about the same number of string conversions overall (though on certain platforms the number will be higher or lower). BUG=none TEST=none Review URL: http://codereview.chromium.org/271056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29832 0039d316-1c4b-4281-b951-d872f2087c98
* Enable System Context Menu for linux views.oshima@chromium.org2009-10-228-14/+29
| | | | | | | | | | | | | | | | * Chagned WindowGtk to pass through right click mouse event for HTCAPTION so that ContextMenuController on Frame/Tab view works. * Added ContetMenuController to NonClientView. * Added "PointIsWithinWindowCaption to BrowserView to exclude chromeos specific components from Caption area. Fix a minor bug in NonClientView * GetViewForPoint was using wrong point. This wasn't causing any issue as the frame_view's origin was (0, 0) BUG=None TEST=run chromeos build and right click frame view and verify that you get system menu. Review URL: http://codereview.chromium.org/303014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29807 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add browser actions popups.estade@chromium.org2009-10-221-0/+7
| | | | | | | | | | | | Also add a new notification that tells the popup to close. BUG=23897 TEST=--load-extension=chrome/test/data/extensions/samples/buildbot TEST=--load-extension=chrome/test/data/extensions/samples/set_page_color Review URL: http://codereview.chromium.org/314008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29785 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/306039 for Sean:sky@chromium.org2009-10-222-0/+63
| | | | | | | | | | | Adding support for constrained dialogs with toolkit_views. BUG=none TEST=none Review URL: http://codereview.chromium.org/322002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29778 0039d316-1c4b-4281-b951-d872f2087c98
* Gets status bubbles on views/gtk to correctly track when the parentsky@chromium.org2009-10-214-2/+50
| | | | | | | | | | | | | window is hidden/minimized/moved. This is made tricky by the fact that gtk doesn't have the notion of owned windows that automatically hidden along with the parent as windows does. BUG=none TEST=none directly, although covered by ui tests. Review URL: http://codereview.chromium.org/304008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29710 0039d316-1c4b-4281-b951-d872f2087c98
* Messaging of the download item for extension is now:mark@chromium.org2009-10-211-7/+7
| | | | | | | | | | | | | | | | Extensions can harm your computer. Are you sure you want to continue? [Continue] [Discard] This involved taking out the GTMUILocalizerAndLayoutTweaker from the xib and placing it within the controller itself, since the content of the UI is determined at runtime and cannot rely simply on the xib contents. For Win and Linux, only the confirm button needed to change. Patch by Andy Bonventre <andybons@gmail.com> BUG=23105,25257 TEST=When clicking on a link to an extension, the messaging should be specific to extensions and the button to confirm the installation should be 'Continue' instead of 'Save'. Review URL: http://codereview.chromium.org/293014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29706 0039d316-1c4b-4281-b951-d872f2087c98
* Use the original profile when opening the keyword editor window, sincepam@chromium.org2009-10-211-0/+4
| | | | | | | | | | | | | | | otherwise the profile pointer may go stale if it was opened from an Incognito window. Simplify the check that already does this on Mac. GetOriginalProfile() returns the profile it's called on, if it isn't incognito. BUG=23359 TEST=open Incognito window, right-click in omnibox, Edit Search Engines, close Incog window, edit an engine Review URL: http://codereview.chromium.org/307010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29666 0039d316-1c4b-4281-b951-d872f2087c98
* Fix drawing code for page action badges.mpcomplete@chromium.org2009-10-202-31/+101
| | | | | | | | | | The badge can now extend beyond the boundary of the image. BUG=24644 Review URL: http://codereview.chromium.org/297014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29581 0039d316-1c4b-4281-b951-d872f2087c98
* Allow ESC to cancel ALT+SHIFT+T in Toolbar.mhm@chromium.org2009-10-203-16/+57
| | | | | | | | | | | By overriding SkipDefaultKeyEventProcessing in View, it will ensure that the current hackish implementation of Toolbar request focus will be dealt before any other focus related actions and accelerators. BUG=8239 TEST=Press ESC while in accessibility mode. Review URL: http://codereview.chromium.org/272024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29572 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bubbles deactivating the opaque frame.ben@chromium.org2009-10-201-8/+8
| | | | | | | | | | | The theme work caused a check that had been included to see if the frame view should be painted as active even if it was inactive. This reintroduces that check. http://crbug.com/20966 TEST=see bug Review URL: http://codereview.chromium.org/303012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29571 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 29457, because this is making ExtensionBrowserTest.PageAction ↵mpcomplete@chromium.org2009-10-203-82/+17
| | | | | | | | | | | | | | | | | | crash on Vista" Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/293031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29556 0039d316-1c4b-4281-b951-d872f2087c98
* Remove +x bit from files that shouldn't have it.evan@chromium.org2009-10-207-0/+0
| | | | | | Review URL: http://codereview.chromium.org/307007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29548 0039d316-1c4b-4281-b951-d872f2087c98
* PanelControler supportoshima@chromium.org2009-10-206-18/+108
| | | | | | | | | | | | | | | | * Refactored BrowserExtender and added NormalExtender and PopopExtender. BrowserExtender::Create factory method returns appropriate extender for given BrowserView. * Added #if/#else to PanelController to accept BrowserView in Constructor. * added guard code in Close so that it will ignore 2nd invocation of Close. (views seems to call Close() (when it requests, and when it's really closed) Added missing code in TabOverviewMessageListener BUG=None TEST=None Review URL: http://codereview.chromium.org/276075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29533 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29457, because this is making ExtensionBrowserTest.PageAction crash ↵nsylvain@chromium.org2009-10-203-16/+82
| | | | | | | | | | | | | | | | | | | | on Vista Original description: Implement badges for page actions. Also add badge text color API. Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/306004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29509 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setIcon({path:...});aa@chromium.org2009-10-202-99/+115
| | | | | | | | BUG=22575 Review URL: http://codereview.chromium.org/269103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29495 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use gtk_dialog_run for extension install errors becausetony@chromium.org2009-10-201-2/+2
| | | | | | | | | | it blocks the main message loop. BUG=19441 Review URL: http://codereview.chromium.org/294014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29482 0039d316-1c4b-4281-b951-d872f2087c98
* Implement badges for page actions. Also add badge text color API.mpcomplete@chromium.org2009-10-193-82/+16
| | | | | | | | | | | | Also change color APIs from wanting ARGB to RGBA. BUG=24635 BUG=24644 BUG=25215 Review URL: http://codereview.chromium.org/291003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29457 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-192-6/+6
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer obey import_search_engine preference even if FRUI is enabled.kuchhal@chromium.org2009-10-196-17/+43
| | | | | | | | | | | | With this change importer will give preference to the value specified in master preference for import_search_engine instead of ignoring it like before. BUG=23649 TEST=Specified in above bug. Review URL: http://codereview.chromium.org/274081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29426 0039d316-1c4b-4281-b951-d872f2087c98
* Do work necessary to make Views About panel work on Chrome OS. This is to be ↵davemoore@chromium.org2009-10-195-24/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | used for forcing Chrome OS updates. There were many things that needed to be fixed for this to work. Make skia's canvas return height of font for size of strings, instead of the actual height of the characters to bring it in line with Windows. Make average character widths use pango metrics and windows dialog units. Make this lazy, to avoid most calls. Fix bug in About panel that failed to adjust the embedded links to allow for the padding that Link adds so they can be focused. Support gtk about panel in regular build, views in chrome os only. Fix WindowGtk to call WindowClosing() Fix canvas_linux::SetupPangoLayout() to wrap correctly, if passed a width Fix Label::ComputeMultiLineFlags() to turn off eliding. With eliding the pango routines always return 1 line. Enable focus manager in dialogs. Version loader crashed in debug. Review URL: http://codereview.chromium.org/282002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29414 0039d316-1c4b-4281-b951-d872f2087c98
* Allow slightly larger browser and page action icons.aa@chromium.org2009-10-172-13/+18
| | | | | | | | | | | | | | | | | | | | | | | This allows 19px icons to be able to be used for both browser and page icons. I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome, but some Chrome location bar icons use 18px for soft edges, so I guess this will just have to be something we advise developers on. We can actually fit up to 21 (whoa nelly) pixels on Windows, but apparently the space is slightly smaller on mac. Also minor layout fix. We were sizing the browser action buttons 1px too short. BUG=24881 TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space. Review URL: http://codereview.chromium.org/286001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29365 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CHROME_PERSONALIZATION to BROWSER_SYNC.nick@chromium.org2009-10-177-69/+62
| | | | | | | | | | Avoid #ifdef in general, favoring #if defined(). In one spot, use PlatformThread::Sleep instead of rolling our own. Review URL: http://codereview.chromium.org/267125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-27 13:40:04 +0000