summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-1347-78/+77
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Small clean-up to not expose base::Process from RenderProcesHost, and ↵jam@chromium.org2009-11-131-2/+1
| | | | | | | | instead only expose base::ProcessHandle. Precursor to moving process startup off the UI thread. Review URL: http://codereview.chromium.org/387047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31922 0039d316-1c4b-4281-b951-d872f2087c98
* Load default browser action icons only once per-window. Thisaa@chromium.org2009-11-132-33/+31
| | | | | | | | | | | | | | | also changes the loading logic to be just like the GTK port, because it was nicer, and because it is nice for them to be parallel as much as possible. It would be better to only load this icon once per application session, but that would require something fancier. BUG=27485 Review URL: http://codereview.chromium.org/389032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31897 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in BrowserActionButton::OnImageLoaded.mpcomplete@chromium.org2009-11-121-0/+4
| | | | | | | | BUG=27167 Review URL: http://codereview.chromium.org/385072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31840 0039d316-1c4b-4281-b951-d872f2087c98
* Focus fix for compact navigation bar.oshima@chromium.org2009-11-123-1/+11
| | | | | | | | | | | | * Make focusable so that focus can be moved to compact navigation bar by tab. * Ctrl-L should focus the compact navigation bar (and select all texts) BUG=51 (chrome-os) TEST=switch to compact navigation bar mode, hit tab or ctrl-L to move focus to compact navigation bar. Review URL: http://codereview.chromium.org/384079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31808 0039d316-1c4b-4281-b951-d872f2087c98
* When extensions use notifications, display the name of the extension in UI ↵johnnyg@chromium.org2009-11-121-2/+2
| | | | | | | | | | | rather than the "origin". BUG=26961 TEST=test extension linked in the bug Review URL: http://codereview.chromium.org/385058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31799 0039d316-1c4b-4281-b951-d872f2087c98
* Allow script in notifications to close the notification by calling ↵johnnyg@chromium.org2009-11-122-1/+12
| | | | | | | | | | | | window.close(). BUG=26277 TEST=none Review URL: http://codereview.chromium.org/385056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31791 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on sync for OS X (behind an --enable-sync switch).akalin@chromium.org2009-11-121-1/+2
| | | | | | | | | | | Added ProfileSyncService::IsSyncEnabled(). BUG=23073 TEST=manually (OS X),trybot Review URL: http://codereview.chromium.org/389019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix jumping/resize/relayout of NTP/webpages when switching between NTP and ↵simonrad@chromium.org2009-11-111-7/+15
| | | | | | | | | | | | | | | | | | another tab. (This really fixes 3 issues) 1. When the bookmarks bar is not docked, it toggles on and off when switching between the NTP and another tab. Since it is part of the UI, this causes the TabContents to be resized. This causes ugly re-layout of some webpages and also causes the NTP to jump when you switch to it, if themed. The solution is to toggle the floating bookmarks bar at a time when no TabContents is attached - that is, after detaching the first one but before attaching the second one. 2. Changing the info-bar can also cause a resize, so we also want to do this when no TabContents is attached. 3. Finally, when the NTP is displayed and another, floating tab is dragged and inserted to the left of the NTP, the selected tab index will not be set correctly. As a result, the NTP will be resized incorrectly before the tabs are even switched. R=beng BUG=23925 TEST=1. Apply Ratchet and Clank theme. Open NTP and Google Calendar in tabs. Switch back and forth between them. The NTP background should not jump or flicker, and Calendar should not re-layout. 2. Try switching between the NTP (or Calendar) and a tab that has an info-bar. 3. Open NTP and another tab. Drag the other tab until it detaches from the windows and floats. Re-attach and detach the tab repeatedly, so that the window switches between displaying the two tabs, and make sure you insert the other tab to the *left* of the NTP. The NTP should never jump. Review URL: http://codereview.chromium.org/376018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31687 0039d316-1c4b-4281-b951-d872f2087c98
* Change width of install bubble to avoid orphan.aa@chromium.org2009-11-111-1/+1
| | | | | | | | | BUG=27351 TEST=none Review URL: http://codereview.chromium.org/385034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31680 0039d316-1c4b-4281-b951-d872f2087c98
* Add a close button to ExtensionInstalledBubble.rafaelw@chromium.org2009-11-111-4/+37
| | | | | | | | | BUG=27156 TEST=Install an extension, the installed successful bubble should have a close button with an x image that will close the bubble when clicked. Review URL: http://codereview.chromium.org/384026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31675 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-118-10/+10
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash during tab dragging. The code was invokingsky@chromium.org2009-11-112-8/+18
| | | | | | | | | | | | InitWindowCreatePoint when making a tab pinned, which is only save to invoke when the drag starts. BUG=27329 TEST=make sure no regressions in tab dragging. Review URL: http://codereview.chromium.org/391006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31663 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a common crash. We were leaking theaa@chromium.org2009-11-111-0/+1
| | | | | | | | | | | | | | BrowserActionView because RemoveChild() does not delete it. This could maybe cause OnImageLoaded() to be called when there is no parent. I couldn't see any other path that could lead to that. BUG=27167 TEST=none Review URL: http://codereview.chromium.org/385031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31651 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid inconsistent state (leading to checkfailures) due to Windows ↵pkasting@chromium.org2009-11-116-161/+48
| | | | | | | | | | | | minimize/restore functionality hiding and showing the autocomplete dropdown outside of the awareness of the controller. Instead, this switches to the simpler model of just creating a new HWND when we want to show the dropdown, and destroying it when we want to close it. Happily, this also seems to save quite a bit of code. BUG=20511 TEST=Type a character in the omnibox, minimize the window, and restore it. The dropdown should have disappeared. Review URL: http://codereview.chromium.org/391011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31649 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a 'V8' column to task manager to track amount of memory in JavaScript heapjamesr@chromium.org2009-11-111-0/+11
| | | | | | | | | BUG=27226 TEST=open task manager, enable column, compare with V8 heap profiler Review URL: http://codereview.chromium.org/377037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31641 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in showing bookmark menus where the wrong menu wouldsky@chromium.org2009-11-111-3/+5
| | | | | | | | | | | appear when rtl. BUG=26376 TEST=see bug Review URL: http://codereview.chromium.org/384021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31624 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a couple of missing parts for extensios on linux/views.oshima@chromium.org2009-11-112-8/+10
| | | | | | | | | | | | | | | | * Creating RenderWidgetHostView for gtk * Fix assertion failure in BrowserBubble * Don't change the window size if the size is empty, which causes gtk assertion error. With this change, most of extension tests in browser passes except for toolstrip. Given that toolstrip is obsolete, may be we should just remove it from test. BUG=None TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/390006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31622 0039d316-1c4b-4281-b951-d872f2087c98
* Added a flag to the Canvas class which allows forcing an RTL directionalityidana@chromium.org2009-11-111-4/+18
| | | | | | | | | | | | | on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g. Windows XP with no RTL fonts installed). BUG=23425 TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs. Review URL: http://codereview.chromium.org/384018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31619 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a label alignment issue in ConfirmMessageBoxDialog. idana@chromium.org2009-11-101-13/+2
| | | | | | | | | | | | | There is no need to manually detect the text directionlity at run time. Setting the label's alignment to views::Label::ALIGN_LEFT is sufficient because the mirroring subsystem will flip it automatically if the locale is RTL. BUG=26378 TEST=Run chrome with --lang=he, enable sync and then disable through the options dialog. Text in dialog box should be right aligned. Review URL: http://codereview.chromium.org/390005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31616 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled extensions should be uninstallable. finnur@chromium.org2009-11-101-1/+1
| | | | | | | | | | | | | | | | | | | | | The code to display the dialog looks up an Extension by id but doesn't return disabled ones. So I added that option to the function. I also added a check so that we don't show the Options button enabled when the extension is disabled, since you need the extension to be enabled for the Options page to work. BUG=26910 TEST=Disable an extension that has an Option page, make sure Options is not enabled after disabling, then uninstall it. It should uninstall. Review URL: http://codereview.chromium.org/385014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31612 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in showing bookmark menu. The problem occurredsky@chromium.org2009-11-101-4/+15
| | | | | | | | | | | | | | when you clicked on one top level menu on the bookmark bar, moused over another menu and then we loaded favicons for the first menu. The code needs to figure out which menu has the icon instead of invoking set icon on menu_. BUG=27067 TEST=make sure bookmark menus work ok. Review URL: http://codereview.chromium.org/388007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31603 0039d316-1c4b-4281-b951-d872f2087c98
* implement "Learn more" link in "Aw snap" page.kuan@chromium.org2009-11-104-14/+54
| | | | | | | | | | | this changelist is only for windows. BUG=21726 TEST=verify that "Learn More" link shows up centralized beneath crash message and when clicked, opens the url specified in bug. Review URL: http://codereview.chromium.org/377016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31573 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an options menu to the frame of the desktop notification, for now with ↵johnnyg@chromium.org2009-11-102-3/+110
| | | | | | | | | | | | | the single option of revoking permissions from that origin. The renderer side change is a related issue that the full URL was being sent as the "source" of the notification rather than only the origin. BUG=26690 TEST=open a notification Review URL: http://codereview.chromium.org/363011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31547 0039d316-1c4b-4281-b951-d872f2087c98
* Add confirmation on extension uninstallation.finnur@chromium.org2009-11-101-12/+23
| | | | | | | | | | | Reuses the Install dialog (and makes it slightly more generic). BUG=27162 TEST=None Review URL: http://codereview.chromium.org/376030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31540 0039d316-1c4b-4281-b951-d872f2087c98
* Return false from TabContentsViewWin::HandleKeyboardEvent even if the tab ↵ananta@chromium.org2009-11-101-1/+4
| | | | | | | | | | | | | | | | | contents delegate (ExternaltabContainer) handled the keyboard event by sending it off to IE. This is to avoid the subsequent keyboard messages from being suppressed. This fixes bug http://code.google.com/p/chromium/issues/detail?id=27173 which caused a number of keyboard messages like Shift + characters to not work in ChromeFrame. This regressed in revision 29857 Review URL: http://codereview.chromium.org/376031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31521 0039d316-1c4b-4281-b951-d872f2087c98
* fix hover animation regression.oshima@chromium.org2009-11-093-12/+16
| | | | | | | | | BUG=27119 TEST=None Review URL: http://codereview.chromium.org/371082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31501 0039d316-1c4b-4281-b951-d872f2087c98
* Slow down animations for the tabstrip so they're visible again.ben@chromium.org2009-11-091-4/+4
| | | | | | | | | http://crbug.com/27119 TEST=create a new tab. you should see it animate in. Review URL: http://codereview.chromium.org/378034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31492 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31479.jcampan@chromium.org2009-11-091-2/+6
| | | | | | | | | The interactive UI tests still fail on the build bot. TBR=sky Review URL: http://codereview.chromium.org/372071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31488 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored FindBarHost/View to create DropdownBarHostView, which I'm plannig ↵oshima@chromium.org2009-11-0912-504/+762
| | | | | | | | | | | | | to use this for CompactLocationBar. BUG=None TEST=enabled find_bar_host_browsertest.cc for linux view build. Review URL: http://codereview.chromium.org/360044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31486 0039d316-1c4b-4281-b951-d872f2087c98
* Tentatively reenabling tests now that I fixed a test running before this onejcampan@chromium.org2009-11-091-6/+2
| | | | | | | | | | | | | | that was doing a Ctrl-Esc instead of Esc, bringing up the Windows start menu. Not sure why it would cause the tests to fail on the bot, probably an activation issue (that I cannot repro locally). BUG=26996 TEST=Make sure the interactive UI tests stay green on the Window build bot. Review URL: http://codereview.chromium.org/379009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31479 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserTabStrip should not be a TabStrip2 subclass, instead, it should just ↵ben@chromium.org2009-11-093-21/+27
| | | | | | | | | | | | | use it. Note that this results in the BrowserTabStrip being leaked. I will solve this problem later. BUG=none TEST=none Review URL: http://codereview.chromium.org/379002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31455 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out why on dragging thesky@chromium.org2009-11-091-26/+9
| | | | | | | | | | | | tab strip model is empty, but not the tab strip. The latest crash data indicates the tab strip is not closing all. BUG=24132 TEST=none Review URL: http://codereview.chromium.org/375017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31450 0039d316-1c4b-4281-b951-d872f2087c98
* Try one other thing temporarily to try to determine cause for a flaky test.finnur@chromium.org2009-11-091-1/+5
| | | | | | | | | | TBR=jcampan BUG=16447 TEST=This is changing a test Review URL: http://codereview.chromium.org/376024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31446 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a test that was sending a Ctrl-Esc instead of Esc key events.jcampan@chromium.org2009-11-091-1/+1
| | | | | | | | | BUG=None TEST=Run the tests. Review URL: http://codereview.chromium.org/377031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31443 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Let status bubble dodge to the right if necessary.thakis@chromium.org2009-11-091-1/+1
| | | | | | | | | | | | | Windows seems to do this either if a shelf is visible or if the status bubble would slide off screen, so chrome/mac now does that too :-/ Note that the right-aligned bubble overlaps a vertical scrollbar if present. That matches windows. BUG=22198 TEST=See bug. Also test that if both popup block bubble and status bubble are at the right, the status bubble should be on top of the popup block bubble. Review URL: http://codereview.chromium.org/372051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31428 0039d316-1c4b-4281-b951-d872f2087c98
* Kiosk Mode implementation.mhm@chromium.org2009-11-092-2/+17
| | | | | | | | | | | | Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble. BUG=23145 TEST=Kiosk Mode functions and Run the ./ui_tests --gtest_filter=KioskModeTest.* Review URL: http://codereview.chromium.org/244003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31412 0039d316-1c4b-4281-b951-d872f2087c98
* Remove flaky label for FindInPageControllerTest.FindDisappearOnNavigatefinnur@chromium.org2009-11-081-3/+1
| | | | | | | | | | | | | When I started looking into the test flakiness, it turns out it hasn't failed in 3 weeks, according to Phajdan's logs, so I am removing the Flaky label. BUG=16447 TEST=This is a test change. Review URL: http://codereview.chromium.org/371054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31399 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views buildben@chromium.org2009-11-081-3/+3
| | | | | | Review URL: http://codereview.chromium.org/375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31397 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the stuff relating to detached tab dragging out of BrowserFrameWin ↵ben@chromium.org2009-11-074-87/+109
| | | | | | | | and onto the TabStrip2 object. It was mostly cross platform anyway.Adds APIs to Widget that:- allow a Widget to be obtained for a given gfx::NativeView- allow native properties to be set on a Widget.Adds an API to Window that lets the caller convert the window's appearance into a lightly transparent transient looking thing for dragging.BUG=noneTEST=none Review URL: http://codereview.chromium.org/149440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31394 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire Ctrl+Shift+I to DevTools, Ctrl+Shift+J to JavaScript console. ↵pfeldman@chromium.org2009-11-071-2/+2
| | | | | | This way modifiers are consistent on Mac and it makes sense on Windows/Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31383 0039d316-1c4b-4281-b951-d872f2087c98
* Reland Extension Installed InfoBubblerafaelw@chromium.org2009-11-078-21/+412
| | | | | | | | | | | | | | | (fix mac build breakage) This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions. TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu. BUG=21412 TBR=willchan Review URL: http://codereview.chromium.org/376014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31365 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-0715-44/+44
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-073-4/+10
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary disabling interactive tests that are failing on the build botjcampan@chromium.org2009-11-071-2/+6
| | | | | | | | | | | (not locally) since the tests have been moved out of process. BUG=26996 TEST=Interactive test build bot should be green. TBR=sky Review URL: http://codereview.chromium.org/377021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with inline autocomplete and URLs that change length ↵pkasting@chromium.org2009-11-072-8/+6
| | | | | | | | | | | | | | | | | | | | during fixup: * URLs with http auth info, which gets stripped * URLs with IDN hosts * URLs with escaped values that get unescaped In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode. The fix is to track how fixup affects the offsets into the URL we care about. Plumbing this required an enormous number of additions :( There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match. Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong). This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it). BUG=4010 TEST=Covered by unittests Review URL: http://codereview.chromium.org/372017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31322 - Extension Installed InfoBubblewillchan@chromium.org2009-11-068-412/+21
| | | | | | | | | | | | | | | This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions. TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu. BUG=21412 Review URL: http://codereview.chromium.org/362022 TBR=rafaelw@chromium.org Review URL: http://codereview.chromium.org/375019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31326 0039d316-1c4b-4281-b951-d872f2087c98
* Adding traces to a test when it fails in the hope of atfinnur@chromium.org2009-11-061-14/+28
| | | | | | | | | | | | | least ruling some things out. These traces will be either be removed (once I get more data). TBR=jcampan BUG=16447 TEST=This is changing a test Review URL: http://codereview.chromium.org/373019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31325 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Installed InfoBubblerafaelw@chromium.org2009-11-068-21/+412
| | | | | | | | | | | | This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions. TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu. BUG=21412 Review URL: http://codereview.chromium.org/362022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31322 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of string cleanup in Sync:munjal@chromium.org2009-11-061-2/+1
| | | | | | | | | | | | | | | | | | - Get rid of sync_char16 from syncapi - Use wstring for title in syncapi since that gets converted to wstring later on anyway. - Use GURL for urls in syncapi - Return const string references from syncapi instead of pointers to C-style strings. - Make appropriate changes to calling code. BUG=26342 TEST=Already exist. Review URL: http://codereview.chromium.org/362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 13:05:58 +0000