summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Refactors DockInfo so that it can be used on Linux. I haven't done thesky@chromium.org2009-05-152-24/+38
| | | | | | | | | | | gtk side yet. BUG=none TEST=none Review URL: http://codereview.chromium.org/113424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16142 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFont->gfx::Fontbeng@google.com2009-05-1527-72/+76
| | | | | | | | | | Does not rename the files yet. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
* Signature changed to take a Profile*tim@chromium.org2009-05-152-2/+2
| | | | | | Review URL: http://codereview.chromium.org/113439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16140 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a trailing slash in BrowserView. gcc doesn't like these.sky@chromium.org2009-05-141-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/114030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16127 0039d316-1c4b-4281-b951-d872f2087c98
* Move Always On Top setting out of Window/WindowDelegate and into task ↵beng@google.com2009-05-145-25/+6
| | | | | | | | | manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views. http://crbug.com/11674 Review URL: http://codereview.chromium.org/115378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16107 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors menus so that I can create a MenuGtk implementation, and moves it intosky@chromium.org2009-05-1410-99/+109
| | | | | | | | | | | | the namespace views. BUG=none TEST=make sure I haven't broken any menus. This impacts all menus in Chrome, except bookmark ones. Review URL: http://codereview.chromium.org/113410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
* Add star icon for bookmarked results in the omnibox2 popup view.beng@google.com2009-05-142-6/+18
| | | | | | | | No, I'm not adding any more ternaries. Review URL: http://codereview.chromium.org/115336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16090 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1428-63/+85
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16088 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression caused by gfx::Size no longer accepting negative tim@chromium.org2009-05-141-3/+2
| | | | | | | | | | | | dimensions. BUG=11900 TEST=Open 'Show Saved Passwords' under Minor Tweaks. Should not crash, and the 'Show Password' button should be visible. Review URL: http://codereview.chromium.org/115331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16067 0039d316-1c4b-4281-b951-d872f2087c98
* Add match count text to the GTK find bar. This also makes the bar wider.brettw@chromium.org2009-05-142-25/+6
| | | | | | | | | | | | | | | | The match count text doesn't currently show up realiably because the data in the find reply is bad. I believe this is bug 11761. The clicker checking code has been moved to the cross-platform FindBarController so it doesn't have to be duplicated for each platform. This also add IntToString16. I didnt add all the variants now. The *Wstring versions should all eventually be changed to string16. http://crbug.com/11750 Review URL: http://codereview.chromium.org/114023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16058 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up of the accelerator code.jcampan@chromium.org2009-05-146-34/+38
| | | | | | | | | | | | | | | The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing. This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators. Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused. BUG=11538 TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus. Also test that tab traversal still work as expected in the browser and in the option dialog. Review URL: http://codereview.chromium.org/113307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with the omnibox2 popup:beng@google.com2009-05-132-7/+13
| | | | | | | | | | | - turn off transparency when glass isn't active - make transparency when glass is active more opaque - decrease the size of text to match the current omnibox popup - make dim text in highlighted rows invert. Review URL: http://codereview.chromium.org/113242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16003 0039d316-1c4b-4281-b951-d872f2087c98
* Move tree-related classes that Linux code depends on from views/ to app/phajdan.jr@chromium.org2009-05-134-11/+9
| | | | | | | | | | TEST=If it compiles and unit_tests pass, it's ok. Just moving files around. http://crbug.com/11066 Review URL: http://codereview.chromium.org/115185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 15965. I wasn't supposed to check that in since it still doesn't ↵maruel@chromium.org2009-05-1328-85/+63
| | | | | | | | | compile on linux and mac! TBR=sky Review URL: http://codereview.chromium.org/113351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1328-63/+85
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15965 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-1316-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Use the standard dotted rectangle when moving a tab out when "Show windowmaruel@chromium.org2009-05-122-1/+23
| | | | | | | | | | | | contents while dragging" is disabled. BUG=805 Patch contributed by Yusuke Sato (yusukes@google.com) Review: http://codereview.chromium.org/113176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15880 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the maximized frame background correctly.glen@chromium.org2009-05-121-3/+13
| | | | | | | | BUG=11695 Review URL: http://codereview.chromium.org/113227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15820 0039d316-1c4b-4281-b951-d872f2087c98
* Removing floating views, they are not used anymore.jcampan@chromium.org2009-05-112-8/+1
| | | | | | | | | BUG=None TEST=Run unit_tests, ui_tests, interactive ui_tests. Make sure focus traversal still works. Review URL: http://codereview.chromium.org/113215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15817 0039d316-1c4b-4281-b951-d872f2087c98
* This CL revert the fix for issue 2780 - RTL: Omnibar - message "Press Tab to ↵xji@chromium.org2009-05-111-46/+4
| | | | | | | | | | | | | | | | search Google" doesn't show correctly in a "New Tab" for RTL locales. (http://crbug.com/2780) Previous fix at http://codereview.chromium.org/100360 may have regressed the startup time by about 5ms/6.7% due to multiple call of PosFromChar(). Ts regression chart is at: http://build.chromium.org/buildbot/perf/xp-release-dual-core/startup/report.html?history=150 I am reverting the CL while working on solutions. Review URL: http://codereview.chromium.org/113221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15784 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to add these files as part of last change.ben@chromium.org2009-05-102-0/+121
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15734 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new ViewsDelegate interface and implementation in the windows browser UI.ben@chromium.org2009-05-102-0/+11
| | | | | | | | | | | | Provides a way for saving and restoring window placement, obtaining system helpers etc. http://crbug.com/11633 TEST=make sure window placement saving works, clipboard, and that windows in the taskbar have a chrome icon. Review URL: http://codereview.chromium.org/113173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15733 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NOTREACHED in status bubble if window is made too small.glen@chromium.org2009-05-091-2/+3
| | | | | | Review URL: http://codereview.chromium.org/100150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15728 0039d316-1c4b-4281-b951-d872f2087c98
* Use the non-native frame when using themes even on Aero Glass.ben@chromium.org2009-05-091-0/+1
| | | | | | Review URL: http://codereview.chromium.org/113183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15725 0039d316-1c4b-4281-b951-d872f2087c98
* Some unnecessary painting and initing was being done.glen@chromium.org2009-05-091-4/+0
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/113182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15714 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at themes.glen@chromium.org2009-05-0919-641/+578
| | | | | | | | | | | | This CL is paired with http://codereview.chromium.org/67284 This CL (for commit purposes) includes http://codereview.chromium.org/67284 BUG=4463,11232,11233,11234,11235 Review URL: http://codereview.chromium.org/99030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the popup blocking whitelist pref. This makes the whitelist ↵pkasting@chromium.org2009-05-092-21/+62
| | | | | | | | actually function.BUG=11440 Review URL: http://codereview.chromium.org/115149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15702 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-0817-17/+14
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 9837 - RTL: "Pop-ups blocked" bar should be at left-bottom ↵xji@chromium.org2009-05-081-2/+12
| | | | | | | | | | | | | | for RTL Chrome. The fix is to position the 'pop-ups blocked' bar at the bottom left for RTL chrome. Test: 1. Launch Hebrew Chrome 2. load http://www.brg8.com/ 3. Observe the 'pop-up blocked' bar after the page load. Review URL: http://codereview.chromium.org/89004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15691 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-0841-126/+46
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Add PreferredSizeChanged() to View to allow subviews to notify their parents ↵erikkay@google.com2009-05-083-1/+7
| | | | | | | | that they'd really like another layout.R=skyTEST=none Review URL: http://codereview.chromium.org/113133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-084-243/+271
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-08155-475/+475
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* this CL changes some comments in the fix of issue 2780xji@chromium.org2009-05-071-3/+4
| | | | | | | BUG=http://crbug.com/2780 Review URL: http://codereview.chromium.org/115097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15573 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 2780 - RTL: Omnibar - message "Press Tab to search ↵xji@chromium.org2009-05-071-4/+45
| | | | | | | | | | | | | | | | | | | | | | Google" doesn't show correctly in a "New Tab" for RTL locales. (http://crbug.com/2780) The error happens in LocationBarView::TextDisplayWidth() which does not correctly calculate the location entry's text display width. The fix itself contains comments so hope it is self-explained. Test steps: 1. Start Chrome with a new user data directory (or clean up all browsing data) and make sure the UI language is Hebrew. 2 Type www.google.com in the omnibox and press Enter. 3 Close and re-open the browser. 4 Type character "h" in Ominibox Without the fix, only "tab" button is showing as keyword hint. With the fix, Hebrew translation of "press tab to search google" is displayed. Please be noted: you need to have enough space in omnibox in order for the whole keyword hint to be displayed, otherwise, only "tab" button will be displayed. Review URL: http://codereview.chromium.org/100360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15562 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the position of the tabstrip to leave space for window controls in ↵ben@chromium.org2009-05-071-3/+11
| | | | | | | | | RTL languages. http://crbug.com/11223 Review URL: http://codereview.chromium.org/115091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15558 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some basic drawing of Linux Omnibox SSL lock icons.deanm@chromium.org2009-05-071-1/+1
| | | | | | | | | BUG=10965 Review URL: http://codereview.chromium.org/115084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15547 0039d316-1c4b-4281-b951-d872f2087c98
* Uses the MirroringContext class in omnibox2.hbono@chromium.org2009-05-071-41/+99
| | | | | | | | Because of the lack of my comments, omnibox2 does not use this MirroringContext class to re-order the text runs and fragments. (Sorry for the lack of comments.) This change uses the MirroringContext class and adds comments that describe it. Review URL: http://codereview.chromium.org/100248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15537 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all traces of NotificationService from views.ben@chromium.org2009-05-071-1/+6
| | | | | | | | | | | | | | | | | | Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay. Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work. Moves the HWNDNotificationSource to common, since it's used by BrowserView. Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed. http://crbug.com/11387 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15468 Review URL: http://codereview.chromium.org/113016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15489 0039d316-1c4b-4281-b951-d872f2087c98
* Popup whitelisting checkpoint.pkasting@chromium.org2009-05-062-72/+221
| | | | | | | | | | | | | | | | | This provides some basic UI for the popup whitelist. The actual whitelist is completely unimplemented and just has TODOs at the hook points. The actual blocking behavior of the browser is unchanged. The popup blocker bubble menu now gets an extra section below the popups with checkable "Always show popups from <host>" items (usually one, can be more on pages with popups from iframes from different hosts). Clicking one of these will whitelist a hostname and open its popups, and remove it from the menu. When navigating to a page with whitelisted popups, the popup blocker bubble is opened (showing "Blocked Popups: 0", text subject to change), and the menu contains the checked entr(y/ies) relevant to these page. Clicking one of these un-whitelists the host and removes the entry from the menu (closing the menu if that was the last such entry). Known UI questions: * Wording is all speculative * Should manually closing all popups associated with a whitelisted site remove that entry/close the menu automatically? (I suspect yes) * Should un-whitelisting a site via the menu entry close its popups, just like whitelisting it opens them? (Not sure) * Should menu items for sites stick around after toggling their whitelisting status, thus keeping the bubble onscreen until it's manually closed, the page is navigated, etc.? (While this is slightly more consistent, I suspect the answer is no) BUG=11440 Review URL: http://codereview.chromium.org/113058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15475 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15468.ben@chromium.org2009-05-061-6/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all traces of NotificationService from views.ben@chromium.org2009-05-061-1/+6
| | | | | | | | | | | | | | | | Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay. Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work. Moves the HWNDNotificationSource to common, since it's used by BrowserView. Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15468 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking on a folder in the bookmark bar now shows its contents as a menu.erg@google.com2009-05-062-2/+2
| | | | | | | | http://crbug.com/11250 Review URL: http://codereview.chromium.org/114005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15463 0039d316-1c4b-4281-b951-d872f2087c98
* The last redesign of interstitial pages made them to be a render view ↵jcampan@chromium.org2009-05-061-1/+13
| | | | | | | | | | | | | painted on top of the normal page. Because they were not know from the tab contents container, the actual hidden page behind them would still get focus. That was particularly noticeable when tabbing. BUG=11505 TEST=Open a page that triggers an interstitial (ex: https://ebay.com). Press tab to cycle the focus. Make sure the focus is moved as expected. Review URL: http://codereview.chromium.org/113039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15446 0039d316-1c4b-4281-b951-d872f2087c98
* Render a "sad tab" on tab crash.willchan@chromium.org2009-05-061-4/+5
| | | | | | | | | | Uses the NotificationRegistrar to notice TAB_CONTENTS_[DIS]CONNECTED events. When it disconnects, add a SadTabGtk to the TabContentsView. Delete it when the tab contents reconnects. BUG=http://www.crbug.com/11081 TEST=Open http://about:crash. Verify that the sad tab renders properly. Navigate to another page to make sure the SadTabGtk is correctly replaced with a new RenderWidgetHostViewGtk. Review URL: http://codereview.chromium.org/111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a DCHECK regression introduced by http://codereview.chromium.org/112001erikkay@google.com2009-05-061-2/+0
| | | | | | | | | | | | Code was removing itself as an observer for something it was no longer observing. TEST=interactive_ui_tests.exe --gtest_filter=BookmarkBarViewTest1.Basic TBR=sky Review URL: http://codereview.chromium.org/113037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15427 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor view from methods to show hung renderer dialog.tc@google.com2009-05-063-81/+51
| | | | | | | | | | This moves the methods into a header that all platforms can use and keeps the windows implementation in hung_renderer_view.cc. Review URL: http://codereview.chromium.org/109039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15424 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the "pick a new user data dir" dialog on windows.tc@google.com2009-05-061-1/+0
| | | | | | | | | | | | | | | | There were three things to be fixed: 1) We don't need to run a separate message loop after the dialog closes. The MessageLoopForUI handles this properly. 2) When tearing down browser_process_impl, io_loop hasn't been initialized yet, so we check to make sure it exists before using it. 3) We don't call window->Close() because that deletes the dialog class before we're done using it. This means we leak the window, but that's ok because we're going to exit anyway. Review URL: http://codereview.chromium.org/114004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15422 0039d316-1c4b-4281-b951-d872f2087c98
* Create a separate UI surface for extensions (bottom shelf) and remove them ↵erikkay@google.com2009-05-064-173/+38
| | | | | | | | | | | | | | from the bookmarks bar (for now). The current implementation doesn't do anything new except for always appear when extensions are loaded. TEST=install an extension and see it show up in the new bottom bar TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar Review URL: http://codereview.chromium.org/112001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15417 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions now work across tabs and windows.finnur@chromium.org2009-05-062-7/+9
| | | | | | | | | | | The extension system now provides TabId to extensions so it is now possible to activate PageActions in other tabs besides the first in the tab strip. :) BUG=None TEST=None (requires a PageAction extension to test against). Review URL: http://codereview.chromium.org/109046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15415 0039d316-1c4b-4281-b951-d872f2087c98