summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Revert r27137: "Create renderers for ExtensionHosts one at a time to avoidmpcomplete@chromium.org2009-09-241-1/+1
| | | | | | | | | blocking the UI" BUG=14040 TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27143 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify life for people trying to pick a "readable" foreground color by not ↵pkasting@chromium.org2009-09-242-22/+8
| | | | | | | | | | requiring them to provide two choices. This also speeds the call up a tiny bit by not calculating the background luminance twice. BUG=none TEST=none Review URL: http://codereview.chromium.org/220029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27138 0039d316-1c4b-4281-b951-d872f2087c98
* Create renderers for ExtensionHosts one at a time to avoid blocking the UI.mpcomplete@chromium.org2009-09-241-1/+1
| | | | | | | | | BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/220028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27137 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27113, it breaks the ChomeOS build.jcampan@chromium.org2009-09-242-5/+12
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/231022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring some of the NativeViewHost and NativeControl focus management so ↵jcampan@chromium.org2009-09-242-12/+5
| | | | | | | | | | | their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Review URL: http://codereview.chromium.org/214029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98
* Regression: Shift modifier on Find was reversed.finnur@chromium.org2009-09-241-1/+1
| | | | | | | | We were also not using GetKeyState correctly in win_util, as the documentation mentions. We should be looking at the high-order bit (&-ing with 0x8000, not 0x80). BUG=22849TEST=Try to use Enter during FindInPage. Notice it should search forwards when Shift key is not pressed and backwards when Shift is pressed. Review URL: http://codereview.chromium.org/218009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27074 0039d316-1c4b-4281-b951-d872f2087c98
* Changes from listening to focus-out/focus-in for active status tosky@chromium.org2009-09-242-12/+5
| | | | | | | | | | | listening for is-active. BUG=none TEST=none Review URL: http://codereview.chromium.org/219016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27071 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-247-55/+48
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* A refactor broke the find bar...characters like ! and ( davemoore@google.com2009-09-234-4/+23
| | | | | | | | | | | became unsearchable BUG=10509 TEST=Open nytimes.com, search for "new". Then type "!". It should appear in the search box but not be found (unless the the text "new!" is really in the page. Confirm you can search for ( and & as well. Review URL: http://codereview.chromium.org/220019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27012 0039d316-1c4b-4281-b951-d872f2087c98
* Implements file contents support in OSExchangeData and DropTargetsky@chromium.org2009-09-231-2/+5
| | | | | | | | | | | | | for gtk. Makes html and file contents support in OSExchangeData only for windows (as that is the only place we need it), and makes dragging files work. BUG=none TEST=none Review URL: http://codereview.chromium.org/232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26995 0039d316-1c4b-4281-b951-d872f2087c98
* Add more view ids and gtk widget names to so gtkparasite istony@chromium.org2009-09-234-0/+5
| | | | | | | | easier to navigate. Review URL: http://codereview.chromium.org/221001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26992 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the remaining DropInfo members in the constructor.jhawkins@chromium.org2009-09-231-4/+17
| | | | | | | | | CID=4402 BUG=none TEST=none Review URL: http://codereview.chromium.org/227007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26984 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26975.pkasting@chromium.org2009-09-237-48/+55
| | | | | | Review URL: http://codereview.chromium.org/222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-237-55/+48
| | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. BUG=none TEST=none Review URL: http://codereview.chromium.org/207059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
* There is a race condition when the HtmlDialogView is closed which causes a ↵ananta@chromium.org2009-09-231-9/+25
| | | | | | | | | | | | | | | | | | | | | | | | crash while dereferencing an invalid delegate_ (HtmlDialogUIDelegate*) member. I could not reproduce this consistently though. The inference is as below:- 1. When the dialog is closed the HtmlDialogView::OnDialogClosed member function is invoked which calls the OnDialogClosed function on the delegate. This in turn causes the delegate to be destroyed. 2. It then sets the delegate to NULL and attempts to close the window. 3. Before the Close method is dispatched if the view attempts to Paint it causes a crash in the HtmlDialogView::GetWindowTitle function because of dereferencing a NULL delegate_. Fix is to add corresponding NULL checks in the relevant functions. This fixes http://b/issue?id=2138035, which was reported with ChromeFrame. Bug=2138035 Review URL: http://codereview.chromium.org/220011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26953 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views build.estade@chromium.org2009-09-231-1/+1
| | | | | | | | TBR=stuartmorgan Review URL: http://codereview.chromium.org/224001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26893 0039d316-1c4b-4281-b951-d872f2087c98
* Download in progress dialog:estade@chromium.org2009-09-231-7/+12
| | | | | | | | | | | - Change hardcoded "Google Chrome" to product name. - Implement for GTK. BUG=21652 Review URL: http://codereview.chromium.org/212051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26891 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a couple of NOTIMPLEMENTEDs in window_gtk and comments onsky@chromium.org2009-09-221-1/+1
| | | | | | | | | | | why we're not going to implement some. BUG=none TEST=none Review URL: http://codereview.chromium.org/207057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
* Automated ui test porting + cleanup:estade@chromium.org2009-09-221-24/+17
| | | | | | | | | | | | | | | | - Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758 Review URL: http://codereview.chromium.org/211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
* Gets the drop arrow to show when dragging URLs over the tab strip.sky@chromium.org2009-09-223-16/+30
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/215047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26839 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a NOTIMPLEMENTED in GoButton.sky@chromium.org2009-09-222-13/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/216045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26832 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab dragging on views restrict the drag to the main window.sky@chromium.org2009-09-222-18/+35
| | | | | | | | | | | | | As X is async, this results in annoying flicker right now. If we stick with this we're going to need to avoid creating a new window. But this is good enough for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/210035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26820 0039d316-1c4b-4281-b951-d872f2087c98
* hide toolstrips in full screen modeerikkay@chromium.org2009-09-223-1/+27
| | | | | | | | | BUG=13439 TEST=none Review URL: http://codereview.chromium.org/214045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26809 0039d316-1c4b-4281-b951-d872f2087c98
* Makes TabIconView use IDR_PRODUCT_LOGO_16 on non-windows platforms.sky@chromium.org2009-09-211-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/207045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26744 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clipping issue on extension shelf (when detached).finnur@chromium.org2009-09-211-2/+13
| | | | | | | | | BUG=22557 TEST=Open NTP, detach the extension shelf and resize the browser horizontally. Toolstrips should not draw outside the extension shelf border. Review URL: http://codereview.chromium.org/211046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26742 0039d316-1c4b-4281-b951-d872f2087c98
* allow the handle to be hidden when moles are expandederikkay@chromium.org2009-09-213-90/+143
| | | | | | | | | BUG=15494 TEST=none Review URL: http://codereview.chromium.org/210031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26706 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-193-8/+8
| | | | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26635 Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26635 - Change the view mode when switching between moles and ↵mbelshe@google.com2009-09-183-8/+8
| | | | | | | | | | | | | | | | | | toolstrips, and propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/210024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26636 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-183-8/+8
| | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserFrameWin::OnMoving bad_override coverity error.mattm@chromium.org2009-09-182-2/+2
| | | | | | | | BUG=17104 Review URL: http://codereview.chromium.org/208019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26633 0039d316-1c4b-4281-b951-d872f2087c98
* Change BrowserBubble to use Close instead of CloseNow. This should makeerikkay@chromium.org2009-09-185-15/+15
| | | | | | | | | | | | | it less susceptible to crashes in certain use cases. Remove a delay in destroying the widget that was added to work around the old crash. BUG=18248 TEST=none Review URL: http://codereview.chromium.org/211027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26625 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash canceling a completed, auto-opened download.paul@chromium.org2009-09-182-8/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | To reproduce this crash: 1. Set 'Always open files of this type' on the download shelf menu to checked for a particular file type. 2. Download a large file of that type. 3. Before the download completes, open its context menu on the shelf. 4. When the download completes, select 'Cancel' from the menu. 5. Crash. The crash occurs because auto-opened downloads automatically remove (and thus delete) themselves from the shelf even if the menu is still running. Selecting a menu item at this point will attempt to access the deleted object. The fix is to let the menu know when the calling object is becoming invalid, so we can avoid doing any further work. BUG=20810 TEST=Try the above repro steps and notice that Chrome doesn't crash. Review URL: http://codereview.chromium.org/213018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26589 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the intializaton of the Download Manager when bringing uptony@chromium.org2009-09-181-3/+0
| | | | | | | | | | | | the options dialog. This was done a long long time ago because we used to register the download dir pref in the Download Manager constructor. Since that's no longer the case, we don't need to intialize the Download Manager. Review URL: http://codereview.chromium.org/208021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26583 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/203029 for Thiago:sky@chromium.org2009-09-182-9/+13
| | | | | | | | | | | | | | | | | | [Windows] Bookmark-menu button should be themed like any other menu button. Command: $ chrome --bookmark-menu BUG=18954 TEST=open chrome/chromium with --bookmark-menu switch in the command line, apply a theme, see if the bookmark-menu is themed? Reset to default theme, see if the bookmark-menu come backs to default state. TEST=none BUG=none Review URL: http://codereview.chromium.org/208017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we access a view after deletion.paul@chromium.org2009-09-181-3/+7
| | | | | | | | | | | | | | | | | When the download shelf menu option 'Remove' is chosen, the view is removed and deleted (along with the object representing the download) so we must not access them after the removal. This CL NULLs the download pointer in the menu to prevent any futher access. BUG=20810 TEST=Remove an item from the download shelf and Chrome should not crash. Review URL: http://codereview.chromium.org/216018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26536 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Strict transport security: add checkbox to clear state."agl@chromium.org2009-09-182-23/+3
| | | | | | | This reverts commit r25955. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26528 0039d316-1c4b-4281-b951-d872f2087c98
* While fixing bug 22070 (Toolstrip theme background not updated when resizing ↵finnur@chromium.org2009-09-183-43/+29
| | | | | | | | | | | | Chrome window) I added code to trigger repainting the background on resize. This flushed out a problem (Skia exceptions) that was causing the extension tests to become flaky on the bots (bug 22135). I've changed the code to do a deep copy on the subset bitmap we get before passing it down to the renderer, which causes Skia to not go haywire when drawing the background. That makes it possible to fix bug 22070, which now causes the background to be updated on resize. There is also now no need to set the background_needs_repaint_ flag to true before calling Layout. We also don't need to keep track of whether we are detached or not, we just need to monitor the background_needs_repaint_ flag. BUG=22070, 22135 TEST=Monitor the bots and see if the tests become flaky again. Review URL: http://codereview.chromium.org/215017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26526 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux Views build, sigh. We need a trybot.pkasting@chromium.org2009-09-171-2/+3
| | | | | | | | BUG=21028 TEST=none Review URL: http://codereview.chromium.org/209024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26502 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make ImageBubbles draw correctly on Linux Views as well. This also ↵pkasting@chromium.org2009-09-172-68/+92
| | | | | | | | | | fixes an error in the window region calculation (I used right()/bottom() where I should have used width()/height()) and updates some comments and variable names in the hope of more clarity. BUG=21028 TEST=Look at image bubbles on Linux Views Review URL: http://codereview.chromium.org/207021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26497 0039d316-1c4b-4281-b951-d872f2087c98
* Handle some startup errors encountered by ModelAssociator (such as tim@chromium.org2009-09-165-0/+17
| | | | | | | | | | | | unable to find tagged nodes) more gracefully by triggering the unrecoverable error handler. This was in response to a suggestion from chron, as we seem to hit this case a fair bit, and crashing is a pain. More importantly it's possible users are hitting it as well and having an explicit error case / message hidden on the options dialog is better than silently failing with no inkling as to what happened. It also just seems preferable to be in the PSS error state when this happens. Review URL: http://codereview.chromium.org/201119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26407 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix Linux Views build.pkasting@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26402 0039d316-1c4b-4281-b951-d872f2087c98
* Convert InfoBubble to using BubbleBorder. This also replaces the border ↵pkasting@chromium.org2009-09-167-440/+472
| | | | | | | | | | | | graphics with a slightly darker set from Nicholas. The downside here is that the Linux views code is definitely going to be broken by this. I'm not sure of the best design for Linux views, so I haven't implemented one. BUG=21028 TEST=Open info bubbles (click star button, hover lock icon) and observe they are rendered with an identical border/shadow to the Omnibox dropdown, and at the same vertical position. Review URL: http://codereview.chromium.org/195099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26394 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of 'Polish dragging of ToolStrips'. This CL restricts the motion of ↵sidchat@chromium.org2009-09-161-1/+23
| | | | | | | | | the ToolStrip to just horizontal motions until it is dragged far enough from the extension shelf, in which case it is torn away from it (similar to Tabs). BUG=18443 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26362 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTRxji@chromium.org2009-09-161-11/+16
| | | | | | | | | | | | | | | | | | | directionality in download shelf. File names in download shelf are forced to be LTR in DownloadItemView and through ElideFileName(). BUG=http://crbug.com/10860 TEST=1. Open chrome with Hebrew UI. 2. Right click a link and chose Save As... (4th item from the top for non-Hebrew speakers) 3. In the save as dialog name the file קובץ.html 4. In the download shelf the filename should display as קובץ.html (not html.קובץ) Review URL: http://codereview.chromium.org/131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98
* Another try to fix a build break caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | This change just adds a namespace. I wish this fixes. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/201132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26322 0039d316-1c4b-4281-b951-d872f2087c98
* A quick build fix caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | It seems this "static_cast<GtkWidget*>(window)" has been moved from a static member "InfoBubble::Show()" to a non-static member "InfoBubble::Init()". So, we don't need this cast. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/204036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26321 0039d316-1c4b-4281-b951-d872f2087c98
* More miscellaneous cleanup bits to try and move info_bubble.* closer to my ↵pkasting@chromium.org2009-09-163-67/+51
| | | | | | | | | | locally rewritten versions, so that the diff will be readable. BUG=none TEST=none Review URL: http://codereview.chromium.org/196131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26312 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the AutocompletePopupPositioner into a BubblePositioner in ↵pkasting@chromium.org2009-09-158-54/+76
| | | | | | | | | | | | preparation for using it to position both the Omnibox bubble and InfoBubbles. It now gets the bounds of the location stack, which can be turned into useful coordinates for both items. This should not result in any visible change. BUG=21028 TEST=none Review URL: http://codereview.chromium.org/194110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26288 0039d316-1c4b-4281-b951-d872f2087c98
* Land review 193091: Avoid unnecessary conversions between wchar_taa@chromium.org2009-09-151-3/+3
| | | | | | | | | and wstring. TBR=erikkay@chromium.org Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26277 0039d316-1c4b-4281-b951-d872f2087c98
* Unified the color definitions for the dividers so that extension shelf is ↵finnur@chromium.org2009-09-154-14/+15
| | | | | | | | | | using the same values as the bookmark bar. The bookmark bar dividers looked much better against very light background than the extension shelf ones did. BUG=18452 TEST=The dividers should look like the bookmark ones and should not look bad against very light colored backgrounds. Review URL: http://codereview.chromium.org/204026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26274 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 01:31:05 +0000