summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Better behavior for ctrl-k: If we're already in forced_query mode, re-select ↵pkasting@chromium.org2009-06-051-1/+1
| | | | | | | | | | the query text instead of clearing the box. BUG=6985 TEST=Press ctrl-k, type "foo", press ctrl-k again. The omnibox should show "?foo" with "foo" selected. Review URL: http://codereview.chromium.org/119135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17757 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for closing the download shelf with multiple tabs open.paul@chromium.org2009-06-041-4/+2
| | | | | | | | | | | Make sure that the browser window is informed of the download shelf visibility status at the end of the show / hide animation. BUG=13369 Review URL: http://codereview.chromium.org/118278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17690 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: use strings, not wstrings for channel ids.evan@chromium.org2009-06-041-1/+2
| | | | | | | | | | They're ASCII anyway. TEST=covered by existing tests Review URL: http://codereview.chromium.org/119131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17682 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid tab drops on application windows.ben@chromium.org2009-06-041-1/+2
| | | | | | | | | | Change by Chase Phillips <cmp@google.com> http://crbug.com/9576 TEST=open a standalone GMail shortcut window, attempt to drop a tab from an existing browser window into it. It should not be added. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17672 0039d316-1c4b-4281-b951-d872f2087c98
* Make the inactive tab background line up with the parent without using magic ↵glen@chromium.org2009-06-045-8/+29
| | | | | | | | | | | numbers. BUG=12761 TEST=Verify that the inactive tab background lines up with the frame image in maximized and unmaximized mode - you will need a heavily patterned theme to test with. Review URL: http://codereview.chromium.org/118221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for DWM crash.glen@chromium.org2009-06-041-1/+2
| | | | | | | | | | BUG=13075 TBR=ben TEST=On XP, verify that Chrome doesn't crash when a theme is installed or reset. Review URL: http://codereview.chromium.org/118252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17652 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the first of probably several patches trying to clean up the ↵erg@google.com2009-06-043-582/+97
| | | | | | | | | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. This version has minor windows compile fixes that changed from under me. Original Review URL: http://codereview.chromium.org/119006 TBR=beng TEST=Popup notification still works. Review URL: http://codereview.chromium.org/119107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17647 0039d316-1c4b-4281-b951-d872f2087c98
* Make tab resize relayout on mouse out work.ben@chromium.org2009-06-042-18/+35
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix timing issue with first run bubble, and tweak size of OEM bubble so it ↵mirandac@chromium.org2009-06-041-1/+6
| | | | | | | | | | | | looks more like Glen's mock. BUG= http://crbug.com/9233 TEST= Run Chrome with --first-run option. Notice that first run info bubble does not go away within the first second even if you click on or away from the browser. Review URL: http://codereview.chromium.org/118143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17632 0039d316-1c4b-4281-b951-d872f2087c98
* Allow WindowGtks to be moved and sized when the mouse is over the caption or ↵ben@chromium.org2009-06-041-9/+8
| | | | | | | | | | sizing border. BUG=none TEST=none Review URL: http://codereview.chromium.org/118218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17608 0039d316-1c4b-4281-b951-d872f2087c98
* Move download shelf from per-tab to per-window. Also disable auto-hiding ofthakis@chromium.org2009-06-046-99/+78
| | | | | | | | | | | | | | the shelf. BUG=9025 TEST=Download file in one tab, open new tab, and check that download shelf is still open. Also try the shelf's close button and the "show all downloads" link. When saving a file, the download animation should not show up. Review URL: http://codereview.chromium.org/115740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of r17500:glen@chromium.org2009-06-041-3/+18
| | | | | | | | | | Theme our bookmark bar buttons. BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17587 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to theme our buttons.glen@chromium.org2009-06-041-10/+28
| | | | | | | | | BUG=12762 TEST=Verify that buttons can be themed. Review URL: http://codereview.chromium.org/119025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views bustage.ben@chromium.org2009-06-044-17/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/112093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17583 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of dragging extensions on the shelf. This part was just about ↵erikkay@google.com2009-06-034-23/+78
| | | | | | | | getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release. Review URL: http://codereview.chromium.org/119103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views build.ben@chromium.org2009-06-031-0/+4
| | | | | | Review URL: http://codereview.chromium.org/119119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17556 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux views build.jcampan@chromium.org2009-06-031-0/+1
| | | | | | | | | BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/118184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17548 0039d316-1c4b-4281-b951-d872f2087c98
* Some previous refactoring I did of the accelerator code had introduced ↵jcampan@chromium.org2009-06-032-56/+2
| | | | | | | | regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox) Review URL: http://codereview.chromium.org/119016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
* FocusManager should accept multiple AcceleratorTargets for each accelerator.yutak@chromium.org2009-06-033-23/+13
| | | | | | | | | | Originally, FocusManager automatically unregisters an old target if multiple AcceleratorTargets are registered to the same accelerator. This behavior is somewhat troublesome, and actually ShelfItemDialog hits a run-time assertion due to the conflict of registrations (issue 12401). This change modifies the behavior of FocusManager to allow multiple targets to be registered for each accelerator. BUG=12401 TEST=See if issue 12401 is resolved. Review URL: http://codereview.chromium.org/114065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17533 0039d316-1c4b-4281-b951-d872f2087c98
* plugins: rename GetPluginNativeView to GetNativeView.evan@chromium.org2009-06-032-4/+4
| | | | | | | | | That's what the function does, and some callers that had nothing to do with plugins were calling GetPluginNativeView. Review URL: http://codereview.chromium.org/118094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17531 0039d316-1c4b-4281-b951-d872f2087c98
* UI Support for Auto Spell Correct. Currently, it is still under the command ↵sidchat@google.com2009-06-032-1/+37
| | | | | | | | line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box. Review URL: http://codereview.chromium.org/119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17528 0039d316-1c4b-4281-b951-d872f2087c98
* When the contents don't have title, use URL for the name of bookmark entry.brettw@chromium.org2009-06-031-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it able to drag star even when the contents of address bar is modified. This change makes the behavior of two different bookmarking operation, starring and drag-and-drop, consistent. Currently, bookmarking a page with no title by clicking star creates a bookmark entry with an empty string as its name field, while dragging star to bookmark manager uses URL for name field. As suggested in BUG5965, the behavior of dragging star is better. I've replaced the code in Browser::BookmarkCurrentPage (one for clicking star) with the code in BrowserToolbarView::WriteDragData (one for dragging star) to fix this issue. The former uses NavigationEntry::title() which returns an empty string, while the latter uses TabContents::GetTitle() which returns URL Additionally, I've made the check done in BrowserToolbarView::GetDragOperations() and Browser::BookmarkCurrentPage() such as ToolbarViewModel::ShouldDisplayURL() consistent. Following the suggestion by glen, I've removed ToolbarViewModel::input_in_progress() from the check. TEST=Bookmark page with no title by clicking star and see that the bookmark entry has the URL for its name field. BUG=5965 Original review: http://codereview.chromium.org/113942 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r17500glen@chromium.org2009-06-031-14/+3
| | | | | | | | | TBR=slightlyoff BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17508 0039d316-1c4b-4281-b951-d872f2087c98
* Theme the download bar. Mostly this is just changing the background color to ↵glen@chromium.org2009-06-031-4/+7
| | | | | | | | | | | match the toolbar, and making the button images transparent. BUG=11703 TEST=Verify that the download bar matches the theme that is installed. Review URL: http://codereview.chromium.org/119088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17502 0039d316-1c4b-4281-b951-d872f2087c98
* Theme our bookmark bar buttons.glen@chromium.org2009-06-031-3/+14
| | | | | | | | | BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. Review URL: http://codereview.chromium.org/112092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17500 0039d316-1c4b-4281-b951-d872f2087c98
* Removed focus manager references from the external tab container as we don't ↵ananta@chromium.org2009-06-031-7/+9
| | | | | | | | | | | | | need the focus manager to achieve tabbing in and out of the chrome frame widget. The other change is to add a check for a NULL container window when the tab contents is being freed. This causes an assert to fire in the focus manager code while trying to unsubclass the window. Review URL: http://codereview.chromium.org/119074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17499 0039d316-1c4b-4281-b951-d872f2087c98
* Linux bookmark manager first cut.estade@chromium.org2009-06-032-9/+14
| | | | | | | | Also add icons to bookmark tree model. Review URL: http://codereview.chromium.org/118150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17489 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-033-97/+582
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform." This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483). Review URL: http://codereview.chromium.org/118166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-033-582/+97
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. Review URL: http://codereview.chromium.org/119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-035-2/+7
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Local text file with spaces in filename is urlencoded in tab titlemhm@chromium.org2009-06-032-2/+3
| | | | | | | | | | | | | | When viewing a local text file with spaces in filename, it is still urlencoded. Filename should be displayed with spaces, not with urlencoding. It would be more user-friendly. Since net::FormatURL is already implemented, using it would be great. But it doesn't escape SPACES, just NORMAL, it doesn't even escape unicode. I plumbed out a unescapeurl that could be used whether we allow conversion of spaces or not. BUG=8775 (http://crbug.com/8775) TEST=Tested whether the input is escaped in the navigational context and ran the net tests New Review: http://codereview.chromium.org/118059 Review URL: http://codereview.chromium.org/56053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17462 0039d316-1c4b-4281-b951-d872f2087c98
* Support for searching bookmarks for IDN.brettw@chromium.org2009-06-021-5/+7
| | | | | | | | | | | | | | The main part of this change is DoesBookmarkContainWords() in bookmark_utils.cc. It tries to match a query words to IDN and %-decoded strings as well as ASCII URL. BUG=3991 TEST=add a unit test, check for IDN in the search box of Bookmark Manager. Checked in for tkent@google.com. Original review: http://codereview.chromium.org/113815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17435 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to change the background of the new tab page. Adds support for ↵glen@chromium.org2009-06-022-7/+25
| | | | | | | | | | | display properties to themes (stored internally as ints/enums, but parsed from text). BUG=12768 TEST=Install a theme with an new tab page background and verify that the background appears on the new tab page. Review URL: http://codereview.chromium.org/115910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17431 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the blue tab titles on GTK by hooking up the browser theme provider to thebrettw@chromium.org2009-06-022-0/+14
| | | | | | | | browser frame. Review URL: http://codereview.chromium.org/118088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17428 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of bugs encountered in getting info bubbles to work:sky@chromium.org2009-06-021-10/+8
| | | | | | | | | | | | | | | | . Initial bounds of windows weren't being set. . Widgets were created initially shown. This was bad for windows as the window would end up showing prematurely. . WindowGtk::window_state_ wasn't being initialized. . And then actual InfoBubble stuff: properly init the bubble, show it and position it on the monitor. BUG=none TEST=none Review URL: http://codereview.chromium.org/118102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17401 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the text of the in-progress download dialog better by special-casing ↵jcampan@chromium.org2009-06-021-5/+24
| | | | | | | | | | the single download case. BUG=11278 TEST=Start a big download, close Chrome. A dialog warning that a download is in progress should be shown. Check that the main text and button text use singular when referring to the download. Start several big downloads. Close Chrome, check the text now uses plural. Review URL: http://codereview.chromium.org/119009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17387 0039d316-1c4b-4281-b951-d872f2087c98
* Make Combobox portableben@chromium.org2009-06-0221-179/+176
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113991 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17382 0039d316-1c4b-4281-b951-d872f2087c98
* Fix opaque app mode display.glen@chromium.org2009-06-021-8/+10
| | | | | | | | | | | Changed the app corner images to be the same size as the center image. BUG=12541 TEST=In an opaque app-frame window, verify that the top edge doesn't have a frame-colored space between the drop shadow and the content area. Review URL: http://codereview.chromium.org/118058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17378 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where can't see contents of autocomplete edit. This wassky@chromium.org2009-06-011-0/+10
| | | | | | | | | | | | happening because all widgets are initially hidden. NativeViewHostGtk only shows the widget, not descendants. BUG=none TEST=none Review URL: http://codereview.chromium.org/118081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17351 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of related bugs:sky@chromium.org2009-06-012-5/+13
| | | | | | | | | | | | | | | | . gdk_display_get_pointer requires a display. . Don't do anything in NativeViewHostGtk if asked to remove and there is no native view. . Make NativeViewHostGtk deal with the native view already having the same parent. . Implement a couple of methods in NativeTabContentsContainerGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/115989 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in omnibox2 popup introduced by themes work. There was no widget ↵ben@chromium.org2009-05-311-1/+2
| | | | | | | | | | | to obtain a theme provider from in this case. TBR=glen BUG=none TEST=none Review URL: http://codereview.chromium.org/118064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17304 0039d316-1c4b-4281-b951-d872f2087c98
* Now that themes are enabled by default, the option should be visible by default.glen@chromium.org2009-05-311-9/+4
| | | | | | | | | BUG=none TEST=Verify that you can see the option to reset your theme in the second tab of the options dialog. Review URL: http://codereview.chromium.org/112079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17302 0039d316-1c4b-4281-b951-d872f2087c98
* Use the right frame type on startup, do proper swapping of frames when ↵glen@chromium.org2009-05-314-6/+6
| | | | | | | | | | | themes change. Leave the native frame decision up to the ThemeProvider. BUG=12890 TEST=In Aero, unstall a theme, reset to default, install again, restart, reset theme to default. Make sure that the Aero frame changes to the themed frame and back again appropriately. Review URL: http://codereview.chromium.org/118053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Windows build by adding necessary headers.brettw@chromium.org2009-05-311-0/+1
| | | | | | Review URL: http://codereview.chromium.org/115975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17296 0039d316-1c4b-4281-b951-d872f2087c98
* Split out the views table functions into separate header files. Many users onlybrettw@chromium.org2009-05-3116-6/+29
| | | | | | | | | | | | | | need either the view or model observers and that's it. I moved the model constructors to a .cc file so we don't have to include l10n_util.h for everybody. A surprising number of files were getting l10n_util from the table code, so I had to add it in a bunch of places. There should be no code change except I made the table column cosntructors take wstring references instead of copies. Review URL: http://codereview.chromium.org/115969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17295 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "User Data" tab to the options, remove the "minor tweaks" tabmhm@chromium.org2009-05-303-378/+487
| | | | | | | | | | | | Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. RELANDING http://codereview.chromium.org/113896 TBR=ben Review URL: http://codereview.chromium.org/115971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 17288 - Test failures.mhm@chromium.org2009-05-303-489/+378
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/115968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17289 0039d316-1c4b-4281-b951-d872f2087c98
* Create a "User data" tab and remove the "minor tweaks" tab. The mockup is ↵mhm@chromium.org2009-05-303-378/+489
| | | | | | | | | | | | | included in the issue. Add new option fields to the "User Data" tab and reorganize the "Under the Hood" to fit a better User Experience. BUG=11435 (http://crbug.com/11435) TEST=Opened the option dialog and checked if functional. Review URL: http://codereview.chromium.org/113896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17288 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by fixing defines not to include windows.ben@chromium.org2009-05-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17286 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to make a browser window come up with TOOLKIT_VIEWS.ben@chromium.org2009-05-303-0/+9
| | | | | | | | | | | TBR=sky BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17271 Review URL: http://codereview.chromium.org/116007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17285 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 23:07:31 +0000