summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Use the standard dotted rectangle when moving a tab out when "Show windowmaruel@chromium.org2009-05-122-1/+23
| | | | | | | | | | | | contents while dragging" is disabled. BUG=805 Patch contributed by Yusuke Sato (yusukes@google.com) Review: http://codereview.chromium.org/113176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15880 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the maximized frame background correctly.glen@chromium.org2009-05-121-3/+13
| | | | | | | | BUG=11695 Review URL: http://codereview.chromium.org/113227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15820 0039d316-1c4b-4281-b951-d872f2087c98
* Removing floating views, they are not used anymore.jcampan@chromium.org2009-05-112-8/+1
| | | | | | | | | BUG=None TEST=Run unit_tests, ui_tests, interactive ui_tests. Make sure focus traversal still works. Review URL: http://codereview.chromium.org/113215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15817 0039d316-1c4b-4281-b951-d872f2087c98
* This CL revert the fix for issue 2780 - RTL: Omnibar - message "Press Tab to ↵xji@chromium.org2009-05-111-46/+4
| | | | | | | | | | | | | | | | search Google" doesn't show correctly in a "New Tab" for RTL locales. (http://crbug.com/2780) Previous fix at http://codereview.chromium.org/100360 may have regressed the startup time by about 5ms/6.7% due to multiple call of PosFromChar(). Ts regression chart is at: http://build.chromium.org/buildbot/perf/xp-release-dual-core/startup/report.html?history=150 I am reverting the CL while working on solutions. Review URL: http://codereview.chromium.org/113221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15784 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to add these files as part of last change.ben@chromium.org2009-05-102-0/+121
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15734 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new ViewsDelegate interface and implementation in the windows browser UI.ben@chromium.org2009-05-102-0/+11
| | | | | | | | | | | | Provides a way for saving and restoring window placement, obtaining system helpers etc. http://crbug.com/11633 TEST=make sure window placement saving works, clipboard, and that windows in the taskbar have a chrome icon. Review URL: http://codereview.chromium.org/113173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15733 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NOTREACHED in status bubble if window is made too small.glen@chromium.org2009-05-091-2/+3
| | | | | | Review URL: http://codereview.chromium.org/100150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15728 0039d316-1c4b-4281-b951-d872f2087c98
* Use the non-native frame when using themes even on Aero Glass.ben@chromium.org2009-05-091-0/+1
| | | | | | Review URL: http://codereview.chromium.org/113183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15725 0039d316-1c4b-4281-b951-d872f2087c98
* Some unnecessary painting and initing was being done.glen@chromium.org2009-05-091-4/+0
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/113182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15714 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at themes.glen@chromium.org2009-05-0919-641/+578
| | | | | | | | | | | | This CL is paired with http://codereview.chromium.org/67284 This CL (for commit purposes) includes http://codereview.chromium.org/67284 BUG=4463,11232,11233,11234,11235 Review URL: http://codereview.chromium.org/99030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the popup blocking whitelist pref. This makes the whitelist ↵pkasting@chromium.org2009-05-092-21/+62
| | | | | | | | actually function.BUG=11440 Review URL: http://codereview.chromium.org/115149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15702 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-0817-17/+14
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 9837 - RTL: "Pop-ups blocked" bar should be at left-bottom ↵xji@chromium.org2009-05-081-2/+12
| | | | | | | | | | | | | | for RTL Chrome. The fix is to position the 'pop-ups blocked' bar at the bottom left for RTL chrome. Test: 1. Launch Hebrew Chrome 2. load http://www.brg8.com/ 3. Observe the 'pop-up blocked' bar after the page load. Review URL: http://codereview.chromium.org/89004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15691 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-0841-126/+46
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Add PreferredSizeChanged() to View to allow subviews to notify their parents ↵erikkay@google.com2009-05-083-1/+7
| | | | | | | | that they'd really like another layout.R=skyTEST=none Review URL: http://codereview.chromium.org/113133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-084-243/+271
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-08155-475/+475
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* this CL changes some comments in the fix of issue 2780xji@chromium.org2009-05-071-3/+4
| | | | | | | BUG=http://crbug.com/2780 Review URL: http://codereview.chromium.org/115097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15573 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 2780 - RTL: Omnibar - message "Press Tab to search ↵xji@chromium.org2009-05-071-4/+45
| | | | | | | | | | | | | | | | | | | | | | Google" doesn't show correctly in a "New Tab" for RTL locales. (http://crbug.com/2780) The error happens in LocationBarView::TextDisplayWidth() which does not correctly calculate the location entry's text display width. The fix itself contains comments so hope it is self-explained. Test steps: 1. Start Chrome with a new user data directory (or clean up all browsing data) and make sure the UI language is Hebrew. 2 Type www.google.com in the omnibox and press Enter. 3 Close and re-open the browser. 4 Type character "h" in Ominibox Without the fix, only "tab" button is showing as keyword hint. With the fix, Hebrew translation of "press tab to search google" is displayed. Please be noted: you need to have enough space in omnibox in order for the whole keyword hint to be displayed, otherwise, only "tab" button will be displayed. Review URL: http://codereview.chromium.org/100360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15562 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the position of the tabstrip to leave space for window controls in ↵ben@chromium.org2009-05-071-3/+11
| | | | | | | | | RTL languages. http://crbug.com/11223 Review URL: http://codereview.chromium.org/115091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15558 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some basic drawing of Linux Omnibox SSL lock icons.deanm@chromium.org2009-05-071-1/+1
| | | | | | | | | BUG=10965 Review URL: http://codereview.chromium.org/115084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15547 0039d316-1c4b-4281-b951-d872f2087c98
* Uses the MirroringContext class in omnibox2.hbono@chromium.org2009-05-071-41/+99
| | | | | | | | Because of the lack of my comments, omnibox2 does not use this MirroringContext class to re-order the text runs and fragments. (Sorry for the lack of comments.) This change uses the MirroringContext class and adds comments that describe it. Review URL: http://codereview.chromium.org/100248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15537 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all traces of NotificationService from views.ben@chromium.org2009-05-071-1/+6
| | | | | | | | | | | | | | | | | | Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay. Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work. Moves the HWNDNotificationSource to common, since it's used by BrowserView. Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed. http://crbug.com/11387 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15468 Review URL: http://codereview.chromium.org/113016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15489 0039d316-1c4b-4281-b951-d872f2087c98
* Popup whitelisting checkpoint.pkasting@chromium.org2009-05-062-72/+221
| | | | | | | | | | | | | | | | | This provides some basic UI for the popup whitelist. The actual whitelist is completely unimplemented and just has TODOs at the hook points. The actual blocking behavior of the browser is unchanged. The popup blocker bubble menu now gets an extra section below the popups with checkable "Always show popups from <host>" items (usually one, can be more on pages with popups from iframes from different hosts). Clicking one of these will whitelist a hostname and open its popups, and remove it from the menu. When navigating to a page with whitelisted popups, the popup blocker bubble is opened (showing "Blocked Popups: 0", text subject to change), and the menu contains the checked entr(y/ies) relevant to these page. Clicking one of these un-whitelists the host and removes the entry from the menu (closing the menu if that was the last such entry). Known UI questions: * Wording is all speculative * Should manually closing all popups associated with a whitelisted site remove that entry/close the menu automatically? (I suspect yes) * Should un-whitelisting a site via the menu entry close its popups, just like whitelisting it opens them? (Not sure) * Should menu items for sites stick around after toggling their whitelisting status, thus keeping the bubble onscreen until it's manually closed, the page is navigated, etc.? (While this is slightly more consistent, I suspect the answer is no) BUG=11440 Review URL: http://codereview.chromium.org/113058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15475 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15468.ben@chromium.org2009-05-061-6/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all traces of NotificationService from views.ben@chromium.org2009-05-061-1/+6
| | | | | | | | | | | | | | | | Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay. Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work. Moves the HWNDNotificationSource to common, since it's used by BrowserView. Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15468 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking on a folder in the bookmark bar now shows its contents as a menu.erg@google.com2009-05-062-2/+2
| | | | | | | | http://crbug.com/11250 Review URL: http://codereview.chromium.org/114005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15463 0039d316-1c4b-4281-b951-d872f2087c98
* The last redesign of interstitial pages made them to be a render view ↵jcampan@chromium.org2009-05-061-1/+13
| | | | | | | | | | | | | painted on top of the normal page. Because they were not know from the tab contents container, the actual hidden page behind them would still get focus. That was particularly noticeable when tabbing. BUG=11505 TEST=Open a page that triggers an interstitial (ex: https://ebay.com). Press tab to cycle the focus. Make sure the focus is moved as expected. Review URL: http://codereview.chromium.org/113039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15446 0039d316-1c4b-4281-b951-d872f2087c98
* Render a "sad tab" on tab crash.willchan@chromium.org2009-05-061-4/+5
| | | | | | | | | | Uses the NotificationRegistrar to notice TAB_CONTENTS_[DIS]CONNECTED events. When it disconnects, add a SadTabGtk to the TabContentsView. Delete it when the tab contents reconnects. BUG=http://www.crbug.com/11081 TEST=Open http://about:crash. Verify that the sad tab renders properly. Navigate to another page to make sure the SadTabGtk is correctly replaced with a new RenderWidgetHostViewGtk. Review URL: http://codereview.chromium.org/111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a DCHECK regression introduced by http://codereview.chromium.org/112001erikkay@google.com2009-05-061-2/+0
| | | | | | | | | | | | Code was removing itself as an observer for something it was no longer observing. TEST=interactive_ui_tests.exe --gtest_filter=BookmarkBarViewTest1.Basic TBR=sky Review URL: http://codereview.chromium.org/113037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15427 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor view from methods to show hung renderer dialog.tc@google.com2009-05-063-81/+51
| | | | | | | | | | This moves the methods into a header that all platforms can use and keeps the windows implementation in hung_renderer_view.cc. Review URL: http://codereview.chromium.org/109039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15424 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the "pick a new user data dir" dialog on windows.tc@google.com2009-05-061-1/+0
| | | | | | | | | | | | | | | | There were three things to be fixed: 1) We don't need to run a separate message loop after the dialog closes. The MessageLoopForUI handles this properly. 2) When tearing down browser_process_impl, io_loop hasn't been initialized yet, so we check to make sure it exists before using it. 3) We don't call window->Close() because that deletes the dialog class before we're done using it. This means we leak the window, but that's ok because we're going to exit anyway. Review URL: http://codereview.chromium.org/114004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15422 0039d316-1c4b-4281-b951-d872f2087c98
* Create a separate UI surface for extensions (bottom shelf) and remove them ↵erikkay@google.com2009-05-064-173/+38
| | | | | | | | | | | | | | from the bookmarks bar (for now). The current implementation doesn't do anything new except for always appear when extensions are loaded. TEST=install an extension and see it show up in the new bottom bar TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar Review URL: http://codereview.chromium.org/112001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15417 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions now work across tabs and windows.finnur@chromium.org2009-05-062-7/+9
| | | | | | | | | | | The extension system now provides TabId to extensions so it is now possible to activate PageActions in other tabs besides the first in the tab strip. :) BUG=None TEST=None (requires a PageAction extension to test against). Review URL: http://codereview.chromium.org/109046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15415 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the window favicon when the throbber is complete. This fixes the bug usingbrettw@chromium.org2009-05-061-1/+7
| | | | | | | | | the Vista frame for popups that the throbber icon is never replaced. http://crbug.com/8078 Review URL: http://codereview.chromium.org/113024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15396 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-061-2/+2
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Merge two TabContents::InvalidateTypes types and properly update tab ↵estade@chromium.org2009-05-063-13/+1
| | | | | | | | | | | | download icon. INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code. TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear. Review URL: http://codereview.chromium.org/109050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15387 0039d316-1c4b-4281-b951-d872f2087c98
* Find bar:estade@chromium.org2009-05-062-5/+3
| | | | | | | | | - system bell for linux find bar when search not found - move "not found" logic to find bar controller Review URL: http://codereview.chromium.org/112002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15382 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-0626-34/+34
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
* move chrome_font to app/gfxben@chromium.org2009-05-0612-12/+12
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15367 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome_canvas to app/gfxben@chromium.org2009-05-0637-37/+37
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15361 0039d316-1c4b-4281-b951-d872f2087c98
* Make the width of the reset options confirmation dialog localizable.It's ↵jungshik@google.com2009-05-061-2/+4
| | | | | | | | | | currently hard-coded to be 400, but it needs to be localizable.I made it localizable and set the value to 80 (which makes it exactly the same width as the current one) for most locales except for Malayalam for which it's too narrow. Once reviewed and landed in the trunk, this need to be merged to the branch. BUG=11267 TEST=Run CHrome with '--lang=ml', go to Options | Advanced and click on 'Restore the defaul settings' button at the bottom. The dialog box popping up should not have any truncated strings due to the dimension of the dialog being too small Review URL: http://codereview.chromium.org/100008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15359 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-0559-63/+61
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the creator URL for popups up to the browser. We don't yet use this ↵pkasting@chromium.org2009-05-051-2/+2
| | | | | | | | | for anything; it will be used for whitelisting popups by hostname. BUG=11440 Review URL: http://codereview.chromium.org/105004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15326 0039d316-1c4b-4281-b951-d872f2087c98
* Move *Animation to app/ben@chromium.org2009-05-0515-17/+17
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-054-4/+4
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* FindBarView::UpdateForResult is not a good place to finnur@chromium.org2009-05-053-1/+7
| | | | | | | | | | | | | | | | | beep if nothing was found on the page. The reason is that it is gets called when you switch from one tab to the other. I've added a function to FindBar that the controller can call and each platform can implement whatever sound they want to use. BUG=10823 TEST=Open google.com, search for z0, it should beep (no matches). Open new tab, switch back to the old tab and it should not beep. Review URL: http://codereview.chromium.org/99372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-0548-55/+56
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable omni box ui test and automation proxy ui test.estade@chromium.org2009-05-051-4/+3
| | | | | | | | Enable a lot of (already essentially working) automation code along the way. Review URL: http://codereview.chromium.org/100278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
* Port the folder selector portion of the BookmarkEditor to GTK.erg@google.com2009-05-051-62/+5
| | | | | | | | | | | | | | | Mirrors the BookmarkEditorView method, where the contents of BookmarkModel are copied to a temporary model so changes can be discarded if the user hits Cancel. In the GTK version, we copy not into another BookmarkModel, but into a GtkTreeStore, which serves as a model to the GtkTreeView on screen. Also ports the unit tests. http://crbug.com/11250 Review URL: http://codereview.chromium.org/99361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15257 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-28 17:36:44 +0000