summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix bug where bookmark bar wouldn't animate away but would rather snap ↵beng@google.com2008-09-161-3/+5
| | | | | | | | | closed (new frames) B=1031854 Review URL: http://codereview.chromium.org/3052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2251 0039d316-1c4b-4281-b951-d872f2087c98
* Add preferences for the clear browsing data dialog so thattc@google.com2008-09-151-5/+28
| | | | | | | | | | | the user choices are persistent. Patch by Arthur Lussos <developer0420@gmail.com> Original issue at http://codereview.chromium.org/3014 Review URL: http://codereview.chromium.org/3059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2222 0039d316-1c4b-4281-b951-d872f2087c98
* Hit test zone for the new tab button should follow its visible shape.beng@google.com2008-09-141-1/+57
| | | | | | | B=2270 Review URL: http://codereview.chromium.org/2843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2209 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of tweaks to the AeroGlassNonClientView:beng@google.com2008-09-141-2/+2
| | | | | | | | | | - fix broken window resizing using the sizing borders... || should have been an &&, resulted in all non-client areas being treated as window caption. - use the width of the client view to size the tabstrip rather than the width of the non-client view. this was causing the new tab button to be clipped. B=2218,2267 Review URL: http://codereview.chromium.org/2841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2205 0039d316-1c4b-4281-b951-d872f2087c98
* Include the area to the right of the tabstrip underneath the window controls ↵beng@google.com2008-09-141-3/+11
| | | | | | | | | in the window caption area. B=1031854 Review URL: http://codereview.chromium.org/2840 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive UI tests...beng@google.com2008-09-142-6/+15
| | | | | | | | | | - in the UI tests, SimulateOSClick was taking screen coordinates and the browser automation provider was treating them as client. For a click, screen coordinates seems better and is what most users were sending. This was causing the focus tests to fail since tabs weren't getting clicked on. Not sure why this wasn't affecting non-new-frames! - a math error in BrowserView2 was leading to incorrect window sizing in constrained window tests. - new frames mean layout is slightly different, and a constant in the constrained window test needed to be adjusted. Review URL: http://codereview.chromium.org/2828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2180 0039d316-1c4b-4281-b951-d872f2087c98
* Get the new frames to pass the accessibility UI tests.beng@google.com2008-09-142-1/+43
| | | | | | | | B=2235 Review URL: http://codereview.chromium.org/3039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2177 0039d316-1c4b-4281-b951-d872f2087c98
* Move more UI stuff into browser/viewsbeng@google.com2008-09-1346-37/+1645
| | | | | | | B=2205 Review URL: http://codereview.chromium.org/2825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2169 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-137-7/+1440
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
* Back r2151 since it causes ui tests failures.maruel@google.com2008-09-131-39/+23
| | | | | | Review URL: http://codereview.chromium.org/3037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2161 0039d316-1c4b-4281-b951-d872f2087c98
* Move XPFrame, VistaFrame to views/old_framesbeng@google.com2008-09-1314-1/+6358
| | | | | | | | | | | | Also remove WindowClippingInfo, since it's not used by anyone. And fix a couple of header include issues. B=2205 Review URL: http://codereview.chromium.org/2820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2158 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to commit these two files.beng@google.com2008-09-132-2/+2
| | | | | | | B=2205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2157 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer files into an importer subdirectory.beng@google.com2008-09-134-4/+5
| | | | | | | | | Also delete title chomper no one uses it. B=2205 Review URL: http://codereview.chromium.org/3035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2154 0039d316-1c4b-4281-b951-d872f2087c98
* Added routines to MetricsService to parse the server response and respond to ↵petersont@google.com2008-09-131-23/+39
| | | | | | | | the request to cease uploading with some probability. Review URL: http://codereview.chromium.org/1633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2151 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the change that fixed the encoding when viewing source in subframes.brettw@google.com2008-09-127-28/+16
| | | | | | | | | This makes view source for some pages (for example Google Reader) not work properly. I speculate that telling WebKit to change the encoding (which causes a reload) right after starting the real load makes it confused. Review URL: http://codereview.chromium.org/3022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2143 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these files, fixing clobber buildbeng@google.com2008-09-125-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2142 0039d316-1c4b-4281-b951-d872f2087c98
* Move View components of the Browser's tab strip into the browser_views ↵beng@google.com2008-09-1214-0/+5355
| | | | | | | | | project, and into the views/ subdirectory on disk. B=2198 Review URL: http://codereview.chromium.org/3020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2140 0039d316-1c4b-4281-b951-d872f2087c98
* Removing static initializers.jcampan@chromium.org2008-09-121-13/+13
| | | | | | | | BUG=None TEST=Make sure download bar is still working fine. Review URL: http://codereview.chromium.org/2431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2137 0039d316-1c4b-4281-b951-d872f2087c98
* Actually fix the javascript alert crasher in a way thaterg@google.com2008-09-122-1/+16
| | | | | | | | | doesn't introduce new crashes. B=1368898 Review URL: http://codereview.chromium.org/1966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2104 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting constrained window change. Seems to break tests on TOT.erg@google.com2008-09-112-13/+1
| | | | | | Review URL: http://codereview.chromium.org/2447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2088 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher and possible security vulnerability in popuperg@google.com2008-09-112-1/+13
| | | | | | | | | handling. B=1368898 Review URL: http://codereview.chromium.org/2437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2079 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-119-260/+245
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the tabstrip doesn't have the chin above it in maximized view in aero.beng@google.com2008-09-111-1/+2
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/2414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at splitting the AutocompleteEdit into Model and View. This was ↵pkasting@chromium.org2008-09-102-16/+16
| | | | | | | | | noticeably harder than with the Popup and I'm not at all sure I've made the right decisions :(. The View code is about 3x larger than the model. BUG=1343512 Review URL: http://codereview.chromium.org/1872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2004 0039d316-1c4b-4281-b951-d872f2087c98
* The About box was needlessly blocking Chrome on Vista SP1 (with UAC ↵finnur@google.com2008-09-101-3/+8
| | | | | | | | disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit. Review URL: http://codereview.chromium.org/1708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2003 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grab bag of AeroGlassFrame issues:beng@google.com2008-09-105-21/+22
| | | | | | | | | | | | - better names and documentation for varions kOnstants in the AeroGlassNonClientView - AeroGlassFrame now uses the actual bounds of the tabstrip to adjust the DWM frame, rather than hard-coding constants. - fix bug in hit testing that meant that tabs weren't selectable... wrong coordinate system used for one function call... not sure how this didn't affect XP?!! B=1031854 Review URL: http://codereview.chromium.org/1882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1996 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with resizeBy in Gears dialogs.mpcomplete@google.com2008-09-091-11/+1
| | | | | | | BUG=1340253 Review URL: http://codereview.chromium.org/1867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1945 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-096-7/+7
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from Szymon Piechowicz <szymonpiechowicz@o2.pl>beng@google.com2008-09-091-6/+6
| | | | | | | | | Moves the New Tab, Window, Incognito Window menu items from the Page menu to the Wrench menu. Code review: http://codereview.chromium.org/1826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1903 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of quick TODO and other cleanups.beng@google.com2008-09-084-13/+1
| | | | | | | | B=1031854 Review URL: http://codereview.chromium.org/1624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
* Support WM_APPCOMMAND on Window. Make it just pass through to ↵beng@google.com2008-09-082-0/+47
| | | | | | | | | | | | WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it. This allows my mouse's back and forward buttons to work on the new frames. B=1031854 Review URL: http://codereview.chromium.org/1620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1849 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is from Andrew Brampton <me@bramp.net>.sky@google.com2008-09-081-1/+2
| | | | | | | | | | | | | | This patches allows menu items in PopUpMenus to be clicked with the right mouse button. menu.cc controls the web content popup menus, and some others chrome_menu{.cc,.h} controls popup menu on the chrome, for example right clicking on a tab. BUG=718 TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1838 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser is destroyed during DestroyBrowser because EndSession ↵beng@google.com2008-09-081-1/+9
| | | | | | | | | handling needs it to be synchronously deleted, rather than by the Window's destruction. B=1031854 Review URL: http://codereview.chromium.org/452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL state in the URL bar being incorrect. Going to an EV site like ↵brettw@google.com2008-09-071-3/+0
| | | | | | | | | | | | | https://www.verisign.com/ would not should the EV name in the URL bar unless you did something like switch tabs away and back because in my cleanup I removed the notification that this was depending on. This patch adds a new NOTIFY_SSL_STATE_CHANGED notification which is broadcast by the various SSL components when they update the flags. The browser now listens for this notification and will update the URL bar. BUG=1359547 TEST=see repro steps in bug Review URL: http://codereview.chromium.org/436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1831 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reinvent the wheel - base::wclscpy does this work in one line of code.beng@google.com2008-09-071-6/+2
| | | | | | Review URL: http://codereview.chromium.org/1807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1828 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the import lock dialog to be sized by locale.tc@google.com2008-09-061-4/+8
| | | | | | | | | Also increase the height of the Italian first run bubble. BUG=1334381,1359145 Review URL: http://codereview.chromium.org/482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1819 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp open file name size.beng@google.com2008-09-051-1/+6
| | | | | | | B=1362425 Review URL: http://codereview.chromium.org/476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1810 0039d316-1c4b-4281-b951-d872f2087c98
* Readding UI test I pulled yesterday; hopefully the bots will like it more ↵finnur@google.com2008-09-056-4/+36
| | | | | | | | now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. Review URL: http://codereview.chromium.org/473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1809 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes keyword editor to show error image when keyword isn't valid.sky@google.com2008-09-051-1/+1
| | | | | | | | | | | BUG=1318 TEST=Edit a keyword in the keyword editor. Change the keyword to one that is being used by another keyword. Make sure the icon updates appropriately. Review URL: http://codereview.chromium.org/258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1803 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash. I believe this is happening during sessionsky@google.com2008-09-052-1/+14
| | | | | | | | | | | | | | | | end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Review URL: http://codereview.chromium.org/440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the polymorphic WindowResources class and FramePartBitmap enum.maruel@google.com2008-09-046-59/+80
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1710 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in BookmarkBarView. If the HistoryService fails to load itsky@google.com2008-09-042-40/+27
| | | | | | | | | | | | | | was possible for BookmarkBarView to deref NULL (the model_ field). There is no point in having the BookmarkBarView wait for history to load now though, so I've taken this out which makes it impossible to get in this situation. BUG=1356168 TEST=make sure bookmarks still work correctly Review URL: http://codereview.chromium.org/426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1709 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include order in aero_glass_frame.cc. This was causing issues with ↵maruel@google.com2008-09-041-2/+2
| | | | | | | | WPO enabled. Review URL: http://codereview.chromium.org/430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1703 0039d316-1c4b-4281-b951-d872f2087c98
* Localize the 11th hour popup window hack. Right before release, we made a ↵erg@google.com2008-09-041-10/+5
| | | | | | | | change to the behaviour of constrained windows, where we hard coded English strings. Localize this now... Review URL: http://codereview.chromium.org/427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1702 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the new frames' BrowserView2::TabSelectedAt calls ↵beng@google.com2008-09-031-1/+5
| | | | | | | | | TabContents::DidBecomeSelected, like Browser::TabSelectedAt does for the old frames. This was causing tab-restore related features (undo close tab, duplicate tab) to result in sad tab being shown when using the magic_browzR switch. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1698 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup to OneShotTimer and RepeatingTimer: moves more of the member ↵darin@google.com2008-09-033-41/+15
| | | | | | | | | | | variables into the Task subclass. Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer. R=beng BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1684 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in making Chrome the default browser from the optionssky@google.com2008-09-031-2/+4
| | | | | | | | | | | dialog. The crash happened if you clicked 'make chrome the default', then closed the window before we verified the choice stuck. BUG=1355679 TEST=make sure setting chrome as the default browser still works. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1662 0039d316-1c4b-4281-b951-d872f2087c98
* Moves the bookmark bar view test into the interactive tests. To getsky@google.com2008-09-021-6/+1
| | | | | | | | | | | | | | | this to work I changed the interactive ui tests to link with everything the unit tests do. I did this by way of clicking on the dependencies dialog in VS. Let me know if that wasn't right. I also had to slightly tweak BookmarkBarModel and BookmarkStorage to deal with changes I did a while back. These changes only matter during testing (background thread is NULL). BUG=1318942 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1659 0039d316-1c4b-4281-b951-d872f2087c98
* Update Copyright text in SCons config files.sgk@google.com2008-09-011-28/+4
| | | | | | TBR: beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1607 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the 11th hour Google Chrome Beta behaviour for constrainederg@google.com2008-08-291-46/+36
| | | | | | | | | | | | | popup windwos: - Pull out the favicon - Manually check the current locale; if it's an english one then display the string "Popup Blocked", otherwise use just the popup's title (without the product name suffixed to it). BUG=1085485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1564 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-26 13:50:15 +0000