summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* views/gtk: Add missing keyboard accelerators to Search Engines dialog.evan@chromium.org2010-01-051-0/+6
| | | | | | | | | | | BUG=16380 TEST=manual Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/518028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35499 0039d316-1c4b-4281-b951-d872f2087c98
* Add space under the tabstrip when the compact navbar is active.oshima@chromium.org2010-01-043-17/+32
| | | | | | | | | | | | | This was in gtk impl, but missing in toolkit_view impl. BUG=None TEST=None test Review URL: http://codereview.chromium.org/517024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35483 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Rename panel content window enum.derat@chromium.org2010-01-021-2/+2
| | | | | | | | | | | | This is just to match up with http://codereview.chromium.org/525001 , a change to make some of the window manager code a bit clearer. TEST=sent to try servers BUG=none Review URL: http://codereview.chromium.org/517026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35438 0039d316-1c4b-4281-b951-d872f2087c98
* Implement browser action context menu on linux.estade@chromium.org2009-12-312-13/+2
| | | | | | | | | BUG=30656 TEST=manual (right click on browser actions and test the actions) Review URL: http://codereview.chromium.org/521016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35400 0039d316-1c4b-4281-b951-d872f2087c98
* Make back forward menu model a MenuModel.estade@chromium.org2009-12-302-7/+7
| | | | | | | | | | | On Linux, implement just enough MenuModel support in GtkMenu. On Linux + windows, remove wrapper classes. On Mac, just change a few function calls around. BUG=none TEST=unit test + manually clicking around on it in debug mode Review URL: http://codereview.chromium.org/501168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35389 0039d316-1c4b-4281-b951-d872f2087c98
* Apply style guideline for variable names for browser action container.mhm@chromium.org2009-12-301-2/+2
| | | | | | | | | | | Change arrowLocation to arrow_location, to follow Chromium code standards. BUG=494008 TEST=None Review URL: http://codereview.chromium.org/522027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35383 0039d316-1c4b-4281-b951-d872f2087c98
* find_bar: Update the behavior of FindNext/FindPrevious on Windows to match ↵evan@chromium.org2009-12-292-29/+16
| | | | | | | | | | | | | | | | the Linux version. Now they are enabled all the time. BUG=None TEST=open a web page, search for text that is in the page or not (doesn't matter). See that the buttons are enabled. Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/518009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35336 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-292-0/+5
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* send the pngs on crosdavemoore@chromium.org2009-12-281-12/+9
| | | | | | | | | | Added code to stream screenshots gtk screenshot support Review URL: http://codereview.chromium.org/517017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35317 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the menu items available in crosdavemoore@chromium.org2009-12-285-23/+50
| | | | | | | | | Bug: 28054 Test: None Review URL: http://codereview.chromium.org/516016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35302 0039d316-1c4b-4281-b951-d872f2087c98
* Handle extensions correctly when the default download location is not writablekinuko@chromium.org2009-12-251-2/+2
| | | | | | | | | | | | | | | | | | | | BUG=28668 TEST=Set the Download location a NON-writable location (such as '/Application' on Mac) in 'Under the Hood' preferences. Make sure 'Ask where to save...' is kept unchecked. Go to 'https://tools.google.com/chrome/intl/en/themes/index.html' and click 'apply theme'. Make sure 'Save as...' dialog opens to ask users for an alternative download location. Save the file in a writable directory. Make sure the theme applies (or an extension installation dialog opens for extensions). Make sure the download does NOT appear in Downloads history. Make sure it also works for chrome extensions. TEST=(regression) Make sure theme/extension installation works as expected in normal cases (when the default download location is pointing to a writable location and 'Ask where to save...' is unchecked in 'Under the Hood' preferences.) Make sure the download does NOT appear in Downloads history. Make sure the same thing happens for chrome extensions. TEST=(regression) Make sure right-clicking on theme/extension files and selecting 'Save link as...' works as a normal download. Make sure the file is downloaded and saved with the given name. Make sure the theme does NOT apply and an extension installation dialog does NOT open. Make sure the download appears in Downloads history. Review URL: http://codereview.chromium.org/486009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35269 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-231-1/+3
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Gets the extension popup/bubble to work correctly on Chrome OS.sky@chromium.org2009-12-226-14/+99
| | | | | | | | BUG=30358 TEST=see bug Review URL: http://codereview.chromium.org/501179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35188 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromeos build to use viewsoshima@chromium.org2009-12-221-6/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/508025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug on removing last pinned tab that left new tab buttonsky@chromium.org2009-12-221-0/+8
| | | | | | | | | | | | | | | | indented too much. When a tab is removed we don't actually remove the tab until the animation is done. This means the value returned by GetTabHOffset isn't correct until after the tab is removed. I'm fixing by forcing layout when done, which triggers calling GetTabHOffset. The bug exists on both gtk and views, this fixes both. BUG=22934 TEST=see bug Review URL: http://codereview.chromium.org/505071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35175 0039d316-1c4b-4281-b951-d872f2087c98
* Fix racing condition that blocks profiles menu showing upxiyuan@chromium.org2009-12-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Chrome should show profiles menu when "enable-udd-profiles" is supplied on command line. This is broken while refactoring app menu code from ToolbarView into AppMenuModel. Previously, the profile submenu model is kept in ToolbarView and profiles menu would show up on 2nd time app menu showing up. After the refactoring, profile menu is moved into AppMenuModel, which is re-created everytime before we show app menu. In AppMenuModel, it requests profiles data from GetProfilesHelper which will later invoke OnGetProfilesDone. However, app menu is created on the UI thread and blocks the callback until it shows up. This makes the profiles mneu empty. The fix is to leverage an existing profile list in BrowserProcess. When "enable-udd-profiles" is on, BrowserInit will get the initial profile list and NewProfileDialog will refresh it if user creates new profile. And AppMenuModel just use the list to populate the profile menu. BUG=30417 TEST=Verify profiles menu exists when "enable-udd-profiles" is on command line for issue 30417. Review URL: http://codereview.chromium.org/503062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35166 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in closing window. The sequence when closing asky@chromium.org2009-12-221-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | window ends like: ~TabStrip ~View ~Tab ~Tab::TabContextMenuContents ~TabStrip::TabContextMenuContents TabStrip::StopAllHighlighting This is problematic as StopAllHighlighting references objects whose destructor has already run. This crashes on Linux, but not on windows (probably because of different implementation of stl). I've fixed this by deleting all child views from ~TabStrip so that if they end up calling into the TabStrip every is still valid. BUG=none TEST=create a couple of tabs, bring up the context menu for each, close the context menu, close the window and make sure you don't get a crash. Be sure and test this on both windows and Chrome OS. Review URL: http://codereview.chromium.org/505066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35151 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tabstrip that could result in no tooltip text for pinnedsky@chromium.org2009-12-221-3/+4
| | | | | | | | | | | | tab. This happened because we weren't setting the title_bounds_, which is used to determine if a tab should have tooltip text. BUG=26079 TEST=see bug Review URL: http://codereview.chromium.org/507062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35122 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn revision from branded builds.jrg@chromium.org2009-12-191-0/+2
| | | | | | | | BUG=htp://crbug.com/30173 Review URL: http://codereview.chromium.org/504065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35029 0039d316-1c4b-4281-b951-d872f2087c98
* In the password option pages, a table is used.jcampan@chromium.org2009-12-194-0/+14
| | | | | | | | | | | | On deletion, the model goes away before the actual table, causing the table to access a deleted object. This CL fixes it. BUG=30791 TEST=Bring up the password dialog (in the options dialog, 'Personal Stuff', 'Show saved passwords'). Review URL: http://codereview.chromium.org/503063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35026 0039d316-1c4b-4281-b951-d872f2087c98
* [More BTP includes.]erg@google.com2009-12-183-0/+3
| | | | | | | | | | | | | | | | | | | | | | Uninstall themes when all theme infobars are gone; not on each infobar's destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Previous Review URL: http://codereview.chromium.org/504052 Review URL: http://codereview.chromium.org/501096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34900 0039d316-1c4b-4281-b951-d872f2087c98
* Add the right-click context menu for Browser actions and Page Actions.finnur@chromium.org2009-12-176-16/+133
| | | | | | | | | | BUG=29538 TEST=Right-click an extension icon and make sure all the options work for both Page and Browser actions (Options should be grayed out when there is no Options page specified in the manifest). Review URL: http://codereview.chromium.org/486022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34812 0039d316-1c4b-4281-b951-d872f2087c98
* fixes foroshima@chromium.org2009-12-172-2/+3
| | | | | | | | | | | | | | | | crash/non responsive issue in compact navbar. crash when adding tab. new command line switch to start chrome in chromeos layout. changed accelerator to toggle compact navbar to ctrl-shit-c. -0 does not work on chromeos for some reason. BUG=chromium-os:1010, 30612 TEST=None Review URL: http://codereview.chromium.org/500043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34791 0039d316-1c4b-4281-b951-d872f2087c98
* Factor tab context menu into a shared model and fix mac and win to use it. ↵pinkerton@chromium.org2009-12-161-24/+5
| | | | | | | | | | Improve a couple of model unit tests. Remove unused members in the models. BUG=28977 TEST=context menus on tabs should work and enable/disable properly Review URL: http://codereview.chromium.org/500030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34718 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom Linux version strings (e.g. release channel, downstream ↵mmoss@google.com2009-12-151-4/+5
| | | | | | | | | | | vendor name, etc.). Also reformat the Mac/Win version strings as per comments in http://codereview.chromium.org/506007. Review URL: http://codereview.chromium.org/506016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34609 0039d316-1c4b-4281-b951-d872f2087c98
* Move channel (beta,dev,stable) determination code to a common location.jrg@chromium.org2009-12-151-75/+6
| | | | | | | | | | | | | | | | | | | | Add channel info to about:version. Linux about box work not done. Linux channel determination code still a stub. BUG=30444 How to verify: - on both Mac and Win, with a branded build: - confirm the About Box and about:version have channel info after the version number. Channel for PC comes from the registry so it'll be the channel of your official install, not this build. Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined. Review URL: http://codereview.chromium.org/506007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34583 0039d316-1c4b-4281-b951-d872f2087c98
* Make a shared app menu model and update win and mac to use it. Remove the ↵pinkerton@chromium.org2009-12-152-125/+8
| | | | | | | | | | NSMenu from Toolbar.xib. BUG=22646 TEST=the app menu works as it used to. Review URL: http://codereview.chromium.org/482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
* [extensions] Position browser action popup correctly for RTL languages.mhm@chromium.org2009-12-141-1/+3
| | | | | | | | | | | ExtensionPopup::Show was hard coded to use BubbleBorder::TOP_RIGHT, by changing it to be dynamic that depends on UI Layout fixes this issue. BUG=29807 TEST=Change chrome language to Arabic, install Sidewiki, the popup will position itself correctly. Review URL: http://codereview.chromium.org/494008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34491 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI helper method to just get the sync status without needing labels.akalin@chromium.org2009-12-142-2/+2
| | | | | | | | | | | Patch by thiago.farina@gmail.com ( original code review: http://codereview.chromium.org/469017 ). BUG=none TEST=trybots Review URL: http://codereview.chromium.org/486044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34487 0039d316-1c4b-4281-b951-d872f2087c98
* Retry landing the chrome-as-chromeos-login-manager changecmasone@google.com2009-12-141-0/+5
| | | | | | | Old CL: http://codereview.chromium.org/449023 Review URL: http://codereview.chromium.org/488007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34463 0039d316-1c4b-4281-b951-d872f2087c98
* [Windows] Fix issue 30123: REGRESSION: Alt-D causes system beepsuzhe@chromium.org2009-12-132-1/+39
| | | | | | | | | BUG=30123 TEST=Press Alt+D should not beep. Review URL: http://codereview.chromium.org/487035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34444 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad rearrangement of code which causes notifications to crash. johnnyg@chromium.org2009-12-121-1/+1
| | | | | | | | | BUG=30109 TEST=none Review URL: http://codereview.chromium.org/490020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34402 0039d316-1c4b-4281-b951-d872f2087c98
* Theme download status message, so that it's readable in themes of any color.mirandac@chromium.org2009-12-121-22/+39
| | | | | | | | BUG= 21176 TEST= Download something large in a dark or light theme. Note that status update (notification of how much data is left to download) is legible. Review URL: http://codereview.chromium.org/488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34395 0039d316-1c4b-4281-b951-d872f2087c98
* Change the cookies view so that the remove buttons are only enabled when ↵johnnyg@chromium.org2009-12-111-0/+4
| | | | | | | | | | | there are cookies in the list to remove. BUG=27663 TEST=none Review URL: http://codereview.chromium.org/486027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34356 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-112-2/+1
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Get web app icon via FavIconHelper and auto repair/updatexiyuan@chromium.org2009-12-112-108/+64
| | | | | | | | | | | | | | | | | | | | | - Expose a DownloadImage method from FavIconHelper to download/decode image for an image url; - Expose FavIconHelper from TabContents; - Update CreateApplicationShortcutView to use the exposed DownloadImage method to get web app icon instead of do it via URLFetcher/PNGCodec; - Check and update web app icon and shortcuts when chrome is lauched as app for OS_WIN; - Code cleanup: - Move a bunch of FavIconHelper methods that are not used externally to private; - Remove an unused cancelable_consumer_ from TabContents; BUG=8539 TEST=Verify issue 8539 is fixed. And create a web page with a non PNG shortcut icon and verify it shows up in create application shortcut dialog. Review URL: http://codereview.chromium.org/482003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34332 0039d316-1c4b-4281-b951-d872f2087c98
* Find bar fixes:estade@chromium.org2009-12-112-7/+38
| | | | | | | | | | | | - prefer previous find from same tab contents over overall most recent find when re-opening find bar - GTK + Windows: always update find bar view text if it doesn't match the search results. TEST=see bug for repro steps BUG=30006 Review URL: http://codereview.chromium.org/482015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34322 0039d316-1c4b-4281-b951-d872f2087c98
* Display channel in about box after version. Windows.jrg@chromium.org2009-12-101-1/+75
| | | | | | | | | BUG=3000 TEST=see bug Review URL: http://codereview.chromium.org/463062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34301 0039d316-1c4b-4281-b951-d872f2087c98
* re-apply r34183estade@chromium.org2009-12-101-1/+1
| | | | | | | | | | | | | | | | | | | --------------- linux: theme scrollbars from GTK theme Pick the color of the slider's thumbpart and rail from the GTK theme. We cannot match the exact visual appearance of the GTK theme, as rendering engines can make arbitrary changes to the actual visual appearance. But by sampling a representative set of pixels, we ensure that we will at least match the general color scheme. BUG=10949 patch by <markus [at] chromium> original review: http://codereview.chromium.org/400027/show Review URL: http://codereview.chromium.org/479006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34285 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent 2 types of extension crashes.asargent@chromium.org2009-12-101-0/+4
| | | | | | | | | | | | | | | | | If javascript code puts custom toJSON functions on Array.prototype, our extension API code detects malformed requests and kills the offending renderer. Also, the browser can crash if a browser action popup process dies (for various reasons, including this json serialization problem). BUG=29283 TEST=Create an extension with a browser action popup that loads prototype.js, and then calls chrome.tabs.update(). Before this change, the popup bubble will crash, and when you click away, crash the browser too. Review URL: http://codereview.chromium.org/466065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34263 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the keyboard events handling code related to ↵suzhe@chromium.org2009-12-107-113/+86
| | | | | | | | | | | | | | | | | | | | | | | | | RenderViewHostDelegate::View and TabContentsDelegate interfaces. Significant changes made by this CL: 1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes. Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow. Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc. 2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling. 3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup. 4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed. BUG=24479, 26054, 26131, 28839 TEST=See bug reports. Review URL: http://codereview.chromium.org/400012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34234 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-105-16/+70
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Properly use string16 for Unicode text.evan@chromium.org2009-12-091-2/+3
| | | | | | | | BUG=29850 Review URL: http://codereview.chromium.org/477011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34203 0039d316-1c4b-4281-b951-d872f2087c98
* Add some spacing so that status area lines up on crosdavemoore@chromium.org2009-12-091-2/+8
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34197 0039d316-1c4b-4281-b951-d872f2087c98
* Share the code that builds the page menu in a common model, make Mac and Win ↵pinkerton@chromium.org2009-12-092-172/+4
| | | | | | | | | | use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code. BUG=22646 TEST=page menu should work as before Review URL: http://codereview.chromium.org/465130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
* Change most callers of NativeScrollbar size functions to use a dedicated ↵pkasting@chromium.org2009-12-093-19/+10
| | | | | | | | | | function that matches WebKit instead, since the callers really care about content area scrollbars. BUG=none TEST=none Review URL: http://codereview.chromium.org/463061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34177 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bugs with panels. We weren't setting the type at the right timesky@chromium.org2009-12-091-2/+2
| | | | | | | | | | | | and needed to set a size_request so that the title gets the right size. BUG=none TEST=none Review URL: http://codereview.chromium.org/466081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34141 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue where clicking on a <SELECT> dropdown in an extension popup ↵andybons@chromium.org2009-12-091-2/+0
| | | | | | | | | | | | | window would hard crash the browser. I'm hoping that this will open up discussions for refactoring work amongst ExtensionHost and TabContentsView, since so much code is shared between the two and both need sufficient Mac love. BUG=29353 TEST=load a browser action with a popup that contains a SELECT element. click on the element and observe that it acts normally (no crashing). Review URL: http://codereview.chromium.org/465108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34136 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34134 - Viewsbased login window for Chrome OS. Doesn't yet actually ↵jrg@chromium.org2009-12-091-5/+0
| | | | | | | | | | | do anything Review URL: http://codereview.chromium.org/449023 TBR=cmasone@google.com Review URL: http://codereview.chromium.org/467060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34135 0039d316-1c4b-4281-b951-d872f2087c98
* Views-based login window for Chrome OS. Doesn't yet actually do anythingcmasone@google.com2009-12-091-0/+5
| | | | | | Review URL: http://codereview.chromium.org/449023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34134 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 17:18:55 +0000