summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Removed logic which made the container size 0 when recreating a tab contentsdavemoore@chromium.org2010-03-021-7/+16
| | | | | | | | | | BUG=37048 TEST=Run browser, kill the renderer to get the sad tab, refresh the tab. The contents of the tab should be displayed. Review URL: http://codereview.chromium.org/660262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40447 0039d316-1c4b-4281-b951-d872f2087c98
* Moves ActionComboboxModel class to its own header so we can share common ↵erg@chromium.org2010-03-022-62/+4
| | | | | | | | | | | | code between windows and linux. BUG=None TEST=compiles, and still works as before. Review URL: http://codereview.chromium.org/661225 Patch from thiago.farina@gmail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40446 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Reduce jank in the cookie manager by batching updates from the model.rsesek@chromium.org2010-03-022-3/+2
| | | | | | | | | | | | | | | | | Subclass TreeModelObserver specifically for the CookiesTreeModel so that we can send TreeModelBatchBegin() and BatchEnd() notifications before and after local storage, databases, and appcache entries load, respectively. This also rewrites CookiesTreeModelObserverBridge::FindCocoaNode() to do breadth-first search, rather than a pre-order traversal as we most often search for origin nodes, which are at depth 1. BUG=35134 TEST=Get a profile with 1K local storage entries. Chromium-->Preferences-->Under the Hood-->Content Settings-->Cookies should not be slow/janky. Review URL: http://codereview.chromium.org/660251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40444 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some of the frame code a bit.pkasting@chromium.org2010-03-026-181/+108
| | | | | | | | | | The only functional change should be that the app panel close button width is now its preferred width, not its preferred width + 4. BUG=none TEST=none Review URL: http://codereview.chromium.org/660128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40407 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/652010 for Thiago:sky@chromium.org2010-03-022-65/+2
| | | | | | | | | | | | | views: refactor out the "Alt" TableView feature. BUG=34181 TEST=open bookmarks manager, type something in the search text-field, see if a message is showed when there is no match and see if everything still works as before. Review URL: http://codereview.chromium.org/660380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40406 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser side handling of moveTo by resizing the content area; not the ↵erg@chromium.org2010-03-022-3/+16
| | | | | | | | | | | window. BUG=27365 TEST=none Review URL: http://codereview.chromium.org/661187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40386 0039d316-1c4b-4281-b951-d872f2087c98
* Relayout root view in OnWindowPosChanged because when we process this ↵dpolukhin@google.com2010-03-021-0/+9
| | | | | | | | | | | message without calling DefWindowProc we don't get OnSize notification. BUG=36280 TEST=See steps to reproduce in the bug. Review URL: http://codereview.chromium.org/660087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40376 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of bad dependency removal (chrome/common -> chrome/browser)phajdan.jr@chromium.org2010-03-021-4/+4
| | | | | | | | | | | This change introduces one more dependency on chrome/browser, but it seems simpler to move gtk_util first and then fix it. TEST=none BUG=none Review URL: http://codereview.chromium.org/661271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the content page of the options dialog to use kAutoFillEnabled instead ↵jhawkins@chromium.org2010-03-021-2/+2
| | | | | | | | | | of the obsolete kFormAutofillEnabled. BUG=36640 TEST=none Review URL: http://codereview.chromium.org/661327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40345 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40313 - Revert 40305 Fix for cases when info bar is stealing focus ↵cira@google.com2010-03-011-1/+13
| | | | | | | | | | | | | | | | | | on Windows Flaky test, going back to original. TEST=in the bug BUG=36943 Review URL: http://codereview.chromium.org/660218 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/661312 TBR=cira@google.com Review URL: http://codereview.chromium.org/661320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40321 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40305 - Fix for cases when info bar is stealing focus on Windowscira@google.com2010-03-011-13/+1
| | | | | | | | | | | | | Breaking Mac 10.5 tests. TEST=in the bug BUG=36943 Review URL: http://codereview.chromium.org/660218 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/661312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40313 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for cases when info bar is stealing focus on Windowsgeorgey@chromium.org2010-03-011-1/+13
| | | | | | | | TEST=in the bug BUG=36943 Review URL: http://codereview.chromium.org/660218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40305 0039d316-1c4b-4281-b951-d872f2087c98
* Rename button from "Close" to "Done" on bookmark bubble and content bubbles.thakis@chromium.org2010-02-272-2/+2
| | | | | | | | | | | xib changes: Change ^IDS_CLOSE to ^IDS_DONE. BUG=36959 TEST=Open bookmark bubble. Button should read "Done". Go to popuptest.com, click "popups blocked" icon. Button in bubble should read "Done". Review URL: http://codereview.chromium.org/661235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40202 0039d316-1c4b-4281-b951-d872f2087c98
* Teach the cookie tree view and model about appcaches. Not hooked up to real ↵michaeln@chromium.org2010-02-266-23/+254
| | | | | | | | | | | | | data yet, but the view and model pieces are in place for windows and gtk (not yet done for the mac). Also adds a 'name' attribute to database details pane, cleans up the layout of the detail panes on windows. BUG=25977 TEST=manual Review URL: http://codereview.chromium.org/650110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40181 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Add the experimental purge memory button. Also add a GRD entry for the ↵thestig@chromium.org2010-02-261-3/+4
| | | | | | | | | | button. BUG=none TEST=The --purge-memory-button switch adds a purge memory button to the task manager. Review URL: http://codereview.chromium.org/661200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40170 0039d316-1c4b-4281-b951-d872f2087c98
* fix bug where translate infobar gets stuck at "Loading..." between switching ↵kuan@chromium.org2010-02-261-8/+4
| | | | | | | | | | | | | | tabs. - problem happened because infobars are destructed when switching between tabs, only the delegates persist. without the infobar to receive the PAGE_TRANSLATED notification to update the translate state, the infobar gets stuck at translating state when user switches back to the associated tab. - fix was to update the state in the infobar delegate on receiving PAGE_TRANSLATE notification so that when a new translate infobar is created, its visual display will reflect the updated after-translate state. BUG=36895 TEST=verify per bug report. Review URL: http://codereview.chromium.org/660187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40135 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a preference to turn off the translate feature.jcampan@chromium.org2010-02-261-3/+70
| | | | | | | | | | | | | | BUG=None TEST=Visit a page in a language other than the Chrome's language. A translate infobar should be shown. In the options/Under the Hood tab, unselect "Offer to translate pages that aren't in a language I read". Navigate again to a page in a non Chrome-UI language. No translate infobar should be shown. Review URL: http://codereview.chromium.org/661095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40128 0039d316-1c4b-4281-b951-d872f2087c98
* fix crash when translate infobar is instantiated with Translating statekuan@chromium.org2010-02-251-0/+2
| | | | | | | | | | | translate infobar was expected to always be instantiated with BeforeTranslate state, but if connection is slow and infobar remains at Translating state when user switches to another tab then switches back to the "Translating" tab, all controls need to be created. BUG=36812 TEST=On a slow connection, open a page that shows translate infobar, click to translate; while it's still translating, switch to another tab then switch back to the translating tab, it shouldn't crash. Review URL: http://codereview.chromium.org/661103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40055 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make pause/resume item in download context menu a check item (the name ↵estade@chromium.org2010-02-251-39/+3
| | | | | | | | | | | | | already toggles between pause and resume) also, share more code between windows and linux. DownloadShelfContextMenu{Win,Linux} don't need to both implement menus::SimpleMenuModel::Delegate. BUG=24759 TEST=download item context menu still works. Review URL: http://codereview.chromium.org/652200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40051 0039d316-1c4b-4281-b951-d872f2087c98
* Translate Infobars for OS X.jeremy@chromium.org2010-02-251-1/+2
| | | | | | | | | | | Infobars.xib changes - Connect and fix class for close button since the translate infobar needs to know where it is to position the "Options" menu to it's left. BUG=34466 TEST=Translate infobars should continue to workon Windows. Review URL: http://codereview.chromium.org/594056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 32106xiyuan@chromium.org2010-02-251-2/+25
| | | | | | | | | | | | | | | | | | Issue 32106 happens when user creates a browser window without creating desktop shortcut. In this case, Windows does not have sufficient relaunching info to support pinning the browser window. The fix is to create a shortcut in "User Pinned" folder which Win7 watches and would get relaunch info from it. Also fix a minor bug in win_util::SetAppIdForWindow that would make the function only work for Win7 but not above. BUG=32106 TEST=Verify fix for 32106. See comemnts #1 and #5 for repro steps. Review URL: http://codereview.chromium.org/660038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39963 0039d316-1c4b-4281-b951-d872f2087c98
* Mirror sysmenu target rect on RTL UIs.pkasting@chromium.org2010-02-241-3/+1
| | | | | | | | BUG=36091 TEST=Start Chrome in Hebrew, click upper left corner, no sysmenu should appear. Review URL: http://codereview.chromium.org/661033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39948 0039d316-1c4b-4281-b951-d872f2087c98
* Add a host validity status icon to the content settings exception editor. ↵pkasting@chromium.org2010-02-242-17/+43
| | | | | | | | | Original patch by Thiago Farina (see http://codereview.chromium.org/650011 ), r=me. BUG=34181 TEST=Open the content settings exception editor, hit add, type a hostname, observe how status icon changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39931 0039d316-1c4b-4281-b951-d872f2087c98
* fix bug to not trigger translation when source language is modified in ↵kuan@chromium.org2010-02-241-6/+2
| | | | | | | | | | | before-translate infobar BUG=36666 TEST=verify per bug report. TBR=jeremy Review URL: http://codereview.chromium.org/652229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39895 0039d316-1c4b-4281-b951-d872f2087c98
* windows: Theme the popup window with the incognito theme when we are in the ↵jhawkins@chromium.org2010-02-241-4/+8
| | | | | | | | | | | | | | incognito mode. BUG=20373 TEST=see bug Patch by Thiago Farina <thiago.farina@gmail.com> Original review at http://codereview.chromium.org/606060 Review URL: http://codereview.chromium.org/657042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39844 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying a JavaScript message box (such as an alert) fromjcampan@chromium.org2010-02-232-2/+7
| | | | | | | | | | | | | | | | | | | | | an extension popup was causing the popup to lose focus and be dismissed, causing other problems. This CL fixes it on Windows with the following: - the message box is now parented to the popup, not the tab - the popup is not disimissed when losing focus to a window for which it is the owner. BUG=29147 TEST=Create an extension with a popup that contains a combo-box and a button to show an alert and confirm box. Click on the combobox and select an item. Click the button to show the alert and confirm message box. The popup should not be closed when you do that. Review URL: http://codereview.chromium.org/650045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39770 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where the "remove" and "remove all" buttons areian@chromium.org2010-02-231-2/+3
| | | | | | | | | | | enabled in the "Cookies" page even when there is nothing selected in the tree view. BUG=34886 TEST=open cookies view, see that remove and remove all are not enabled until you select something. Review URL: http://codereview.chromium.org/650173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39676 0039d316-1c4b-4281-b951-d872f2087c98
* Build breakage fixoshima@chromium.org2010-02-221-1/+1
| | | | | | | | | | TBR=sky@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/650179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39650 0039d316-1c4b-4281-b951-d872f2087c98
* Build breakage fixoshima@chromium.org2010-02-221-1/+1
| | | | | | | | | | TBR=sky@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/652078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39648 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserFrameView for ChromeOS.oshima@chromium.org2010-02-229-76/+21
| | | | | | | | | | | | | | | * Introduced NormalBrowserFrameView, which can place OTR avatar icon in the right place. - This is based on OpaqueBrowserFrameView, but a lot of stuff that are unnecessary in ChromeOS has been removed. - Moved OTR Avatar icon view to BrowserView for now as this is much simpler to implement the above change. I'll revisit the possibility to refactor layout code to GetBoundsForXXX later. * removed most of browser extender stuff. BUG=chromium-os:1007 TEST=open incognito window and switch to compact navigation mode (ctrl-shift-c). incognito icon should be placed between tabstrip and status area. Review URL: http://codereview.chromium.org/593098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39645 0039d316-1c4b-4281-b951-d872f2087c98
* Removes tab overview related classes and renames TabOverviewTypes tosky@chromium.org2010-02-2221-2879/+20
| | | | | | | | | | | WmIpc. BUG=none TEST=none Review URL: http://codereview.chromium.org/646079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39604 0039d316-1c4b-4281-b951-d872f2087c98
* Fix truncation issues for new Privacy UI. Also, make the checkbox for the ↵ben@chromium.org2010-02-201-2/+3
| | | | | | | | | | | "clear cookie on exit" item wrap. http://crbug.com/35118 TEST=none Review URL: http://codereview.chromium.org/646059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39564 0039d316-1c4b-4281-b951-d872f2087c98
* Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can ↵jorlow@chromium.org2010-02-202-2/+1
| | | | | | | | | | | | | | | make its decision. Before, it used the TabContents to get the profile to get the map, but this was incorrect because the current tab isn't necessarily from the same profile as the original request. As long as we have the HostContentSettingsMap, we might as well handle "remember" in CookieModalDialog. This bug exists in 4.1. TEST=none BUG=none Review URL: http://codereview.chromium.org/651023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39558 0039d316-1c4b-4281-b951-d872f2087c98
* Show extension action context menus on mouse upfinnur@chromium.org2010-02-202-2/+13
| | | | | | | | | | | | | | | instead of mouse down. BUG=33155 TEST=Make sure right-click menus for Page Actions still work. Then right-click a Page Action and while the context menu is up, right click a browser action/bookmark bar (the right menu should show). Review URL: http://codereview.chromium.org/650087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39556 0039d316-1c4b-4281-b951-d872f2087c98
* Bound page reloading ignoring cache to the following user actions:avayvod@chromium.org2010-02-201-0/+6
| | | | | | | | | | | | | - pressing Ctrl+F5 or Shift+F5 or Ctrl+Shift+R - Shift- or Ctrl-clicking the Reload button. Should work on Windows and Chrome OS (including compact navigation mode). BUG=36244 TEST=Verify that everything works as described above. Review URL: http://codereview.chromium.org/650048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39543 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this. The first attempt failed becausesky@chromium.org2010-02-194-59/+107
| | | | | | | | | | | | | | | | | | View::MirroredX is defined inline in the .cc, which apparently means gcc won't export it for callers outside of view.cc. Changes the rendering of mini-tabs slightly: . the icons of mini-tabs scales up to 24x24 on mouse over. . phantom tabs are rendered in their own layer behind other tabs at 40% opacity. The icon for phantom tabs are rendered at 60% opactiy. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/650066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39513 0039d316-1c4b-4281-b951-d872f2087c98
* Make use of SimpleMenuModel in DownloadShelfContextMenuWin and ↵estade@chromium.org2010-02-192-59/+40
| | | | | | | | | | | | | | DownloadShelfContextMenuGtk. BUG=31365 TEST=manually patch by Thiago Farina original review at http://codereview.chromium.org/552251/show Review URL: http://codereview.chromium.org/647059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39496 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39489 - Changes the rendering of minitabs slightly:sky@chromium.org2010-02-194-107/+59
| | | | | | | | | | | | | | | | . the icons of minitabs scales up to 24x24 on mouse over. . phantom tabs are rendered in their own layer behind other tabs at 40% opacity. The icon for phantom tabs are rendered at 60% opactiy. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/646067 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/650062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39490 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the rendering of mini-tabs slightly:sky@chromium.org2010-02-194-59/+107
| | | | | | | | | | | | | . the icons of mini-tabs scales up to 24x24 on mouse over. . phantom tabs are rendered in their own layer behind other tabs at 40% opacity. The icon for phantom tabs are rendered at 60% opactiy. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/646067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39489 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement the exceptions dialog for the content filtering settings.erg@chromium.org2010-02-194-145/+2
| | | | | | | | | BUG=35178 TEST=none Review URL: http://codereview.chromium.org/646060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39468 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark star button theming. Patch by Thiago Farina.mirandac@chromium.org2010-02-193-4/+11
| | | | | | | | | | | BUG= 35028 TEST= Apply a theme. Restart Chrome. Reset to default theme. Bookmark button is correctly returned to default. (see bug report) Review URL: http://codereview.chromium.org/630006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39461 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-1940-47/+47
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-198-0/+8
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when installing an extension from incognito mode.mpcomplete@chromium.org2010-02-191-3/+6
| | | | | | | | BUG=36077 Review URL: http://codereview.chromium.org/646072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39408 0039d316-1c4b-4281-b951-d872f2087c98
* Actually delete databases in CookiesTreeModel.jochen@chromium.org2010-02-181-7/+3
| | | | | | | | | BUG=34633 TEST=delete a database while it's opened in the renderer Review URL: http://codereview.chromium.org/600104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39346 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular message loop for cros login windowdavemoore@chromium.org2010-02-181-1/+1
| | | | | | | | | | | | | | First we have to allow the regular initialization to happen. This will permit the login wizard screens to use the network and rendering capabilities of chrome safely. Once a user logs in and cros mounts their encrypted directory as a profile, we change the default profile to that one and create a new browser window with it as well. This ought to make launching the first browser window even faster. Review URL: http://codereview.chromium.org/604052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39339 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in cookie prompting:sky@chromium.org2010-02-182-21/+3
| | | | | | | | | | | | | | | | | | . In certain situations we could crash because we weren't letting CookiePromptView::Init complete and then attempting to reference some NULL fields. I've fixed this by adding AppModalDialog::IsValid and moving the logic that was in Init to IsValid. This way we only create CookiePromptView when needed. . We were leaking AppModalDialogs. I've made CookiePromptView own the AppModalDialog and delete it when the CookiePromptView is deleted. BUG=36079 TEST=enable prompting for cookies, go to a bunch of sites make sure you don't crash. Review URL: http://codereview.chromium.org/632006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39328 0039d316-1c4b-4281-b951-d872f2087c98
* previous cl (r39286) only disables commands in fullscreen mode for ↵kuan@chromium.org2010-02-171-1/+1
| | | | | | | | | | chromeos=1, this cl adds another variant toolkit_views=1. BUG=34340 TEST=verify per bug report. Review URL: http://codereview.chromium.org/629005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39296 0039d316-1c4b-4281-b951-d872f2087c98
* disable comamnds in full screen modekuan@chromium.org2010-02-171-0/+8
| | | | | | | | | | | original bug was to disable CTRL+B (toggling of bookmark bar) in full screen mode; turns out there's a method that other platforms call to disable specific comamnds in full screen mode BUG=34340 TEST=verify per bug report. Review URL: http://codereview.chromium.org/626007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39286 0039d316-1c4b-4281-b951-d872f2087c98
* When we're initializing the modal dialog box which asks whether the page has ↵jorlow@chromium.org2010-02-171-0/+20
| | | | | | | | | | | | | | permission to access a "cookie", double check that the value has not since been set. If it has, close the window before it's even shown. This is a stop-gap solution. We should probably come up with something more elegent long term. TEST=Go to a page that starts a database transaction and immediately sets a local storage value. You should get one prompt instead of 2. BUG=36006 Review URL: http://codereview.chromium.org/619009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39270 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 00:28:07 +0000