summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Convert Alternate NavURL Fetcher to use the new infobar framework.ben@chromium.org2008-12-032-0/+132
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/13070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6268 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-038-26/+37
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 4829: No file extensions listed when saving imagesfinnur@google.com2008-12-031-2/+1
| | | | | | | | | | | | | | | | | | | We were not supplying a filter list for the Save As dialog. Now that we do, the user can select between, for example, say *.jpg and *.* as filters and we behave as follows: With a *.jpg filter active, user enters foo and we save the file as: foo.jpg With a *.jpg filter active, user enters foo. and we save the file as: foo..jpg (which is consistent with IE) With a *.jpg filter active, user enters foo.jpg, we save the file as: foo.jpg With a *.jpg filter active, user enters foo.jpeg, we save the file as: foo.jpeg (not foo.jpg or foo.jpeg.jpg) With a *.* filter active, we respect whatever user enters as extension, except if the filename contains one or more trailing dots then we strip out all those trailing dots. Also test filenames created when saving web pages, as opposed to images (should work as before). Review URL: http://codereview.chromium.org/12836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6258 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-028-37/+26
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
* Don't close tabs on middle-click when the release happens off the tab. ↵pkasting@chromium.org2008-12-011-1/+5
| | | | | | | | Patch by Mohamed Mansour, r=ben. See http://codereview.chromium.org/12816/ . BUG=1062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6184 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.open()/window.close() regression by disabling window.close() ↵erg@google.com2008-12-011-0/+1
| | | | | | | | | | | until a message comes back from the Browser thread saying that it's OK to allow javascript close calls. ISSUE=http://crbug.com/4007 Review URL: http://codereview.chromium.org/12691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6165 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new submenu in the context menu for a text box. This submenu displays ↵sidchat@google.com2008-12-011-39/+8
| | | | | | | | some spell check languages that Chrome supports, derived from the accept languages list and the current spell check language. The spell check language which is currently set is shown to be selected. The user can click on some other spell check language, and it will become effective immediately (this part of the code was addressed in a previous CL, and has been checked in). Review URL: http://codereview.chromium.org/12614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6162 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/12502 for sverrir:sky@google.com2008-12-011-8/+15
| | | | | | | | | | | Fix selection after deleting cookies. The selection was seemingly random because the model to view mapping changed when deleting items. BUG=3692 TEST=Try deleting items in cookies view and make sure selection doesn't jump around unexpectedly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6150 0039d316-1c4b-4281-b951-d872f2087c98
* Changes filter used when importing in bookmark manager to includesky@google.com2008-12-011-1/+1
| | | | | | | | | | | | | *.htm. BUG=4388 TEST=Create a file name foo.htm. Go to bookmark manager, choose import, navigate to directory with foo.htm and make sure the the open dialog shows foo.htm. Review URL: http://codereview.chromium.org/12459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6144 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding docus manager crasher work-around.jcampan@chromium.org2008-11-261-2/+7
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/12685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6050 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my previous commit, it seems to be breaking the UI tests in debug ↵jcampan@chromium.org2008-11-261-7/+2
| | | | | | | | mode. Review URL: http://codereview.chromium.org/12666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6020 0039d316-1c4b-4281-b951-d872f2087c98
* Changes keyword editor to map all input in the keyword field to lowersky@google.com2008-11-262-14/+17
| | | | | | | | | | | | case. BUG=4520 TEST=bring up the keyword editor, type some text and make sure it gets mapped to lower case. Review URL: http://codereview.chromium.org/12452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6018 0039d316-1c4b-4281-b951-d872f2087c98
* Some crashes reported from the field seems to indicate that whenjcampan@chromium.org2008-11-251-2/+7
| | | | | | | | | | | | | | | | | storing/restoring the focused view on a tab, the focus manager or focused view is garbage. I have not been able to repro any of these crashers and was not able to discover much from the mini-dumps. This is a simple work-around that just prevents the storing/restoring of focus when closing a tab, to avoid the cases reported in the crasher. Note this is the equivalent of CL 12622 (which is on the release branck), which was reviewed by Ben. BUG=4633 Review URL: http://codereview.chromium.org/12652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6000 0039d316-1c4b-4281-b951-d872f2087c98
* Changelist for erg's readability review.erg@google.com2008-11-253-114/+180
| | | | | | | | | | | | | | | | I am submitting BlockedPopupContainer for my C++ windows readability review. It's original code reviews are: http://codereview.chromium.org/8782 http://codereview.chromium.org/9373 http://codereview.chromium.org/10606 In addition to the above reviews, the test cases have been (re)written in: http://codereview.chromium.org/10206 http://codereview.chromium.org/9709 http://codereview.chromium.org/10282 Review URL: http://codereview.chromium.org/10618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5992 0039d316-1c4b-4281-b951-d872f2087c98
* Set the delegate on incoming TabContents in ↵erg@google.com2008-11-251-3/+5
| | | | | | | | BlockedPopupContainer::ReplaceContents. Review URL: http://codereview.chromium.org/12646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5988 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash with plugin installer infobar due to the infobardelegate not being ↵ben@chromium.org2008-11-252-5/+13
| | | | | | | | | | removed from the containing TabContents. http://crbug.com/4620 Review URL: http://codereview.chromium.org/12624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5957 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 5929 (r5882) with crash fix and also this change:ben@chromium.org2008-11-254-26/+134
| | | | | | | | | | | http://codereview.chromium.org/11392/show which fixes the remainder of the UI test issues apparently. http://crbug.com/4620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5954 0039d316-1c4b-4281-b951-d872f2087c98
* rollbackben@chromium.org2008-11-243-42/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5933 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r5882 with a crash fix.ben@chromium.org2008-11-243-9/+42
| | | | | | | http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5929 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5882. It broke LoginPromptTest.TestBasicAuth and .TestTwoAuths.maruel@chromium.org2008-11-243-36/+2
| | | | | | Review URL: http://codereview.chromium.org/11399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5922 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base versions of the graphics headers, which previously just ↵brettw@google.com2008-11-221-1/+1
| | | | | | | | forwarded to the skia ones. Review URL: http://codereview.chromium.org/11588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
* Add new infobar files to SCons build.sgk@google.com2008-11-221-0/+2
| | | | | | Review URL: http://codereview.chromium.org/11380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5892 0039d316-1c4b-4281-b951-d872f2087c98
* This change makes the following infobars use the new system:ben@chromium.org2008-11-223-2/+36
| | | | | | | | - save password Review URL: http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5882 0039d316-1c4b-4281-b951-d872f2087c98
* Beginnings of a new InfoBar system.ben@chromium.org2008-11-217-9/+679
| | | | | | | | | | This implements AlertInfoBar and InfoBarContainer. It also makes the crashed plugin/js oom infobars use this new system. Design Doc: http://dev.chromium.org/developers/design-documents/info-barshttp://crbug.com/4620 Review URL: http://codereview.chromium.org/11318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5856 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Container->Widgetben@chromium.org2008-11-2149-165/+158
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Adds various docking positions when dragging around a tab. I've addedsky@google.com2008-11-203-98/+427
| | | | | | | | | | | | | | | | | | | | | | | the ability to dock to the following locations: Maximize the window on drop. Resize the window to fill up the left, bottom, or right half of the monitor. Tile the newly created window with an existing chrome window such that the two are on top of each other and fill the height of the monitor, or tiled such that they fill the width of the monitor. The graphics suxor. Glen says he'll come up with something better once its landed. BUG=none TEST=4628 Review URL: http://codereview.chromium.org/11325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5797 0039d316-1c4b-4281-b951-d872f2087c98
* Don't execute a NOTREACHED in TabStrip::DestroyDraggedSourceTab if thesky@google.com2008-11-201-1/+2
| | | | | | | | | | | | | | | tab strip contains the tab but the model is closing all. Normally the end of the animation removes the tab, but if we're closing all tabs the animation isn't run. I was hitting this when I have more than one window open and drag a tab in a window with a single tab and release it. BUG=none TEST=none Review URL: http://codereview.chromium.org/11294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5733 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-191-0/+67
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this change: http://codereview.chromium.org/10967/showben@chromium.org2008-11-191-2/+2
| | | | | | | | | Now with two improvements: - no longer create WebContentsViews as WS_VISIBLE, to prevent them from showing up in the taskbar - make sure overridden CreateView in NativeUIContents and StatusView have the correct signature. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5723 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for developer0420@gmail.comjoshia@google.com2008-11-192-7/+53
| | | | | | | | | | | | | | | | | | | | | The LPITEMIDLIST returned from SHBrowseForFolder might not get released if SHGetPathFromIDList fails Added in the comment changes Added GetDisplayNameOf for getting selection, using old way if STRRET Structure type does not equal STRRET_WSTR as I was unable to get complete code coverage. Added BrowseCallbackProc and listen to MSG so that we can highlight existing value Added in the comment changes ( changed to smart pointer for managing COM interface pointers.) Review URL: http://codereview.chromium.org/11481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5686 0039d316-1c4b-4281-b951-d872f2087c98
* Land this change again now I've fixed the crash.ben@chromium.org2008-11-1914-60/+76
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5669 0039d316-1c4b-4281-b951-d872f2087c98
* put back this change now chromebot has had a chance to runben@chromium.org2008-11-191-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5653 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser window is visible, even if the startup info says that ↵ben@chromium.org2008-11-191-1/+3
| | | | | | | | | it should be hidden. This fixes the problem of invisible browser window when launched from bash. http://crbug.com/4438 Review URL: http://codereview.chromium.org/11454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5652 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back a bunch of changes to tab dragging that seem to not have helped ↵ben@chromium.org2008-11-182-8/+15
| | | | | | | | | | | reduce the crashiness any :-/ r5335 dragged_tab_controller.cc (delegate NULL setting) r5124 changes to make AutomationProvider::WindowSimulateDrag use SendInput instead of SendMessage r5117 dragged_tab_controller.cc (delegate NULL setting) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5636 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 5596 because it broke the buildnsylvain@chromium.org2008-11-1814-72/+60
| | | | | | Review URL: http://codereview.chromium.org/11439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5598 0039d316-1c4b-4281-b951-d872f2087c98
* Last couple of bits of new-frame related cleanup:ben@chromium.org2008-11-1814-60/+72
| | | | | | | | | | | | | - Remove frame_util.cc, moving functions to BrowserList (endsession) and BrowserView (GetBrowserWindowForHWND) - Tidy up interface for TabIconView model. The model now sources only the information it needs (loading state and favicon). - Replace BrowserType class with an enum on Browser. http://crbug.com/2320 http://crbug.com/3363 Review URL: http://codereview.chromium.org/10786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5596 0039d316-1c4b-4281-b951-d872f2087c98
* Changes about view to explicitly set the background to white. This waysky@google.com2008-11-171-0/+1
| | | | | | | | | | | | even though the field is disabled you get a white background. BUG=4511 TEST=Bring up about chrome and make sure background of version string is white. Review URL: http://codereview.chromium.org/11421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5574 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback! Now with 25% more HWND.ben@chromium.org2008-11-171-2/+2
| | | | | | :-/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5573 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HWND from TabContents creation. ben@chromium.org2008-11-171-2/+2
| | | | | | R=brettw ReviewURL: http://codereview.chromium.org/10967/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5554 0039d316-1c4b-4281-b951-d872f2087c98
* Quick test to locate position of crash on qemu. Will remove after one batch ↵ben@chromium.org2008-11-161-1/+2
| | | | | | of crashes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5546 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Browser restore saved last size/position using the WindowDelegate ↵ben@chromium.org2008-11-152-1/+9
| | | | | | | | code rather than hand-rolling its own. Review URL: http://codereview.chromium.org/10959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5520 0039d316-1c4b-4281-b951-d872f2087c98
* Rewire the throbber so that the timer for updating lives on BrowserView, not ↵ben@chromium.org2008-11-144-54/+57
| | | | | | | | | TabStrip, so that app window/popup throbber updating doesn't need to be plumbed through the tabstrip and the browser object! http://crbug.com/3297 Review URL: http://codereview.chromium.org/10761 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5513 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmark manager blue.glen@chromium.org2008-11-141-2/+14
| | | | | | Review URL: http://codereview.chromium.org/11006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5506 0039d316-1c4b-4281-b951-d872f2087c98
* Rid most of the Browser object of HWND dependencies.ben@chromium.org2008-11-145-6/+126
| | | | | | Review URL: http://codereview.chromium.org/10929 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5492 0039d316-1c4b-4281-b951-d872f2087c98
* Remove browser\views\frame\browser_view2.cc andsgk@google.com2008-11-141-7/+0
| | | | | | | browser\views\old_frames from the SCons build. Review URL: http://codereview.chromium.org/10723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5486 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/agl@chromium.org2008-11-141-0/+1
| | | | | | | | | | | | | | | #ifdef out windows-specific portion of chrome/common/l10n_util.h, which allows me to port some other files. I also extracted parts of chrome/views/tree_view.h to tree_model.h, so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h is platform-independent and can be included in files using it as base class. Review URL: http://codereview.chromium.org/8618 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
* Make border and background setting and getting non-virtual and use the ↵brettw@google.com2008-11-149-11/+11
| | | | | | | | correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual. Review URL: http://codereview.chromium.org/10638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the interactive ui tests by correctly initializing the specified popup ↵ben@chromium.org2008-11-141-2/+1
| | | | | | | | | bounds. TBR=erg Review URL: http://codereview.chromium.org/10724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5429 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-1414-127/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we were not checking if an app from another windowsky@google.com2008-11-141-8/+52
| | | | | | | | | | | | was on top of Chrome's topmost brower window when attempting to dock a dragged tab. BUG=1094303 TEST=see bug Review URL: http://codereview.chromium.org/10715 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5416 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-29 13:46:19 +0000