| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the billing address drop down from the Autofill preferences "Add credit card" dialog.
Nib changes: remove the billing address label and drop down from AutoFillCreditCardSheet.xib.
BUG=57976
TEST=compiles, no billing address drop down visible in any Autofill preferences UI.
Review URL: http://codereview.chromium.org/3964003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, replace "About Chrome" with "About Chrome OS" in the wrench menu.
TEST=Connect to a dev server with a newer version, and check that the menu item appears, and the dialog works.
BUG=chromium-os:6526
BUG=chromium-os:7847
Review URL: http://codereview.chromium.org/3858002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/3885003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility extension API on Windows. This adds a few more
accessibility events to views accessibility while we're at it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3999001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I used label/goto in ToolkitView::RunMenu. It sucks, but probably better because the change is smaller than other approach (for branch). Please let me know if you have better idea.
BUG=chromium-os:6497
TEST=none
Review URL: http://codereview.chromium.org/4046001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it on.
BUG=58917
TEST=none
Review URL: http://codereview.chromium.org/3961003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screenreaders. Rename AccessibleToolbarView to AccessiblePaneView to reflect
that it covers more than just toolbars. Also add infobars to the F6 pane
traversal.
BUG=372
TEST=none
Review URL: http://codereview.chromium.org/3722004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that Ananta has graciously converted ChromeFrame to use the new SSL InfoBubble I can try again to delete the old SSL Page Info dialogs.
TBR=jcivelli
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3927003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sidchat
BUG=57687
TEST=interactive_ui_tests
Review URL: http://codereview.chromium.org/4001004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/3828014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
InstantLoader::DestroyPreviewContents()
AutocompleteEditView::GetMaxYCoordinate()
BUG=None
TEST=Everything should still compile.
Review URL: http://codereview.chromium.org/3772008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7707
TEST=Manual.
Review URL: http://codereview.chromium.org/3902004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ok.
BUG=59148
TEST=none
Review URL: http://codereview.chromium.org/3803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't correctly return a preferred/minimum size and the options dialog
can end up getting clipped (because the cached size is too
small).
Also, makes the options window always use the minimum size when
showing. This way if we happen to remove an option such that the
dialog is smaller the dialog won't end up too big.
BUG=59122
TEST=With aero enabled bring up the options dialog on M6/M7. Then bring up
the options dialog with this fix enabled and make sure you don't get
any clipping.
Review URL: http://codereview.chromium.org/3825006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48706
TEST=none
Review URL: http://codereview.chromium.org/3792007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
removes windows_message_list which isn't used.
This keeps a stub for registry in the old location until we can update that.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3836005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this since it's mostly a revert.
TBR=ben@chromium.org
BUG=59298
TEST=make sure instant isn't in preferences anymore.
Review URL: http://codereview.chromium.org/3809005
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3777009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this since it's mostly a revert.
TBR=ben@chromium.org
BUG=59298
TEST=make sure instant isn't in preferences anymore.
Review URL: http://codereview.chromium.org/3809005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove AppLauncher class (it's not used anymore).
BUG=56236,57371
TEST=build and ran it.
Review URL: http://codereview.chromium.org/3852001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from Win/Gtk. It has been replaced with the PageInfoBubble so it is not in use anymore.
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3830001
TBR=finnur@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is in Offline mode.
Also tackled the resize flicker by adding animation.
BUG=59331, 59307
TEST=Contact mpcomplete for details on how to test the crash. For the resize, just make sure the bubble animates after the Site Information is available (most of the time that is almost instantly).
Review URL: http://codereview.chromium.org/3747005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the PageInfoBubble so it is not in use anymore.
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3830001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59368
TEST=Tabbed ui for clearing private data UI gone
Review URL: http://codereview.chromium.org/3819004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
text.
BUG=59229
TEST=Manual test using test case attached to bug 59229.
Review URL: http://codereview.chromium.org/3818005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59296, 59297
TEST=UI does not show up on Windows anymore unless you have the flag on.
Review URL: http://codereview.chromium.org/3748008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Nest current checkboxes inside tab, add needed elements to other tab.
BUG=57876
TEST=as in bug 54349; functionality currently hidden behind flag
Review URL: http://codereview.chromium.org/3590020
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/3840001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rolls in some of raz@'s windows fixes.
BUG=57877
TEST=Dialog grays out before disappearing when trying to clear server side data (and handles server errors)
Review URL: http://codereview.chromium.org/3680003
TBR=erg@google.com
Review URL: http://codereview.chromium.org/3836002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behind switch
BUG=59095
TEST=See ui in options tab and clear other data tab
Review URL: http://codereview.chromium.org/3758004
TBR=raz@chromium.org
Review URL: http://codereview.chromium.org/3811008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/win/windows_version. Many files now only need to include this instead of all of win_util.
Remove a bunch of unused code from base/win_util. There was a surprising amount.
Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56169
TEST=hover over a link on the NTP and hide and show the bookmarks bar
Review URL: http://codereview.chromium.org/3795004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cancelling out of the setup dialog needs to re-layout in order to properly go
from the setting up text to the sign in text.
BUG=59037
TEST=On Windows, bring up Options, Under the Hood, disable the proxy if it isn't, hit the setup button, cancel out of the login dialog. Button should resize and not clip.
Review URL: http://codereview.chromium.org/3817002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59095
TEST=See ui in options tab and clear other data tab
Review URL: http://codereview.chromium.org/3758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Options menu ("Under the Hood" tab) on Windows.
R=mattm
BUG=59125
TEST=net_unittests.exe --gtest_filter=SSLConfigServiceWinTest.SetTest.
Manually verify the Options menu has the two new checkboxes.
Review URL: http://codereview.chromium.org/3779003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the size actually changes. Layout was the wrong place for the check
before as Layout may be invoked even if the size hasn't changed.
BUG=59164
TEST=make sure tabstrip on windows still has animations.
Review URL: http://codereview.chromium.org/3782006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed around BlockedPopupContainer so that it can handle any types
and made TabContents offer a mode to block all child content.
BUG=58927
TEST=enable instant, go to a site that would normally show a popup on
entering (or explicitly enable all popups). While typing in
the omnibox the popup shouldn't appear, but as soon as you
commit the instant result it should appear.
Review URL: http://codereview.chromium.org/3694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26450
TEST=Load webpage with three JS alerts. Check "Prevent this page from creating
additional dialogs" on the second, and Cancel that alert. Ensure that the
third alert is not shown.
Review URL: http://codereview.chromium.org/3792001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the second.
BUG=none
TEST=none
TBR=mirandac
Review URL: http://codereview.chromium.org/3751005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57885
TEST=included
Review URL: http://codereview.chromium.org/3755006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* RTL support is menu positioning only. Menu content will
be done after beta.
* Fix the location of menu when it has to be placed at the
left edge.
* Temporarily disable rounded corner for beta.
I'm pretty sure there was a bug filed for RTL, but I couldn't find it today.
BUG=chromium-os:7722
TEST=select rtl language (hebrew) and make sure menu's position is correctly adjusted. Language menu on info bar should have scroll button with this change.
Review URL: http://codereview.chromium.org/3803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56510
TEST=hide and close the bookmarks bar on the NTP and note the logo in the lower right corner stays visible
Review URL: http://codereview.chromium.org/3730005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=57885
TEST=included
Review URL: http://codereview.chromium.org/3573014
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/3797001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mirandac
Review URL: http://codereview.chromium.org/3777002
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/3744006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mirandac
Review URL: http://codereview.chromium.org/3777002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57885
TEST=included
Review URL: http://codereview.chromium.org/3573014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NEW_WINDOW. Many places were leaking a Browser and preventing Chrome
from shutting down.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3655006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Call OnMenuOpened when the window is mapped.
This is necessary as DOMUI menu doesn't show the popup window until page is renderred.
* Moved listners to Menu2 as Menu2 manages MenuListeners.
BUG=chromium-os:7642
TEST=TestMenuKeyboardAccess,TestAltMenuKeyboardAccess passes with this fix.
Review URL: http://codereview.chromium.org/3678005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
is needed because pdf documents might disallow copying/printing and it's confusing to have an enabled menu item which does nothing.
BUG=47364
Review URL: http://codereview.chromium.org/3692007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62345 0039d316-1c4b-4281-b951-d872f2087c98
|