summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Solved 2 bugs which caused Chrome to maximize itself whendouble clicking, ↵idanan@chromium.org2009-02-184-6/+18
| | | | | | | | either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler. Review URL: http://codereview.chromium.org/21268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9953 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fullscreen mode support.pkasting@chromium.org2009-02-185-8/+114
| | | | | | | | | There is no UI for this (yet), just F11 to toggle in and out. BUG=534 Review URL: http://codereview.chromium.org/20423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9950 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogs had focus problems.jcampan@chromium.org2009-02-1811-11/+19
| | | | | | | | | | | | | | | | | | They would not be focused when shown and tab traversal was not working. This was caused by several issues: - HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default. - DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab. - DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view). Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method. BUG=6859 TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields Review URL: http://codereview.chromium.org/21439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in GetDefaultSearchEngineName() in first run bubble.cpu@google.com2009-02-173-12/+17
| | | | | | | | | | | | - It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active. - But rather than guessing the profile, get it from the guts of the location bar. - crasher is ranked #34 by Laforge BUG=6211 Review URL: http://codereview.chromium.org/20381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9916 0039d316-1c4b-4281-b951-d872f2087c98
* When internal functions try to focus the location bar, check whether it's ↵pkasting@chromium.org2009-02-172-0/+12
| | | | | | | | | focusable, and clear the focus if it's not. This shouldn't kick in in any cases today (I don't think), but it will matter in fullscreen mode, where creating a new tab should not attempt to focus the (unfocusable) location bar, but should not do nothing either, since these leaves focus in a hosed state. There are other choices here. I could make View::RequestFocus() try and clear the focus if the view is not focusable. That seems likely to cause side-effects unless I restore a lot of the calls to IsFocusable() that I previously removed. I also don't know whether sticking this on BrowserWindow was the right approach; if there's a better spot architecturally, speak up. Review URL: http://codereview.chromium.org/21368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9882 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in preparation for Fullscreen mode.pkasting@chromium.org2009-02-135-144/+94
| | | | | | | | | | | | | | | * Remove some unnecessary cruft from BrowserView. * Change Find bar to position itself based on the translated bounds of the bookmark bar or toolbar, whichever is found. This is a bit simpler than the offset-based version before and works much better with Fullscreen mode. * Make Bookmark bar not have a strange "1 px" minimum size, which was only needed because we were always subtracting that much in the BrowserView layout functions. * Change BrowserView toolbar layout functions to always lay out toolbars (instead of only when visible; they are 0-height when invisible), and explicitly set their visibility. This shouldn't have any visible effect, but it goes hand-in-hand with the Find bar changes. * Add a function on the Bookmark bar to determine if we're displaying detached, and change various callers to use it. Right now this does fairly little, but in Fullscreen mode it becomes necessary because we always display the Bookmark bar this way. There is one user-visible effect: when toggling the Bookmark bar on/off while the Find bar is visible, the Find bar will now snap to the Bookmark bar only when it finishes "attaching" to the toolbar, not as soon as it starts. Finnur and I both think this actually looks slightly better. Review URL: http://codereview.chromium.org/21359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9799 0039d316-1c4b-4281-b951-d872f2087c98
* Originally this change was intended as the solution to accidentally ↵idanan@google.com2009-02-131-3/+2
| | | | | | | | | | | maximizing Chrome by double-clicking on the new tab button. This solution does work but another one is being coded for a more general problem. This change solves also the accidental maximizing of Chrome when double-clicking the close tab button except on the last tab (rightmost in LTR systems). See issue 2827 for further details.This change removes a band-aid which did not perform a hit-test on the tab-strip while it is animating in order to avoid unknown chromebot crashes as reported by Ben. The removal of the fix makes the hit-test perform as expected.Trying this now, at Peter's suggestion, so that we can measure and diagnose potential problems hidden by the said band-aid. [NOTE] Revied and approved as http://codereview.chromium.org/20329 by Peter kasting. Had to copy changes to repo where I have commit rights. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9777 0039d316-1c4b-4281-b951-d872f2087c98
* Make system menus show up at the right place for all frames, whether they're ↵pkasting@chromium.org2009-02-135-127/+99
| | | | | | | | | | | | | | | | triggered by clicking the window icon or hitting alt-space. Make clicking the icon for windows without a non-client view (e.g. the Bookmark Manager on Aero Glass) bring up the system menu. Clean up more dead code, verbose code, or unnecessary statics/members. TEST=Right-click titlebars, hit alt-space, and left-click window icons (where present), for: * Main window * Dialogs, e.g. the bookmark manager * Popups * App windows When right-clicking, a system menu should appear at the cursor. For the other cases, a system menu should appear at the system native location (roughly just below the titlebar). Review URL: http://codereview.chromium.org/20225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9766 0039d316-1c4b-4281-b951-d872f2087c98
* Make some functions const. This will help with my fullscreen mode changes.pkasting@chromium.org2009-02-137-12/+22
| | | | | | | The only tricky bit here is how GetBookmarkBarView() is no longer guaranteed to return non-NULL. The only caller of this is the automation framework, in one place, which explicitly NULL-checks the result and does the right thing, so there should not be any problems. Review URL: http://codereview.chromium.org/23026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9764 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the executable bit from a bunch of files that shouldn't have had it.evan@chromium.org2009-02-122-0/+0
| | | | | | | R=tony (looked over my shoulder before I committed) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9683 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of landing chrome_resources project. Changes from last time:tc@google.com2009-02-1238-38/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | - fix scons dependencies by adding a target for grit/theme_resources.h - fix mac build by adding grit to unittest include path - fix check deps by adding rules for /grit dir. Create a chrome_resources.vcproj that holds grd files that hold non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/24011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
* This is an attempt at finding the reason for the page_cycler slowness caused bymad@chromium.org2009-02-124-12/+126
| | | | | | | | | | | | | | | the new resize corner. Local experiment led me to believe that it is WebKit that is slower when we specify a resize corner area. To validate this hypothesis, I always return an empty rect to WebKit, but I still compute and push the rect to the render widget and I also draw the bitmap even if this will cause it to be drawn on top of the scroll bars when there is only one. TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Create a chrome_resources.vcproj that holds grd files that hold"tc@google.com2009-02-1238-38/+38
| | | | | | | | | | This reverts commit r9631. TBR=deanm Review URL: http://codereview.chromium.org/23023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
* Create a chrome_resources.vcproj that holds grd files that holdtc@google.com2009-02-1238-38/+38
| | | | | | | | | | | | | | | | | | | | | non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/20247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
* Redo my IPC change, undoing the linker dependency.jam@chromium.org2009-02-111-442/+438
| | | | | | Review URL: http://codereview.chromium.org/21225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9557 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9493.kuchhal@chromium.org2009-02-104-126/+12
| | | | | | Review URL: http://codereview.chromium.org/21231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9517 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from HWNDs to NativeViews, take 2. (First attempt was r9409, in which ↵avi@chromium.org2009-02-108-14/+14
| | | | | | | | I missed a file.) Review URL: http://codereview.chromium.org/20226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9507 0039d316-1c4b-4281-b951-d872f2087c98
* revert my ipc change due to compile failure in debug ipc_testsjam@chromium.org2009-02-101-2/+19
| | | | | | Review URL: http://codereview.chromium.org/20229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9494 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding of http://codereview.chromium.org/16488.mad@chromium.org2009-02-104-12/+126
| | | | | | | | Adding proper project dependency in chrome.sln. Review URL: http://codereview.chromium.org/21188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ipc logging for non browser processes. I broke this in my last ↵jam@chromium.org2009-02-101-19/+2
| | | | | | | | refactoring, since the logger functions only got registered in the browser. This fix registers them using a global object for each message type (that's only compiled when debugging is enabled). One less thing to take care of when creating new message types. Review URL: http://codereview.chromium.org/20213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9492 0039d316-1c4b-4281-b951-d872f2087c98
* Try reverting r9409 to see if it fixes crashes on chromebot.kuchhal@chromium.org2009-02-108-14/+14
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/21215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9481 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UI test regression, there's a better way to refactor this anyway.pkasting@chromium.org2009-02-103-0/+20
| | | | | | | TBR=glen Review URL: http://codereview.chromium.org/24007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
* Make aero glass code look more like other nonclient views in hopes of easing ↵pkasting@chromium.org2009-02-097-260/+167
| | | | | | | | | refactoring. More cleanup. Change tabstrip layout to match opaque frame. BUG=5054 Review URL: http://codereview.chromium.org/20161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9408.brettw@chromium.org2009-02-094-126/+12
| | | | | | Review URL: http://codereview.chromium.org/20190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9414 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from HWNDs to NativeViews.avi@chromium.org2009-02-098-14/+14
| | | | | | Review URL: http://codereview.chromium.org/21143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9409 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new resizer corner.mad@chromium.org2009-02-094-12/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To display a resize bitmap and handle the mouse interactions as requested in http://code.google.com/p/chromium/issues/detail?id=458. BUG=458 There are unfortunately two cases to handle and they must be handled separately. The first one is when there are no bottom shelf like the download bar, and the case where there is one. For the case without, we must draw on top of what we receive from WebKit, so we intercept the bitmap in RenderWidgetHostViewWin::OnPaint() so that we can draw the resize corner bitmap on top of it (taking into account whether we are in a right to left language or not). For the case where we have a bottom shelf, we use a dedicated view that we properly layout on top of the bottom shelf view (which takes care of handling the RTL language case for us). Same split for the mouse interactions. Without the bottom shelf, we must deal with it in RenderWidgetHostViewWin::OnMouseEvent() by sending the root window a WM_NCLBUTTONDOWN message with either HTBOTTOMRIGHT or HTBOTTOMLEFT (based on the RTL setting) and let the OS take care of the resizing. IF we have a bottom shelf, we must deal with the mouse interaction in BrowserView::NonClientHitTest() to either return HTBOTTOMRIGHT or HTBOTTOMLEFT (again, based on the RTL setting) and, again, let the OS take care of the resizing. More details here: http://code.google.com/p/chromium/wiki/BrowserViewResizer git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9408 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom border widths. Allow user to resize the window (instead of ↵pkasting@chromium.org2009-02-062-107/+82
| | | | | | | | | doing nothing) when over our client edge graphics. Make resize corner behavior on XP more native. More cleanup. BUG=5054 Review URL: http://codereview.chromium.org/21116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9315 0039d316-1c4b-4281-b951-d872f2087c98
* Move the about:ipc tab to a dialog. This patch is kind of a hack, the Windowsbrettw@chromium.org2009-02-066-5/+537
| | | | | | | | | | | | | specific code for the settings dialog and the table view are just copied from the old dialog. I tried to change as little as possible. The only significant change should be that I commented out saving the settings in the profile. This is a re-land of my previous patch which didn't ifdef the code based on the IPC logging preprocessor define. Previous review URL: http://codereview.chromium.org/19741 Review URL: http://codereview.chromium.org/20033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9303 0039d316-1c4b-4281-b951-d872f2087c98
* New menu item for personalization project.munjal@chromium.org2009-02-061-0/+7
| | | | | | Review URL: http://codereview.chromium.org/21006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9285 0039d316-1c4b-4281-b951-d872f2087c98
* Move resource_message_filter and resource_request_details to the renderer_host.brettw@chromium.org2009-02-053-0/+166
| | | | | | | | | | Make the repost form warning portable by abstracting the show function from the view. Rename the Windows repost form warning and move it to browser/views. This also fixes a comment in browser_process.h Review URL: http://codereview.chromium.org/20066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9242 0039d316-1c4b-4281-b951-d872f2087c98
* Improved OTR avatar and popup window rendering. Neither one precisely ↵pkasting@chromium.org2009-02-046-145/+121
| | | | | | | | | | | matches the old code but IMO each looks better. Once again, the aero_glass_non_client_view changes here are hackish, and will get cleaned up later. BUG=5054 Review URL: http://codereview.chromium.org/20011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9116 0039d316-1c4b-4281-b951-d872f2087c98
* Remember change in Spell Check language by putting it in the list of accept ↵sidchat@google.com2009-02-031-0/+29
| | | | | | | | | | | languages when the user changes the language from languages options menu. It also includes a fix (required for this change to work) when existing users are updated to use language only code for spellcheck languages instead of languages+region. Issue=5829 Review URL: http://codereview.chromium.org/19520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9106 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9090.ojan@google.com2009-02-036-526/+5
| | | | | | | Broke chromium full build. Review URL: http://codereview.chromium.org/21024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9094 0039d316-1c4b-4281-b951-d872f2087c98
* Move the about:ipc tab to a dialog. This patch is kind of a hack, the Windowsbrettw@chromium.org2009-02-036-5/+526
| | | | | | | | | specific code for the settings dialog and the table view are just copied from the old dialog. I tried to change as little as possible. The only significant change should be that I commented out saving the settings in the profile. Review URL: http://codereview.chromium.org/19741 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9090 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some of the most egregious problems with Aero glass frames. These ↵pkasting@chromium.org2009-02-032-30/+30
| | | | | | | | | | | changes are basically hacks, but they're hacks that get our frame width, tabstrip layout (in non-OTR mode), and client edge drawing to exactly match pre-Magic-BrowzR code. In subsequent changes I will clean this all up to work better. This also fixes windows refusing to become activated. BUG=5054,6174 Review URL: http://codereview.chromium.org/19548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a divide by zero crash with a temporary workaround (until we have themes).ben@chromium.org2009-02-031-0/+6
| | | | | | | | http://crbug.com/6294 Review URL: http://codereview.chromium.org/19767 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9058 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old web app code it's no longer needed. Simplifies startup a little.ben@chromium.org2009-02-021-1/+0
| | | | | | | | Also fixes a regression from the BrowserInit porting work. I was a little over-zealous removing the CommandLine handling. It turns out that it's this that MessageWindow uses to convey the command line of the signalling process to the existing process, and that the existing process re-runs BrowserInit with the signalling process' command line. So I plumbed that back through again. Review URL: http://codereview.chromium.org/19746 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of header includes. I removed some unnecessary headers from abrettw@chromium.org2009-02-012-0/+2
| | | | | | | | variety of places and added ones in other files that were accidentally depending on them. Review URL: http://codereview.chromium.org/19742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9022 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-0119-68/+90
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back these tab changes since there are still issues.ben@chromium.org2009-01-311-22/+2
| | | | | | | TBR=idanan Review URL: http://codereview.chromium.org/19735 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9000 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with constrained windows and/or custom frame windows:pkasting@chromium.org2009-01-301-30/+83
| | | | | | | | | | | | | | | | | * Wrong titlebar height * Titlebars not handling custom font size properly * Drawing errors in maximized mode * One-pixel overlap glitch on bottom corners of client edges * Borders not handling custom border sizes correctly * Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip) * Wrong icon sizing (only a problem in theory, no one uses this code ATM) These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable. BUG=5054 Review URL: http://codereview.chromium.org/19484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
* Provides the ability to write a unit test that brings up a browser. Assky@google.com2009-01-302-52/+143
| | | | | | | | | | | | | | a proof of concept I converted FindInPageControllerTest.FindInPageFrames over to this. See the description in InProcessBrowserTest for how it all works. BUG=none TEST=none Review URL: http://codereview.chromium.org/19644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8934 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize DefaultNonClientView and ConstrainedWindowNonClientView to match ↵pkasting@chromium.org2009-01-291-165/+120
| | | | | | | | | | | changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation. This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes. This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.) Review URL: http://codereview.chromium.org/19684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
* Per Glen, remove the bottom border of maximized windows. I went ahead and ↵pkasting@chromium.org2009-01-294-87/+56
| | | | | | | | also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be. Review URL: http://codereview.chromium.org/19477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the option for HTTPServer to be created with a specificsky@google.com2009-01-292-10/+10
| | | | | | | | | | | | | | | MessageLoop. I'm going to need this when running ui tests in process. In this case I'll pass in the IO thread. I'll change all callers to use the new method, but before doing that wanted to make sure you're ok with it. BUG=none TEST=none Review URL: http://codereview.chromium.org/19039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
* Make the shared shell dialog not use Windows types, as well as the web contentsbrettw@chromium.org2009-01-293-4/+4
| | | | | | | code that runs it. Review URL: http://codereview.chromium.org/19666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8895 0039d316-1c4b-4281-b951-d872f2087c98
* Move kClientEdgeThickness from BrowserView to NonClientView (which makes ↵pkasting@chromium.org2009-01-294-27/+13
| | | | | | | | | more sense anyway) so I'll be able to use it in custom_frame_window.cc. Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one. Review URL: http://codereview.chromium.org/19458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect spacing/width calculation for titlebar text. I used the wrong ↵pkasting@chromium.org2009-01-292-51/+49
| | | | | | | | | constants, oops. Also some tiny reorderings and similar nonfunctional changes in order to make this class closer to its sibling NonClientView subclasses, so I can eventually refactor them all more easily. Review URL: http://codereview.chromium.org/19447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8849 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RenderWidgetHostView::GetPluginHWND to GetPluginNativeViewbrettw@chromium.org2009-01-291-4/+8
| | | | | | Review URL: http://codereview.chromium.org/19438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8846 0039d316-1c4b-4281-b951-d872f2087c98
* fix p13n build.tim@chromium.org2009-01-291-0/+3
| | | | | | Review URL: http://codereview.chromium.org/18835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8841 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 19:03:15 +0000