summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* DevTools: store devtools split offset only when devtools is being hidden.pfeldman@chromium.org2009-07-071-3/+6
| | | | | | | | Otherwise any browser window closed afterwards will overwrite settings with the original ones. Review URL: http://codereview.chromium.org/155140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20026 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up contents creation in BrowserViewben@chromium.org2009-07-071-3/+1
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue once and for all where distributor logo overlays window controls. ↵ben@chromium.org2009-07-072-0/+19
| | | | | | | | | | Need to force a layout and schedule a paint when a window is made visible. http://crbug.com/15520 TEST=see bug. Review URL: http://codereview.chromium.org/155111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20006 0039d316-1c4b-4281-b951-d872f2087c98
* Popup changesdavemoore@chromium.org2009-07-072-0/+341
| | | | | | Review URL: http://codereview.chromium.org/155075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20001 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the no-match red background to take up more spacefinnur@chromium.org2009-07-061-10/+23
| | | | | | | | | | | (basically leaving only one pixel margin around the edges). BUG=htt://crbug.com/15874 TEST=None, Find box should work as before. Review URL: http://codereview.chromium.org/155061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19985 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the current remaining Views-GTK compile and linker errors.brettw@chromium.org2009-07-061-0/+11
| | | | | | | | Chrome still doesn't run. Review URL: http://codereview.chromium.org/155026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-043-2/+8
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 19829.mirandac@chromium.org2009-07-022-211/+9
| | | | | | | | BUG= http://crbug.com/1455 Review URL: http://codereview.chromium.org/149156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux2 build.brettw@chromium.org2009-07-023-3/+3
| | | | | | | | I removed the extra argument from WidgetGTK::Init but didn't update these sites. Review URL: http://codereview.chromium.org/155006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19843 0039d316-1c4b-4281-b951-d872f2087c98
* Change status bubble so that it expands to accommodate URL's that are ↵mirandac@chromium.org2009-07-022-9/+211
| | | | | | | | | | | abridged in the standard width. BUG= http://crbug.com/1455 TEST= Mouse over a link which is abridged in the status bubble. Hover for 2 seconds. Link should expand to show as much as possible without extending out of the view in which it is contained. Review URL: http://codereview.chromium.org/146043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19829 0039d316-1c4b-4281-b951-d872f2087c98
* Convert menu strings to UTF16, fix some views-GTK build errors.brettw@chromium.org2009-07-0210-28/+27
| | | | | | Review URL: http://codereview.chromium.org/150171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
* Add split with devtools container into the browser view.pfeldman@chromium.org2009-07-022-6/+55
| | | | | | Review URL: http://codereview.chromium.org/151150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19807 0039d316-1c4b-4281-b951-d872f2087c98
* Adds user metrics for tab overview.sky@chromium.org2009-07-013-2/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19776 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions can now specify multiple icons and switch between themfinnur@chromium.org2009-07-012-18/+65
| | | | | | | | | | | using optional parameters to enableForTab. BUG=http://crbug.com/11906 TEST=None Review URL: http://codereview.chromium.org/149046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19772 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19758.mirandac@chromium.org2009-07-014-49/+17
| | | | | | Review URL: http://codereview.chromium.org/150180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19763 0039d316-1c4b-4281-b951-d872f2087c98
* Improves tab overview.sky@chromium.org2009-07-018-25/+153
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19761 0039d316-1c4b-4281-b951-d872f2087c98
* Theme window control buttons.mirandac@chromium.org2009-07-014-17/+49
| | | | | | | | | BUG= http://crbug.com/14579 TEST= Install a theme with themed window control buttons. Observe that WCB's are themed. Review URL: http://codereview.chromium.org/150041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19758 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add docked pane into the browser view.pfeldman@chromium.org2009-07-012-0/+5
| | | | | | Review URL: http://codereview.chromium.org/150160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19723 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-012-11/+0
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* Regression: task manager icon for chrome is blankcpu@google.com2009-07-011-3/+0
| | | | | | | | | | | | | - During first run (confusing the newbie) - In other special situations when we show UI before the main chrome window is created BUG=14192 TEST=see bug Review URL: http://codereview.chromium.org/151061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19692 0039d316-1c4b-4281-b951-d872f2087c98
* This CL removes the last (major) Windows specific part out of the focus ↵jcampan@chromium.org2009-06-3022-87/+75
| | | | | | | | | | | | | | | | | | | | | | | manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Review URL: http://codereview.chromium.org/146093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity was complaining about the result of getenv not being null checked, ↵finnur@chromium.org2009-06-301-40/+25
| | | | | | | | | | | but when I look at the code and confer with mal it looks like the offending code can just be removed (and some de-linting applied). BUG=None TEST=None (report a bug dialog should work as before). Review URL: http://codereview.chromium.org/151069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19612 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity nit. Enums lacking name...finnur@chromium.org2009-06-301-2/+2
| | | | | | | | | BUG=None TEST=No need for one. Review URL: http://codereview.chromium.org/151056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19611 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in delayed tab resizing. If the Resize Relayout code is called ↵ben@chromium.org2009-06-291-0/+6
| | | | | | | | | | | after the last tab has been closed but before the window is destroyed (this whole process is very async) there are zero tabs in the layout and as a result GetTabAt(0) will crash. http://crbug.com/14603 TEST=none Review URL: http://codereview.chromium.org/150064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19557 0039d316-1c4b-4281-b951-d872f2087c98
* Take two for http://codereview.chromium.org/131094tim@chromium.org2009-06-292-0/+7
| | | | | | | | This time without browser_tests timeout that caused the revert. The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached. Review URL: http://codereview.chromium.org/149117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up the create browser window.sky@chromium.org2009-06-293-4/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19492 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustage by using ALLOW_THIS_IN_INITIALIZER_LISTben@chromium.org2009-06-271-5/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19460 0039d316-1c4b-4281-b951-d872f2087c98
* gcl error, this file belonged in last changesetben@chromium.org2009-06-271-0/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19459 0039d316-1c4b-4281-b951-d872f2087c98
* First part of bookmark context menu reorg.ben@chromium.org2009-06-278-763/+84
| | | | | | | | | | | BookmarkContextMenu controller (XP state bits) go back into browser/bookmarks. views::MenuItemView infrastructure lives in browser/views/bookmark_context_menu. BUG=none TEST=bookmark context menus on bookmark bar, bookmark manager, bookmark folder menus. Review URL: http://codereview.chromium.org/149055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19458 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-2621-253/+272
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the win KeywordEditorView for cross platform friendliness.mattm@chromium.org2009-06-263-687/+31
| | | | | | | | | | | The TableModel is moved to search_engines/template_url_table_model.* The shared logic, and ownership of the url_model_ and table_model_, is moved to search_engines/keyword_editor_controller.* BUG=13326 Review URL: http://codereview.chromium.org/146138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19421 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab overview show the arrow at the right location.sky@chromium.org2009-06-265-10/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/147218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19403 0039d316-1c4b-4281-b951-d872f2087c98
* Change BrowserBubble so that clients can say if they expect canvas mirroring ↵cira@chromium.org2009-06-262-7/+3
| | | | | | | | | | | | | to happen or not. ExtensionShelf doesn't need mirroring since View methods already provide most of the RTL functionality. BUG=http://crbug.com/11880 TEST=Run chrome --lang=he and add 1+ extensions, and see if the handle is in proper position. Review URL: http://codereview.chromium.org/149045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19395 0039d316-1c4b-4281-b951-d872f2087c98
* move the ResetToDefault function for prefs to chrome/browser/options_utilmattm@chromium.org2009-06-261-54/+2
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/147190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-262-7/+0
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-262-0/+7
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to tab overview to get it performant:sky@chromium.org2009-06-265-6/+71
| | | | | | | | | | | | | | | | . Delay getting thumnbails until 300ms after the window is shown. This is necessary as getting the thumnbails is very expensive. . Configure the thumnbail for one cell at a time. For same reason as last one. . Don't show new tab window widget as we don't yet have the type set up. BUG=none TEST=none Review URL: http://codereview.chromium.org/147174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19340 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19315 to see if it fixes the builds.rvargas@google.com2009-06-262-5/+0
| | | | | | | | | TBR=klink BUG=none Review URL: http://codereview.chromium.org/149049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19331 0039d316-1c4b-4281-b951-d872f2087c98
* Make omnibox2 dropdown not flash during result set transitions...ben@chromium.org2009-06-262-59/+170
| | | | | | | | | | | | | - Animate smoothly between decreasing popup heights. Increasing popup heights are instantaneous. - Don't start a size adjustment until a few ms after the result set is updated to avoid jumping the height of the omnibox popup during typing as results from async providers stream in. - The result row carries a copy of the match data so it always has something to paint even if the match that corresponded to those results is now gone. These rows aren't actually actionable by the user and only appear during the animation. The result views are retained even if they are not visible (clipped). BUG=none TEST=type slowly in the omnibox, note the height of the popup doesn't jump between characters. Review URL: http://codereview.chromium.org/149030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19317 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the outdated and flaky UI tests, and introduces a whole new set of ↵klink@chromium.org2009-06-262-0/+5
| | | | | | | | shiny unit tests instead.BUG=2242,2243 Review URL: http://codereview.chromium.org/146124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19315 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension delimiters to the right.cira@chromium.org2009-06-251-0/+1
| | | | | | | | | BUG=http://crbug.com/11880 TEST=Load Chrome with --lang=he, and add 1+ extension. Delimiters should be on the right. Review URL: http://codereview.chromium.org/147132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19302 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the tab order in the task manager.jcampan@chromium.org2009-06-251-1/+1
| | | | | | | | | BUG=http://crbug.com/6781 TEST=See bug Review URL: http://codereview.chromium.org/149010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19254 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 14481 - RTL: Chrome is trying to open exe file directly ↵xji@chromium.org2009-06-252-11/+31
| | | | | | | | | | | | | | | | | | | after clicking down arrow on download shelf instead of drawing a context menu After changing the download items in download shelf to be RTL in RTL UI, need to change the computation of x coordinate of drop down button. BUG=http://crbug.com/14481 TEST= 1. Run Hebrew Chrome 2. Download an exe file >> Dangerous file warning should show up now 3. Click "Save" button 4. Click the down arrow on the download shelf 5. Chrome should draw a context menu after clicking down arrow (not trying to open the exe file) Review URL: http://codereview.chromium.org/131091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19232 0039d316-1c4b-4281-b951-d872f2087c98
* Show EV cert info text next to security icon.ukai@chromium.org2009-06-252-8/+9
| | | | | | | | | | | | | Use hbox to pack location entry, security icons and EV cert info text. Change ToolbarModel::GetInfoText not return SkColor. BUG=none TEST=none Review URL: http://codereview.chromium.org/126117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19224 0039d316-1c4b-4281-b951-d872f2087c98
* Update Skia transfer mode names in browser/* to Skia r239amanda@chromium.org2009-06-254-5/+5
| | | | | | | TBR=levin Review URL: http://codereview.chromium.org/147131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19218 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to 45111 and Skia to 239amanda@chromium.org2009-06-253-3/+3
| | | | | | Review URL: http://codereview.chromium.org/147121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
* Fork bookmark context menu logic across platforms. There's too much crazy ↵ben@chromium.org2009-06-257-3/+1053
| | | | | | | | | | | stuff going on here, I can't begin to unravel it on more than one platform at a time. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/146125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
* Now that the tab_table_ of the TaskManager is parent owned, it should not be ↵jcampan@chromium.org2009-06-241-4/+0
| | | | | | | | | | | | accessed after the views have been removed. This was causing a crasher in the browser tests (as a deleted object was accessed). BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/147110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19198 0039d316-1c4b-4281-b951-d872f2087c98
* Merging r18584 into chrome/browser/views/tab_contents/tab_contents_view_win.cc.yusukes@google.com2009-06-241-2/+5
| | | | | | | | | | | | | | My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368). I've confirmed that no patch other than mine is submitted to the old file: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log BUG=12290 TEST=See http://codereview.chromium.org/125111 Review URL: http://codereview.chromium.org/147074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix order of parameters that was causing title and keyword to be switched.ben@chromium.org2009-06-241-1/+1
| | | | | | | | | http://crbug.com/15226 TEST=see bug Review URL: http://codereview.chromium.org/147112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19192 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 04:18:28 +0000