summaryrefslogtreecommitdiffstats
path: root/chrome/browser/views
Commit message (Collapse)AuthorAgeFilesLines
* Remove the Menu object, converting all the remaining callers to use Menu2. ↵ben@chromium.org2009-06-129-57/+74
| | | | | | | | | | | I'll rename Menu2->Menu afterwards. TEST=none BUG=none Review URL: http://codereview.chromium.org/122027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18315 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-129-73/+61
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6103 -- Individual download items on the download shelf ↵xji@chromium.org2009-06-121-27/+36
| | | | | | | | | | | | | | | | | are not mirrored on RTL locales, and issue 13217 -- Dangerous File warning on the shelf in RTL seems to misplace the buttons Enable UI mirroring for DownloadItemView. During painting each download items, for those items without corresponding mirrored images, flip the canvas to paint the mirrored image. And flip canvas back to normal to paint others. BUG=http://crbug.com/6103 BUG=http://crbug.com/13217 Test=Open Hebrew Chrome, go to "http://build.chromium.org/buildbot/continuous/LATEST/", download mini_installer.exe, the layout of the warning should be "cancel_button ok_button warning_message warning_icon" from left to right. Click "ok" to download, the layout of the download item in download shelf should be "drop_down_icon download_file_name(or download_file_name with download_status) download_progress_animation and download icon" from left to right. Review URL: http://codereview.chromium.org/118260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18292 0039d316-1c4b-4281-b951-d872f2087c98
* Adds wiring for tab overview.sky@chromium.org2009-06-122-0/+310
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18267 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a layout bug in the fonts and languages dialog wheretc@google.com2009-06-111-13/+7
| | | | | | | | | | | | | | | buttons get cut off on the right side of the dialog. Instead of sizing the label text based on a constant from the localized resources, use the default text size (no-multiline text). I also tightened up the font preview box to just use the size of the text + a constant padding on all sides. BUG=13366 Review URL: http://codereview.chromium.org/125013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18217 0039d316-1c4b-4281-b951-d872f2087c98
* Another fix for issue 13724: Don't hard code chrome.exeagl@chromium.org2009-06-111-1/+4
| | | | | | | | | | | | Use chrome::kBrowserProcessExecutableName instead. BUG=13724 http://codereview.chromium.org/123022 (By Edward Crossman) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert mad's backing store changes, it completely hosed Linux painting.deanm@chromium.org2009-06-111-4/+6
| | | | | | | | | This was r18090, reverted in r18092, recommitted without review in 18130. Review URL: http://codereview.chromium.org/122034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18158 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser window crash on windows.thakis@chromium.org2009-06-111-0/+8
| | | | | | | | | | | | | BUG=13681 (http://crbug.com/13681) TEST=Follow these steps -Ctrl+Shift+N to Incognito window. -Download a file -Close the Incognito window after download is finished. Review URL: http://codereview.chromium.org/120001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18151 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding reverted patch 18090.mad@google.com2009-06-111-6/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18130 0039d316-1c4b-4281-b951-d872f2087c98
* Fix HWND for Importer Dialogmhm@chromium.org2009-06-111-4/+2
| | | | | | | | | | | | Instead of grabbing the HWND from the browser, we can grab it from the current view since each view has a Widget who is associated with a HWND (NativeView). By doing that, we can assure the parent hwnd is that. Before, it was retrieving the hwnd from Browser* which caused this bug. BUG=13154 (http://crbug.com/13154) TEST=Launched Options>Importer>Import and it brought up the Options dialog. Review URL: http://codereview.chromium.org/119408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18118 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions in incognito mode.mpcomplete@google.com2009-06-111-0/+2
| | | | | | | | | | | Add a browsertest to make sure we don't crash with an incognito window open. Had to finagle utility_process_host to make it work in a browsertest. BUG=12326 TEST=none Review URL: http://codereview.chromium.org/118476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18116 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-102-7/+1
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18090jrg@chromium.org2009-06-101-4/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18092 0039d316-1c4b-4281-b951-d872f2087c98
* To help resolve the performance issue introduced when enabling the resize ↵mad@google.com2009-06-101-6/+4
| | | | | | | | corner, we now keep all non-intersecting rects separately and send an array of invalidation bitmaps via IPC as opposed to a single unionized rect :-) Review URL: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18090 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors tab overview and gets the rest of the chunks working. I'vesky@chromium.org2009-06-1010-308/+903
| | | | | | | | | | | | | | | | refactored it so that there is a clear object responsible for dragging and the controller now controls it all. There is some common code between TabOverviewDragController and DraggedTabController. I will try and share some code between these two later. BUG=none TEST=none Review URL: http://codereview.chromium.org/118513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18089 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 8838: Close box not highlightedidanan@chromium.org2009-06-101-0/+1
| | | | | | | | | | | | | | | We optimize mouse-mouve event handling by ignoring two mouse-move events in a row which works in most cases except that when we animate tab-closing on windows we send a duplicate mouse-move event on purpose to highlight the button. Unfortunately our optimization kicks in. Fixed by reseting the flag to optimize this before sending the extra mouse-move. BUG=8838 Review URL: http://codereview.chromium.org/118454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18052 0039d316-1c4b-4281-b951-d872f2087c98
* Remove checked-in .vcproj files that have been converted to gyp.sgk@google.com2009-06-101-909/+0
| | | | | | | | BUG=none TEST=successful build Review URL: http://codereview.chromium.org/119411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18044 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile bustage by using macroben@chromium.org2009-06-101-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18000 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Menu2Delegate interface and fold methods onto Menu2Model instead.ben@chromium.org2009-06-096-142/+78
| | | | | | | | | | | | | Enhance SimpleMenuModel::Delegate interface to support additional options required by the above. Make MenuHostWindow process WM_MENUCOMMAND and WM_MENUSELECT - the first so we can determine which index was selected, the second so we can track highlight changes within a menu. Convert Tab's context menu back to the windows native menu. This will make my life easier when I upgrade chrome_menu.cc to the new API if only the bookmarks menus/context menus are using it. BUG=none TEST=page, app menus again, context menu for tabs. open a bunch of tabs, open this page: http://bengoodger.dreamhosters.com/software/chrome/cxmenutest.html, close that tab then right click on the menu quickly. should not crash! Review URL: http://codereview.chromium.org/118426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17996 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 13570: Find box stops responding to browser window resize.finnur@chromium.org2009-06-091-0/+26
| | | | | | | | | | | | If you enter a search term and delete it, the Find box UI flag gets set as inactive and the box stops moving when the browser resizes. This fixes that. BUG=13570 TEST=Open Find, press 'e', press Backspace, resize the window. The Find box should move. Review URL: http://codereview.chromium.org/119383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17980 0039d316-1c4b-4281-b951-d872f2087c98
* Implement different radio groups for Options > Personal Stuffmhm@chromium.org2009-06-092-8/+9
| | | | | | | | | | | | | | Passwords and Form autofill share the same group, they need to be treated separately. It did not work correctly, when "password" radio option was chosen,two of "form autofill" radio option both change to blank(not selected). This patch will properly create different radio groups for passwords and autofill. BUG=13222 (http://crbug.com/13222) TEST=Radio buttons now function propertly TBR=ben Review URL: http://codereview.chromium.org/119347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views bustage by updating callsite to use the new function name.ben@chromium.org2009-06-091-2/+3
| | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/118419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17929 0039d316-1c4b-4281-b951-d872f2087c98
* Form Autofil Options should be a radio groupmhm@chromium.org2009-06-092-84/+64
| | | | | | | | | | | | The Form Autofil is currently just a checkbox. To fit the chomium design, we prefer radios for single questions because it a bit clearer which choice you choose. As well, we merged import data and clear browsing data into browsing data since the page was getting a bit long. BUG=13222 (http://crbug.com/13222) TEST=Tested the options pane, the form autofil worked as expected. Review URL: http://codereview.chromium.org/119146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17926 0039d316-1c4b-4281-b951-d872f2087c98
* Fix omnibox popup positioning by not calling "SetChildBounds" which attempts ↵ben@chromium.org2009-06-091-5/+4
| | | | | | | | | | to do a bunch of things to keep windows visible on screen... this isn't really what we want for this window, so we just call SetBounds instead. http://crbug.com/11721 TEST=drag window so it's half offscreen, type in the omnibox. dropdown should appear properly anchored underneath omnibox even though it's half offscreen. Review URL: http://codereview.chromium.org/119338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17922 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird stretchy text rendering in O2 popup. Apparently the tile flags ↵ben@chromium.org2009-06-091-2/+2
| | | | | | | | | | were angering the skia gods. http://crbug.com/13277 TEST=size window to various sizes, type stuff in omnibox, text shouldn't be stretched or scrunched. Review URL: http://codereview.chromium.org/118414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17921 0039d316-1c4b-4281-b951-d872f2087c98
* First part of tab overview. It isn't wired up, nor is it complete, butsky@chromium.org2009-06-0810-0/+1054
| | | | | | | | | | | it's a good enough stage that I want to check it in. BUG=none TEST=none Review URL: http://codereview.chromium.org/119329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17906 0039d316-1c4b-4281-b951-d872f2087c98
* Creates a BlockedPopupContainerView interface, and changes the current ↵erg@google.com2009-06-084-303/+257
| | | | | | | | | | BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17905 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the TabContents::SetInitialFocus(reverse) method to ↵jcampan@chromium.org2009-06-081-2/+3
| | | | | | | | | | | TabContents::FocusThroughTabTraversal(reverse), as SetInitialiFocus can be easily confused with TabContentView::SetInitialFocus(). BUG=None TEST=None Review URL: http://codereview.chromium.org/118392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17900 0039d316-1c4b-4281-b951-d872f2087c98
* Convert toolbar page and app menus over to use the new system.ben@chromium.org2009-06-084-266/+446
| | | | | | | TEST=test page and app menus thoroughly. Review URL: http://codereview.chromium.org/119291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17897 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusting the page action icon drawing slightly.finnur@chromium.org2009-06-081-14/+16
| | | | | | | | | | | | | When multiple page actions are active, there was no padding between icons. Also, the entry_width was being truncated too much (the more page actions the more apparent it came). This fixes that. BUG=12060 TEST=Have multiple page actions (more than 3) active in the Omnibox, make sure there is a little bit of space between each icon. Start typing and make sure you can type all the way to the page action icons. Review URL: http://codereview.chromium.org/118390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17888 0039d316-1c4b-4281-b951-d872f2087c98
* Clicking a bookmark does not discard omnibox editsmhm@chromium.org2009-06-081-7/+16
| | | | | | | | | | | We need to manually reset the omnibox by reverting the text before the bookmark click event occurs BUG=12627 (http://crbug.com/12627) TEST=Clicked on bookmark while editing in omnibox to bring up suggestionlist, as well tried unfocused omnibox while clicking on a focused inpage browser link Review URL: http://codereview.chromium.org/119292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17849 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BrowserToolbarView->ToolbarView to match file name.ben@chromium.org2009-06-066-541/+548
| | | | | | | | | Reorganize functions in CC to match header and related OCD activities. No logic changes. Review URL: http://codereview.chromium.org/118352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17809 0039d316-1c4b-4281-b951-d872f2087c98
* Completely miscellaneous minor cleanup. Remove some unneeded class ↵pkasting@chromium.org2009-06-051-7/+7
| | | | | | | | declarations, modify or add a couple comments, change a function name in hopes of greater accuracy. Review URL: http://codereview.chromium.org/119264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17798 0039d316-1c4b-4281-b951-d872f2087c98
* Give the Go button the correct tooltip based on what's in the omnibox.pkasting@chromium.org2009-06-051-6/+18
| | | | | | | | BUG=6906 TEST=Type "foo" into the Omnibox. Verify the Go button tooltip refers to searching for "foo" using your default engine. Change to "foo.com". Verify the Go button tooltip refers to navigating to foo.com. Change to using some custom search engine (e.g. tab-to-search on yahoo.com) and put in a search term. Verify the Go button tooltip refers to searching for your term on the chosen engine. Review URL: http://codereview.chromium.org/119263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17791 0039d316-1c4b-4281-b951-d872f2087c98
* Change the name of chrome\browser\views\blocked_popup_container.{cc,h}sgk@google.com2009-06-053-5/+5
| | | | | | | | | | to blocked_popup_container_view.{cc,h}, to avoid duplication with the same-named files in chrome\browser. BUG=none TEST=successful build Review URL: http://codereview.chromium.org/119253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17775 0039d316-1c4b-4281-b951-d872f2087c98
* More theme bits for the NTP and window frame.glen@chromium.org2009-06-051-0/+12
| | | | | | | | | BUG=12768,13352 TEST=Verify that a theme with attribution works on the NTP and a theme with an overlay shows up Review URL: http://codereview.chromium.org/119227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17773 0039d316-1c4b-4281-b951-d872f2087c98
* Better behavior for ctrl-k: If we're already in forced_query mode, re-select ↵pkasting@chromium.org2009-06-051-1/+1
| | | | | | | | | | the query text instead of clearing the box. BUG=6985 TEST=Press ctrl-k, type "foo", press ctrl-k again. The omnibox should show "?foo" with "foo" selected. Review URL: http://codereview.chromium.org/119135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17757 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for closing the download shelf with multiple tabs open.paul@chromium.org2009-06-041-4/+2
| | | | | | | | | | | Make sure that the browser window is informed of the download shelf visibility status at the end of the show / hide animation. BUG=13369 Review URL: http://codereview.chromium.org/118278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17690 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: use strings, not wstrings for channel ids.evan@chromium.org2009-06-041-1/+2
| | | | | | | | | | They're ASCII anyway. TEST=covered by existing tests Review URL: http://codereview.chromium.org/119131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17682 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid tab drops on application windows.ben@chromium.org2009-06-041-1/+2
| | | | | | | | | | Change by Chase Phillips <cmp@google.com> http://crbug.com/9576 TEST=open a standalone GMail shortcut window, attempt to drop a tab from an existing browser window into it. It should not be added. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17672 0039d316-1c4b-4281-b951-d872f2087c98
* Make the inactive tab background line up with the parent without using magic ↵glen@chromium.org2009-06-045-8/+29
| | | | | | | | | | | numbers. BUG=12761 TEST=Verify that the inactive tab background lines up with the frame image in maximized and unmaximized mode - you will need a heavily patterned theme to test with. Review URL: http://codereview.chromium.org/118221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for DWM crash.glen@chromium.org2009-06-041-1/+2
| | | | | | | | | | BUG=13075 TBR=ben TEST=On XP, verify that Chrome doesn't crash when a theme is installed or reset. Review URL: http://codereview.chromium.org/118252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17652 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the first of probably several patches trying to clean up the ↵erg@google.com2009-06-043-582/+97
| | | | | | | | | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. This version has minor windows compile fixes that changed from under me. Original Review URL: http://codereview.chromium.org/119006 TBR=beng TEST=Popup notification still works. Review URL: http://codereview.chromium.org/119107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17647 0039d316-1c4b-4281-b951-d872f2087c98
* Make tab resize relayout on mouse out work.ben@chromium.org2009-06-042-18/+35
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix timing issue with first run bubble, and tweak size of OEM bubble so it ↵mirandac@chromium.org2009-06-041-1/+6
| | | | | | | | | | | | looks more like Glen's mock. BUG= http://crbug.com/9233 TEST= Run Chrome with --first-run option. Notice that first run info bubble does not go away within the first second even if you click on or away from the browser. Review URL: http://codereview.chromium.org/118143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17632 0039d316-1c4b-4281-b951-d872f2087c98
* Allow WindowGtks to be moved and sized when the mouse is over the caption or ↵ben@chromium.org2009-06-041-9/+8
| | | | | | | | | | sizing border. BUG=none TEST=none Review URL: http://codereview.chromium.org/118218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17608 0039d316-1c4b-4281-b951-d872f2087c98
* Move download shelf from per-tab to per-window. Also disable auto-hiding ofthakis@chromium.org2009-06-046-99/+78
| | | | | | | | | | | | | | the shelf. BUG=9025 TEST=Download file in one tab, open new tab, and check that download shelf is still open. Also try the shelf's close button and the "show all downloads" link. When saving a file, the download animation should not show up. Review URL: http://codereview.chromium.org/115740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of r17500:glen@chromium.org2009-06-041-3/+18
| | | | | | | | | | Theme our bookmark bar buttons. BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17587 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to theme our buttons.glen@chromium.org2009-06-041-10/+28
| | | | | | | | | BUG=12762 TEST=Verify that buttons can be themed. Review URL: http://codereview.chromium.org/119025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views bustage.ben@chromium.org2009-06-044-17/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/112093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17583 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 23:33:15 +0000