summaryrefslogtreecommitdiffstats
path: root/chrome/browser/visitedlink_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rework visited link updating mechanism to be more robust.dglazkov@chromium.org2009-08-101-1/+30
| | | | | | | | | | | | | | | | | | This is a follow-up to http://src.chromium.org/viewvc/chrome?view=rev&revision=22540, which eliminated one crash, but still left behind another, this time due to racing between history backend and WebView creation. The solution is to make sure no visited-link-related messages are sent to the rendering process until we know for sure it is created. BUG=17555 TEST=VisitedLinkeRelayTest.WebViewReadiness R=darin Review URL: http://codereview.chromium.org/165210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22917 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we never call into WebCore::Page static methods when Page ↵dglazkov@chromium.org2009-08-051-0/+1
| | | | | | | | | | | | | | | | constructor hasn't been called. This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called), we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation. BUG=17555 R=darin TEST=unable to repro, speculative fix. Review URL: http://codereview.chromium.org/159887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22540 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-061-1/+1
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that VisitedLink listener Add event only fires when new fingerprint ↵dglazkov@chromium.org2009-07-041-5/+5
| | | | | | | | | | | | is added, and not during resizing/rebuilding or deleting fingerprints. R=brettw TEST=VisitedLinkTest.Listener BUG=15926 Review URL: http://codereview.chromium.org/149185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19931 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Acid3 Test 48: LINKTEST, Chromium side....dglazkov@chromium.org2009-07-031-14/+352
| | | | | | | | | | | | | | | | | R=brettw BUG=http://crbug.com/231 BUG=http://crubg.com/5160 TEST=ExpireHistoryTest.ArchiveSomeOldHistory TEST=ExpireHistoryTest.ExpiringVisitsReader TEST=VisitedLinkTest.Listener TEST=VisitedLinkTest.Resizing TEST=VisitedLinkRelayTest.* TEST=VisitedLinkEventsTest.* Review URL: http://codereview.chromium.org/113591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98
* Port visitedlink tests to Linux. Also make them pass on Linux, whichphajdan.jr@chromium.org2009-03-161-4/+4
| | | | | | | | | | | | | may fix the attached bug. The problem was that the debug check was in wrong place (too early, before every member was initialized), so it failed in the test. BUG=8710 Review URL: http://codereview.chromium.org/48005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11734 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Porting profiles to the Mac.avi@chromium.org2009-01-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/19623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8831 0039d316-1c4b-4281-b951-d872f2087c98
* Roll forward 8722,8721jeremy@chromium.org2009-01-271-23/+23
| | | | | | Review URL: http://codereview.chromium.org/19028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8734 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8722,8721.maruel@chromium.org2009-01-271-23/+23
| | | | | | Review URL: http://codereview.chromium.org/19024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8723 0039d316-1c4b-4281-b951-d872f2087c98
* First step of porting VisitedLinkMaster to POSIX:jeremy@chromium.org2009-01-271-23/+23
| | | | | | | | | | | | * Use POSIX file access APIs rather than HANDLEs. * Add stubs so that VisitedLinkMaster compiles on POSIX. Still to be done: * Bring up Surrounding infrastructure to turn on unit tests. Review URL: http://codereview.chromium.org/18530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8721 0039d316-1c4b-4281-b951-d872f2087c98
* Add Terminate() to the Process object, have RenderProcessHost use this to ↵brettw@google.com2008-11-141-5/+5
| | | | | | | | | | avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Review URL: http://codereview.chromium.org/10895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
* Makes deleting history no longer delete starred urls. Thiseffectively ↵sky@google.com2008-08-271-1/+1
| | | | | | reenables the code in ExpireHistoryBackend. I also madethe code consistent so that when we delete visits as the result ofhistory deletion we don't change the typed/visit count of theunderlying url.BUG=1214201 1256202TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1423 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-261-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 17:06:53 +0000