summaryrefslogtreecommitdiffstats
path: root/chrome/browser/web_applications
Commit message (Collapse)AuthorAgeFilesLines
* Enable unit tests in browser/web_applications/web_app_unittest.cc. I forgot ↵thestig@chromium.org2010-06-281-1/+1
| | | | | | | | | | this in r50897. BUG=none TEST=none Review URL: http://codereview.chromium.org/2863026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51024 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for chrome/browser/web_applications and mark some code as Win32 ↵thestig@chromium.org2010-06-253-7/+75
| | | | | | | | | | and/or Views only. (TTF) BUG=none TEST=included. Review URL: http://codereview.chromium.org/2826019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50897 0039d316-1c4b-4281-b951-d872f2087c98
* Add DISABLE_RUNNABLE_METHOD_REFCOUNT to make disabling refcounts in ↵ajwong@chromium.org2010-06-161-5/+1
| | | | | | | | | | | RunnableMethods easier. BUG=none TEST=none Review URL: http://codereview.chromium.org/2830006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Use different AppUserModelID for SxS installs.mattm@chromium.org2010-06-111-2/+2
| | | | | | | | | BUG=44572 TEST=see bug Review URL: http://codereview.chromium.org/2616002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49477 0039d316-1c4b-4281-b951-d872f2087c98
* Allow "chrome-extension://" to be used as web app url.xiyuan@chromium.org2010-05-261-0/+1
| | | | | | | | | BUG=29201 TEST=Verify a web app shortcut for "chrome-extension://" url could be created. Review URL: http://codereview.chromium.org/2193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48294 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.tfarina@chromium.org2010-05-241-4/+4
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/2110021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48014 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnvironmentVariableGetter from base/linux_util.h to base/env_var.h and ↵thestig@chromium.org2010-04-031-4/+3
| | | | | | | | | | rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/1606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43559 0039d316-1c4b-4281-b951-d872f2087c98
* Append a number to make app shortcut name unique.xiyuan@chromium.org2010-03-261-4/+23
| | | | | | | | | | | | - Move DownloadManager's unique path helpers into download utils; - Use those functions to make shortcut file name unqiue. BUG=642 TEST=Verify fixes for issue 642. Review URL: http://codereview.chromium.org/1276003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42769 0039d316-1c4b-4281-b951-d872f2087c98
* Create a toplevel gfx/ dir and seed it with icon_util.ben@chromium.org2010-03-131-1/+1
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build. linux_util.h caused a weird compile error when #included on Windows.phajdan.jr@chromium.org2010-03-121-1/+4
| | | | | | | | | | TBR=evan BUG=30785 TEST=none Review URL: http://codereview.chromium.org/874005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41427 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing tests for Linux desktop shortcuts logic.phajdan.jr@chromium.org2010-03-121-1/+7
| | | | | | | | | | | | | | | This also makes the code use EnvironmentVariableGetter instead of calling getenv directly because we need the control in tests. This is a follow-up after http://codereview.chromium.org/607001 TEST=ShellIntegrationTest.GetDesktopShortcutTemplate BUG=30785 Review URL: http://codereview.chromium.org/798002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41423 0039d316-1c4b-4281-b951-d872f2087c98
* Use web app icon as ICON_BIG for Windowsxiyuan@chromium.org2010-03-081-0/+1
| | | | | | | | | | | | | | | | | - Add a WindowDelegate::GetWindowAppIcon for BrowserView to expose an icon to use as ICON_BIG; - Add an app_icon_ memeber and accessor functions to TabContents; - Update/Set the app_icon_ of TabContents when web app icon is downloaded for converting a tab to app or for chrome web app shortcuts update (this happens when chrome is opened as an app; - Use the app icon as ICON_BIG in WindowWin::UpdateWindowIcon; BUG=32039 TEST=Verify fix for issue 32039 and also Alt-Tab list on XP/Vista uses big icon. Review URL: http://codereview.chromium.org/668265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40962 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 3: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-1/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix app shortcut mess up per issue 31789xiyuan@chromium.org2010-02-231-0/+8
| | | | | | | | | | | | | | | | | | Issue 31789 is caused by a longer than MAX_PATH chars web app description. Fix it by limiting the description string size to MAX_PATH. Note: 1. MSDN mentions that the size limitation for Win2000 or later is INFOTIPSIZE but the limit on my vista dev machine is MAX_PATH. <http://msdn.microsoft.com/en-us/library/bb774955(VS.85).aspx> 2. The size limit includes the terminating NULL. BUG=31789 TEST=Verify fix for issue 31789. facebook.com has a 261-char description and chromium should be able to create a working shortcut for it. Review URL: http://codereview.chromium.org/650186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39686 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-192-1/+2
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Add better error reporting for creating application shortcuts.phajdan.jr@chromium.org2010-02-161-1/+6
| | | | | | | | | TEST=none BUG=30785 Review URL: http://codereview.chromium.org/607001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39085 0039d316-1c4b-4281-b951-d872f2087c98
* Implement launch disposition for extension-apps.rafaelw@chromium.org2010-02-051-7/+3
| | | | | | | | | | | | This change adds an --app-id command switch that signifies that the extension-app with the given id should be launched according to its configuration. It also adds parsing for app.window_type in the manifest and the behavior that when installed and a desktop shortcut is created, the --app-id switch is used rather than the --app switch. BUG=32361 Review URL: http://codereview.chromium.org/573016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38184 0039d316-1c4b-4281-b951-d872f2087c98
* Update/repair legacy gears web app shortcutsxiyuan@chromium.org2010-01-131-0/+9
| | | | | | | | | | | | r34332 has a bug that web app data dir could be missing for legacy gears shortcut. The fix is to make sure the data dir exists. BUG=8539 TEST=Create a legacy gears web app shortcuts and then update to a version with this fix and launching chrome should update the shortcuts with new icon locations. Review URL: http://codereview.chromium.org/551008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36146 0039d316-1c4b-4281-b951-d872f2087c98
* Append profile info to win7 app id per issue 30414xiyuan@chromium.org2010-01-062-23/+44
| | | | | | | | | | | | | | | | | | | | | Add profile info to app id for non-default profile so that win7 could group chrome icons based on profile. - Add a new chrome/common/win_util.h/cc to hold app id functions that would include profile info for non-default profiles; - Add unit test to the new GetChromiumAppId function; - Browser and JumpList to use the GetChromiumAppId for BrowserWindow and JumpList; - UserDataManager to use it for shortcuts it creates; - Make app id for web apps include profile info as well; - Change web_app::UpdateShortcuts to just update shortcuts description, icon and app id; BUG=30414 TEST=Verify fix for issue 30414. Review URL: http://codereview.chromium.org/506079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35634 0039d316-1c4b-4281-b951-d872f2087c98
* Get web app icon via FavIconHelper and auto repair/updatexiyuan@chromium.org2009-12-112-6/+397
| | | | | | | | | | | | | | | | | | | | | - Expose a DownloadImage method from FavIconHelper to download/decode image for an image url; - Expose FavIconHelper from TabContents; - Update CreateApplicationShortcutView to use the exposed DownloadImage method to get web app icon instead of do it via URLFetcher/PNGCodec; - Check and update web app icon and shortcuts when chrome is lauched as app for OS_WIN; - Code cleanup: - Move a bunch of FavIconHelper methods that are not used externally to private; - Remove an unused cancelable_consumer_ from TabContents; BUG=8539 TEST=Verify issue 8539 is fixed. And create a web page with a non PNG shortcut icon and verify it shows up in create application shortcut dialog. Review URL: http://codereview.chromium.org/482003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34332 0039d316-1c4b-4281-b951-d872f2087c98
* Set prop app id for chromium/application shortcut.xiyuan@chromium.org2009-11-192-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up change after andrew's patch for win7 shortcut to properly set app id for chromium/application shortcut. - Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to base/win_util.cc as SetAppIdForPropertyStore to share with file_util shortcut code; - Add an app_id args to file_util's CreateShortcutLink and UpdateShortcutLink; - Update code that calls the above two function in installer and UserDataManager so that the chromium shortcuts are created with proper app id (except the uninstall shortcut which is not tagged with any app id). - Move ComputeApplicationNameFromURL from Browser to web_app namespace and use it as app id for application shortcut. This makes pinned shortcut and browser window use the same app id and Win7 correctly groups them; - Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL per Ben's comments; - Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than 128 chars and contains no space per msdn; - Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName BUG=28104 TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application. Review URL: http://codereview.chromium.org/399045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32508 0039d316-1c4b-4281-b951-d872f2087c98
* Disable create application shortcuts for internal pagesxiyuan@chromium.org2009-11-192-0/+20
| | | | | | | | | | | | | | | | | - In fact, we only allow scheme file, ftp, http and https to have shortcuts; - Removed GetFavIcon().isNull() for checking since we are using url scheme now; - Add a CommandCreateAppShortcut to BrowserTest per Ben's comments; BUG=26743 TEST=Verify create application shortcuts menu item is disabled for all internal pages including but not limited to new tab page, history, downloads, view-source etc. Review URL: http://codereview.chromium.org/404011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32503 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web app shortcuts natively per issue 25528xiyuan@chromium.org2009-11-172-0/+331
- Implement a CreateApplicationShortcutView similar to the current Gears-based one; - Add a few profile prefs to persist user's last checked shortcut locations - Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications" in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls file_util code to creates shortcut on Windows; - Add Win7 taskbar pin/unpin support function to file_util; - Update TabContents to replace gears with new code; Note: - Gears dialog is modaless but this one is a modal dialog. - Gear's icon store is not migrated because gears icons could still be used by shortcuts created by gears and thus we could not delete them even after migration. And we are not using the local ico files in the dialog even if they exists. - New CreateApplicationShortcutView is included when TOOLKIT_VIEW is defined. However on platforms other than Windows, the actual CreateShortCut code is not implemented. Right now it calls ShellIntegration's CreateDesktopShort if OS_LINUX is defined and NOTREACHED() for other platforms. BUG=25528 TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7. Review URL: http://codereview.chromium.org/372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 15:12:30 +0000