| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=67615
TEST=none
Review URL: http://codereview.chromium.org/6086001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61409
TEST=trybots
Review URL: http://codereview.chromium.org/5730004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash.
Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done:
- Changed the name of DidProcessCrash to GetTerminationStatus.
- Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus.
- Improved process_util_unittest to actually test for crashing and terminated processes on all platforms.
- Added a new notification for renderers that were killed.
- Added error code information to crash notification.
- Added status and error code information to renderer IPC message for RenderViewGone.
- Added a UMA histogram count for number of renderer kills.
BUG=http://crosbug.com/8505
TEST=ran new unit test. Test passes on try servers.
Review URL: http://codereview.chromium.org/5172009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
system.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=10031
TEST=cros sync works
Review URL: http://codereview.chromium.org/5685004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for the following bug:
[11725:11725:1206/035953:10306309386:ERROR:base/process_util_posix.cc(105)] Received signal 11
base::debug::StackTrace::StackTrace() [0x1f68261]
base::(anonymous namespace)::StackDumpSignalHandler() [0x1fa2853]
0x2ba8f9b0f100
__pthread_mutex_lock_internal [0x2ba8f6dce423]
LockImpl::Lock() [0x1f7a9f6]
Lock::Acquire() [0x58a947]
AutoLock::AutoLock() [0x58a979]
MessageLoop::PostTask_Helper() [0x1f7e2cc]
MessageLoop::PostDelayedTask() [0x1f7e40d]
WebResourceService::ScheduleNotification() [0x158db6f]
WebResourceService::UnpackPromoSignal() [0x158e1db]
WebResourceServiceTest_UnpackPromoSignal_Test::TestBody() [0xcbb723]
testing::HandleExceptionsInMethodIfSupported<>() [0x1b6ff6b]
testing::Test::Run() [0x1b72cb9]
testing::TestInfo::Run() [0x1b76548]
testing::TestCase::Run() [0x1b7669b]
testing::internal::UnitTestImpl::RunAllTests() [0x1b771f0]
testing::HandleExceptionsInMethodIfSupported<>() [0x1b6fd4f]
testing::UnitTest::Run() [0x1b6fdb7]
base::TestSuite::Run() [0x33ed0a8]
main [0x1a4f56d]
0x2ba8f9afb1c4
0x433829
Program received signal SIGSEGV, Segmentation fault.
__pthread_mutex_lock (mutex=0x170) at pthread_mutex_lock.c:50
50 pthread_mutex_lock.c: No such file or directory.
in pthread_mutex_lock.c
(gdb) bt
#0 __pthread_mutex_lock (mutex=0x170) at pthread_mutex_lock.c:50
#1 0x00007ffff5ac327d in LockImpl::Lock (this=0x170) at base/lock_impl_posix.cc:41
#2 0x00007ffff5a85dee in Lock::Acquire (this=0x168) at ./base/lock.h:40
#3 0x00007ffff5a85e50 in AutoLock::AutoLock (this=0x7fffffffd450, lock=...) at ./base/lock.h:95
#4 0x00007ffff5ac7a16 in MessageLoop::PostTask_Helper (this=0x0, from_here=..., task=0x7fffe29a8e00, delay_ms=1974154931, nestable=true)
at base/message_loop.cc:378
#5 0x00007ffff5ac7816 in MessageLoop::PostDelayedTask (this=0x0, from_here=..., task=0x7fffe29a8e00, delay_ms=1974154931) at base/message_loop.cc:318
#6 0x00007ffff77009e1 in WebResourceService::ScheduleNotification (this=0x7fffe41ed4e0, promo_start=1264899600, promo_end=1327971600)
at chrome/browser/web_resource/web_resource_service.cc:285
Note how this is NULL in MessageLoop::PostDelayedTask.
Patch from Dominic Battré (battre@google.com)
BUG=65462
TEST=none
TBR=mirandac
Review URL: http://codereview.chromium.org/5559007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65462
TEST=WebResourceServiceTest.UnpackPromoSignal
Review URL: http://codereview.chromium.org/5648001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_path_watcher into subdir
profile* into profiles/ subdir
login* into ui/login
visitedlink* into subdir
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5606002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed web resource server from ntp preferences; no longer needed.
Fixed bug that caused the last updated cache time to not be stored correctly.
Scheduled a notification to be sent at the time a web resource element becomes available to force NTP cache update.
BUG=64597
TEST=see me.
Review URL: http://codereview.chromium.org/5302008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61583
TEST=private; see me for details.
Review URL: http://codereview.chromium.org/4804001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
code of a
renderer process that went away so that we can tell at the UI level
what happened to the tab: did it crash, or was it killed by the OOM
killer (or some other reason). This is in preparation for implementing
a new UI for when a process is killed by the OOM on ChromeOS which
handles it differently from a crash.
Most of the changes are modifications of the argument list to include
a status and error code for the exited process, but in addition the
following was done:
- Changed the name of DidProcessCrash to GetTerminationStatus.
- Added some new enum values to TerminationStatus enum (and named it)
in process_util.h, so it can be used as the status returned by
WhatHappenedToProcess.
- Improved process_util_unittest to actually test for crashing and
terminated processes on all platforms.
- Added a new notification for renderers that were killed.
- Added error code information to crash notification.
- Added status and error code information to renderer IPC message for
RenderViewGone.
- Added a UMA histogram count for number of renderer kills.
[This change was previously reviewed and LGTM'd:
http://codereview.chromium.org/3386014/show
but due to issues with "git cl push" was never committed to the tree.]
BUG=none
TEST=ran new unit test. Test passes on try servers.
Review URL: http://codereview.chromium.org/3869001
TBR=gspencer@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer process that went away so that we can tell at the UI level
what happened to the tab: did it crash, or was it killed by the OOM
killer (or some other reason). This is in preparation for implementing
a new UI for when a process is killed by the OOM on ChromeOS which
handles it differently from a crash.
Most of the changes are modifications of the argument list to include
a status and error code for the exited process, but in addition the
following was done:
- Changed the name of DidProcessCrash to GetTerminationStatus.
- Added some new enum values to TerminationStatus enum (and named it)
in process_util.h, so it can be used as the status returned by
WhatHappenedToProcess.
- Improved process_util_unittest to actually test for crashing and
terminated processes on all platforms.
- Added a new notification for renderers that were killed.
- Added error code information to crash notification.
- Added status and error code information to renderer IPC message for
RenderViewGone.
- Added a UMA histogram count for number of renderer kills.
[This change was previously reviewed and LGTM'd:
http://codereview.chromium.org/3386014/show
but due to issues with "git cl push" was never committed to the tree.]
BUG=none
TEST=ran new unit test. Test passes on try servers.
Review URL: http://codereview.chromium.org/3869001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread instead of chrome_thread in more 97 files.
Now the remaining files that are including chrome_thread.h are:
chrome_thread.cc and browser_thread.h.
They will be fixed next.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3717004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename entries under task_manager, themes, views, web_applications,
web_resource, webdata and worker_host.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3579014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not the whole theme.
BUG=57187
TEST=no more crash on Linux.
Review URL: http://codereview.chromium.org/3576014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
signal delivery.
BUG=56388
TEST=unit test for web_resource_service still works.
Review URL: http://codereview.chromium.org/3523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57012
TEST=no more leak in web_resource_service unit test.
Review URL: http://codereview.chromium.org/3448026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=new unit test should pass.
Review URL: http://codereview.chromium.org/3473013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56388
TEST=none
Review URL: http://codereview.chromium.org/3382014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
server.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3418020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3130020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string_number_conversions.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3013046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters).
TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/2854015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1: Convert RegisterStringPref.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/2809022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build and Unittests
Review URL: http://codereview.chromium.org/1995008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/671024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
using the /proc/self/exe trick we use for plugins. Since we don't
need any resources from .pak files, this should be safe.
BUG=22703
TEST=Install a theme, verify that it worked properly.
Review URL: http://codereview.chromium.org/464073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
utility process on OS X.
Other changes:
* An error initializing the sandbox on OS X is now treated as fatal.
* Improved error reporting for sandbox-related failures.
BUG=26492,23837
TEST=Installing extensions and themes should still work on OS X.
Review URL: http://codereview.chromium.org/434077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale.
- For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before)
- All other process types will honor the language they got on the command line when starting up.
- When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.)
- During browser startup, if someone passed a language, bail because Mac can't support that.
TEST=The tips on the NTP and the dates on the history page are in the same language at the UI.
BUG=26856
BUG=22727
Review URL: http://codereview.chromium.org/399086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/376007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeThread instead.
BUG=25354
Review URL: http://codereview.chromium.org/342068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=25354
Review URL: http://codereview.chromium.org/345023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24746
Review URL: http://codereview.chromium.org/339033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354
Review URL: http://codereview.chromium.org/306032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/22727
TEST= Set preferred language to a different setting from the locale in the OS X system settings.
Make sure that the language of the tips matches the language setting (which
should be the same as that of the Chrome UI). If tips are not available in
the Chrome UI language, no tips should be shown.
Review URL: http://codereview.chromium.org/258037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We don't currently use the zygote to spawn the utility process, so after browser updates bad bugs can occur with mismatched subprocesses. See crbug.com/23327 and crbug.com/22703.
BUG=23327
TEST=Extensions installation/autoupdate and New Tab Page tip download should still work.
Review URL: http://codereview.chromium.org/256036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21394
TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear.
Review URL: http://codereview.chromium.org/199073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/19162
TEST= Start browser with NNTP, note line of tips at bottom.
Review URL: http://codereview.chromium.org/173087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.
Review URL: http://codereview.chromium.org/149255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
load tips from popgadget, at http://www.google.com/labs/popgadget/world.
BUG= http://crbug.com/14962
TEST= Enable new tab page. See welcome message. On reload afterwards (and always after that, as long as preferences file isn't removed), see browsing recommendations appear in bottom right corner.
Review URL: http://codereview.chromium.org/147109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
|