| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=123061,131119
TEST=unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10539143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126317
TEST=unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10536083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=unit tests pass.
TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10539045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an active (begin<now<end) promotion arrives after the initial
launch sequence, the promo resource service will notify clients
immediately AND schedule a notification at the end of promotion.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10541054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Web resource service fails to keep fetching the data once
a fetch has failed because in_fetch_ flag is never reset.
Review URL: https://chromiumcodereview.appspot.com/10540039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Purge legacy notification promo code.
* Get rid of NotificationPromo::Delegate.
* Get rid of RefCountedThreadSafe.
* Unit test cleanup.
BUG=12637
TEST=compiles, unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10496008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content\public\test. This way we can enforce that internal content headers don't leak to embedders.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110061,125974
TEST=PromoResourceServiceTest.*
Review URL: https://chromiumcodereview.appspot.com/10446053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=owners
Review URL: https://chromiumcodereview.appspot.com/10386221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only remaining use of content::URLFetcher is content::URLFetcher::Create.
Make content::URLFetcher not inherit from net::URLFetcher.
Also make code that directly create URLFetcherImpl instead call content::URLFetcher::Create.
BUG=118220
TEST=
TBR=mnissler@chromium.org,sky@chromium.org,mal@chromium.org,sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10412050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change all references to net::URLFetcherDelegate.
Change some instances of content::URLFetcher to net::URLFetcher as
needed.
Remove unused files auth_response_handler.*.
BUG=118220
TEST=
TBR=sky@chromium.org,joi@chromium.org,mnissler@chromium.org,rlp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=achuith,agl,rsesek
BUG=None (yet)
TEST=Chrome hits SSL version instead of non-SSL version of promo server.
Review URL: https://chromiumcodereview.appspot.com/10407012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=119373
TEST=unit tests pass.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137328
Review URL: https://chromiumcodereview.appspot.com/10398032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=119373
TEST=unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10398032
TBR=achuith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119373
TEST=unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10398032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily make a shim content::URLFetcherDelegate class. A future CL
will replace all instances of content::URLFetcherDelegate with
net::URLFetcherDelegate and remove that class.
Move most URLFetcher methods to net::URLFetcher, except for the static
methods (which will be handled in a future CL) and AssociateWithRenderView,
which is content-specific.
Replace all instances of content::URLFetcher* in the URLFetcherDelegate
callbacks with net::URLFetcher* (except for rlz, which required its own special hack).
BUG=118220
TEST=
TBR=mnissler@chromium.org,jhawkins@chromium.org,cpu@chromium.org,estade@chromium.org,sky@chromium.org,joth@chromium.org,satish@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an upcoming CL that needs those functions from
chrome/common/extensions.
TBR=satorux@chromium.org, pkasting@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10384086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation tries to achieve feature parity with the existing implementation based on the tips server. Additional features will be added over time. Legacy code has not been deleted to keep the diff manageable and reviewable.
* Add InitFromJson to parse new format. The old parser is now InitFromJsonLegacy, soon to be deleted.
* Introduce additional data members num_groups_ (previously a const set to 100), initial_segment_ and increment_. These modify the start time calculation in StartTimeForGroup. time_slice_ is now in seconds instead of hours.
* build_ and platform_ set to succeed by default. These will be deleted soon, along with the rest of the legacy code.
* max_views_ of 0 is unlimited views.
* num_groups_ is now exclusive so the range of groups is from [0, num_groups_).
* We construct the new promo server url by adding params for os, channel, version and locale.
* WebResourceService takes a GURL instead of const char* as a param in the ctor and saves a GURL instead of const char* as its data member.
BUG=119373
TEST=unit tests. See promo in chrome using --promo-server-url="http://achuithz600.mtv.corp.google.com/www/files/promoresource4"
Review URL: http://codereview.chromium.org/10356006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10304006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boolean flag.
This is just prep work for a large CL that rewrites the JSON parser. Splitting
out this interface change will make it easier to review the other CL.
BUG=121469
TEST=No functional change.
Review URL: https://chromiumcodereview.appspot.com/9960077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mucked around here before.
R=achuith@chromium.org,jstritar@chromium.org,mirandac@chromium.org
BUG=None
TEST=achuith gets more vacuous rubber stamp work
NOTRY=true
Review URL: http://codereview.chromium.org/9967010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=118914
TEST=none
Review URL: http://codereview.chromium.org/9734001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once complete, forwarding headers will be removed from net/base/ .
TEST=none
R=willchan
Review URL: http://codereview.chromium.org/9703062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
TBR=willchan@chromium.org,mirandac@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9648020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NTP sign in link was being throttled using a server side check to prevent overloading the sync servers.
Now that the NTP sign in link is being shown to 100% of users we no longer need to throttle it.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9361020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9317074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
TBR=achuith@chromium.org,joaodasilva@chromium.org,sky@chromium.org
TEST=Compiles, runs, unit_tests --gtest_filter=PromoResource* are OK, no regressions.
BUG=None
NOTRY=true
Review URL: http://codereview.chromium.org/9310045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9233018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition.
I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this.
BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118415
Review URL: https://chromiumcodereview.appspot.com/9150017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
what was done with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition.
I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9150017
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition.
I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9150017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change broke Linux and Mac bots. I would recommend to ask committers to run your next change on trybots.
(*1) http://chromegw.corp.google.com/i/chromium/builders/Mac/builds/10788/steps/compile/logs/stdio
(*2) http://chromegw.corp.google.com/i/chromium/builders/Linux/builds/19313/steps/compile/logs/stdio
(*3) http://chromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/21385/steps/compile/logs/stdio
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9185026
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/9215005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9185026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98716
R=jam@chromium.org
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/8963033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=davemoore@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/8919017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use base::Bind instead of NewRunnableMethod.
* Inline WebResourceFetcher into WebResourceService, as they have the same lifetime.
* Move stuff specific to PromoResourceService into that class.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8905022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:24158
TEST=NONE
Review URL: http://codereview.chromium.org/8931005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=93109
TEST=Launch Chromium, log in, open the NTP.
Review URL: http://codereview.chromium.org/8922011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also move NTPPromoShown to notification_promo.cc
BUG=106743
TEST=NONE.
Review URL: http://codereview.chromium.org/8833009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Turn on flag to check cookies when updating NTP Promo.
Review URL: http://codereview.chromium.org/8772063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103851
TEST=tree
R=kbr
Review URL: http://codereview.chromium.org/8758003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8520009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently doing it on FILE thread causes a race, which causes crbug 83153.
In order to move back to UI thread, we have to drop chrome channel support in GPU blacklist (it's a FILE operation); also, we have to move the collection of ATI driver version in linux to GPU process.
Note that this is the minimum change required for the move. Further cleanup will follow once this is merged safely back to M16.
BUG=97535
TEST=unittest
Review URL: http://codereview.chromium.org/8670004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8614003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600, 94925
TEST=none
TBR=mnissler
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110235
Review URL: http://codereview.chromium.org/8573021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializers.
BUG=101600, 94925
TEST=none
TBR=mnissler
Review URL: http://codereview.chromium.org/8573021
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8568039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600, 94925
TEST=none
TBR=mnissler
Review URL: http://codereview.chromium.org/8573021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110235 0039d316-1c4b-4281-b951-d872f2087c98
|