summaryrefslogtreecommitdiffstats
path: root/chrome/browser/webdata/autofill_change.h
Commit message (Collapse)AuthorAgeFilesLines
* Autofill deprecate unique_ids in favor of guids for WebDataServicedhollowa@chromium.org2010-10-291-15/+72
| | | | | | | | | | | Provides GUID-based APIs for Add, Update, Remove for both Autofill credit cards and profiles. New Autofill change notifications for these GUID-based APIs. BUG=58813 TEST=WebDataServiceAutofillTest.* Review URL: http://codereview.chromium.org/4102012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64464 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: More dtor deinlining. (Can almost see the end!)erg@google.com2010-10-221-16/+6
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
* This is stage 1 of transition to GUIDs as primary identifier for AutoFill ↵dhollowa@chromium.org2010-10-201-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | profiles and credit cards. The transition will look like this in terms of table migration: Current: CREATE TABLE autofill_profiles ( label VARCHAR, unique_id INTEGER PRIMARY KEY, first_name VARCHAR, middle_name VARCHAR, last_name VARCHAR, email VARCHAR, company_name VARCHAR, address_line_1 VARCHAR, address_line_2 VARCHAR, city VARCHAR, state VARCHAR, zipcode VARCHAR, country VARCHAR, phone VARCHAR, fax VARCHAR); Transitional (adds guid column): CREATE TABLE autofill_profiles ( label VARCHAR, unique_id INTEGER PRIMARY KEY, first_name VARCHAR, middle_name VARCHAR, last_name VARCHAR, email VARCHAR, company_name VARCHAR, address_line_1 VARCHAR, address_line_2 VARCHAR, city VARCHAR, state VARCHAR, zipcode VARCHAR, country VARCHAR, phone VARCHAR, fax VARCHAR, guid VARCHAR NOT NULL); // <- add guid End goal (in follow up CL): CREATE TABLE autofill_profiles ( // remove label // remove unique_id guid VARCHAR NOT NULL PRIMARY KEY // <- reorder guid, make primary first_name VARCHAR, middle_name VARCHAR, last_name VARCHAR, email VARCHAR, company_name VARCHAR, address_line_1 VARCHAR, address_line_2 VARCHAR, city VARCHAR, state VARCHAR, zipcode VARCHAR, country VARCHAR, phone VARCHAR, fax VARCHAR); And similarly for the credit_cards table. BUG=58813 TEST=AutoFillProfileTest.Compare, GUIDTest.GUIDCorrectlyFormatted, WebDataServiceAutofillTest.ProfileRemoveGUID, WebDataServiceAutofillTest.CreditCardRemoveGUID, WebDatabaseTest.AutoFillProfile, WebDatabaseTest.CreditCard, WebDatabaseMigrationTest.MigrateVersion30ToCurrent Review URL: http://codereview.chromium.org/3760009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63173 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to web database and autofill components requiredtim@chromium.org2010-04-021-9/+19
| | | | | | | | | | | | | | | | | | | | | to sync profiles / addresses. The main part here is adding Refresh to the PersonalDataManager. It changes the expectation that the PDM is the only thing modifying autofill, which is necessary as the sync engine connects directly to the WebDatabase on the DB thread. The tricky part is ID generation, which I spent a great deal of time harping over in my sync change to make sure that everything is in an eventually consistent state. Note that because of the way the autofill window takes an isolated copy of the data, there *are* extremely rare cases where an edit will get dropped - I cover this case in PersonalDataManagerTest.Refresh. TEST=WebDataServiceTest, PersonalDataManagerTest. Review URL: http://codereview.chromium.org/1550007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43426 0039d316-1c4b-4281-b951-d872f2087c98
* Hook autofill++ WebDatabase changes up to the NotificationService.tim@chromium.org2010-03-271-8/+54
| | | | | | | | TEST=WebDataServiceAutofillTest Review URL: http://codereview.chromium.org/1385002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42881 0039d316-1c4b-4281-b951-d872f2087c98
* Return a list of changed from WebDatabase::RemoveFormElementsAddedBetween()skrul@chromium.org2009-12-171-3/+1
| | | | | | | | | | | | | | This changes add a list of AutofillChange out parameter to the RemoveFormElementsAddedBetween() method in order to communicate exactly what happened to the caller. This method may only update some autofill entries (by removing use timestamps that fall in the specified time range) or completely remove the autofill entry (if all the use timestamps fall between the specified time range). For sync, we need to know the difference. This change also required some new testing method on WebDatabase to make it possible to add new autofill entries with specific timestamps. This is needed to create a reliable test that requires entries to be added at different times. If there is a better way to do this, please let me know. The next change will add the notifications to the WebDataService. BUG=30169 Review URL: http://codereview.chromium.org/506047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34889 0039d316-1c4b-4281-b951-d872f2087c98
* Send notifications when single items are removed from autofill.skrul@chromium.org2009-12-161-0/+35
This patch will send an AUTOFILL_ENTRIES_REMOVED when an autofill entry is removed via WebDataService::RemoveFormValueForElementName() is called (note that the next change will have this implemented for the bulk removal method). This change also includes a bit of refactoring on how the notification details are sent from the WDS thread back to the main thread. Previously I was sending the data back via a WDResult but that didn't work well when expanded to different notifications since there is so way to tell what a given request was for. So I added some fields to the WedDataRequest class to hold the affected keys and the notification type. BUG=30168 Review URL: http://codereview.chromium.org/506001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34721 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 06:02:58 +0000