| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6626042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrates bad country code "UK" to good country code "GB". These bad country codes were introduced in build 686.
BUG=74511
TEST=WebDatabaseMigrationTest.MigrateVersion34ToCurrent
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/6606021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6592067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6598058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
country.
* Changes the country field to a <select> field.
* Restricts the possible values for the "country" field to a set of known values
* Moves the country field to the top of the Autofill dialog
* Changes the field labels according to the selected country
BUG=56599,56602,56604
TEST=
Review URL: http://codereview.chromium.org/6484022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to the underlying |autofill_profiles| schema. These changes split out name, email, and phone information into separate relationaly-tied tables so that we can support multi-valued fields. New tables are introduced: |autofill_profile_names|, |autofill_profile_emails|, and |autofill_profile_phones|. Also, the |label| fields have been removed from both |credit_cards| and |autofill_profiles|.
BUG=65625
TEST=WebDatabaseMigrationTest.*:WebDatabaseTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75710
Review URL: http://codereview.chromium.org/6546034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to the underlying |autofill_profiles| schema. These changes split out name, email, and phone information into separate relationaly-tied tables so that we can support multi-valued fields. New tables are introduced: |autofill_profile_names|, |autofill_profile_emails|, and |autofill_profile_phones|. Also, the |label| fields have been removed from both |credit_cards| and |autofill_profiles|.
BUG=65625
TEST=WebDatabaseMigrationTest.*:WebDatabaseTest.*
Review URL: http://codereview.chromium.org/6546034
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes to the underlying |autofill_profiles| schema. These changes split out name, email, and phone information into separate relationaly-tied tables so that we can support multi-valued fields. New tables are introduced: |autofill_profile_names|, |autofill_profile_emails|, and |autofill_profile_phones|. Also, the |label| fields have been removed from both |credit_cards| and |autofill_profiles|.
BUG=65625
TEST=WebDatabaseMigrationTest.*:WebDatabaseTest.*
Review URL: http://codereview.chromium.org/6546034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes remaining vestiges of profile and credit card labels as a means for identification. Labels do remain in the profile and credit card classes but are private, not persisted to the database, and created upon demand. This also cleans up the web_data_service and web_database methods that used labels as identifiers.
BUG=72929
TEST=WebDataServiceAutofillTest.*:WebDatabaseTest.* and miscellaneous others.
Review URL: http://codereview.chromium.org/6480073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This variable was uninitialized and the compiler gave a warning (which
got converted into an error because we compile using -Werror) when
GetIDAndCountOfFormElement() and its children are inlined. This is
because there is a path in that function that returns true but leaves
the pair_id variable uninitialized (if s.Step() is 0).
Note that I am not a Chromium committer so you will have to commit
this.
Patch by asharif; http://codereview.chromium.org/6293011/
BUG=70144
TEST=no visible change
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing r71485 (which was reverted in r71500).
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6278007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6291003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles,unittests
Review URL: http://codereview.chromium.org/5849001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65129
TEST=manual (see bug)
Review URL: http://codereview.chromium.org/5559012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
haven't changed.
BUG=65129
TEST=unit_tests --gtest_filter=WebDatabaseTest.Update*
Review URL: http://codereview.chromium.org/5610002
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/5515006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65129
TEST=unit_tests --gtest_filter=WebDatabaseTest.Update*
Review URL: http://codereview.chromium.org/5610002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Final round of unique_id deprecation. These changes migrated web_database schemas for profiles and credit cards, clean up the web_dataservice interface, bring the personal_data_manager interface inline with the GUID interfaces for web_dataservice, convert remaining unit tests to be GUID-based, and some changes to platform UI code that used unique IDs for edits.
BUG=58813
TEST=WebDataServiceTest.*, WebDatabaseTest.*, WebDatabaseMigrationTest.*, PersonalDataManagerTest.*, AutoFillTest.*, AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillProfileTest.MergeWith, ProfileSyncServiceAutofillTest.*, TwoClientLiveAutofillSyncTest.*
Review URL: http://codereview.chromium.org/4388001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our autofill UI for filling the billing address and credit card information
simultaneously quickly gets out of hand for users with multiple address and
credit card profiles. We want a clean, simple UI; so we will just fill one
part of the form or the other; but not both.
This cl also removes the billing address drop down from the Autofill preferences "Add credit card" dialog.
BUG=57976
TEST=unit_tests --gtest_filter=*AutoFill*
unit_tests --gtest_filter=*Autofill*
Review URL: http://codereview.chromium.org/3961004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60184
TEST=unit_tests --gtest_filter=WebDatabaseTest.RemoveAutoFillProfilesAndCreditCardsModifiedBetween
Review URL: http://codereview.chromium.org/4064001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
profiles and credit cards.
The transition will look like this in terms of table migration:
Current:
CREATE TABLE autofill_profiles (
label VARCHAR,
unique_id INTEGER PRIMARY KEY,
first_name VARCHAR,
middle_name VARCHAR,
last_name VARCHAR,
email VARCHAR,
company_name VARCHAR,
address_line_1 VARCHAR,
address_line_2 VARCHAR,
city VARCHAR,
state VARCHAR,
zipcode VARCHAR,
country VARCHAR,
phone VARCHAR,
fax VARCHAR);
Transitional (adds guid column):
CREATE TABLE autofill_profiles (
label VARCHAR,
unique_id INTEGER PRIMARY KEY,
first_name VARCHAR,
middle_name VARCHAR,
last_name VARCHAR,
email VARCHAR,
company_name VARCHAR,
address_line_1 VARCHAR,
address_line_2 VARCHAR,
city VARCHAR,
state VARCHAR,
zipcode VARCHAR,
country VARCHAR,
phone VARCHAR,
fax VARCHAR,
guid VARCHAR NOT NULL); // <- add guid
End goal (in follow up CL):
CREATE TABLE autofill_profiles (
// remove label
// remove unique_id
guid VARCHAR NOT NULL PRIMARY KEY // <- reorder guid, make primary
first_name VARCHAR,
middle_name VARCHAR,
last_name VARCHAR,
email VARCHAR,
company_name VARCHAR,
address_line_1 VARCHAR,
address_line_2 VARCHAR,
city VARCHAR,
state VARCHAR,
zipcode VARCHAR,
country VARCHAR,
phone VARCHAR,
fax VARCHAR);
And similarly for the credit_cards table.
BUG=58813
TEST=AutoFillProfileTest.Compare, GUIDTest.GUIDCorrectlyFormatted, WebDataServiceAutofillTest.ProfileRemoveGUID, WebDataServiceAutofillTest.CreditCardRemoveGUID, WebDatabaseTest.AutoFillProfile, WebDatabaseTest.CreditCard, WebDatabaseMigrationTest.MigrateVersion30ToCurrent
Review URL: http://codereview.chromium.org/3760009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Data dialog
BUG=49128
TEST=none
Review URL: http://codereview.chromium.org/3807009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58756
TEST=none
Review URL: http://codereview.chromium.org/3818001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes |WebDatabase::MigrateOldVersionsAsNeeded()| to return error status should database migration fail. If migration does fail then the initialization as a whole is rolled back. The error code is returned to caller so user is alerted. This also cleans up logging so that in all error cases log warnings are emitted. Additionally, this reworks the Autofill credit card migration logic to test the schema before migrating. This is preferable to the existing logic that attempted the migration and then looked for failure after the fact.
BUG=54012
TEST=WebDatabaseMigrationTest.*
Review URL: http://codereview.chromium.org/3615007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3560008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3308006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a created_by_policy field to TemplateURL. Added unit tests.
BUG=49306
TEST=WebDatabaseTest.Keywords*
Review URL: http://codereview.chromium.org/3323006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds migration unit tests to web database for missing images on the search ballot. This is follow-up from review http://codereview.chromium.org/3189004.
BUG=52452, 50699, 10913
TEST=WebDatabaseMigrationTest.MigrateVersion22ToCurrent, WebDatabaseMigrationTest.MigrateVersion22CorruptToCurrent, WebDatabaseMigrationTest.MigrateVersion24ToCurrent
Review URL: http://codereview.chromium.org/3295002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(This is the trunk version of 3228011).
BUG=10913
TEST= run build on profile from before 37036; search engines should work. run build on corrupted profile (one from before 37036 that has been updated with build 6.0.472.50); search engines should work.
Review URL: http://codereview.chromium.org/3240007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
template_url_model.h.
Separated out the TemplateURL::IDType which is now TemplateURLId into its own
file, since this was a primary reason for including template_url.h in another
header.
Similarly separate out the TemplateURLModelObserver from template_url_model.h to
reduce how often that file is included.
BUG=None
TEST=Compiling.
Review URL: http://codereview.chromium.org/3270011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
add a column which is already present. If we create a table as part of the init process, don't try to alter the table, because it already exists.
BUG=10913
TEST= search engine dialog works, search engines don't disappear.
Review URL: http://codereview.chromium.org/3239006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
them).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3161027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50699
TEST=First three (or two in Vietnam and Iran) search engine logos always available on import in --organic Chrome (not Chromium).
Review URL: http://codereview.chromium.org/3189004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The token service now supports serialization of tokens into the web database. The token service doesn't actually know the email of the user though, and it's assumed that whoever is using the token service does. Not sure whether that's a bad choice or not, open to suggestions.
This CL adds a new DB table.
Design comments / corrections are welcome. Testing in Chromium OS is in progress and not yet done. This CL will not be submitted prior to more Chromium OS testing.
BUG=47092,47093
TEST=Unit tests included
Review URL: http://codereview.chromium.org/3061025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Limits the number of Autocomplete entries added to the WebDB, per form submission, to a maximum of 256. If elements occur that have duplicate names, only the first occurrence is added.
BUG=51727
TEST=WebDatabaseTest.Autofill_AddFormFieldValues
Review URL: http://codereview.chromium.org/3143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49172
TEST=None
Review URL: http://codereview.chromium.org/3035046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
temporary workaround to prevent DOS'ing the browser with large profile data.
BUG=49172
TEST=WebDatabase.*
Review URL: http://codereview.chromium.org/2811059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These changes add encryption support on Mac for the Encryptor class. AES 128 bit is used for the encryption, and the auto-generated password is stored now in the Mac Keychain. This implies the Encryptor class on Mac can now block for user input, and can fail if access is denied.
BUG=42038, 49131
TEST=EncryptorTest.CypherTextDiffers, EncryptorTest.DecryptError, EncryptorPasswordTest.*
Review URL: http://codereview.chromium.org/2943014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remnants of shipping address and CVV.
BUG=47426,47423
TEST=PersonalDataManager.*
Review URL: http://codereview.chromium.org/2818033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters).
TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/2854015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The cleanup removes ny row with a string field larger than a reasonable size. The string fields examined here are precisely the ones that were subject to corruption by the original bug.
BUG=38364
TEST=Manually created autofill profile entries with sizes greater and less than the limit. Restarted browser and forced the migration code to trigger. Verified that all the statements execute successfully, and that the too-large profiles were deleted.
Review URL: http://codereview.chromium.org/2805006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UTF16ToUTF8 conversions.
BUG=41862
TEST=trybots
Review URL: http://codereview.chromium.org/2481003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for crash seen in the field. The AutoFillType class was not thread-safe. These changes
make it so. Also adds unit tests that cover mappings from type to group and subgroup, and
out of range conditions.
BUG=42341
TEST=AutoFillTypeTest
Review URL: http://codereview.chromium.org/1789001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41427
TEST=In the bug.
Review URL: http://codereview.chromium.org/1576040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41196,38364
TEST=In the bugs
Review URL: http://codereview.chromium.org/1519033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to sync profiles / addresses.
The main part here is adding Refresh to the PersonalDataManager.
It changes the expectation that the PDM is the only thing modifying autofill,
which is necessary as the sync engine connects directly to the WebDatabase
on the DB thread.
The tricky part is ID generation, which I spent a great deal of time harping
over in my sync change to make sure that everything is in an eventually
consistent state. Note that because of the way the autofill window takes an
isolated copy of the data, there *are* extremely rare cases where an edit will
get dropped - I cover this case in PersonalDataManagerTest.Refresh.
TEST=WebDataServiceTest, PersonalDataManagerTest.
Review URL: http://codereview.chromium.org/1550007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43426 0039d316-1c4b-4281-b951-d872f2087c98
|