summaryrefslogtreecommitdiffstats
path: root/chrome/browser/webdata
Commit message (Collapse)AuthorAgeFilesLines
* Fix AutoFillProfile leaks in WebDataService.tim@chromium.org2010-04-021-9/+14
| | | | | | | | TBR=akalin Review URL: http://codereview.chromium.org/1569016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43438 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to web database and autofill components requiredtim@chromium.org2010-04-025-46/+119
| | | | | | | | | | | | | | | | | | | | | to sync profiles / addresses. The main part here is adding Refresh to the PersonalDataManager. It changes the expectation that the PDM is the only thing modifying autofill, which is necessary as the sync engine connects directly to the WebDatabase on the DB thread. The tricky part is ID generation, which I spent a great deal of time harping over in my sync change to make sure that everything is in an eventually consistent state. Note that because of the way the autofill window takes an isolated copy of the data, there *are* extremely rare cases where an edit will get dropped - I cover this case in PersonalDataManagerTest.Refresh. TEST=WebDataServiceTest, PersonalDataManagerTest. Review URL: http://codereview.chromium.org/1550007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43426 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Handle filling select controls.jhawkins@chromium.org2010-03-272-54/+27
| | | | | | | | | BUG=38222 TEST=none Review URL: http://codereview.chromium.org/1309003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42891 0039d316-1c4b-4281-b951-d872f2087c98
* Hook autofill++ WebDatabase changes up to the NotificationService.tim@chromium.org2010-03-274-29/+261
| | | | | | | | TEST=WebDataServiceAutofillTest Review URL: http://codereview.chromium.org/1385002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42881 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-181-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Implement set_whole_number and use it to load whole phone numbers ↵jhawkins@chromium.org2010-03-172-4/+7
| | | | | | | | | | from the WebDB. BUG=38218 TEST=WebDatabaseTest.AutoFillProfile Review URL: http://codereview.chromium.org/1043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41872 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* More code cleanups found by -Wextra.evan@chromium.org2010-03-091-1/+1
| | | | | | | | (I'm still waiting on a v8 change to turn this on for the whole codebase...) Review URL: http://codereview.chromium.org/746001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41080 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for autofill sync.skrul@chromium.org2010-03-022-9/+9
| | | | | | | | Including some changes to make things testable, including adding WebDatabase* to the ctor of the MA and PC, plus making some methods virtual on WebDatabase. Review URL: http://codereview.chromium.org/661316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40359 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill Change Processor and Model Associatorzork@google.com2010-03-018-61/+212
| | | | | | | | | BUG=29926 TEST=none Review URL: http://codereview.chromium.org/628003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40304 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebDatabase::UpdateAutofillEntries()skrul@chromium.org2010-02-254-37/+270
| | | | | | | | | | This new method will replace existing autofill entries with the list provided as the argument. Provided entries that don't exist are added. BUG=36713 Review URL: http://codereview.chromium.org/660023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac builder bustageskrul@chromium.org2010-02-231-2/+2
| | | | | | Review URL: http://codereview.chromium.org/656003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39743 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this patch on behalf of Mark Hahnenberg <mhahnenb(at)gmail.com>skrul@chromium.org2010-02-234-50/+230
| | | | | | | | | | | | | | Added a vector of Time objects to the AutofillEntry object for storingthe results retrieved from the date_created field of the autofill_datestable corresponding to the AutofillKey retrieved from the autofill table. Also modified the old GetAllAutofillEntries test to account for this newlystored data. BUG=35230 TEST=WebDatabaseTest.GetAllAutofillEntries Review URL: http://codereview.chromium.org/600070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39742 0039d316-1c4b-4281-b951-d872f2087c98
* Fix recently added FormField constructors that I missed in the last commit.jhawkins@chromium.org2010-02-111-4/+8
| | | | | | | | | TBR=zork BUG=none TEST=none Review URL: http://codereview.chromium.org/598047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38718 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r38570. The underlying bug has been fix.jhawkins@chromium.org2010-02-112-17/+39
| | | | | | | | | | | Move conditions of FormField creation to FormFieldHistoryManager; AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data. TBR=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38711 0039d316-1c4b-4281-b951-d872f2087c98
* Added the GetAllAutofillEntries function to the WebDatabase class in ↵skrul@chromium.org2010-02-105-0/+96
| | | | | | | | | | | preparation for autofill sync. BUG=30959 TEST=WebDatabaseTest.GetAllAutofillEntries Review URL: http://codereview.chromium.org/598004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38699 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move conditions of FormFields creation to FormFieldHistoryManager;tony@chromium.org2010-02-102-39/+17
| | | | | | | | | | | | | AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data." This reverts commit r38570. TBR=jhawkins Review URL: http://codereview.chromium.org/602014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38573 0039d316-1c4b-4281-b951-d872f2087c98
* Move conditions of FormFields creation to FormFieldHistoryManager; AutoFill ↵jhawkins@chromium.org2010-02-102-17/+39
| | | | | | | | | | does not have the same conditions. This required manipulating the FormField data structure to add necessary field data. BUG=none TEST=none Review URL: http://codereview.chromium.org/602008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38570 0039d316-1c4b-4281-b951-d872f2087c98
* Implement adding, updating and removing credit cards from the web database ↵jhawkins@chromium.org2010-01-255-39/+383
| | | | | | | | | | through the gtk AutoFill dialog. BUG=18201 TEST=WebDatabaseTest.CreditCard, PersonalDataManagerTest.SetCreditCards Review URL: http://codereview.chromium.org/555068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37036 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to save and remove AutoFill profiles from the AutoFillDialog.jhawkins@chromium.org2010-01-245-90/+134
| | | | | | | | BUG=18201 TEST=PersonalDataManagerTest.SetProfiles Review URL: http://codereview.chromium.org/545175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36978 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up AutoFill profile DB handling in WebDataService.jhawkins@chromium.org2010-01-202-8/+123
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/552072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36684 0039d316-1c4b-4281-b951-d872f2087c98
* Implement initial support for saving and loading AutoFill profiles to the WebDB.jhawkins@chromium.org2010-01-203-7/+314
| | | | | | | | BUG=18201 TEST=WebDatabaseTest.AutoFillProfile Review URL: http://codereview.chromium.org/548078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36664 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-6/+3
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak from cl 524003 (Change WDS to use the DB thread...)skrul@chromium.org2010-01-043-43/+21
| | | | | | | | This is a second try of cl 524003 -- the previous version caused a leak. The only change in this patch is the addition of the ui_thread_ member in TemplateURLModelTest and the corresponding initializer. This allows the DeleteOnUIThread trait of the WebDataService to do its job. Review URL: http://codereview.chromium.org/522025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35462 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35339 - Change WDS to use the DB thread rather than its own thread.michaeln@google.com2009-12-293-21/+43
| | | | | | | | | | | | | This cleanup was requested by brettw and was started to make it easier for the sync service to post tasks to the WDS thread (now the DB thread). This simplifies the WDS a bit since it no longer has to manage its own thread, and can assume that the DB thread is running throughout its lifetime. One change in behavior that is significant is that previous to this change, the WDS worker thread would always be joined when Shutdown() was called from Profile::~Profile(). Now the Shutdown() method schedules a task that can extend the lifetime of the WDS past the lifetime of the Profile instance. Review URL: http://codereview.chromium.org/524003 TBR=skrul@chromium.org Review URL: http://codereview.chromium.org/521013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35356 0039d316-1c4b-4281-b951-d872f2087c98
* Change WDS to use the DB thread rather than its own thread.skrul@chromium.org2009-12-293-43/+21
| | | | | | | | | | This cleanup was requested by brettw and was started to make it easier for the sync service to post tasks to the WDS thread (now the DB thread). This simplifies the WDS a bit since it no longer has to manage its own thread, and can assume that the DB thread is running throughout its lifetime. One change in behavior that is significant is that previous to this change, the WDS worker thread would always be joined when Shutdown() was called from Profile::~Profile(). Now the Shutdown() method schedules a task that can extend the lifetime of the WDS past the lifetime of the Profile instance. Review URL: http://codereview.chromium.org/524003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35339 0039d316-1c4b-4281-b951-d872f2087c98
* Differentiate between ADD and CHANGED when adding new autofill entries.skrul@chromium.org2009-12-214-34/+97
| | | | | | | | Adding a new autofill entry can either result in an ADD (when the name/value par was never seen before) or with an UPDATE (when the name/value pair already exists). Review URL: http://codereview.chromium.org/507053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35108 0039d316-1c4b-4281-b951-d872f2087c98
* Bring the remove notifications up from the WebDatabase to the WebDataService.skrul@chromium.org2009-12-182-31/+75
| | | | | | Review URL: http://codereview.chromium.org/505046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34986 0039d316-1c4b-4281-b951-d872f2087c98
* Changes Init to use ASSERT_EQ, rather than true.sky@chromium.org2009-12-181-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=skrul Review URL: http://codereview.chromium.org/501102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34907 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-185-25/+55
| | | | | | | | | | | | | . If we can't init the web db a dialog is shown to the user. . If we can't init the web db the default search provider no longer becomes NULL. BUG=28374 TEST=none Review URL: http://codereview.chromium.org/501090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34901 0039d316-1c4b-4281-b951-d872f2087c98
* Return a list of changed from WebDatabase::RemoveFormElementsAddedBetween()skrul@chromium.org2009-12-178-39/+186
| | | | | | | | | | | | | | This changes add a list of AutofillChange out parameter to the RemoveFormElementsAddedBetween() method in order to communicate exactly what happened to the caller. This method may only update some autofill entries (by removing use timestamps that fall in the specified time range) or completely remove the autofill entry (if all the use timestamps fall between the specified time range). For sync, we need to know the difference. This change also required some new testing method on WebDatabase to make it possible to add new autofill entries with specific timestamps. This is needed to create a reliable test that requires entries to be added at different times. If there is a better way to do this, please let me know. The next change will add the notifications to the WebDataService. BUG=30169 Review URL: http://codereview.chromium.org/506047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34889 0039d316-1c4b-4281-b951-d872f2087c98
* Send notifications when single items are removed from autofill.skrul@chromium.org2009-12-164-22/+108
| | | | | | | | | | This patch will send an AUTOFILL_ENTRIES_REMOVED when an autofill entry is removed via WebDataService::RemoveFormValueForElementName() is called (note that the next change will have this implemented for the bulk removal method). This change also includes a bit of refactoring on how the notification details are sent from the WDS thread back to the main thread. Previously I was sending the data back via a WDResult but that didn't work well when expanded to different notifications since there is so way to tell what a given request was for. So I added some fields to the WedDataRequest class to hold the affected keys and the notification type. BUG=30168 Review URL: http://codereview.chromium.org/506001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34721 0039d316-1c4b-4281-b951-d872f2087c98
* Add details to autofill add notificationskrul@chromium.org2009-12-164-39/+129
| | | | | | | | | | This change adds a details payload containing the list of modified keys to the autofill add notification. The existing mechanism for passing values back from query methods (WDResult) is reused here to pass the modified keys back to the caller. BUG=29606 Review URL: http://codereview.chromium.org/477009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34717 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove a NOTIMPL since we have a bug on itevan@chromium.org2009-12-091-1/+2
| | | | | | | | | | Also, update some comments to use the new bug number. BUG=8205,25404 Review URL: http://codereview.chromium.org/483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34193 0039d316-1c4b-4281-b951-d872f2087c98
* Add notification for autofill changes.skrul@chromium.org2009-12-073-2/+48
| | | | | | | | | | This is the first in a series of changes for adding notifications to autofill. This change adds the notification plumbing to WebDataService::AddFormFieldValues that sends a simple notification. The next change will add a Details<> payload to the notification with a list of changes that were performed, and then I will expand the notifications to the other autofill mutation methods. Review URL: http://codereview.chromium.org/455027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33970 0039d316-1c4b-4281-b951-d872f2087c98
* Add the beginnings of a unit test for the autofill features of the ↵skrul@chromium.org2009-12-011-0/+91
| | | | | | | | | | WebDataService. This is so I can start adding change notification to the autofill methods, which is need to sync this data type. Review URL: http://codereview.chromium.org/435030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33475 0039d316-1c4b-4281-b951-d872f2087c98
* Many changes to DictionaryValues:pkasting@chromium.org2009-11-251-2/+2
| | | | | | | | | | | | | | | | | * Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs. * Use these APIs with all key iterator usage. * SetXXX() calls cannot fail, so change them from bool to void. * Change GetSize() to size() since it's cheap, and add empty(). Other: * Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop). * Shorten a few bits of code. BUG=567 TEST=none Review URL: http://codereview.chromium.org/441008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
* Add a label member to the FormField class. This member will hold the value ↵jhawkins@chromium.org2009-11-231-12/+32
| | | | | | | | | | of the field's label once we parse this value from the DOM. BUG=none TEST=none Review URL: http://codereview.chromium.org/418032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32834 0039d316-1c4b-4281-b951-d872f2087c98
* Ninth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-071-1/+3
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/372013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FormStructure and an initial method, EncodeUploadRequest. This ↵jhawkins@chromium.org2009-11-041-8/+20
| | | | | | | | | | also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/355003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30980 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the element_ member of FormField, as we don't use it and shouldn't be ↵jhawkins@chromium.org2009-10-291-24/+12
| | | | | | | | | | using WebCore internals in glue anyway. BUG=none TEST=none Review URL: http://codereview.chromium.org/342032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30512 0039d316-1c4b-4281-b951-d872f2087c98
* Add functions to purge the Web Database memory and get the service without ↵pkasting@chromium.org2009-10-232-13/+54
| | | | | | | | | | creating it, for the memory purger. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/326014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29945 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some #includes where possible.pkasting@chromium.org2009-10-235-30/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/335002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29915 0039d316-1c4b-4281-b951-d872f2087c98
* Break out FormFieldValues::Element into FormField, which will eventually ↵jhawkins@chromium.org2009-10-235-59/+56
| | | | | | | | | | hold more autofill data about each form field. BUG=none TEST=none Review URL: http://codereview.chromium.org/306061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29913 0039d316-1c4b-4281-b951-d872f2087c98
* Make PNGCodec::Decode(...) not make an intermediary copy of the decoded data;erg@google.com2009-10-222-5/+4
| | | | | | | | | | | instead have it write directly to the returned SkBitmap. BUG=http://crbug.com/24493 TEST=Perf should get better. On the perf trybot, tab_complex_theme_cold got an average of ~40ms better. Review URL: http://codereview.chromium.org/305001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29780 0039d316-1c4b-4281-b951-d872f2087c98
* Rename AutoFillForm to FormFieldValues to better reflect the purpose of the ↵jhawkins@chromium.org2009-10-205-59/+65
| | | | | | | | | | data structure. BUG=none TEST=none Review URL: http://codereview.chromium.org/306014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29580 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some structures in webkit/glue to string16.darin@chromium.org2009-10-202-39/+38
| | | | | | | | | | R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/305002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29549 0039d316-1c4b-4281-b951-d872f2087c98
* Move autofill related WebView{Delegate} methods into the WebKit API.darin@chromium.org2009-10-165-68/+81
| | | | | | | | | | | | This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29244 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sqlite error handler to a single locationcpu@chromium.org2009-10-151-0/+4
| | | | | | | | | | | | | | - Eliminate code duplication - Cover other 3 databases - Still doing the same as before, sending UMA histograms BUG=11908 TEST=none Review URL: http://codereview.chromium.org/270101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29073 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-4/+3
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 23:01:42 +0000