summaryrefslogtreecommitdiffstats
path: root/chrome/browser/wrench_menu_model.cc
Commit message (Collapse)AuthorAgeFilesLines
* Build fixes to the CLrkc@google.com2010-08-221-0/+2
| | | | | | Review URL: http://codereview.chromium.org/3061044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98
* Properly convert the preferences label if it's not ASCII.mnissler@chromium.org2010-08-201-1/+1
| | | | | | | | | BUG=52823 TEST=Configure arabic locale, fire up chrome, check the "Preferences" item in the wrench menu. Review URL: http://codereview.chromium.org/3166022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56878 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Checkin for CL: http://codereview.chromium.org/3061044/show"phajdan.jr@chromium.org2010-08-191-2/+0
| | | | | | | | | | Broke compile. TBR=rkc Review URL: http://codereview.chromium.org/3199006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56717 0039d316-1c4b-4281-b951-d872f2087c98
* Checkin for CL: http://codereview.chromium.org/3061044/showrkc@google.com2010-08-191-0/+2
| | | | | | | | | | | | | | TEST=Backend: Various reports submitted from Chrome OS and Windows builds sent to the feedback test server. For Chromium OS, sent reports with current screenshot and saved screenshots; verified all reports for data accuracy and completion. Frontend: Tested the UI features by excersizing various options; tested not selecting any issue, tested switching between screenshot types. Review URL: http://codereview.chromium.org/3181027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56708 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPrintf into its own file and use the base namespace. Currently ↵brettw@chromium.org2010-08-171-0/+1
| | | | | | | | | | | | | | this has using directives for the functions so I don't have to change all files to use the namespace. No code changes to logic. TEST=it compiles + the included unit tests BUG=none Review URL: http://codereview.chromium.org/3181016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56299 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use 'Preferences' instead of 'Options' in wrench menu.tfarina@chromium.org2010-08-141-0/+13
| | | | | | | | | | BUG=17870 TEST=launch chrome, open the wrench menu, see if the 'Preferences' menu is in there instead of the 'Options' menu. Review URL: http://codereview.chromium.org/3060050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56148 0039d316-1c4b-4281-b951-d872f2087c98
* Adding remoting setup to wrench menuhclam@chromium.org2010-08-121-0/+8
| | | | | | | | | | | | | | pranvak@ is OOO so I'm submitting for him. This patch will add a menu in wrench menu to start the chromoting setup flow. Submit for: pranvak@chromium.org Reviewed: http://codereview.chromium.org/3075024/show Review URL: http://codereview.chromium.org/3134003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55815 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55311 - Add remoting to wrench menu.erikchen@google.com2010-08-061-8/+0
| | | | | | | | | | | | | | | | | | | This change adds remoting item to wrench menu. The change is under flag enable-remoting, so end users will not see it. The CL is cleaned up. It was compiling and working. I added the check for kEnableRemoting and resynched and it is no longer compiling. Submitted for: pranavk@chromium.org Reviewed: http://codereview.chromium.org/3075024/show BUG=50242 TEST=NONE Review URL: http://codereview.chromium.org/3080038 TBR=hclam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55316 0039d316-1c4b-4281-b951-d872f2087c98
* Add remoting to wrench menu.hclam@chromium.org2010-08-061-0/+8
| | | | | | | | | | | | | | | | | This change adds remoting item to wrench menu. The change is under flag enable-remoting, so end users will not see it. The CL is cleaned up. It was compiling and working. I added the check for kEnableRemoting and resynched and it is no longer compiling. Submitted for: pranavk@chromium.org Reviewed: http://codereview.chromium.org/3075024/show BUG=50242 TEST=NONE Review URL: http://codereview.chromium.org/3080038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55311 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will ↵sanjeevr@chromium.org2010-07-271-0/+6
| | | | | | | | | | | be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. BUG=None. TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled. Review URL: http://codereview.chromium.org/3026025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
* Use check item for side tab menu.oshima@chromium.org2010-07-211-2/+2
| | | | | | | | | BUG=chromium-os:4948 TEST=manual: toggle side tab from wrench menu and side tab menu will be checked. Review URL: http://codereview.chromium.org/3034021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53235 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-201-29/+82
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* Put sidetab menu back to wrench menu (confirmed with sky)oshima@chromium.org2010-07-201-0/+5
| | | | | | | | | | | | Removed OpenTanMode (confirmed with cole) Removed ToolbarView::SetAppMenuModel BUG=49229 TEST=none. Review URL: http://codereview.chromium.org/2832058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52968 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement the update available notification in the wrench menu.rsesek@chromium.org2010-07-191-1/+4
| | | | | | | | | | | | The changes to restart_browser.mm also affect the sheet displayed in the About window. Note that the badge on the wrench menu looks bad. BUG=45147 TEST=difficult Review URL: http://codereview.chromium.org/2856042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52911 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the decrement zoom button appear before the increment button.sky@chromium.org2010-07-161-1/+1
| | | | | | | | | | BUG=48332 TEST=make sure the wrench menu has the decrement zoom button before the increment zoom button. Review URL: http://codereview.chromium.org/3008004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52682 0039d316-1c4b-4281-b951-d872f2087c98
* GTK/Mac: Switch the zoom buttons to the opposite order.erg@chromium.org2010-07-151-2/+2
| | | | | | | | | | | A views implementation will be needed since it doesn't follow the model. BUG=48332 TEST=Minus is on the left, Plus is on the right. Review URL: http://codereview.chromium.org/3013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52513 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Put buttons into the new unified Wrench menu.rsesek@chromium.org2010-07-151-4/+8
| | | | | | | | | | | | This also makes changes to MenuController to support NIB-based initialization. Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru). BUG=47848 TEST=Click on Wrench menu and see buttons. Buttons perform their function. Review URL: http://codereview.chromium.org/2923009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
* Adds create application shortcuts to under the tools menu as per Bensky@chromium.org2010-07-141-0/+9
| | | | | | | | | | | and Glen. BUG=48018 TEST=see bug Review URL: http://codereview.chromium.org/2910010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52382 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Grouped buttons should be equal sizes in new wrench menu.erg@chromium.org2010-07-091-6/+8
| | | | | | | | | | | | | This completes the linux implementation of the new wrench menu. Turning on by default. Will watch how this goes. BUG=45757 TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons should be equal. Review URL: http://codereview.chromium.org/2961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51974 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanups to the new wrench menu.erg@chromium.org2010-06-301-8/+35
| | | | | | | | | | | | | | | - Make the rendering for multiple buttons pretty by unifying sequnces of buttons. - Add the zoom label control and make the wrench menu model listen for notifications about zoom percentage changing. - Fixes crash that would have gone away once this was taken out from behind a flag BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2799043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes new wrench related problems on views:sky@chromium.org2010-06-251-2/+2
| | | | | | | | | | | | | . crash when showing page menu via alt-e. . dchecks when running on views on linux. BUG=45734 TEST=none TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2867029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50911 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r50859 with chromeos fixes.erg@chromium.org2010-06-251-0/+86
| | | | | | | | | | | | | | | | GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. Review URL: http://codereview.chromium.org/2800015 BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98
* Enables the new wrench menu by default on windows.sky@chromium.org2010-06-251-0/+4
| | | | | | | | | BUG=45734 TEST=make sure the new wrench menu works! Make sure and exer Review URL: http://codereview.chromium.org/2845022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50893 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50859 - GTK: First draft of the unified cut/copy/paste and ↵rafaelw@google.com2010-06-251-86/+0
| | | | | | | | | | | | | | | | | | +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2836029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.erg@chromium.org2010-06-251-0/+86
| | | | | | | | | | | | | Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50859 0039d316-1c4b-4281-b951-d872f2087c98
* Provides a single place to test whether the new wrench menu issky@chromium.org2010-06-241-0/+21
| | | | | | | | | | | | enabled. I'm doing this as I'm ready to turn it on for views and want a single place to turn it off should we decided to do that. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2813032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50722 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing the following. This differs from the first insky@chromium.org2010-06-231-0/+4
| | | | | | | | | | | | | | | | that I wasn't setting a field in a default: of a switch where I have a NOTREACHED. Moves cut/copy/paste and increment/descrement/fullscreen into buttons on views. BUG=45734 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2868029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50613 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50604 - Moves cut/copy/paste and increment/descrement/fullscreen into ↵mrossetti@chromium.org2010-06-231-4/+0
| | | | | | | | | | | | | | | | buttons on views. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2803013 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2829021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50608 0039d316-1c4b-4281-b951-d872f2087c98
* Moves cut/copy/paste and increment/descrement/fullscreen into buttonssky@chromium.org2010-06-231-0/+4
| | | | | | | | | | | on views. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2803013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50604 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Show the "About" menu item on the new Wrench menu.tfarina@chromium.org2010-06-221-0/+6
| | | | | | | | | BUG=45734 TEST=chrome\Debug\chrome --new-wrench-menu, see if the "About Google Chrome"/"About Chromium" is there. Review URL: http://codereview.chromium.org/2858017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50453 0039d316-1c4b-4281-b951-d872f2087c98
* First unified app menu behind the "--new-wrench-menu" flag.erg@chromium.org2010-06-081-0/+174
Does not contain Cole's unified edit menu / zoom controls. This is just scaffolding that should allow all the rest of the unified menu to exist, while letting each platform implement the native-only portions in their platform specific ways. Only modifies the linux implementation to actually use the new model, though the command line flag and the new model should be shared between platforms. BUG=45734,45757 TEST=Run with --new-wrench-menu on linux. Notice how long the unified menu is. Review URL: http://codereview.chromium.org/2677006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49130 0039d316-1c4b-4281-b951-d872f2087c98