| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6538033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73252
TEST=see bug
Review URL: http://codereview.chromium.org/6539013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The theme on the gallery that corresponds to classic has a real extension id
that we need to detect. By the time the BrowserThemeProvider can detect it, it
has already been unpacked so just hard code the extension ID into chrome.
BUG=67751
TEST=Install a theme, verify that 'use classic theme' is enabled, install Default theme, verify that 'use classic theme' is disabled
Review URL: http://codereview.chromium.org/6532033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73252
TEST=see bug
Review URL: http://codereview.chromium.org/6507043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 2.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6531028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
/src/chrome/browser/a*
BUG=58409
Review URL: http://codereview.chromium.org/6539002
Patch from Kushal Pisavadia <kushi.p@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simpler! -=150 lines :)
Need this to be able to use SyncerThread2.
BUG=26339
TEST=DataTypeManagerImpl2Test
Review URL: http://codereview.chromium.org/6528042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10937
TEST=make sure [Activate] button does not show in connection details if the device is already activated
Review URL: http://codereview.chromium.org/6516019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable print preview on Mac, make sure print button in print preview works.
Review URL: http://codereview.chromium.org/6479004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the client-side phishing detection classifies a page as phishing it will
send back a ping to Google to verify whether or not the page is really phishing.
If the server also classifies the site as phishing we may show a phishing
interstitial if it is enabled.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6014003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hookup yet).
BUG=59242
TEST=unit,sync_unit,sync_integration
Review URL: http://codereview.chromium.org/6465005
TBR=zea@chromium.org
Review URL: http://codereview.chromium.org/6537027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
75262 breaks sync for non-@gmail.com accounts. Will revert until that
is sorted out.
BUG=73067
TBR=hclam
Review URL: http://codereview.chromium.org/6519058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
builder per thestig's suggestion fixed the flakiness).
BUG=69389
TEST=none
Review URL: http://codereview.chromium.org/6289002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
interface.
BUG=chromium-os:8514
TEST=manual
Review URL: http://codereview.chromium.org/6515016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9181
TEST=Drag a URL or ay text to the toolbar area, including back/forward/reload
buttons, and the browser action/menu area. This should not interfere with
dragging and dropping of browser actions. Test that browser actions behave
as they should (i.e. should be able to change their order in the toolbar).
Review URL: http://codereview.chromium.org/6462009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59242
TEST=unit,sync_unit,sync_integration
Review URL: http://codereview.chromium.org/6465005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Should pass after the last WK roll (r75275).
TBR=podivilov@chromium.org
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
BUG=73289
Review URL: http://codereview.chromium.org/6531030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Having namespaces ui::gfx and just gfx are causing compiler disambiguation
problems. This will resolve that.
BUG=carnitas
TEST=compiles and gfx_unittests
Review URL: http://codereview.chromium.org/6533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a simple DOMUI interface to the HSTS list. Since the
list is stored, hashed in memory and on disk, there's no list of
entries. But the set can be queried and we can provide insertion and
deletion.
BUG=none
TEST=Open about:net-internals, goto HSTS tab.
Review URL: http://codereview.chromium.org/6500010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6507015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
disabled, as it timeouts, not fails.
BUG=73289
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
failing after WK roll.
BUG=73289
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=73287
TEST=UILayoutTest.MediaUILayoutTest
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Third attempt to land http://codereview.chromium.org/6409040/ -- now without memory leaks)
- cloud_policy.proto autogenerated from policy_templates.json
- C++ method decoding the protobuf also autogenerated from policy_templates.json
- changed policy fetching mechanism to fetch new-style policy protobufs
BUG=68309, chromium-os:11253, chromium-os:11255
TEST=CloudPolicyCacheTest.*; also manual test against python testserver
Review URL: http://codereview.chromium.org/6532019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70118
TEST=browser_tests
Review URL: http://codereview.chromium.org/6529021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11782
TEST=manual.
Review URL: http://codereview.chromium.org/6507039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This policy allows for locking the user to download files only to the specified location.
When the policy is set the UI elements should be inactive and the save dialog should never appear.
Changes in the Preferences.xib file only wire the enabled status of the download location and save prompt checkbox elements to a variable that tracks the managed state of the DefaultDownloadDir pref. No UI elements were harmed in this change.
BUG=59768
TEST=All old download manager tests shouldn't break. UI should behave correctly when policy is set.
Review URL: http://codereview.chromium.org/6525054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui.
BUG=59946, 59945
TEST=trybots
Review URL: http://codereview.chromium.org/6539004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we are ignoring path then it makes sense to ignore also a Query part.
If there are several matches: prefer currently selected tab.
BUG=chromium-os:11047
TEST=Manual
Review URL: http://codereview.chromium.org/6489002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, neither `.set` nor `.remove` give the user the
ability to take action after the asynchronous cookie
monster does its thing in the background. One can listen
for events, but can't distinguish between events generated
from one's own code, and events generated through
normal interaction with the web. This makes infinite
loops much easier to write than they should be. Callbacks
make that class of problem simpler to deal with.
BUG=70102
TEST=Check that `.set` and `.remove` callbacks are triggered.
Review URL: http://codereview.chromium.org/6525016
Patch from Mike West <mkwst@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We no longer need to sort input method IDs by names in EnableInputMethods()
as the input method IDs returned from GetInputMethodIdsFromLanguageCode()
are sorted per the whitelist.txt.
BUG=chromium-os:12252
TEST=keyboard switching on the login screen works as before
Review URL: http://codereview.chromium.org/6532016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change depends on http://codereview.chromium.org/6528043/.
BUG=chromium-os:11479
TEST=manual
Review URL: http://codereview.chromium.org/6526042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
spellchecker.
* Fix bug where Polish would always use Hunspell, even when the OS X native dictionary already has Polish support.
* Spruce up comments in spell_checker_mac.cc
BUG=69944
TEST=None
Review URL: http://codereview.chromium.org/6515001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/6534014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When it's necessary, we should use SwitchLanguageAndEnableKeyboardLayouts()
instead of SwitchLanguage().
BUG=chromium-os:12049
TEST=confirm that keyboard layouts are enabled as before on the login screen.
Review URL: http://codereview.chromium.org/6480110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is one of the patches for replacing Keyboard Overlay with new one.
BUG=chromium-os:6268,chromium-os:12111
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/6529015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
patch.
BUG=73200
TEST=none
Review URL: http://codereview.chromium.org/6534009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change brings in the recent changes of the key positions and sizes.
BUG=chromium-os:6268
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/6529045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
exposing getters for TC, routing_id, and sending messages.
Review URL: http://codereview.chromium.org/6537004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Open All Bookmarks
- Open All Bookmarks in New Window
- Open All Bookmarks in Incognito Window
BUG=56106
TEST=modify and add new tests into unit_tests. changes pass unit_tests
Review URL: http://codereview.chromium.org/6508017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Works around webkit bug 12519
BUG=73047
TEST=manual
Review URL: http://codereview.chromium.org/6507019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'protected' and 'unlimited' storage rights to chrome extensions and applications.
BUG=52357
TEST=extension_special_storage_policy_unittest.cc
Review URL: http://codereview.chromium.org/6299012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6334067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72363
TEST=none
Review URL: http://codereview.chromium.org/6537008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Merge HomeAddress into Address, since there are no other subclasses.
* Eliminate unhelpful wrapper functions
* Get rid of Apartment Number code, since we always store that as generic line 2 data.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6533011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
any plans when the last plan expires.
BUG=chromium-os:9945
TEST=When cellular data plan runs out, make sure that the no data left notification appears.
Review URL: http://codereview.chromium.org/6526057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to use the hidden property/attribute to get keyboard navigation working.
This regressed in r66954
BUG=None
TEST=On NTP
Right click one of the Apps
Press down/up keys it should select the next/previous menu item.
Review URL: http://codereview.chromium.org/6528026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12187
TEST=See issue
Review URL: http://codereview.chromium.org/6526039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6531001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73093
TEST=none
Review URL: http://codereview.chromium.org/6538001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75196 0039d316-1c4b-4281-b951-d872f2087c98
|