summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fixes bug in handling of openning background tabs by way of clickingsky@chromium.org2011-01-066-9/+18
| | | | | | | | | | | on omnibox. BUG=60553 TEST=see bug Review URL: http://codereview.chromium.org/6028010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70616 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect assertion following the move of Geolocation provider in to its ↵jknotten@chromium.org2011-01-064-20/+32
| | | | | | | | | | | | | | | own thread. Change r61182 <http://crrev.com/61182> moved the geolocation providers on to their own "Geolocation" thread. The experimental CoreLocation provider needs to be changed accordingly to send position updates to the Geolocation thread instead of browser thread. BUG=67311 TEST=None Review URL: http://codereview.chromium.org/6037016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70615 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] In modal JS dialogs with text fields, disable line breaks and just ↵rsesek@chromium.org2011-01-061-1/+2
| | | | | | | | | | | overflow the text box. BUG=65232 TEST=See reduced test case in bug. Review URL: http://codereview.chromium.org/6028013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70614 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression in upgrade detection in about dialog.grt@chromium.org2011-01-061-1/+1
| | | | | | | | | BUG=67478 TEST=Install SxS, start chrome, open about dialog, notice that it doesn't say to restart if there's no update. Review URL: http://codereview.chromium.org/6076008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70612 0039d316-1c4b-4281-b951-d872f2087c98
* Remove legacy non-client-based geolocation code.jknotten@chromium.org2011-01-063-49/+0
| | | | | | | | BUG=59907 Review URL: http://codereview.chromium.org/5938002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70602 0039d316-1c4b-4281-b951-d872f2087c98
* No-op change to trigger a buildfinnur@chromium.org2011-01-061-2/+2
| | | | | | | | | | | | (fix a typo in a random file) TBR=sky BUG=None TEST=None Review URL: http://codereview.chromium.org/6109002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70601 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate about:conflicts with --diagnosticsfinnur@chromium.org2011-01-0611-136/+273
| | | | | | | | | | | | | | | | | This should enable the user to find conflicting dlls that are crashing Chrome on startup. This changelist introduces a limited_mode for scanning, since the diagnostics tests run without the help of many Chrome services, so we can't use the File thread for asynchronous scanning or the notification system. Also changed the scanning so that if no signature/description is given in the blacklist, then we mark the DLL as a confirmed match if the name and the location match (before we used to match it as a 'suspected' match). A very sizable chunk of the blacklist is malware, which has no signature, so this gives us the ability to trigger the wrench badge on finding malware (that part remains opt-in through about:flags). Also added failure count to diagnostics output (sometimes the error scrolls off screen, so having a note at the bottom helps). BUG=51105 TEST=All diagnostics tests run as part of the unit tests. Review URL: http://codereview.chromium.org/6098004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70600 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UI-thread blocking issue in SetImeConfig.yusukes@google.com2011-01-063-31/+71
| | | | | | | | | | | Do not kill ibus-daemon before FlushImeConfig() since it can lead the ibus_config_set_value() call to block for 25 seconds (i.e. GDBus default timeout) when ibus-1.4 and GDBus libraries are in use. BUG=chromium-os:9685 TEST=manually with ibus-1.3 and 1.4. Review URL: http://codereview.chromium.org/6032005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70598 0039d316-1c4b-4281-b951-d872f2087c98
* This is follow-up CL forkochi@chromium.org2011-01-061-1/+1
| | | | | | | | | | | http://codereview.chromium.org/6057002/ BUG=chromium-os:10364 TEST=manually check if pulldown menu of apps on newtab page doesn't have 'create shortcut'. Review URL: http://codereview.chromium.org/6060003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo; unbreak official Win build.avi@chromium.org2011-01-061-1/+1
| | | | | | | | | | BUG=9911 TEST=Official Win builder builds. Review URL: http://codereview.chromium.org/6083013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70595 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to the remaining files under url_request directory.tfarina@chromium.org2011-01-0660-161/+190
| | | | | | | | | | | | It just adds the 'namespace net' to these files and a typedef for them, because there are many entries to fix in one pass. They will be fixed later. BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/6056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70592 0039d316-1c4b-4281-b951-d872f2087c98
* Printing: Get settings on the UI thread on all platforms.thestig@chromium.org2011-01-062-19/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6027007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70591 0039d316-1c4b-4281-b951-d872f2087c98
* [SYNC] HttpBridge's UrlFetcher should not send cookieszea@chromium.org2011-01-062-4/+1
| | | | | | | | | BUG=60227 TEST=unit Review URL: http://codereview.chromium.org/6093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70580 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Do not make folder editor dialog resizable.tfarina@chromium.org2011-01-061-0/+1
| | | | | | | | | BUG=None TEST=manual Review URL: http://codereview.chromium.org/6000011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70578 0039d316-1c4b-4281-b951-d872f2087c98
* Move remoting setup from the wrench menu to the advances options page.sergeyu@chromium.org2011-01-066-26/+54
| | | | | | | | | BUG=67218 TEST=None Review URL: http://codereview.chromium.org/5974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70577 0039d316-1c4b-4281-b951-d872f2087c98
* Chromoting setup flow: implemented rest of setup flow steps.sergeyu@chromium.org2011-01-0612-49/+440
| | | | | | | | | BUG=67218 TEST=None Review URL: http://codereview.chromium.org/6033005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70576 0039d316-1c4b-4281-b951-d872f2087c98
* [gtk] Fix a couple painting issues with infobar arrows.estade@chromium.org2011-01-062-0/+17
| | | | | | | | | | | | 1) repaint the arrow when the location icon moves. The location icon can move, for example, when the home button is added or removed. 2) paint the arrow on top of the location icon explicitly. This is necessary because sometimes the location icon sits in a different X window from the toolbar, and we cannot paint over it in the toolbar's expose event. In particular, try going to paypal.com and then crashing flash. Without this patch, the top of the arrow will be lopped off. BUG=68457 TEST=manual Review URL: http://codereview.chromium.org/6056010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70574 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for the Remoting setup flow.sergeyu@chromium.org2011-01-0614-110/+316
| | | | | | | | | | | | | | 1. Add gaia_login.html and setup_flow_error.html resources. 2. Add SetupFlowErrorStepBase for errors. 3. More flexible message handling. 4. Support for multiple message handlers in ServiceProcessControl. BUG=67218 TEST=Unittests. Review URL: http://codereview.chromium.org/6064006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70573 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add metrics for various accelerators.derat@chromium.org2011-01-065-6/+83
| | | | | | | | | | | | | | | | | | This adds reporting of the accelerators used to invoke various actions (e.g. Back can be invoked by Alt-Left, Backspace, or F1 on Chrome OS). These stats will be used as input for future keyboard designs. Also removed the F5 "System options" accelerator, which is a no-op -- Chrome never sees this key since the window manager grabs it. BUG=chromium-os:10403 TEST=replaced the metrics calls with logging statements and checked that they were executed when expected Review URL: http://codereview.chromium.org/6035010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70572 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix issue where multiple calls to showNotification was broken.arv@chromium.org2011-01-061-7/+7
| | | | | | | | | BUG=68432 TEST=Manually by calling showNotification multiple times. Review URL: http://codereview.chromium.org/5985011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70568 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix issue with the calculation of the index of a list item.arv@chromium.org2011-01-061-1/+2
| | | | | | | | | | | This fixes issues where list items cannot be selected when zoomed out a bit. BUG=68670 TEST=Zoom out and select bookmarks Review URL: http://codereview.chromium.org/5978008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 6.avi@chromium.org2011-01-0637-315/+433
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6056009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70565 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the user to choose which corner of the screen should get notifications.johnnyg@chromium.org2011-01-0617-42/+397
| | | | | | | | | BUG=none TEST=create notifications, use the options menu Review URL: http://codereview.chromium.org/6006007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70564 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::BaseName instead of the deprecated ↵tfarina@chromium.org2011-01-061-1/+1
| | | | | | | | | | | file_util::GetFilenameFromPath. Part 4. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6097002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70563 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent Notifications on Mac from bringing main browser window to the top ↵dimich@chromium.org2011-01-064-49/+25
| | | | | | | | | | | | when clicked. The only relevant Notification.xib change: added a custom transparent view backed by BalloonOverlayViewCocoa class on top of the whole Notification balloon, so it gets first crack at mouse messages. The view is using springs to autoresize in both dimensions. BUG=68589 TEST=none Review URL: http://codereview.chromium.org/6105001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70562 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the crash in about:sync code. This was caused by a race condition.lipalani@chromium.org2011-01-062-0/+10
| | | | | | | | | BUG=65370 TEST= Review URL: http://codereview.chromium.org/6074006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70561 0039d316-1c4b-4281-b951-d872f2087c98
* Linux, webui: do file access on the file thread when the "change proxy ↵mdm@chromium.org2011-01-062-30/+73
| | | | | | | | | | settings" button is pressed. BUG=63690 TEST=webui version does not crash in debug builds, native version no longer needs temporary exception Review URL: http://codereview.chromium.org/5969011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70557 0039d316-1c4b-4281-b951-d872f2087c98
* fixing the case of duplicate profiles.lipalani@chromium.org2011-01-054-105/+84
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6047006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70556 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Textfield::Keystroke with views::KeyEvent.oshima@chromium.org2011-01-0534-95/+91
| | | | | | | | | | | | | It looks big, but most of change is simple signature change. Note: I need your advice on how to deal with WM_CHAR event on Win. Please see my comment below. BUG=none TEST=no new functionality. All tests should still pass. Review URL: http://codereview.chromium.org/6034002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70553 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure the description 'Google Search' is set on the first searchsky@chromium.org2011-01-053-16/+124
| | | | | | | | | | | match. BUG=64375 TEST=see bug Review URL: http://codereview.chromium.org/6053010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70551 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last usage of wstring from Linux build, fix official builders.avi@chromium.org2011-01-051-6/+6
| | | | | | | | | BUG=9911 TEST=Official Linux builders build Review URL: http://codereview.chromium.org/6065015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70547 0039d316-1c4b-4281-b951-d872f2087c98
* In the sync integration tests, test timestamps for equality rather than ↵nick@chromium.org2011-01-052-37/+60
| | | | | | | | | | | using less-than comparison. This is to prepare for a switchover to token-based timestamps, where less-than comparison is not supported. BUG=58217 TEST=sync integration tests Review URL: http://codereview.chromium.org/3810007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70544 0039d316-1c4b-4281-b951-d872f2087c98
* Use ListSingleSelectionModel for content settings exceptions lists.estade@chromium.org2011-01-052-1/+2
| | | | | | | | | BUG=64153 TEST=none Review URL: http://codereview.chromium.org/6002016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70543 0039d316-1c4b-4281-b951-d872f2087c98
* Add several helper functions.lzheng@chromium.org2011-01-051-279/+233
| | | | | | | | | BUG=none TEST=safe_browsing_database_unittest.cc stays green. Review URL: http://codereview.chromium.org/6011008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70542 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "inspect element" for chrome:// pages.estade@chromium.org2011-01-051-10/+0
| | | | | | | | | | | It's already possible to open the js debugger for these pages via the wrench menu, so disabling "inspect element" is just a nuisance. Also, there's no obvious reason in my mind why it should be different for debug/release (I do most of my domui development in release as it's faster to build and easier to use the debugger). BUG=none TEST=manual Review URL: http://codereview.chromium.org/6094007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70540 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics regular expressions should be stored in external data files.dhollowa@chromium.org2011-01-057-66/+216
| | | | | | | | | | | This change moves the Autofill heuristics regular expressions out to a new autofill_resources.grd file. This grd file is not meant to be localized. Eventually it will contain the locale-specific regular expressions as well as the English versions. This CL, however, just moves the English versions out of source. BUG=55787 TEST=FormStructureBrowserTest.HTMLFiles Review URL: http://codereview.chromium.org/6026010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70535 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Don't skip words when user clicks ignore in the spelling panelsail@chromium.org2011-01-051-7/+1
| | | | | | | | | | | | | | | Clicking Ignore in the spelling panel would skip misspelled words. The problem was that the Chromium code and the spell checker were both advancing to the next word. This caused us to advance twice instead of once. Fix was to simply remove the Chromium code that was advancing to the next word. BUG=68557 TEST=Downloaded version 9.0.597.19 of Google Chrome and verified that the bug existed on both 10.5 and 10.6. Applied my patch and verified that pressing ignore worked correctly on both 10.5 and 10.6. Review URL: http://codereview.chromium.org/6103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70532 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 5.avi@chromium.org2011-01-0527-127/+164
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6023012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70530 0039d316-1c4b-4281-b951-d872f2087c98
* Update the HTML source to use the CSS3 syntax for gradients.arv@chromium.org2011-01-0525-274/+135
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6079010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70528 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PipelineImpl to use CompositeFilter to manage Filter state transitions.acolwell@chromium.org2011-01-051-1/+1
| | | | | | | | | | | BUG=54110 TEST=media_unittests CompositeFilterTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70267 Review URL: http://codereview.chromium.org/5744002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70527 0039d316-1c4b-4281-b951-d872f2087c98
* Uses bool WebKit::WebWidget::confirmComposition(const WebString& text).suzhe@google.com2011-01-051-4/+2
| | | | | | | | | | | | | | | | | | | | Before this CL, following events will be received by the web page when a text is inserted by an IME: compositionstart compositionend textInput With this CL, the web page will only receive textInput event. See also: https://bugs.webkit.org/show_bug.cgi?id=51693 BUG=none TEST=none Review URL: http://codereview.chromium.org/5999012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70525 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Unselect all list items when the Autofill lists are blurred.jhawkins@chromium.org2011-01-051-0/+28
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5977011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70520 0039d316-1c4b-4281-b951-d872f2087c98
* Move lots of GMock stuff out of line.erg@google.com2011-01-0519-51/+172
| | | | | | | | | | | | | | Nico did some treemapping of our build time on Mac, and (surprise!) gmock unittests dominated. Gmock works with several large, heavy templates, and previous patches that out of line the ctors/dtors have significantly sped up compilation (e.g.GLMock) and have reduced thrashing. Nico says I should plug this again: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts BUG=none TEST=none Review URL: http://codereview.chromium.org/6056008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70516 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DelayedMenuButton by merging it into MenuButton.rsesek@chromium.org2011-01-0512-275/+175
| | | | | | | | | | | | XIB Changes: * Switch the back/forward buttons to be MenuButtons instead of DelayedMenuButtons. BUG=32094 TEST=Back/forward buttons and menu still work. Wrench menu still works. Review URL: http://codereview.chromium.org/5995004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70512 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix spelling panel not refreshingsail@chromium.org2011-01-051-1/+4
| | | | | | | | | | | | | On 10.6 the spelling panel wouldn't refresh correct when moving to the next word. The problem was that updateSpellingPanelWithMisspelledWord: wasn't being called from the main thread. BUG=52479 TEST=Performed spell check on 10.6 and verified that the spelling panel correctly refreshed. Review URL: http://codereview.chromium.org/6078011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70511 0039d316-1c4b-4281-b951-d872f2087c98
* Make searchBox.value and searchBox.verbatim available during initial page load.tonyg@chromium.org2011-01-052-26/+54
| | | | | | | | | BUG=66104 TEST=interactive_ui_tests --gtest_filter=InstantTest.* Review URL: http://codereview.chromium.org/5974009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70510 0039d316-1c4b-4281-b951-d872f2087c98
* Minimize login promptscbentzel@chromium.org2011-01-053-31/+397
| | | | | | | | | | | | | | | | | | LoginHandler can receive useful notifications from the same NavigationController. Excluding them can trigger spurious login dialogs for the same target. Also, re-order authentication dialog cancellations to prevent unnecessary dialogs from being shown to the user. BUG=51570 TEST=LoginPromptBrowserTest.* Contributed by: asanka@google.com Review URL: http://codereview.chromium.org/5814005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70509 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of NavigationController from NavigationEntry so NavigationEntry ↵pinkerton@chromium.org2011-01-055-25/+22
| | | | | | | | | | can be used independently. BUG=none TEST=page titles in back/foward menu, tabs Review URL: http://codereview.chromium.org/5976015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70506 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove unnecessary includes from scoped_handle_win.htfarina@chromium.org2011-01-051-1/+2
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5988009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70500 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for speex to get gyp changes for use_system_speex:phajdan.jr@chromium.org2011-01-051-1/+1
| | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=70427 Convert all users to the shim header for speex. BUG=68524 TEST=none Review URL: http://codereview.chromium.org/5968013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70499 0039d316-1c4b-4281-b951-d872f2087c98