| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deleted/cancelled, the delegate should never be called again.
(The text added to URLRequest::Cancel() was copied from URLRequest::~URLRequest()).
The comment change in resource_dispatcher_host.cc is an unrelated name fix.
TEST=0
BUG=0
Review URL: http://codereview.chromium.org/118151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/119050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=ben
Review URL: http://codereview.chromium.org/118184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only.
Enables the PasswordStore refactoring yet again (third time's the charm?).
BUG=12479
TEST=Password save/autofill should continue to work on Windows.
Review URL: http://codereview.chromium.org/118131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox)
Review URL: http://codereview.chromium.org/119016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window with two tabs. Drag one of those tabs in and out of the window's tabstrip many times. Open a new window and drag a tab into that window's tabstrip.
Review URL: http://codereview.chromium.org/118142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
base/gfx/gtk_util merge.
BUG=none
TEST=Linux compile turns green.
Review URL: http://codereview.chromium.org/119111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Originally, FocusManager automatically unregisters an old target if multiple AcceleratorTargets are registered to the same accelerator. This behavior is somewhat troublesome, and actually ShelfItemDialog hits a run-time assertion due to the conflict of registrations (issue 12401). This change modifies the behavior of FocusManager to allow multiple targets to be registered for each accelerator.
BUG=12401
TEST=See if issue 12401 is resolved.
Review URL: http://codereview.chromium.org/114065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the task manager view is added.
http://crbug.com/12927
TEST=open the task manager, should work
Review URL: http://codereview.chromium.org/119105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
That's what the function does, and some callers that had nothing to do with
plugins were calling GetPluginNativeView.
Review URL: http://codereview.chromium.org/118094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=willchan
Review URL: http://codereview.chromium.org/118183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box.
Review URL: http://codereview.chromium.org/119002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Display stuff in the right pane. Also fix a bug I introduced in the last patch.
Review URL: http://codereview.chromium.org/118178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r17517.
TBR=willchan
Review URL: http://codereview.chromium.org/119100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erg
Review URL: http://codereview.chromium.org/118180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=willchan
Review URL: http://codereview.chromium.org/118177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows you to edit the bookmark title, and remove the bookmark.
BUG=11738
TEST=Click the bookmark star, you should be able to edit the bookmark title
and remove the bookmark.
Review URL: http://codereview.chromium.org/119079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it able to drag star even when the contents of address bar is modified.
This change makes the behavior of two different bookmarking operation, starring
and drag-and-drop, consistent.
Currently, bookmarking a page with no title by clicking star creates a bookmark
entry with an empty string as its name field, while dragging star to bookmark
manager uses URL for name field. As suggested in BUG5965, the behavior of
dragging star is better.
I've replaced the code in Browser::BookmarkCurrentPage (one for clicking star)
with the code in BrowserToolbarView::WriteDragData (one for dragging star) to
fix this issue. The former uses NavigationEntry::title() which returns an empty
string, while the latter uses TabContents::GetTitle() which returns URL
Additionally, I've made the check done in
BrowserToolbarView::GetDragOperations() and Browser::BookmarkCurrentPage() such
as ToolbarViewModel::ShouldDisplayURL() consistent. Following the suggestion by
glen, I've removed ToolbarViewModel::input_in_progress() from the check.
TEST=Bookmark page with no title by clicking star and see that the bookmark
entry has the URL for its name field.
BUG=5965
Original review: http://codereview.chromium.org/113942
Patch by tyoshino@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server response.
TEST=Adds "ja" to Accept-Language, accesses
http://www.xn--w22as22a.haun.org/empty.pl, which takes 10 seconds to response,
and confirms "Waiting for ..." message has Unicode host name.
BUG=3991
Original review URL: http://codereview.chromium.org/118070
Patch by tkent@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we enter an address that redirects to some other page to the address box,
it should show the address where we are redirected to after navigation
completes. Currently, it doesn't when we follow this procedure more than once
as described in BUG 5374.
After redirection, the renderer says that it navigated to the same page by
returning existing page_id in ViewHostMsg_FrameNavigate_Params, but
NavigationController::ClassifyNavigation() compares params.url with
pending_entry_->url() and says it's not SAME_PAGE. Therefore, the result is
not correctly treated and goes into EXISTING_PAGE handler. It compares
the existing entry for the page with pending_entry_. It's false, so it doesn't
call DiscardNonCommittedEntriesInternal(). pending_entry_ left not released.
Toolbar's view uses this pending_entry_'s url for showing address on the
address bar.
We should not check URL. Just overwrite entry_ with the response from renderer.
TEST=
Access http://www.google.com , https://www.google.com , and then
https://www.google.com . The address bar should show http://www.google.com .
Prepare some site http://example.com which redirects to http://example.org ,
and then access http://example.com , and then change the redirection to
http://example.net . Retry accessing http://example.com . The address bar
should show http://example.net .
BUG=5374
Original review: http://codereview.chromium.org/115916
Patch by tyoshino@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dictionaries, which allows us to specify properties per plugin.
This is the first part of allowing extensions to have plugins only accessible
by the extension process.
BUG=12960
Review URL: http://codereview.chromium.org/114072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=slightlyoff
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Navigate to a URL with an elided title in the tab. Hover the mouse over the tab. A tooltip should appear with the full title. Navigate to google.com and hover over the tab. A tooltip should not appear (unless the tab is small enough).
Review URL: http://codereview.chromium.org/118161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
match the toolbar, and making the button images transparent.
BUG=11703
TEST=Verify that the download bar matches the theme that is installed.
Review URL: http://codereview.chromium.org/119088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12467
TEST=Apply a theme and verify that bookmark bar text colors changes.
Review URL: http://codereview.chromium.org/112092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
need the focus manager to achieve tabbing in and out of the chrome frame widget.
The other change is to add a check for a NULL container window when the tab contents is being freed.
This causes an assert to fire in the focus manager code while trying to unsubclass the window.
Review URL: http://codereview.chromium.org/119074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows password_form_manager_unittest.cc and search_provider_unittest.cc
to run on linux/mac.
Review URL: http://codereview.chromium.org/118137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also add icons to bookmark tree model.
Review URL: http://codereview.chromium.org/118150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BlockedPopupContainer
into something that can be cross-platform."
This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483).
Review URL: http://codereview.chromium.org/118166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BlockedPopupContainer into something that can be cross-platform.
- BlokedPopupContainers are no longer ConstrainedWindows.
- There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement.
Review URL: http://codereview.chromium.org/119006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also adds more explicit #includes for needed things.
Review URL: http://codereview.chromium.org/118162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parents.
A commit on behalf of tangjie: (already reviewed)
http://codereview.chromium.org/113671
BUG=http://code.google.com/p/chromium/issues/detail?id=11901
TEST=click anywhere in the extension bar and note whether this also gets counted as a click on the tab that's directly above it veritcally.
Review URL: http://codereview.chromium.org/119065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hood" view into the window.
BUG=13151
TEST=enabled portions of the user data panel.
Review URL: http://codereview.chromium.org/119060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements InspectorClient's API for reading / writing inspector settings. Here is how this is done:
- inspector_client_impl.cc caches / serializes preferences into raw strings. It supports all kinds of settings except for string vector. I did not implement it since a) it requires more escaping b) I think we should get rid of it upstream. It then passes serialized settings string over IPC.
- There is a dedicated IPC message called UpdateInspectorSettings that takes care of settings update.
Two things I don't like:
1) reading settings and writing settings follow different paths: WebPreferences interface for read, delegate -> IPC for write. WebPreferences on read is used since these settings are needed very early in the page cycle. delegate -> IPC on write is the only option.
2) this looks like too much code on the Chrome side for functionality like this. Is there a more generic way of settings and persisting WebKit's preferences in Chrome? Should there be one?
Review URL: http://codereview.chromium.org/119041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally set the transient on the InfoBubble dialog window.
BUG=11738
Review URL: http://codereview.chromium.org/119042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This means there are no longer two objects to keep around, the widget
and the wrapper C++ object. This simplifies ownership in hierarchies.
Review URL: http://codereview.chromium.org/118116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- miscellanous cleanups (add missing includes for OS_ defines etc)
Further changesets may follow. I was only looking at header files up to character_encoding.h.
Review URL: http://codereview.chromium.org/118072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_util::InsertBeforeExtension(wstring*, wstring&)
file_util::PathComponents(wstring&, vector<wstring>*)
file_util::ReplaceExtension(wstring*, wstring&)
BUG=none
TEST=manual test for importing IE bookmarks with some sub-directories.
Original patch by tkent@google.com.
See http://codereview.chromium.org/118109
r=ojan,estade
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When viewing a local text file with spaces in filename, it is still urlencoded. Filename should be displayed with spaces, not with urlencoding. It would be more user-friendly.
Since net::FormatURL is already implemented, using it would be great. But it doesn't escape SPACES, just NORMAL, it doesn't even escape unicode. I plumbed out a unescapeurl that could be used whether we allow conversion of spaces or not.
BUG=8775 (http://crbug.com/8775)
TEST=Tested whether the input is escaped in the navigational context and ran the net tests
New Review: http://codereview.chromium.org/118059
Review URL: http://codereview.chromium.org/56053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This test was disabled because it started failing, however it's
passing on the tryservers now so we'll give it another chance.
BUG=9600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12426
TEST=From the New Tab Page (NTP), click the Remove thumbnails link, remove thumbnails but don't press the Done button. Navigate to a URL (ex: www.google.com). Navigate to the NTP again, the thumbnails removed previously should still be showing. Also test that removal works properly when pressing the Done button.
Review URL: http://codereview.chromium.org/118119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main part of this change is DoesBookmarkContainWords() in
bookmark_utils.cc. It tries to match a query words to IDN and
%-decoded strings as well as ASCII URL.
BUG=3991
TEST=add a unit test, check for IDN in the search box of Bookmark
Manager.
Checked in for tkent@google.com.
Original review: http://codereview.chromium.org/113815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of at the end of the strip. This was because the LINK transition type triggered the TabStripModel to apply heuristics about where to open the URL, even though all URLs opened from the address bar should bypass these heuristics. There were already hooks on the low-level functions to bypass the heuristics, I just had to expose them one level higher. This meant an expansion to one of the TabContentsDelegate function's argument list, hence the number of files touched. (This seems like a good capability to expose anyway, though.)BUG=6797TEST=Have multiple tabs in your tab strip. Select the first tab, paste in a URL, and hit alt-enter. The newly opened tab should appear at the far end of the strip.
Review URL: http://codereview.chromium.org/118038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
display properties to themes (stored internally as ints/enums, but parsed from text).
BUG=12768
TEST=Install a theme with an new tab page background and verify that the background appears on the new tab page.
Review URL: http://codereview.chromium.org/115910
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17431 0039d316-1c4b-4281-b951-d872f2087c98
|