| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
to "Show in folder" that launches native file browser.
BUG=32277
TEST=None
Review URL: http://codereview.chromium.org/3593005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=59603
TEST=Have an extension add several context menu items. Verify that the context
menu properly shows the extension's icon. Now call chrome.contextMenus.remove
repeatedly to remove all the items. Then add one or more new ones. The icon
should still show up properly, and not revert to the default puzzle piece
icon.
Review URL: http://codereview.chromium.org/4170008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2720002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5667
TEST=manual
Review URL: http://codereview.chromium.org/4218003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=nickcarter
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4188007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR:nkostylev@chromium.org
3rd attempt to land http://codereview.chromium.org/4003006
BUG=chromium-os:7971
TEST=Login and examine /tmp/login-times-sent
Review URL: http://codereview.chromium.org/4141009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
retry of failed sends on feedback reports.
If the initial send fails, the first retry will be in 15 minutes after the
attempt. The next attempt will be in 30 minutes and the time will double till
we hit a 4 hour delay - the send will be then retried every 4 hours till the
Chrome instance is up.
BUG=cros:6331
TEST=Tested with up to 25 reports at a time, with varying network connectivity
(via pulling out the network cable); report data verified on the feedback
server.
Review URL: http://codereview.chromium.org/4027005
TBR=rkc@chromium.org
Review URL: http://codereview.chromium.org/4096007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the initial send fails, the first retry will be in 15 minutes after the
attempt. The next attempt will be in 30 minutes and the time will double till
we hit a 4 hour delay - the send will be then retried every 4 hours till the
Chrome instance is up.
BUG=cros:6331
TEST=Tested with up to 25 reports at a time, with varying network connectivity
(via pulling out the network cable); report data verified on the feedback
server.
Review URL: http://codereview.chromium.org/4027005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread.
Add several other DCHECKs to protect other members
BUG=61105
TEST=ExtensionManagementTest.ExternalUrlUpdate,extensionsServiceTest.UpdatePending*
Review URL: http://codereview.chromium.org/4190010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
single-process mode. This asserts when the cache is cleared.
Review URL: http://codereview.chromium.org/4165007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
surface.
Currently, this is only used to DCHECK a currently implicit invariant, but I want to use this to let every surface container only remember its last painted-to surface, and not its last created surface.
No behavior change.
BUG=53165
TEST=none
Review URL: http://codereview.chromium.org/4142004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also re-enabled this test.
BUG=46601
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/4106006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48086,60781
TEST=Open the Page Info bubble and the Content Settings bubble. Each close when switching tabs.
Review URL: http://codereview.chromium.org/4111007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60946
TEST=none
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/4154006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
buttons.
BUG=46652
TEST=Switch back and forth between themes that put the buttons on different sides of the window frame (try Ambiance and Clearlooks). Incognito windows should move the spy guy back and forth.
Review URL: http://codereview.chromium.org/4177007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59531
TEST=browser_tests
Review URL: http://codereview.chromium.org/4100008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
empty profile, import ignores FF data and imports from Safari instead.
BUG=61112
TEST=see bug.
Review URL: http://codereview.chromium.org/4206002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Most functions moved to chrome/browser/gtk/gtk_util.h because they're only
used within chrome/browser.
* BGRAToRGBA() is used within chrome/ and app/ so moved it to base/gtk_util.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4170002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4145007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created a new GTK widget that gives us more control over when X windows (associated with GL contexts) are created and destroyed. This achieves the same thing as the overlay code (now reverted). It fixes two regressions with the overlay code:
- maps.google.com and html5test.com now work (switching between software and hardware rendering)
- expose events now get through in accelerated mode
BUG=58862,59887
TEST=Go to html5test.com. Should switch contents to show results. Disable compositing window manager. Go to http://peter.sh/2010/06/chromium-now-features-gpu-acceleration-and-css-3d-transforms/. Adjust the rotate z slider to enable accelerated compositing. Drag a different window over top. Redraws should happen.
Review URL: http://codereview.chromium.org/3973009
Patch from Jonathan Backer <backer@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
heuristics.
BUG=57105
TEST=FormStructureTest.HeuristicsHiddenFields
Review URL: http://codereview.chromium.org/4193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This works around a wicked new clang linker optimization, but also feels cleaner in general.
BUG=http://llvm.org/bugs/show_bug.cgi?id=8478
TEST=clang/mac builder stays green with newer clang version
Review URL: http://codereview.chromium.org/4191003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tests fixed.
Revert 64252 - The ChromeFrame objects now provides an unfrozen interface called IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object.
Review URL: http://codereview.chromium.org/3541017
TBR=hansl@google.com
Review URL: http://codereview.chromium.org/4134008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c2bafbefa8022337ba9520fd9a2f64fd2cd4c52f.
BUG=none
TEST=build bot should cycle green
Review URL: http://codereview.chromium.org/4119015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Throws an error in port.postMessage if the port has already been disconnected.
3. Sets lastError when tabs.sendRequest can't connect to the tab.
BUG=27565, 32899
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3676008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53934
TEST=Manually
Review URL: http://codereview.chromium.org/4185007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* cleaned up code that are no longer in use.
BUG=chromium-os:5763
TEST=maual. pressing shutdown button on login/locker will shutdown the system.
Review URL: http://codereview.chromium.org/4054001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60149
TEST=None
Review URL: http://codereview.chromium.org/4216001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Auto whitelist all existing users when owner unchecks "allow anyone
to sign in";
- Move IsEmailInCachedWhitelist into a static method of user settings
provider so that it could be shared;
BUG=chromium-os:7941
TEST=Verify fix for chromium-os:7941.
Review URL: http://codereview.chromium.org/4093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/4136002/show
BUG=http://code.google.com/p/chromium-os/issues/detail?id=8114
TEST=All of the network menu
Review URL: http://codereview.chromium.org/4210002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8095
TEST=Click on user pod.
Review URL: http://codereview.chromium.org/4100006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_.
BUG=28372,32048,32070,35341,45561,48544,48562,52858
TEST=N/A
Review URL: http://codereview.chromium.org/4087009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
new tabs.
BUG=914 (http://code.google.com/p/nativeclient/issues/detail?id=914)
TEST=none
Relied on trybots and manually checking "about:histograms"
Review URL: http://codereview.chromium.org/4065005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60713
TEST=Configure policy to disable sync, start chrome. Observe that it doesn't crash right away!
Review URL: http://codereview.chromium.org/4127008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dimich@chromium.org
BUG=61097
TEST=none
Review URL: http://codereview.chromium.org/4184005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removes use of labels and unique_ids in the testing_automation_provider
BUG=58813
TEST=none
Review URL: http://codereview.chromium.org/4192005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr@chromium.org
BUG=57158
TEST=none
Review URL: http://codereview.chromium.org/4154005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object.
Review URL: http://codereview.chromium.org/3541017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org,fishd@chromium.org
BUG=61092
TEST=none
Review URL: http://codereview.chromium.org/4217001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr@chromium.org
BUG=57158
TEST=none
Review URL: http://codereview.chromium.org/4095010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
TEST=trybots
Review URL: http://codereview.chromium.org/4097010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli@chromium.org
BUG=50025
TEST=none
Review URL: http://codereview.chromium.org/4100010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CAPTCHA correctly
BUG=chromium-os:7867
TEST=unit tests, install on device and verify that you can clear the CAPTCHAd state for a HOSTED account, and still see the appropriate log message.
Review URL: http://codereview.chromium.org/4109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Incognito mode.
BUG=chromium-os:6907
TEST=Enter Guest mode, open new tab. Check opened page.
Review URL: http://codereview.chromium.org/4010004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/4179001/show
7. Textfield - focus border issue
9. Textfield - font size
11. Sign in - h padding
13,14 Link text & color.
Button minimal width - 90px.
BUG=chromium-os:8101
TEST=manual
Review URL: http://codereview.chromium.org/4156005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
assigned.
Make proxy settings work on welcome screen in chromium OS.
BUG=http://crosbug.com/3062
TEST=Manual
Review URL: http://codereview.chromium.org/3860001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8095
TEST=Click on Guest pod.
Review URL: http://codereview.chromium.org/4103006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preference is managed.
BUG=49607
TEST=none
Review URL: http://codereview.chromium.org/4170006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8099
TEST=manual
Review URL: http://codereview.chromium.org/4205001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
algorithms via the command-line argument --ssl-alg.
BUG=58831
TEST=Run test_server.py as an HTTPS server with --ssl-alg=rc4. Connect via openssl s_client -connect 127.0.0.1:1337 -cipher DEFAULT:\!RC4. Observe a connection failure. Connect with openssl s_client -connect 127.0.0.1:1337, observe that a ciphersuite that uses RC4 is negotiated.
Review URL: http://codereview.chromium.org/3812007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64233 0039d316-1c4b-4281-b951-d872f2087c98
|