summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* When I added some new tests in automated_ui_tests I flushed out a crash in ↵finnur@google.com2008-08-131-5/+6
| | | | | | the IDC handler for ViewSource. If Navigate is not called before ViewSource we get a crash when trying to use the output from GetLastCommittedEntry(). To facilitate automatic testing We should instead just check it for null and only do something if a URL is available to us. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@779 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix regression from previous change to toolbar - forgot to take into ↵beng@google.com2008-08-131-0/+1
| | | | | | | | | account the width of the Go button when sizing the location bar so that the last button on the toolbar (the app menu) spilled off the end. TBR=glen git-svn-id: svn://svn.chromium.org/chrome/trunk/src@774 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the toolbar/location bar look nice in popup windows.beng@google.com2008-08-134-67/+104
| | | | | | | | Rather than creating a frankenstein separate window type for popups, this just uses BrowserView2, and the regular BrowserToolbarView, but hides all the irrelevant controls. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@770 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of metrics to help us quantify two cases that can prevent us to ↵cpu@google.com2008-08-134-32/+77
| | | | | | | | | get crash reports. - Added env_vars to exe project instead of keep duplicating the strings. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@766 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of RootView. Removes unused double_buffered field fromsky@google.com2008-08-124-4/+4
| | | | | | | | | | | RootView, as well as renaming RootView::ProcessPendingPaint to PaintNow. BUG=1255929 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@750 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the Delayed UI test so the tree will be green.tc@google.com2008-08-121-1/+1
| | | | | | TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@747 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bit of plumbing to make it so Browser doesn't need to know about ↵ojan@google.com2008-08-123-5/+21
| | | | | | | | RenderViewHost. Don't know how what I had before built. Tested more thoroughly this time. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@732 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser\render_view_host_manager.cc to SCons build.sgk@google.com2008-08-121-0/+1
| | | | | | TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@731 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new Thread::StopSoon() facility. Add a new tight loop to control the ↵maruel@google.com2008-08-124-32/+66
| | | | | | | | worker thread shutdown in a way that is safe even for printer driver that displays a dialog box and attaches to the browser window. BUG=1274015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@729 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few places that wind up using Lock recursively.erikkay@google.com2008-08-124-82/+94
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@725 0039d316-1c4b-4281-b951-d872f2087c98
* Revert this CL. Breaks compile.ojan@google.com2008-08-123-21/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@724 0039d316-1c4b-4281-b951-d872f2087c98
* Add some printing related unit tests.maruel@google.com2008-08-124-0/+293
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@721 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bit of plumbing just so Browser doesn't need to know about RenderViewHost.ojan@google.com2008-08-123-5/+21
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@720 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an invalid DCHECK. If we are closing the browser andojan@google.com2008-08-121-1/+0
| | | | | | | the beforeunload handler hangs, then is_waiting_for_unload_ack will be true here. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@719 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHost management out of WebContents into a newbrettw@google.com2008-08-1215-1221/+1639
| | | | | | | | | | | | | | RenderViewHostManager object. The goal for this patch is to change no logic or APIs, just move the code. So there are some not very clean callback functions and no new unit tests for this file (although is is still covered by the same WebContents unit tests). This should make the actual cleanup in a later pass much easier to follow. I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup a few files, reduce the number of includes.maruel@google.com2008-08-123-6/+7
| | | | | | | | Applied glint. No code change, just moving around. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@713 0039d316-1c4b-4281-b951-d872f2087c98
* Change the ProxyService to work with ASCII strings.darin@google.com2008-08-121-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@711 0039d316-1c4b-4281-b951-d872f2087c98
* Fiddle with destruction order of the dragged tab controller to ensure that ↵beng@google.com2008-08-121-0/+3
| | | | | | | | | there's still a TabStrip available for it. B=1145714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@708 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash due to race condition in ImportingProgressView.finnur@google.com2008-08-121-1/+1
| | | | | | | | | | | | What is happening is that the ImporterView creates an ImportingProgressView to show the progress of the import but the ImportingProgressView receives the Cancel event before ImportStarted, so importing_ is not set to true. Cancel will think import is done and returns true (allowing the view to be destroyed) and then the ImporterView will try to communicate with a dead observer. By initializing importing_ to true this crash is avoided (we wouldn't be creating the view unless we were about to import, right?). BUG=1320194 TEST=Open Import dialog, press Enter and then Esc really quickly and Chrome should not crash (try it 10 times to be sure). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@702 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the SafeBrowsing database version to 3, to reset everyone's databaseifette@google.com2008-08-121-1/+1
| | | | | | after we had database corruption last week from bad data being served git-svn-id: svn://svn.chromium.org/chrome/trunk/src@695 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling sync_channel in the browser to allow accessibility code making ↵jcampan@google.com2008-08-126-6/+32
| | | | | | | | | blocking calls. This replaces my previous CL that was somehow duplicating some of these functionalities. BUG=None TEST=Run the unit tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@691 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build updates:sgk@google.com2008-08-121-0/+1
| | | | | | | | | | | | | * Add base\file_util_linux.cc. * Add unit tests base\{idletimer,string_escape}_unittest.cc. * Add chrome\browser\views\hwnd_html_view.cc. * Add chrome\browser\tabs\tab_dragging_test.cc. * Add chrome\browser\views\bookmark_bar_view_test.cc * Add chrome\test\ui\view_event_test_base.cc. * Only define on Windows build of base: _Win32_WINNT=0x0600, WINVER=0x0600, _HAS_EXCEPTIONS=0. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@688 0039d316-1c4b-4281-b951-d872f2087c98
* Don't terminate the process when a tab becomes unresponsive during ojan@google.com2008-08-114-24/+14
| | | | | | | | | | | | | unload/beforeunload. Instead, just call close on it. If two tabs are in the same process, then terminating the process is totally wrong. This also avoids the bugs where we show sad tab, or don't remove the tab from the tabstrip. Also, remove a couple of bogus DCHECKS. BUG=1314995,1301757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@685 0039d316-1c4b-4281-b951-d872f2087c98
* If a sync message can't be routed, respond immediately with an error.ojan@google.com2008-08-111-2/+7
| | | | | | | This will allow us to process alerts correctly if they happen after the tab has been closed in the browser process. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@679 0039d316-1c4b-4281-b951-d872f2087c98
* Move Tab Drag Tests inside Project interactive_ui_testssidchat@google.com2008-08-111-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@675 0039d316-1c4b-4281-b951-d872f2087c98
* If the user runs chrome with a language on the command line ontc@google.com2008-08-111-4/+11
| | | | | | | | | | | | | first-run, make sure we pass that language to the importer process. The code for this is basically a copy of what is in chrome/browser/render_process_host.cc:291. TEST=Run "chrome --lang=ko --first-run" and import settings during first run. Make sure the importer dialog is in Korean. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@673 0039d316-1c4b-4281-b951-d872f2087c98
* Per discussion with Brian/Mark/Ben, set the renderer timeout to 20 seconds ↵jabdelmalek@google.com2008-08-111-1/+1
| | | | | | | | | | | | but keep the plugin at 10. Not too ideal because the plugin dialog will come up incorrectl if webkit is hung, but let's try it out for the next release and see if we're still getting complaints. TBR=beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@671 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to remove a pixel gap between the client edge of the toolbars and ↵beng@google.com2008-08-111-7/+11
| | | | | | | | | the client edge of the content area. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@668 0039d316-1c4b-4281-b951-d872f2087c98
* Set the hung renderer and plugin timeout to 10 seconds.jabdelmalek@google.com2008-08-112-3/+3
| | | | | | BUG=1314703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@665 0039d316-1c4b-4281-b951-d872f2087c98
* Another Frame Grab-Bagbeng@google.com2008-08-1119-201/+207
| | | | | | | | | | | | | | | - makes more stuff in Browser object only happen if you're using the old frames- rename BrowserWindow::Update to BrowserWindow::UpdateToolbar since that's what it does - add window position save/restore handling to Browser- remove BrowserWindow::BrowserDidPaint - relic from HaloFrame days- remove BrowserWindow::GetRootView - unused and exposes impl details- remove BrowserWindow::DetachFromBrowser - unused - store BrowserView2* on HWND's property list so infobubbles can access it later- both frames (Opaque and AeroGlass) notify the BrowserView2 when they're moved so BrowserView2 can reposition the status bubble and close the autocomplete popup - remove BrowserView2::ShowTabContents - no longer used - remove BrowserView2::ShelfVisibilityChanged - no longer used - remove BrowserView2::SetWindowTitle - never used - remove BrowserView2::ProfileChanged - now called from TabSelectedAt- properly unhook infobars etc when a tab is detached B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@660 0039d316-1c4b-4281-b951-d872f2087c98
* A simple view that wraps a RenderViewHost in an HWNDView, to facilitatetimsteele@google.com2008-08-113-0/+168
| | | | | | | | rendering HTML as an arbitrary browser view. DOMView currently does something like this, but it uses TabContents and is hence pretty heavyweight. We may be able to replace DOMView with HWNDHtmlView. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@656 0039d316-1c4b-4281-b951-d872f2087c98
* A set of tests to exercise chrome menus as well as parts of bookmarksky@google.com2008-08-117-58/+1184
| | | | | | | | | | | | bar view. These are disabled until we straighten out the buildbot that is always logged in. BUG=1318922 TEST=this is just a bunch of tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@654 0039d316-1c4b-4281-b951-d872f2087c98
* Rename HttpProxy* classes to Proxy*. Move them into a net/proxy/ subdirectory.darin@google.com2008-08-111-6/+6
| | | | | | I'm making this change because proxy resolution is really not specific to the HTTP protocol. We need to use the proxy service in our FTP implementation, for example. I made a separate directory instead of just putting these in base, because I anticipate more files once we have our own PAC implementation. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@651 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the hung renderer warning delay to 30s temporarily.beng@google.com2008-08-101-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@638 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the TabStrip is laid out after a drag-detach operation is ↵beng@google.com2008-08-092-4/+4
| | | | | | | | | | completed. This is important because if there was a pending animation it was canceled, potentially leaving the TabStrip in a bad visual state. Also remove some debugging code that wasn't useful. B=1317895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@633 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the window icon to be shown in the task bar, Alt+Tab etc.beng@google.com2008-08-091-8/+10
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@614 0039d316-1c4b-4281-b951-d872f2087c98
* Even more tweaks.beng@google.com2008-08-0910-29/+98
| | | | | | | | | | - make window icon and title work on app windows - make window title updating sync with the task bar - make Aero Glass frame respect app mode settings - move title formatting routine from TabRenderer into Browser (a more central location) - appearance adjustments for app windows with info bars git-svn-id: svn://svn.chromium.org/chrome/trunk/src@612 0039d316-1c4b-4281-b951-d872f2087c98
* Remove includes that are already included in the header.paulg@google.com2008-08-091-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@611 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out the tests for now.sidchat@google.com2008-08-091-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@609 0039d316-1c4b-4281-b951-d872f2087c98
* M chrome/test/ui/ui_tests.vcprojsidchat@google.com2008-08-081-0/+262
| | | | | | | | AM chrome/browser/tabs/tab_dragging_test.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@606 0039d316-1c4b-4281-b951-d872f2087c98
* More tweaks to the frames. Provide proper layout for the title bar in app mode.beng@google.com2008-08-084-21/+33
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@605 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap the text in a label in the options dialog.tc@google.com2008-08-081-0/+3
| | | | | | | | BUG=1314224 TEST=chrome --lang=fil, options, middle tab, the last section should not have elided text. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@603 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in the first run dialog where the "Google Chrome is ready totc@google.com2008-08-081-2/+6
| | | | | | | | | complete your installation." text would overlap the product icon. BUG=1252749 TEST=chrome --lang=el --first-run and verify that the text wraps git-svn-id: svn://svn.chromium.org/chrome/trunk/src@602 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where we weren't resizing the content area at the end of a ↵glen@google.com2008-08-081-5/+5
| | | | | | | | | download shelf animation. This was caused by a disconnect between tabcontents::shelf_visible_ and the finished state. BUG=1317014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@601 0039d316-1c4b-4281-b951-d872f2087c98
* Add deps files and rules for the checkdeps script.brettw@google.com2008-08-081-0/+19
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@600 0039d316-1c4b-4281-b951-d872f2087c98
* Allow constrained popups to resize themselves...up to 10 times. (Then we ↵erg@google.com2008-08-083-16/+29
| | | | | | | | ignore their pleas for resizes since they're obviously up to no good.) BUG=1255747 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@585 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify AboutChromeView to only contain what someone would need to make a ↵erikkay@google.com2008-08-081-10/+1
| | | | | | | | | support request, removing official build number and user agent. The more detailed version information is in about:version. BUG=1300256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@578 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to make the opaque frame look better including adding support for app ↵beng@google.com2008-08-0811-58/+209
| | | | | | | | windows. Document the constants in the non-client view. Make the OTR frame work. Add a check to browser process that we use to check if we're using the new frames so we can disable various functionality that isn't appropriate. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@573 0039d316-1c4b-4281-b951-d872f2087c98
* Update Firefox importer tests to be in sync with the new escaping rulesbrettw@google.com2008-08-082-2/+2
| | | | | | for < and > in queries. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@570 0039d316-1c4b-4281-b951-d872f2087c98
* Third times a charm! This is an attempt at re-landing r408. This time the ↵darin@google.com2008-08-086-23/+28
| | | | | | | | UI test is revised to give the browser a chance to notice a crashed tab. TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@557 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 09:20:36 +0000