summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Run appcache layout tests in chrome using the ui test harness.michaeln@chromium.org2010-06-251-0/+75
| | | | | | | | | BUG=39365 TEST=yes Review URL: http://codereview.chromium.org/2822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50798 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove knowledge of AutocompleteTextField from ToolbarController.shess@chromium.org2010-06-2511-36/+31
| | | | | | | | | | | | | Concentrate the calculation in the location bar. Was going to do this in rewiring omnibox decorations, pulled it out before creating cocoa/location_bar/ subdir. BUG=none TEST=none Review URL: http://codereview.chromium.org/2846030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50797 0039d316-1c4b-4281-b951-d872f2087c98
* Change classes and functions for DNS Prefetching to Predictor*jar@chromium.org2010-06-2520-406/+421
| | | | | | | | | | | | | | | The DNS prefetching system has been extended to handle TCP/IP preconnection. As a result, class names and function names will be migrated to variations on Predictor* and Predict* to better indicate functionality. This change is only meant to include name changes, comment updates, and no semantic changes. r=mbelshe Review URL: http://codereview.chromium.org/2813031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50792 0039d316-1c4b-4281-b951-d872f2087c98
* A few cleanups to the sync unit tests.nick@chromium.org2010-06-254-7/+9
| | | | | | | | | | | | I didn't want to mix these in with other changes that are due to real expectations changes. BUG=46769 (related work) TEST=sync_unit_tests Review URL: http://codereview.chromium.org/2811031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50791 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50784 - Canvas refactoring part 3.ben@chromium.org2010-06-2435-169/+159
| | | | | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2811032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the horizontal layout code from notifications logic. This code is ↵johnnyg@chromium.org2010-06-242-46/+11
| | | | | | | | | | | not used currently nor do we expect to switch to a horizontal layout anytime soon. BUG=none TEST=none Review URL: http://codereview.chromium.org/2818030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50787 0039d316-1c4b-4281-b951-d872f2087c98
* Only examine host & path in gallery download url checkrafaelw@chromium.org2010-06-243-18/+39
| | | | | | | | | BUG=47425 TEST=All tests pass Review URL: http://codereview.chromium.org/2867024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50786 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2435-159/+169
| | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply "Move the files in resources/shared/ into resources.pak"erg@chromium.org2010-06-244-13/+201
| | | | | | | | | | | | Now with one line fix to fix the mac build. BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2842025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50783 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Don't show labels in the suggestions popup when the user is editing ajhawkins@chromium.org2010-06-247-12/+58
| | | | | | | | | | | field in an auto-filled form. BUG=47437 TEST=AutoFillManagerTest.GetFieldSuggestionsFormIsAutoFilled Review URL: http://codereview.chromium.org/2861025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50782 0039d316-1c4b-4281-b951-d872f2087c98
* Show extension icons next to their top-level context menu items.asargent@chromium.org2010-06-2412-125/+272
| | | | | | | | | | | | | | | Also fix a bug in extension icon caching where we weren't keeping track of potential resizing done by ImageLoadingTracker before setting the cached SkBitmap. BUG=39494 TEST=Install an extension that includes an icon and uses the experimental context menu API. You should see the extension's icon in the context menu next to its top-level item. Review URL: http://codereview.chromium.org/2867008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50779 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50761 - Move the files in resources/shared/ into resources.pakerg@chromium.org2010-06-244-201/+13
| | | | | | | | | | | | BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2817026 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2855021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50777 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-2432-336/+275
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* New HTML Sync Setup UI! This paves the way for the Passphrase UI. (coming ↵dantasse@chromium.org2010-06-2413-159/+491
| | | | | | | | | | | | | | | | | | | | | | | | | | | soon...) Old flow: - type username/password. wait for Gaia auth and initial sync (with throbber) - success! or error. New flow: - type username/password. wait for Gaia auth. (with throbber) - error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one. - wait for initial sync (with throbber) - success! or error, which brings you back to the gaia auth screen. Smaller details: - removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow. - added a logging statement to log if you cancel from the Choose Data Types screen. - added a pref to the profile for whether you want to "keep everything synced" or choose one by one. - added a couple more strings. Not final yet, I don't think. BUG=45869 TEST=Exercise all the different paths through the login flow. Review URL: http://codereview.chromium.org/2851012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50774 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 43800 - RTL/LTR eliding in Linux omnibox dropdown.xji@chromium.org2010-06-241-8/+24
| | | | | | | | | | | | | | | | Unlike Windows, in Linux, we do not draw the strings in autocomplete popup by ourselves. Instead, we rely on Pango to draw the strings. We only need to pass the text, the attribute, and the width to Pango, and Pango will draw the text correctly (taking care of visual runs for bidi text). The only small problems are that: when the UI is RTL, for pure English text, we need to insert LRE mark so that the ending punctuation is drawn correctly as is (not flipped), for example "....(choose location)" will not be drawn as "(....(choose location" in RTL UI. Also, for some (not all) pure English text, when eliding, the ellipsis appears at the very left of the string in RTL UI. I do not know the reason of such inconsistency, but looks like adding LRE mark to pure English also forces the ellipsis appears at the right of the string. BUG=43800 TEST=Omnibox should elide long URLs, mixed LTR/RTL text, etc. correctly in both LTR and RTL locales Review URL: http://codereview.chromium.org/2824027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50773 0039d316-1c4b-4281-b951-d872f2087c98
* Remove scary "Extension has access to everything you own" warning when thempcomplete@chromium.org2010-06-241-22/+1
| | | | | | | | | | | extension wants to inject script into file URLs, since this requires user opt-in now. BUG=47180 Review URL: http://codereview.chromium.org/2810028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50772 0039d316-1c4b-4281-b951-d872f2087c98
* linux: work around gnome keyring memory corruptionevan@chromium.org2010-06-241-105/+171
| | | | | | | | | | | | | | | | | Older versions of gnome keyring corrupt memory if you fetch too much data from it. Despite our best efforts, we couldn't come up with a way to tell if you're using the broken old version so that we could blacklist it. Instead, we fetch passwords one-by-one, which is slow but tolerable since we do it on a background thread anyway. While I'm here, refactor the code a bit to simplify it. TEST=password manager doesn't crash when using mdm's sample 100 password db with --password-store=gnome on hardy Review URL: http://codereview.chromium.org/2838023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50771 0039d316-1c4b-4281-b951-d872f2087c98
* Create background contents on startup.atwilson@chromium.org2010-06-242-9/+42
| | | | | | | | Implement BackgroundContentsService::CreateBackgroundContents() to automatically relaunch registered BackgroundContents when the browser starts. Review URL: http://codereview.chromium.org/2862026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50770 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on update screen.nkostylev@google.com2010-06-241-3/+8
| | | | | | | | | | | Introduced in CL http://codereview.chromium.org/2842024 BUG= http://crosbug.com/4208 TEST=Execute OOBE, update screen should check for update and proceed. Review URL: http://codereview.chromium.org/2871022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50768 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly disallow user scripts from extensions sync.akalin@chromium.org2010-06-242-8/+23
| | | | | | | | | BUG=46654 TEST=ExtensionUtilTest.IsSyncableExtension Review URL: http://codereview.chromium.org/2803022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50762 0039d316-1c4b-4281-b951-d872f2087c98
* Move the files in resources/shared/ into resources.pakerg@chromium.org2010-06-244-13/+201
| | | | | | | | | BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2817026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50761 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BMM paste on mac and list hover artifact.feldstein@chromium.org2010-06-243-1/+12
| | | | | | | | | | | | | | | | | The Bookamark manager on mac would paste a url into a bookmarks url field, and then the same paste event would propagate up to the list and paste the page as a new bookmark. This stops propagation of paste events from the text fields in the list. Also, now that the list has spacers for the dynamic rendering, the spacers would get a 2 pixel hover effect. This removes that. You can see it by slowly moving from the last bookmark down to below the bottom of the list. BUG=43442 TEST=NONE Review URL: http://codereview.chromium.org/2805031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50758 0039d316-1c4b-4281-b951-d872f2087c98
* Convert notification UI on Mac to a NIB rather than hand-coded. Also update ↵johnnyg@chromium.org2010-06-247-300/+153
| | | | | | | | | | | the UI to reflect the latest mocks. Also improve the animation onto the screen. BUG=34627 TEST=none Review URL: http://codereview.chromium.org/2822019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50757 0039d316-1c4b-4281-b951-d872f2087c98
* Make import from the options menu OOP on Mac OS X.mirandac@chromium.org2010-06-242-2/+3
| | | | | | | | BUG=46701 TEST=import Firefox passwords from the menu once the browser is running. Because import is OOP, FF passwords should be imported. All other import processes should still work as advertised. Review URL: http://codereview.chromium.org/2800026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50753 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-2432-275/+336
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Adds comment to why we need std::min in getting selection start.sky@chromium.org2010-06-243-7/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2831023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50743 0039d316-1c4b-4281-b951-d872f2087c98
* Require user opt-in before allowing content script injection on file URLs.mpcomplete@chromium.org2010-06-2411-6/+173
| | | | | | | | BUG=47180 Review URL: http://codereview.chromium.org/2809034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
* Allow suppression of first run bubble from master preferences.mirandac@google.com2010-06-248-13/+24
| | | | | | | | | BUG=18185 TEST= add "suppress_first_run_bubble:true" to distribution section of master_preferences. run as first_run, and watch bubble not appear. Review URL: http://codereview.chromium.org/2812022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50734 0039d316-1c4b-4281-b951-d872f2087c98
* Fire the document load complete and focus event on the root document object.ctguil@chromium.org2010-06-241-4/+8
| | | | | | | | | BUG=47084,47208 TEST=none Review URL: http://codereview.chromium.org/2822027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50732 0039d316-1c4b-4281-b951-d872f2087c98
* Converts the CRLF line endings to LF. I only encountered this becausesky@chromium.org2010-06-241-264/+264
| | | | | | | | | | | I need to change this file for another patch and the try bots kept barfing. I finally figured it out it was because of CRLF instead LF. BUG=none TEST=none Review URL: http://codereview.chromium.org/2837016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50730 0039d316-1c4b-4281-b951-d872f2087c98
* Disable check for duplicate URLs. Turns out the most visited computation can ↵brettw@chromium.org2010-06-241-3/+0
| | | | | | | | | | generate these in some legitimate cases and we don't want to assert. TEST=none BUG=none Review URL: http://codereview.chromium.org/2799027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50729 0039d316-1c4b-4281-b951-d872f2087c98
* GRD change + new HTML file for sync UI changedantasse@chromium.org2010-06-242-0/+226
| | | | | | | | | BUG=45869 TEST=Doesn't do anything yet Review URL: http://codereview.chromium.org/2845019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50728 0039d316-1c4b-4281-b951-d872f2087c98
* Change copyright to help grd change along.mirandac@google.com2010-06-241-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2809036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50725 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the first run search engine dialog so that it reflects Glen's mocks. ↵mirandac@google.com2010-06-242-133/+39
| | | | | | | | | | This change adds an image to the top of the dialog, and removes the text and link at the bottom. It also removes the horizontal separators. BUG=46716 TEST=Run Chrome in first-run with master_preferences set to load the new search engine dialog. It should look reasonable. Review URL: http://codereview.chromium.org/2818014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50724 0039d316-1c4b-4281-b951-d872f2087c98
* Provides a single place to test whether the new wrench menu issky@chromium.org2010-06-245-8/+29
| | | | | | | | | | | | enabled. I'm doing this as I'm ready to turn it on for views and want a single place to turn it off should we decided to do that. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2813032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50722 0039d316-1c4b-4281-b951-d872f2087c98
* Unsubscribe from updates notifications on exit from update screen.nkostylev@google.com2010-06-241-3/+9
| | | | | | | | | | | Added extra debug logging for update screen. BUG= http://crosbug.com/4208 TEST=Manually: run OOBE, press Esc on update screen, you should stay at login screen. Review URL: http://codereview.chromium.org/2842024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50721 0039d316-1c4b-4281-b951-d872f2087c98
* Pass start url to be opened after login.nkostylev@google.com2010-06-248-15/+49
| | | | | | | | | | | | Single url is enough. If needed it could be easily changed to multiple ones. Hopefully merging login_screen & existing_user_controller will remove some of duplication. BUG= http://crosbug.com/4214 TEST=Manual. "Can't access your account" should open BWSI with help link in it. Review URL: http://codereview.chromium.org/2802021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50719 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Reset to defaults button to the Mozc configuration dialog.mazda@chromium.org2010-06-242-3/+49
| | | | | | | | | BUG=chromium-os:2625 TEST=manual Review URL: http://codereview.chromium.org/2861021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50715 0039d316-1c4b-4281-b951-d872f2087c98
* Change the language indicator to the country code when using ibus-xkb.mazda@chromium.org2010-06-245-7/+92
| | | | | | | | | BUG=chromium-os:4044 TEST=manually check the indicator on the netbook Review URL: http://codereview.chromium.org/2876006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50714 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the tooltip for the language indicator when the indicator is hidden.yusukes@google.com2010-06-241-3/+2
| | | | | | | | | BUG=chromium-os:4227 TEST=manual Review URL: http://codereview.chromium.org/2837015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50713 0039d316-1c4b-4281-b951-d872f2087c98
* Add IsScreenLockerMode() interface to the StatusAreaHost class.yusukes@google.com2010-06-246-8/+26
| | | | | | | | | | | LanguageMenuButton will use the interface to implement crosbug.com/2619 (Implement input language selector on the log in page) BUG=none TEST=ran try bot Review URL: http://codereview.chromium.org/2846031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50709 0039d316-1c4b-4281-b951-d872f2087c98
* fix forgotten homepage preference on Windowsdanno@chromium.org2010-06-242-15/+18
| | | | | | | | | | BUG=47055 TEST=manual Review URL: http://codereview.chromium.org/2815021 Patch from Gábor Fehér <gfeher@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50708 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Port the ExtensionBrowserTest.PluginLoadUnload test part 2. (TTF)thestig@chromium.org2010-06-241-4/+3
| | | | | | | | BUG=29900 TEST=ported. Review URL: http://codereview.chromium.org/2849019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50707 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark manager on mac and windows.tony@chromium.org2010-06-242-3/+10
| | | | | | | | | | | | | | | Mac was failing because the resources directory was in a different place. Win was failing because path separators between two filepaths are different causing the equality check to fail. TBR=erg Review URL: http://codereview.chromium.org/2873017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50706 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BookmarksUITest.FLAKY_ShouldRedirectToExtension while I fixtony@chromium.org2010-06-241-1/+1
| | | | | | | | TBR=leiz Review URL: http://codereview.chromium.org/2800025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50701 0039d316-1c4b-4281-b951-d872f2087c98
* sqlite_utils: don't dereference an empty vector.nick@chromium.org2010-06-242-5/+35
| | | | | | | | | | | | | | | user_settings: Add unit test intended to exercise the above path. In practice though these tests don't hit the bug, since EncryptData("") results in non-empty ciphertext. bonus: don't leak a sqlite handle in one of the other sync unit tests. TEST=none BUG=40217 Review URL: http://codereview.chromium.org/2801017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50700 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crash issue.suzhe@chromium.org2010-06-241-13/+17
| | | | | | | | | BUG=47376 TEST=none Review URL: http://codereview.chromium.org/2868033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50697 0039d316-1c4b-4281-b951-d872f2087c98
* Fix copy & paste error from http://codereview.chromium.org/2855009.rafaelw@chromium.org2010-06-241-1/+1
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/2867023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50688 0039d316-1c4b-4281-b951-d872f2087c98
* Move the bookmark manager into resources.pak.tony@chromium.org2010-06-243-2/+103
| | | | | | | | | | | | This allows for the bookmark manager to work after upgrading in the background on Linux. BUG=42770 TEST=Bookmark manager still works Review URL: http://codereview.chromium.org/2814009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50683 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "get html from page" functionality for PyAuto.jrg@chromium.org2010-06-244-10/+127
| | | | | | | | | BUG=36184 TEST=Run PyAuto's content.py and make sure it passes. Review URL: http://codereview.chromium.org/2861019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50678 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 10:42:41 +0000