summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Separate out most view creation from WebContents. This adds a new ↵brettw@google.com2008-10-1719-200/+358
| | | | | | | | sub-delegate to RenderViewHostDelegate which is implemented by WebContentsView. I did a lot of plumbing and moving around as a result. Review URL: http://codereview.chromium.org/6608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3527 0039d316-1c4b-4281-b951-d872f2087c98
* The translation lead requested that this sentence be a singletc@google.com2008-10-171-14/+41
| | | | | | | | | string, otherwise it will likely be grammatically incorrect. This is a hack until http://crbug.com/3295 is implemented. Review URL: http://codereview.chromium.org/7396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3512 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for a possible assertion caused by r3407.hbono@chromium.org2008-10-171-1/+2
| | | | | | | | When a user opens a "Fonts and Languages" dialog (through [Options] -> [Change Font and Language Settings]) and presses its "OK" button without changing anything, the debug build of Chromium raises an assert exception because the LanguagePageView::SaveChanges() function reads the value of an initialized member variable |LanguagePageView::spellcheck_language_index_selected_|. To prevent this possible assertion, this change initializes the member variable |LanguagePageView::spellcheck_language_index_selected_| to -1 in the constructor of the LanguagePageView class. Review URL: http://codereview.chromium.org/7387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3506 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing file from r3496.aa@google.com2008-10-171-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3499 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bit of Greasemonkey support hidden behind the --enable-greasemonkey ↵aa@google.com2008-10-164-15/+183
| | | | | | | | | | | | | flag. Implementation follows the pattern of the visited links system. Things still to be done: - stop using a hardcoded script directory - watch script directory and update shared memory when necessary - move file io to background thread - support for @include patterns -- now, all scripts are applied to all pages Review URL: http://codereview.chromium.org/7254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3496 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-16234-3006/+2881
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build: GetViewContainer changed name from under me. :)finnur@google.com2008-10-161-2/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/7464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in downloading files (issue 3423).finnur@google.com2008-10-161-0/+9
| | | | | | | | | | | | | | | | | | | | | | | I was finally able to reproduce a problem where we would crash when clicking Save on the Download Tab (it would also crash during animation of the items on the download shelf after switching away from the tab downloading). The reason for the crash is that if the controls on the download shelf have not been laid out once (before switching to a tab that doesn't have a download shelf), then we'll crash inside NativeControlContainer ctor when it tries to ValidateNativeControl() (it walks up the parent hierarchy trying to find the ViewContainer and ends up dereferencing a NULL pointer). This was reviewed by jcampan as http://codereview.chromium.org/7446 I had to recreate the changelist before submitting (long story). Review URL: http://codereview.chromium.org/7604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3492 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more shared_event that I missed last timeagl@chromium.org2008-10-164-4/+0
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/7397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3485 0039d316-1c4b-4281-b951-d872f2087c98
* When a mixed-content resource was loaded, we would apply the mixed-content ↵jcampan@chromium.org2008-10-162-5/+4
| | | | | | | | | | | | | | | state to the active entry, which would be the pending entry if there is one. That caused a problem in cases where a bad resource is loading and we are initiating a navigation from the browser (and therefore creating a pending entry). More details: In the GoodFrame test, the top-frame is HTTPS and we load an HTTP frame with an image. As soon as the bad frame has loaded, we navigate back (creating a pending entry). In rare cases, the notification for the mixed-content image of the HTTP frame would happen after the back action, mistakingly setting the mixed-content state on the pending entry. BUG=2742 TEST=Run the SSL UI tests 1000 times. Review URL: http://codereview.chromium.org/7440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3480 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-1665-294/+118
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Return without doing anything instead of dereferencing junk in unexpected cases.mark@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3470 0039d316-1c4b-4281-b951-d872f2087c98
* Update SpellChecker to download the latest version of the bdic dictionary files.sidchat@google.com2008-10-162-3/+46
| | | | | | Review URL: http://codereview.chromium.org/6474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3468 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the following changes to the bookmark bar context menu:sky@google.com2008-10-163-88/+75
| | | | | | | | | | | | . Nukes the open menu item. . Adds open incognito and for folders open all incognito. BUG=144 TEST=Fully test the context menu of bookmark folders/urls. Review URL: http://codereview.chromium.org/7357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3464 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser\interstitial_page.cc to the SCons build.sgk@google.com2008-10-161-1/+2
| | | | | | | Move render_widget_host_hwnd.cc to render_widget_host_win.cc. Review URL: http://codereview.chromium.org/7336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3463 0039d316-1c4b-4281-b951-d872f2087c98
* Change the prefix for unconfirmed, potentially dangerous downloads mal@chromium.org2008-10-161-1/+1
| | | | | | | | | | | | | | | | | from: dangerous_download_%d to: unconfirmed %d We want to avoid alarming names in the UI. I'm open to better suggestions for the prefix. R= jcampan@chromium.org, brian@chromium.org Review URL: http://codereview.chromium.org/7107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3455 0039d316-1c4b-4281-b951-d872f2087c98
* This is the same change as 2419 minus a line of debug code I accidentally ↵petersont@google.com2008-10-165-183/+567
| | | | | | | | left in browser_main.cc which ignored the user preference. Review URL: http://codereview.chromium.org/4229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken resize from bottom with magic frame.ben@chromium.org2008-10-161-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3443 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.ben@chromium.org2008-10-1671-217/+207
| | | | | | | http://crbug.com/3430 Review URL: http://codereview.chromium.org/7376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3441 0039d316-1c4b-4281-b951-d872f2087c98
* As agreed on by the SafeBrowsing server team:paulg@google.com2008-10-152-15/+14
| | | | | | | | | | | 1. Back off when we encounter a parse error. 2. Ignore commands we don't understand instead of returning an error. 3. Make redirect URL parsing in an update response more robust to changes in format. Review URL: http://codereview.chromium.org/7329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3425 0039d316-1c4b-4281-b951-d872f2087c98
* Add a check in Chrome to not run user level mode if machine level Chromekuchhal@chromium.org2008-10-152-7/+57
| | | | | | is already installed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3423 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lot of robustness to SDCH filter decodingjar@google.com2008-10-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | a) Do meta-refresh (and partially disable sdch) when we have an sdch decode error early on (due to lack of dictionary). b) Gracefully handle proxy removal of "gzip" in "content-encoding: sdch,gzip". c) Recover from completely stripped content encoding (in response to a request for which we advertised an SDCH dictionary) by using a filter that can optionally decode sdch with an optional gzip as well. Some field tests have shown problems with this protocol's transit across the ether. The general approach we've adopted is to stop using SDCH on the problematic site when we have problems. This will prevent a malicious site from shutting down all use of SDCH. r=kmixter,openvcdiff,huanr Review URL: http://codereview.chromium.org/6433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3420 0039d316-1c4b-4281-b951-d872f2087c98
* Change SpellChecker language without restarting the browser.sidchat@google.com2008-10-156-25/+143
| | | | | | Review URL: http://codereview.chromium.org/7056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3407 0039d316-1c4b-4281-b951-d872f2087c98
* This file was left out of my last checkin due to prior gcl cruft.beng@google.com2008-10-151-32/+21
| | | | | | http://crbug.com/2186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3402 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-1590-1051/+942
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Insert NULL check to fix dist crashben@chromium.org2008-10-151-5/+4
| | | | | | Review URL: http://codereview.chromium.org/7407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3399 0039d316-1c4b-4281-b951-d872f2087c98
* Change #ifdef _DEBUG test to #ifndef NDEBUG test.maruel@google.com2008-10-153-6/+6
| | | | | | Review URL: http://codereview.chromium.org/7404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher when shutting down with a pending dangerous download.jcampan@chromium.org2008-10-151-2/+4
| | | | | | | | BUG=3457 TEST=See bug Review URL: http://codereview.chromium.org/7406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3396 0039d316-1c4b-4281-b951-d872f2087c98
* Enable magic browzr again.ben@chromium.org2008-10-141-1/+1
| | | | | | R=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3385 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HitTest/GetViewForPoint to use gfx::Pointben@chromium.org2008-10-1410-30/+28
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3384 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some places I missed the renaming changes.brettw@google.com2008-10-142-10/+10
| | | | | | Review URL: http://codereview.chromium.org/7332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3382 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RenderWidgetHostHWND to RenderWidgetHostViewWin for consistency with ↵brettw@google.com2008-10-1410-124/+139
| | | | | | | | | other view-related classes. No logic change. Review URL: http://codereview.chromium.org/7310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3379 0039d316-1c4b-4281-b951-d872f2087c98
* Rename various text zoom related stuff to be more generic, since we now canbrettw@google.com2008-10-144-15/+11
| | | | | | | | | | optionally zoom the page. I added an easy way in render_view to toggle between text zoom and full page zoom, and allowed the embedder to specify this in the glue layer. This allows me to fix the text zoom layout test, which specifically asks that the text be zoomed. Review URL: http://codereview.chromium.org/7320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3377 0039d316-1c4b-4281-b951-d872f2087c98
* Try and find the location of crashben@chromium.org2008-10-141-0/+2
| | | | | | Review URL: http://codereview.chromium.org/7323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3367 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-1419-136/+135
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-1413-116/+88
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build by including string.brettw@google.com2008-10-141-0/+2
| | | | | | Review URL: http://codereview.chromium.org/7303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3347 0039d316-1c4b-4281-b951-d872f2087c98
* Move more view stuff out of WebContents. This moves context menus and infobrettw@google.com2008-10-1416-181/+229
| | | | | | | | | | bars. I removed the associated functions on TabContents, and have callers call directly through to the view when the care about mucking with the info bar (which is busted, IMO). Review URL: http://codereview.chromium.org/7245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3346 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r3334 to disable magic_browzR and see if that fixes the crashes in the mal@chromium.org2008-10-141-1/+1
| | | | | | | | | reliability tests. TBR= ben@chromium.org Review URL: http://codereview.chromium.org/7135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3340 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on MagicBrowzr again.ben@chromium.org2008-10-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in saving pages.ben@chromium.org2008-10-131-0/+1
| | | | | | | http://crbug.com/3393 Review URL: http://codereview.chromium.org/7285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3331 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at refactoring the interstitial page.jcampan@chromium.org2008-10-1321-713/+892
| | | | | | | | | | | | | | | | | The SSL and malware blocking pages were doing similar things in 2 different classes. There is now a base class called InterstitialPage that contains the common logic. As part of that refactoring, the safe browsing was changed so that the SafeBrowsingBlockingPage is only used from the UI thread. This CL also adds transient entries to the navigation controller: that type of entry gets deleted as soon as a navigation occurs. It is used by interstitial that need to create such a temporary entry while they show. BUG=3013 TEST=Run the unit tests and ui tests. Review URL: http://codereview.chromium.org/6311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3324 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin processes (except Gears) run at normal priority.jam@chromium.org2008-10-131-2/+6
| | | | | | | | | This fixes a lot of the spurious unresponsive plugin dialogs, and also makes it so that the browser process isn't hung waiting for a low priority plugin process when cpu usage is high. I was able to simulate this by using 100% cpu in a test program. Before this change, the dialog always comes up and a flash video never plays. The browser process is also hung. With this change the video plays and I can interact with the browser. Review URL: http://codereview.chromium.org/7129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3323 0039d316-1c4b-4281-b951-d872f2087c98
* I forgot to make the background images not dnd-able on the blocking pages.jcampan@chromium.org2008-10-134-6/+6
| | | | | | | | | | TEST=Visit https://ebay.com. On the blocking page, try dragging things around. You should not be able to. BUG=3235 Review URL: http://codereview.chromium.org/7127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3322 0039d316-1c4b-4281-b951-d872f2087c98
* Add new web_contents_view_win.cc to the SCons build.sgk@google.com2008-10-131-0/+5
| | | | | | Review URL: http://codereview.chromium.org/7269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3318 0039d316-1c4b-4281-b951-d872f2087c98
* Minor code clean up.paulg@google.com2008-10-132-4/+9
| | | | | | Review URL: http://codereview.chromium.org/7271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3314 0039d316-1c4b-4281-b951-d872f2087c98
* Popups opened from popups should be constrained and subject to constrained ↵erg@google.com2008-10-131-7/+7
| | | | | | | | | | | popup limits. This solves the UI issue, but there's still the backend stuff which I've filled as http://crbug.com/3382 BUG=2632 Review URL: http://codereview.chromium.org/7233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3313 0039d316-1c4b-4281-b951-d872f2087c98
* Use system title bar font for app windows, detached popups, constrained popups.ben@chromium.org2008-10-132-5/+21
| | | | | | | | http://crbug.com/3376 Review URL: http://codereview.chromium.org/7274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3307 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up throbber animation for vista detached popup windows and app windows.ben@chromium.org2008-10-136-10/+76
| | | | | | | | http://crbug.com/3296 Review URL: http://codereview.chromium.org/7261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3293 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted improvements to window maximization and flicker on Windows Vista ↵ben@chromium.org2008-10-131-3/+3
| | | | | | | | | with aero-glass disabled. http://crbug.com/2488 Review URL: http://codereview.chromium.org/7262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3292 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 04:43:25 +0000