summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Change to integrate SystemMonitor changes into chrome.mbelshe@google.com2008-11-1411-152/+88
| | | | | | | | | | | | This enables the dynamic detection of battery status changes so that we can turn on/off the hi-res timer. Review URL: http://codereview.chromium.org/10264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5489 0039d316-1c4b-4281-b951-d872f2087c98
* Port some unit tests in chrome/browser/agl@chromium.org2008-11-144-38/+25
| | | | | | | | | | | | | This first requires http://codereview.chromium.org/8618 . Only snippet_unittest is enabled for build. For rest of files it's only a platform cleanup. Review URL: http://codereview.chromium.org/8191 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5488 0039d316-1c4b-4281-b951-d872f2087c98
* Remove browser\views\frame\browser_view2.cc andsgk@google.com2008-11-141-7/+0
| | | | | | | browser\views\old_frames from the SCons build. Review URL: http://codereview.chromium.org/10723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5486 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/agl@chromium.org2008-11-149-64/+41
| | | | | | | | | | | | | | | #ifdef out windows-specific portion of chrome/common/l10n_util.h, which allows me to port some other files. I also extracted parts of chrome/views/tree_view.h to tree_model.h, so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h is platform-independent and can be included in files using it as base class. Review URL: http://codereview.chromium.org/8618 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
* New unit test for webdatabase functions that record form entries for autofill.petersont@google.com2008-11-141-0/+87
| | | | | | Review URL: http://codereview.chromium.org/10903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5481 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage, I missed this file with my base namespace changes.brettw@google.com2008-11-141-3/+3
| | | | | | Review URL: http://codereview.chromium.org/10738 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5448 0039d316-1c4b-4281-b951-d872f2087c98
* Add Terminate() to the Process object, have RenderProcessHost use this to ↵brettw@google.com2008-11-1430-146/+143
| | | | | | | | | | avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Review URL: http://codereview.chromium.org/10895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
* Make border and background setting and getting non-virtual and use the ↵brettw@google.com2008-11-1410-15/+16
| | | | | | | | correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual. Review URL: http://codereview.chromium.org/10638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
* Update the user delay histogram for the SafeBrowsing.paulg@google.com2008-11-143-6/+8
| | | | | | Review URL: http://codereview.chromium.org/10916 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5434 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the interactive ui tests by correctly initializing the specified popup ↵ben@chromium.org2008-11-141-2/+1
| | | | | | | | | bounds. TBR=erg Review URL: http://codereview.chromium.org/10724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5429 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage:ben@chromium.org2008-11-142-6/+6
| | | | | | | | | - Apparently blank tabs must have NewTabUIURL as their URL. - flag wasn't initialized. Review URL: http://codereview.chromium.org/10721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5427 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms to measure new SafeBrowsing performance.paulg@google.com2008-11-146-14/+81
| | | | | | Review URL: http://codereview.chromium.org/10712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5423 0039d316-1c4b-4281-b951-d872f2087c98
* Remove chrome\browser\browser_commands.cc from the SCons build.sgk@google.com2008-11-141-3/+0
| | | | | | | Remove a duplicate entry for safe_browsing\safe_browsing_service.cc. Review URL: http://codereview.chromium.org/10904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5418 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-1433-493/+376
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we were not checking if an app from another windowsky@google.com2008-11-141-8/+52
| | | | | | | | | | | | was on top of Chrome's topmost brower window when attempting to dock a dragged tab. BUG=1094303 TEST=see bug Review URL: http://codereview.chromium.org/10715 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5416 0039d316-1c4b-4281-b951-d872f2087c98
* Stop the search boxes being too wide on RTL languages.glen@chromium.org2008-11-131-0/+1
| | | | | | | | BUG=4365 Review URL: http://codereview.chromium.org/10688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5409 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in adding bookmark groups. Adding wasn't setting thesky@google.com2008-11-131-0/+1
| | | | | | | | | | | | modified date, which meant newly added groups wouldn't show up in the combobox of the bookmark bubble. BUG=766 TEST=see bug Review URL: http://codereview.chromium.org/10709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5400 0039d316-1c4b-4281-b951-d872f2087c98
* Three menu bugs:sky@google.com2008-11-131-0/+68
| | | | | | | | | | | | | | | | | | . If a context menu was shown from a menu, then hidden we did not keep mouse capture and bad things happened (menu wouldn't go away when clicking else where, crash ...). . We only update menu sizes on first show of a menu. That way if a context menu doesn't have icons things don't shift around. . If nothing was selected in the menu pressing the context menu showed the context menu for the root. It doesn't make sense for the root menu to have a context menu. BUG=4364 TEST=see bug Review URL: http://codereview.chromium.org/10706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5397 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce memory consumption by keeping the SafeBrowsingpaulg@google.com2008-11-135-83/+182
| | | | | | | | database closed when not processing updates. Review URL: http://codereview.chromium.org/10643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5381 0039d316-1c4b-4281-b951-d872f2087c98
* Puts chrome menus on a slimfast diet: they are no longer chubby. Isky@google.com2008-11-131-0/+1
| | | | | | | | | | | | | | | added an option such that menus can be rendered in two ways, chubby or skinny. The only places that uses the taller menus is the bookmark bar. I also made the menus use the right font. BUG=1074332 TEST=none Review URL: http://codereview.chromium.org/10865 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5367 0039d316-1c4b-4281-b951-d872f2087c98
* Reordered some logic to fix a bug which caused the clearing of the database ↵petersont@google.com2008-11-131-5/+7
| | | | | | | | to malfunction. Review URL: http://codereview.chromium.org/10862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5365 0039d316-1c4b-4281-b951-d872f2087c98
* Changes UnloadUITest to navigate to last URL synchronously in hopes ofsky@google.com2008-11-131-3/+4
| | | | | | | | | | | | | making ui test more consistent. I suspect I could get the same effect by changing the last sleep to kMaxTestExecutionTime, but seems best to use the sync function here. TEST=none BUG=none Review URL: http://codereview.chromium.org/10692 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5354 0039d316-1c4b-4281-b951-d872f2087c98
* Some speculative fixes for UI test flakiness.beng@google.com2008-11-131-6/+7
| | | | | | | | | | - make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests. - potential crashes caused by NULL TabcontentsDelegates. TBR=sky Review URL: http://codereview.chromium.org/10674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 5: Add additional ↵pkasting@chromium.org2008-11-1310-47/+58
| | | | | | | | | AutocompleteMatch types, and pass a type to the AutocompleteMatch constructor. The added detail in the new types is not used for anything functional; its sole purpose is for metric logging. Someday we could probably update other bits of the code to make use of this, though (e.g. the paste-and-search vs. paste-and-go determinant code). These are separable changes, but doing either one without the other would have required an annoying number of fragile temporary changes. Review URL: http://codereview.chromium.org/10855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5329 0039d316-1c4b-4281-b951-d872f2087c98
* * Try to rename chrome exes in shutdown path as well.kuchhal@chromium.org2008-11-124-21/+37
| | | | | | | | BUG=1463346 Review URL: http://codereview.chromium.org/10805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5313 0039d316-1c4b-4281-b951-d872f2087c98
* New functions in WebDatabase and WebDataService for the removal of form ↵petersont@google.com2008-11-125-8/+172
| | | | | | | | | | entries made between two given times. BrowserDataRemover::Remove now clears autofill data. BUG=3870 Review URL: http://codereview.chromium.org/9775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5312 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 5: Add TypeToString() helpers. ↵pkasting@chromium.org2008-11-122-0/+36
| | | | | | | | One of these is unused for the moment. Review URL: http://codereview.chromium.org/10657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5307 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for save dialogs to take a default extension.sky@google.com2008-11-128-27/+38
| | | | | | | | | BUG=4287 TEST=see bug Review URL: http://codereview.chromium.org/10621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix infobubble crash due to first run bubble having slightly different ↵ben@chromium.org2008-11-122-9/+4
| | | | | | | | | initialization path than the bookmarks bubble. http://crbug.com/4344 Review URL: http://codereview.chromium.org/10849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5301 0039d316-1c4b-4281-b951-d872f2087c98
* Break out command execution from ExecuteCommand implementation into separate ↵ben@chromium.org2008-11-122-514/+519
| | | | | | | | functions. Review URL: http://codereview.chromium.org/10823 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5289 0039d316-1c4b-4281-b951-d872f2087c98
* If setProcessBackgrounded fails, don't continue throughmbelshe@google.com2008-11-121-1/+4
| | | | | | | | | | this function. This is defensive coding being added in part to see if it doesn't reveal anything interesting for bug 1231568 Review URL: http://codereview.chromium.org/11003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5286 0039d316-1c4b-4281-b951-d872f2087c98
* * Need to read version from registry if relaunching browser.kuchhal@chromium.org2008-11-121-0/+1
| | | | | | | | BUG=4316 Review URL: http://codereview.chromium.org/10820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5281 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 3: Pass match.type to the edit ↵pkasting@chromium.org2008-11-123-17/+13
| | | | | | | | | and let it make the determination about showing the search hint, instead of making the determination in the popup. In the ultimate patch, the types on which we'll show the hint will expand, so this saved duplicating some logic at points in the popup; in retrospect it makes more sense anyway, since there's no reason for the popup to know anything about the search hint. That's more the edit's job anyway. Review URL: http://codereview.chromium.org/10839 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5276 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 2: Remove the AutocompleteMatch ↵pkasting@chromium.org2008-11-124-44/+23
| | | | | | | | | NULL constructor. It's too easy to forget to set various members with this. The changes from .resize() to .erase() are necessary because the compiler doesn't know resize() won't be enlarging the vector and thus needing to access the NULL constructor. The changes to the HistoryContents shortcut code were similarly necessary to avoid a NULL construction, but in the end I think made the resulting code a bit clearer. Review URL: http://codereview.chromium.org/10837 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5271 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 1: Random miscellaneous small ↵pkasting@chromium.org2008-11-125-86/+70
| | | | | | | | style and similar changes. In one or two cases the motivation is not obvious without looking at the original patch. Review URL: http://codereview.chromium.org/10822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5261 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure ResourceDispatcherHost properly cleans up a cancelledsky@google.com2008-11-121-1/+10
| | | | | | | | | | | | | | | | | | | request that is not in a pending state. When we cancel a URLRequest with no pending IO, nothing happens. This means ResourceDispatcherHost doesn't clean up its maps and delete the URLRequest. Another possibility for fixing this is to invoke OnResponseCompleted, but as the request isn't really completed that may cause other bad things. Let me know if you think this should be fixed in another way. BUG=4302 TEST=see bug Review URL: http://codereview.chromium.org/10814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5252 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder browser.cc to match style guide, and remove browser_commands.ccben@chromium.org2008-11-124-1705/+1700
| | | | | | Review URL: http://codereview.chromium.org/10623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5246 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder functions in browser.hben@chromium.org2008-11-127-295/+236
| | | | | | | | | | | | | Also remove unnecessary functions: - Browser::MoveToFront - Browser::WindowActivationChanged - Browser::ExecuteWindowsAppCommand Also rename function: - Browser::ShowNativeUI -> Browser::ShowNativeUITab Review URL: http://codereview.chromium.org/10617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix history_indexer.idl to stop from rebuilding it every time.maruel@chromium.org2008-11-121-0/+12
| | | | | | Review URL: http://codereview.chromium.org/10816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5235 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TableView to have its own mouse handling code so that we cansky@google.com2008-11-121-0/+4
| | | | | | | | | | | start a drag when user clicks anywhere on a row. BUG=4306 TEST=thoroughly test drag and drop of bookmark manager table. Review URL: http://codereview.chromium.org/9776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5233 0039d316-1c4b-4281-b951-d872f2087c98
* oopsben@chromium.org2008-11-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5222 0039d316-1c4b-4281-b951-d872f2087c98
* oopsben@chromium.org2008-11-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5221 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some Windows-specific stuff from RenderProcessHost by having callers ↵brettw@google.com2008-11-1112-28/+21
| | | | | | | | get the process handle and PID directly from the corresponding Process object. Review URL: http://codereview.chromium.org/10608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ShowAndFit variation of Browser::Show, since the "varation" doesn't ↵ben@chromium.org2008-11-113-7/+5
| | | | | | | | seem to actually work. Review URL: http://codereview.chromium.org/10807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5214 0039d316-1c4b-4281-b951-d872f2087c98
* Style fixes to BlockedPopupContainer before I submiterg@google.com2008-11-112-20/+26
| | | | | | | | it for my readability review. Review URL: http://codereview.chromium.org/10606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5212 0039d316-1c4b-4281-b951-d872f2087c98
* Move the hang monitor to the BrowserView, since it's highly Windows/HWND ↵ben@chromium.org2008-11-115-60/+66
| | | | | | | | | | specific. http://crbug.com/4310 Review URL: http://codereview.chromium.org/10601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5211 0039d316-1c4b-4281-b951-d872f2087c98
* Accept the changes in the UI Language in Options ... -> Language Menu only ↵sidchat@google.com2008-11-112-4/+18
| | | | | | | | | if "OK" button is clicked - otherwise, discard the changes. Issue=2835 Review URL: http://codereview.chromium.org/9777 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5210 0039d316-1c4b-4281-b951-d872f2087c98
* More cleanup in Browser:ben@chromium.org2008-11-1111-121/+36
| | | | | | | | | | - remove "RunSimpleFrameMenu" method that isn't used anymore. - rename Browser::GetType() to Browser::type() Review URL: http://codereview.chromium.org/10605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5209 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the possibility of failure when starting apaulg@google.com2008-11-116-26/+10
| | | | | | | | | | SafeBrowsing update transaction. If we fail to start the transaction, we report the error to the protocol manager which aborts the update process. Review URL: http://codereview.chromium.org/9778 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5207 0039d316-1c4b-4281-b951-d872f2087c98
* Only block alert() requests from blocked popups; not all popups.erg@google.com2008-11-114-86/+96
| | | | | | | | | Add two unit tests to make sure we do the right thing; required adding a bunch of stuff to the automation layer. Review URL: http://codereview.chromium.org/10282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5198 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 19:15:41 +0000