| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL reworks the GtkSocket/GtkPlug code for windowed plugins on linux. Instead of having the plugin ask the browser to create a socket to plug into, it simply creates a plug and sends it to the browser. The browser creates a socket and attaches the plug when the socket becomes realized
This fixes 2 main issues:
- we can create windowed plugins in background tabs (Issue 16125)
- we can detach tabs with windowed plugins and reattach them (Issue 17110)
I reworked the IPCs, so it removes some amount of linux-specific things. We also need less synchronous IPCs to create/destroy plugins, so that should be a bit faster. In particular, I removed the plugin pid map, and instead made sure the renderer always destroys the plugin containers if the plugin process crashes - they will be destroyed if the renderer process crashes. Let me know if you have an issue with that.
Also, the intermediate plug/socket creation now happens in webplugin_delegate_impl_gtk. That means test_shell uses it as well. It made the code a lot simpler, and means we're testing it as well, albeit with a bit of extra overhead.
Bonus: I found a big bad bug in the GtkPluginContainer that made its width/height alias with some internal gtk structures. That was certainly causing some amounts of bugs.
Bonus 2: scrolling now looks more in sync with the rest of the page, though I'm not exactly sure which part caused that.
BUG=16125,17110
TEST=a lot of manual testing involving YouTube videos
Review URL: http://codereview.chromium.org/174295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
issue.
BUG=19823
TEST=see bug
Review URL: http://codereview.chromium.org/173333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
errors locally.
Review URL: http://codereview.chromium.org/174414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
separator, status and tooltip.
BUG=19982
TEST=Assign @role application, document, radiogroup, region, separator, status or tooltip to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly.
Review URL: http://codereview.chromium.org/174382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20158
Review URL: http://codereview.chromium.org/174365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously holding two controls keys and releasing one would show the
non-control omnibox results, but hitting enter would take the control results.
Fix this by showing the correct results if any control key is held down.
Review URL: http://codereview.chromium.org/173324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the dialog.
This keeps that column from forcing the other columns into a scroll bar when a page with a long title is viewed.
BUG=17930
TEST=none
Review URL: http://codereview.chromium.org/173308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19801
TEST=See bug (on both mac and linux)
Review URL: http://codereview.chromium.org/173341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19728
TEST=install two themes without dismissing info bar. then dismiss the info bar. It shouldn't crash.
Review URL: http://codereview.chromium.org/174349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a general rework of how "crashed extension" infobar works
and how the extension is actually recovered after the crash.
This is a subset of original http://codereview.chromium.org/164151/ .
I had to remove the part which unloads the entire extension on crash,
because it interacts badly with other parts of the browser. I'm fixing that.
TEST=See bug.
http://crbug.com/15888
Review URL: http://codereview.chromium.org/173314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seemed that r24220 caused failures on all of Linux UI (valgrind) bots.
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/173345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.
This forces local storage and database to be enabled on
chrome-extension:// pages.
Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.
erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff
BUG=19511
Review URL: http://codereview.chromium.org/173306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
support.
TEST=none
BUG=19663
Review URL: http://codereview.chromium.org/173095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome extensions.
Last time I tried to check this in, I had to roll
it back because it made installing extensions from
file:// URLs not work.
Turned out that we just have to add a single line
mapping the ".crx" extension to our mimetype.
BUG=13296
TEST=Install an extension from the interweb, it should install. Install an extension from disk, it should install.
Review URL: http://codereview.chromium.org/174380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overriden in derived test classes.
Also making the unique id counter static in order to avoid conflicts with id values handed out from base classes.
Since the id will be used on the other side of automation, it's not enough to make the id generator function overridable. All request IDs must be unique.
R=amit
BUG=none
TEST=Should be no change. Run automation tests.
Review URL: http://codereview.chromium.org/174345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce filter delay to 100ms, add stock icons to dialog buttons,
remove extraneous cookie icons.
BUG=17919
TEST=none
Review URL: http://codereview.chromium.org/173331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=HttpBridgeTest, sync integration
BUG=20182
Review URL: http://codereview.chromium.org/173325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from the menu.
BUG=20137
TEST=Verify that the Chrome menu doesn't contain 'import' or 'clear browsing data' options.
Review URL: http://codereview.chromium.org/149745
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
produce one.
BUG=19994
Review URL: http://codereview.chromium.org/174267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20151
Review URL: http://codereview.chromium.org/174363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also remove the no longer used GTK variable, since the GTK_PATH modification
was a hack for 32-bit binaries on 64-bit distros.
Review URL: http://codereview.chromium.org/173286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix up the bookmark bar border color.
BUG=20139
TEST=none
Review URL: http://codereview.chromium.org/174352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18768
TEST= none
Review URL: http://codereview.chromium.org/174085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
call chrome.devtools.connect() to open up a Port by which it can receive devtools messages to implement the proposed perf trace extensions API documented here:
http://code.google.com/p/chromium/wiki/ExtensionsPerfTraceAPI
Review URL: http://codereview.chromium.org/159882
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some glibc library functions behave a little differently than Windows so this column was not working correctly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/174357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
just up until the first null character.
TEST=HttpBridgeTest
Review URL: http://codereview.chromium.org/174291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
function. This fixes an issue when rendering the tab title where the ellipses are rendered no matter how small the tab is sized. This change also fixes an issue where we were using the default font to determine whether to show the tooltip.
BUG=19741
TEST=Open many tabs. See that the ellipses should disappear when there's no room left in the tab to display them.
Review URL: http://codereview.chromium.org/173300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/18340
Review URL: http://codereview.chromium.org/174328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since we don't have real rounded corners, make the corner look less
blocky and only clip by 3 pixels. This matches the "rounding" of
the bottom of the find box.
Review URL: http://codereview.chromium.org/174344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18540
TEST=Valgrind Mac bots should stay green
Review URL: http://codereview.chromium.org/174293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes a crash that occurs when a small download has
completed quickly, and the download shelf receives two 'complete'
notifications (one at shelf item creation, and one when the
download observer fires).
We detect this case by checking for an existing complete
animation and ignoring the second notification.
BUG=18416 (http://crbug.com/18416)
TEST=Download something, close the window before the animation completes
and notice that Chrome doesn't crash.
Review URL: http://codereview.chromium.org/174326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=20007
TEST=WinAudioTest.PCMWaveStreamPendingBytes
We used to guess what is in the hardware audio buffer to
perform audio sync. But due the triple buffering and
other platforms has other buffering scheme we need to be
able to know how many bytes are left in the hardware buffer.
We provide this data via AudioCallback::OnMoreData(), so we
can predict when the requested buffer will be played.
Review URL: http://codereview.chromium.org/174243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requires --enable-byte-range-support
BUG=12258
TEST=covered by unit tests.
Review URL: http://codereview.chromium.org/173231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by ui_tests.
http://crbug.com/17806
Review URL: http://codereview.chromium.org/174245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
temp_scaffolding_stubs.cc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I left the temporary hack that allows all origins until we are
ready to break everything all at once.
Also, I still need to devise some way to test this.
BUG=12129
Review URL: http://codereview.chromium.org/173166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ie, disabled), when the user
clicks in "Reset to defaults" button.
BUG=7334 (http://crbug.com/7334)
TEST=Download a file, enable "Always open files of this type" from download item
menu, go to Options/Under the
Hood and then click on "Reset to defaults" button.
Contributed by tfarina (thiago.farina@gmail.com)
Review URL: http://codereview.chromium.org/174306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12748 (http://crbug.com/12748)
TEST=Goes to view-source:http://www.google.com/ and see if the menu is enabled.
Review URL: http://codereview.chromium.org/165068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
platforms
AutomationProvider::OverrideEncoding is not implemented yet.
BUG=none
TEST=none
TBR=jshin
Review URL: http://codereview.chromium.org/174305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24077 0039d316-1c4b-4281-b951-d872f2087c98
|