summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Move last shutdown file access off the UI thread and onto the file thread.jam@chromium.org2009-11-252-36/+52
| | | | | | Review URL: http://codereview.chromium.org/437049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33056 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed handling of preferred login info in password manager.tim@chromium.org2009-11-252-15/+31
| | | | | | | | | | | | | BUG=23850 TEST=Go to a login page (i.e. gmail), log in with several different user accounts. Observe that the last used account is now the one that is used for the initial page autofill. Patch by zelidrag@chromium.org Original Review: http://codereview.chromium.org/437032 Review URL: http://codereview.chromium.org/434070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33051 0039d316-1c4b-4281-b951-d872f2087c98
* sync: get rid of path_helpers files.nick@chromium.org2009-11-2515-224/+0
| | | | | | | | | | | Patch from Thiago Farina (thiago.farina@gmail.com) BUG=26443 TEST=None Review URL: http://codereview.chromium.org/414072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33050 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore UTF-8's BOM when parsing userscript's metadata.hayato@chromium.org2009-11-252-1/+21
| | | | | | | | | BUG=27333 TEST=UserScriptTest and check the issue does not happen against userscipt encoded in UTF-8 with BOM.. Review URL: http://codereview.chromium.org/420001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33048 0039d316-1c4b-4281-b951-d872f2087c98
* Posix: Catch SIGHUP/SIGINT and do a clean shutdown.thestig@chromium.org2009-11-251-9/+31
| | | | | | | | BUG=28746 TEST=Ctrl+C = clean shutdown. Review URL: http://codereview.chromium.org/432019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33046 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-2521-127/+130
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a new 'all_frames' property to content scripts andaa@chromium.org2009-11-251-0/+10
| | | | | | | | | | | default it to false. This should improve performance in sites that use frames and elimiate confusion, since in most cases developers *don't* expect content scripts to match frames. Review URL: http://codereview.chromium.org/412008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
* Tiny clean up. Use ASSERT_EQ instead of EXPECT_EQ.hayato@chromium.org2009-11-251-5/+5
| | | | | | | | | BUG=None TEST=UserScriptMasterTest Review URL: http://codereview.chromium.org/434034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33033 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary instrumentation added to track down a crash in URLFetcher.eroman@chromium.org2009-11-251-10/+2
| | | | | | | | | | This is almost a full revert of r31526, except that the two DCHECK(url_request_context_getter_) which I promoted to CHECK()s remain as CHECK()s (since they will be useful to catch similar problems in the future, and are cheap). BUG=27074 Review URL: http://codereview.chromium.org/434050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33026 0039d316-1c4b-4281-b951-d872f2087c98
* Transfer CF downloads to the host browser.TEST=Click a download link (not ↵tommi@chromium.org2009-11-251-0/+3
| | | | | | | | via redirect) in a web page displayed by Chrome Frame. The request should be handled by the host browser.BUG=23561 Review URL: http://codereview.chromium.org/385108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33022 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't send double/triple click events to renderer.estade@chromium.org2009-11-241-0/+2
| | | | | | | | | | This goes along with webkit bug: https://bugs.webkit.org/show_bug.cgi?id=31841 BUG=17466 Review URL: http://codereview.chromium.org/431031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32998 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the window to be moved when dragging on the incognito iconviettrungluu@chromium.org2009-11-241-2/+13
| | | | | | | | | | BUG=25028 TEST=Drag the window from both incognito view and regular window bar while it's in foreground and background Review URL: http://codereview.chromium.org/434030 Patch from feldstein. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32997 0039d316-1c4b-4281-b951-d872f2087c98
* Remove theming from notifications and extension/bookmark sync promo.mirandac@chromium.org2009-11-241-1/+17
| | | | | | | | | | BUG= 28577 TEST= Trigger notification (remove a thumbnail) with themed browser, note that text and link in notification (and in extension/bookmark sync promo) are legible and retain original colors. Review URL: http://codereview.chromium.org/437045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32996 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: make bookmark bar drag buttons prettier.viettrungluu@chromium.org2009-11-243-26/+138
| | | | | | | | | | | (In particular, clip them to their rounded rectangle.) BUG=28593 TEST=Drag bookmark bar buttons with a wide variety of themes; make sure edges/corners are correctly clipped from drag images. Review URL: http://codereview.chromium.org/435028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32995 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --enable-user-script and associated tests.aa@chromium.org2009-11-242-67/+6
| | | | | | | | | | | This doesn't remove the underlying support from UserScriptMaster; that is a riskier change. BUG=27520 Review URL: http://codereview.chromium.org/418043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32987 0039d316-1c4b-4281-b951-d872f2087c98
* Stop opening _all_ notification location changes in a new tab. That was ↵johnnyg@chromium.org2009-11-242-20/+60
| | | | | | | | | | | | | | allowing unwanted popups from a notification with script that sets window.location=foo. Instead override some RVHDelegate::View methods to allow popups to be blocked, and new-tab links to open in new tabs; now regular links will navigate the toast. The view methods are implemented using the standard helper. BUG=28015 TEST=none Review URL: http://codereview.chromium.org/434041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32986 0039d316-1c4b-4281-b951-d872f2087c98
* Move some theme images to being serviced on the IO thread. Fortony@chromium.org2009-11-243-7/+26
| | | | | | | | | | | | | | | | | Linux Release builds on my machine, all the chrome://theme/ image requests block for 300-400ms during browser startup (it's faster after startup). Something is blocking the UI thread so move image requests that aren't themed off the UI thread. This is safe to do because ResourceBundle is thread safe. I still see chrome://theme/theme_ntp_attribution and chrome://theme/theme_ntp_background blocking so I will look into those next (I think with the default theme, they shouldn't be loaded at all). Review URL: http://codereview.chromium.org/440009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
* Fix app icon flicker in loading animationxiyuan@chromium.org2009-11-241-1/+1
| | | | | | | | | | | | | The flicker is caused by setting window title icon while a loading animation is in progress. Fix the problem by skipping window icon update when loading animation is running. BUG=15782 TEST=Verify no flicker while web app loads per Ben's comments. Review URL: http://codereview.chromium.org/436028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32982 0039d316-1c4b-4281-b951-d872f2087c98
* o Updates the browser action buttons when a tab is changed. This is needed ↵andybons@chromium.org2009-11-243-1/+17
| | | | | | | | | | | | for tab-specific browser action buttons. o If a tooltip is not present on a browser action button, clear the tooltip of the button. BUG=28719 TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab. Review URL: http://codereview.chromium.org/434047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32980 0039d316-1c4b-4281-b951-d872f2087c98
* Make notifications permission available in the extension manifest and hook ↵johnnyg@chromium.org2009-11-242-7/+47
| | | | | | | | | | | up to the desktop notification service. BUG=27249 TEST=none Review URL: http://codereview.chromium.org/432005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32979 0039d316-1c4b-4281-b951-d872f2087c98
* Fix page action spacing on Linux.mattm@chromium.org2009-11-242-8/+5
| | | | | | | | | | | Use the same constant for both Linux and Windows. BUG=28660 TEST=load extensions, compare spacing Review URL: http://codereview.chromium.org/440002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32977 0039d316-1c4b-4281-b951-d872f2087c98
* Update the sync menu item to change on Linux to reflect the current sync state.zork@chromium.org2009-11-242-0/+59
| | | | | | | | | BUG=28209 TEST=Enable sync and sign in. The "Sync my Bookmarks" label should now read "Bookmarks Synced..." Review URL: http://codereview.chromium.org/431032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32975 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a flaky dev tools sanity test.ager@chromium.org2009-11-241-3/+0
| | | | | | | | | | | | | | | The test only works if the source of scripts are found in a specific order. This cannot be ensured since the source is found by traversing the heap. The scripts tab is only visible after processing the debugger test page, so only check for visibility in that case. Enable test on Linux again where it passes after this change. TEST=none BUG=26540 Review URL: http://codereview.chromium.org/434044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32968 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildtony@chromium.org2009-11-241-0/+1
| | | | | | | | TBR=arv Review URL: http://codereview.chromium.org/431038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32966 0039d316-1c4b-4281-b951-d872f2087c98
* Merge in part of the last perf change. Move when we initializetony@chromium.org2009-11-242-20/+24
| | | | | | | | | | | | | | | the CSS/HTML for the NTP. This should allow the history query to happen sooner. Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated. Also make sure we only hang on to the original profile. I think the incognito profile can be deleted out from under us when the last incognito window is closed. Review URL: http://codereview.chromium.org/434038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the nonclientframeview for popups on views/gtk drawsky@chromium.org2009-11-241-1/+50
| | | | | | | | | | | | nothing. This is needed as we want the window manager rendering the decorations. BUG=none TEST=none Review URL: http://codereview.chromium.org/436026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32963 0039d316-1c4b-4281-b951-d872f2087c98
* Update Signal Thread to use ref counting and locks to ensure thread safety.zork@chromium.org2009-11-242-2/+3
| | | | | | Review URL: http://codereview.chromium.org/418042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32948 0039d316-1c4b-4281-b951-d872f2087c98
* Disables default browser check and exit menu for toolkit_views onsky@chromium.org2009-11-244-3/+17
| | | | | | | | | | | chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/431029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
* Sets widget created by info bubbles to a custom type so that theysky@chromium.org2009-11-242-0/+14
| | | | | | | | | | | don't get a drop shadow and centered on screen. BUG=none TEST=none Review URL: http://codereview.chromium.org/431021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32936 0039d316-1c4b-4281-b951-d872f2087c98
* Switch theme loading to use its own string.avi@google.com2009-11-243-6/+3
| | | | | | | | | BUG=http://crbug.com/24177 TEST=no visible change Review URL: http://codereview.chromium.org/361006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: improve hover/clicked state appearance of bookmark bar buttons.viettrungluu@chromium.org2009-11-241-33/+56
| | | | | | | | | | | | | I more or less implemented things as per discussion with Cole and Glen. (This does not re-create the appearance on Win Chrome, which is not exactly right either.) BUG=28477 TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states. Review URL: http://codereview.chromium.org/440001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32930 0039d316-1c4b-4281-b951-d872f2087c98
* disable extension toolstrips by default, addingerikkay@chromium.org2009-11-242-0/+8
| | | | | | | | | | | --enable-extension-toolstrips BUG=24475 TEST=Extension*Toolstrip* Review URL: http://codereview.chromium.org/434026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to prevent selecting a popup menu item from crashing when the item is ↵avi@google.com2009-11-241-2/+5
| | | | | | | | | | | auto-opened. BUG=http://crbug.com/28215 TEST=as in bug Review URL: http://codereview.chromium.org/431019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32925 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce DLOG in websocket codeukai@chromium.org2009-11-242-31/+1
| | | | | | | | | BUG=28657 TEST=none Review URL: http://codereview.chromium.org/440005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32919 0039d316-1c4b-4281-b951-d872f2087c98
* Move base64 from 'net/base' into 'base'.hayato@chromium.org2009-11-2411-22/+20
| | | | | | | | | BUG=13572 TEST=none Review URL: http://codereview.chromium.org/399068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Restore omnibox text selection on tab switch.derat@chromium.org2009-11-242-12/+5
| | | | | | | | | | | | | | | | | Tested by: - highlighting omnibox text - switching to a different tab - highlighting some other text - switching back to the first tab - confirming that the omnibox highlighting was restored but PRIMARY didn't get updated when switching back BUG=20674 TEST=see above Review URL: http://codereview.chromium.org/440003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32914 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move the NTP HTML generation to early so we can avoid an extra"tony@chromium.org2009-11-243-23/+20
| | | | | | | | | | | | | It caused New Tab Warm on Windows to regress to the speed before adding the cache on Windows. This reverts commit r32899. TBR=arv Review URL: http://codereview.chromium.org/431024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Create app modal dialogs in a different way to work around a KDE 3 ↵thestig@chromium.org2009-11-248-7/+16
| | | | | | | | | | window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows. BUG=28230 TEST=see bug Review URL: http://codereview.chromium.org/425016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a TODO in post_commit_command.cc. Clarify what's going on.nick@chromium.org2009-11-241-3/+4
| | | | | | Review URL: http://codereview.chromium.org/431023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32904 0039d316-1c4b-4281-b951-d872f2087c98
* Move the NTP HTML generation to early so we can avoid an extratony@chromium.org2009-11-243-20/+23
| | | | | | | | | | | | | trip to the UI thread later. Not sure if this will make a difference. Move the NTP and CSS handler init to after adding the MostVistedHandler. This should allow an earlier db fetch for the cases when the HTML/CSS are not in the cache (e.g., browser startup). Review URL: http://codereview.chromium.org/439013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes extension packing codepath that was hitting a race condition DCHECK ↵andybons@chromium.org2009-11-243-0/+8
| | | | | | | | | | described in http://crbug.com/27944. BUG=28530 TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash. Review URL: http://codereview.chromium.org/436008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame's host network stack implementation for IE full tab mode ↵ananta@chromium.org2009-11-241-14/+6
| | | | | | | | | | | | | | | | | | | | | | | | implicitly follows redirects. When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While this works in most cases, some sites actually returned an error for the second request initiated by Chrome. Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as redirect codes on the same lines as the default http job. Test=covered by existing network tests. I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL. Fixes http://code.google.com/p/chromium/issues/detail?id=28296 Bug=28296 Review URL: http://codereview.chromium.org/402107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32896 0039d316-1c4b-4281-b951-d872f2087c98
* Final part of PathString cleanup.munjal@chromium.org2009-11-2419-383/+284
| | | | | | | | | BUG=26342 TEST+exist Review URL: http://codereview.chromium.org/429003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32894 0039d316-1c4b-4281-b951-d872f2087c98
* Added main menu item for Sync in OS X. (Right below "Preferences..."). Made ↵akalin@chromium.org2009-11-2411-149/+285
| | | | | | | | | | | | | it work without a browser window being present. Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}. BUG=27995 TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in. Review URL: http://codereview.chromium.org/423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when an extension popup shows a JS alert. Showing the alert takes...rafaelw@chromium.org2009-11-245-39/+76
| | | | | | | | | | | | | | | | Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Review URL: http://codereview.chromium.org/435010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
* page info dialog polish:estade@chromium.org2009-11-232-8/+7
| | | | | | | | | | | | | | GTK: - set default size of contents, rather than window as a whole---this gets line wrapping right. All: - change title string to Title Case instead of Sentence case - fix Connection text for mixed/unsafe content BUG=28507 Review URL: http://codereview.chromium.org/437026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ResourceBundle::LoadImageResourceBytes since it appears totony@chromium.org2009-11-237-8/+8
| | | | | | | | | be identical to LoadDataResourceBytes. Migrate callers to LoadDataResourceBytes. Review URL: http://codereview.chromium.org/437019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
* Moved common OpenSyncMyBookmarksDialog() code into SyncStatusUIHelper.akalin@chromium.org2009-11-235-29/+32
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32880 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the ExtensionApiTest.ExecuteScript test as flaky as it failed for no ↵ananta@chromium.org2009-11-231-1/+3
| | | | | | | | | | | | | | | | apparent reason on the vista dbg builder. Issue http://code.google.com/p/chromium/issues/detail?id=28630 has been logged to track this. TBR=aa Bug=28630 Review URL: http://codereview.chromium.org/432010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32866 0039d316-1c4b-4281-b951-d872f2087c98
* Fix environment variables not being used after switching to ↵jam@chromium.org2009-11-233-7/+8
| | | | | | | | | | ChildProcessLauncher. BUG=28602 TEST=verified flash works on Mac Review URL: http://codereview.chromium.org/439005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32854 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 16:12:58 +0000