| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Auth_cache is contained in the http session. We need to share
the http session with the parent profile request context in order to retain http authentication.
Weirdly enough, Profile::GetDefaultRequestContext() is not the same as profile_->GetRequestContext(),
It does NOT yet pop up a dialog if the user hasn't done so already.
BUG=19581
TEST=Included.
Review URL: http://codereview.chromium.org/241001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ChromeFrame Active Document
server. This allows the document server to receive a number of menu events like Find, View->Text Size, etc.
Thanks to Stoyan for helping me debug this :)
Clicking on Edit->Find in the menu in IE with this causes IEFrame to call our Active document's Exec implementation
with the IDM_FIND command. The handling here is to invoke our default Find handling. Added support for
honoring user text size selections. The next thing to be done is to honor the current text size setting while
launching Chrome.
I also fixed the rgs files to have LF as the terminating character.
This fixes Bug http://code.google.com/p/chromium/issues/detail?id=23667
Bug=23667
Review URL: http://codereview.chromium.org/243082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23906
Review URL: http://codereview.chromium.org/257058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=5168,5169
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/257043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/246100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, the crash could be repro'ed as follows (it also occurred under other circumstances as well): Have a window with one or more tabs in it. Create a new window with a single tab. Drag the tab in the new window, and while dragging right-click (and release).
This patch also prevents right-clicks while dragging from stopping the drag.
BUG=23591
TEST=See above.
Review URL: http://codereview.chromium.org/242139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based mostly on Ben's patch, but made it compile, work, and descoped
moving the bookmark bar around the view heiarchy.
XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view].
BUG=17625
Review URL: http://codereview.chromium.org/246034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Hopefully will solve crash.
BUG=23588
Review URL: http://codereview.chromium.org/258020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This had the bad effect of showing bad/strange menus upon right-click on various buttons or, worse, crashing.
BUG=22148,23606
TEST=Right click on back/forwards buttons (after some navigation so that they're active), page/wrench buttons, and bookmark bar off-the-side button and make sure no menu is shown (and it that it doesn't crash). Also do so when the menu is active/highlighted with menu already showing.
Review URL: http://codereview.chromium.org/251091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/257055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems the added subclassing is causing crashers in the field.
BUG=23861
TEST=None
TBR=beng
Review URL: http://codereview.chromium.org/259052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
revert previous checkin (compile failure due to bad merge resolution)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC.
BUG=23832
TEST=run set_page_color extension, when it sets the color, the popup
should close
Review URL: http://codereview.chromium.org/243096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switches for changing the url and size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/246091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
if this gets us more accurate data on new tab times.
BUG=21398
TBR=evanm (ok'ed in person)
Review URL: http://codereview.chromium.org/257052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and leak.
CID=6380
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23858
TEST=none
Review URL: http://codereview.chromium.org/242147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/259050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit merge from 49050:49097.
TEST=none
BUG=23858
Review URL: http://codereview.chromium.org/257049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
call DeleteSoon, not in the destructor. Otherewise the process can be reused in the meantime. This matches what we do in ChildProcessHost.
BUG=21038
Review URL: http://codereview.chromium.org/257028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249057/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
open the keyword editor dialog and press enter.
Review URL: http://codereview.chromium.org/259029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=6325
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/256045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
purify XP leak:
std::_W::_Allocate(unsigned int,wchar_t *) [unit_tests.exe]
Alloc Location
...
chrome/browser/importer/ie_importer.cc IEImporter::StartImport(ProfileInfo,WORD,ImporterBridge *)
base/tuple.h ?DispatchToMethod@VImporter@@P81@AEXUProfileInfo@@GPAVImporterBridge@@@ZU2@GV?$scoped_refptr@VImporterBridge@@@@@@YAXPAVImporter@@P80@AEXUProfileInfo@@GPAVImporterBridge@@@ZABU?$Tuple3@UProfileInfo@@GV?$scoped_refptr@VImporterBridge@@@@@@@Z
^^^
This reverts commit r28007 and r27996.
TBR=jeremy
Review URL: http://codereview.chromium.org/260011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is in support of the next round of rebundling.
TEST=does it still build, do the unit tests still pass, does it still work?
BUG=14610
Review URL: http://codereview.chromium.org/243100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
task manager window.
discoverability++
Review URL: http://codereview.chromium.org/203047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to get the datetime formatting work correctly in a renderer process (e.g. FTP directory list that is now done in a renderer process.)
BUG=23361,23082
TEST=...
Review URL: http://codereview.chromium.org/243060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We don't currently use the zygote to spawn the utility process, so after browser updates bad bugs can occur with mismatched subprocesses. See crbug.com/23327 and crbug.com/22703.
BUG=23327
TEST=Extensions installation/autoupdate and New Tab Page tip download should still work.
Review URL: http://codereview.chromium.org/256036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ImporterHost as preparation for OOPprofile import.
ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process.
This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc.
ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world.
ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface.
There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can.
BUG=14458
TEST=Profile import should continue to work on Windows/Linux & Mac.
Review URL: http://codereview.chromium.org/242091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
off tabs.
BUG=http://crbug.com/19320
BUG=http://crbug.com/23407
BUG=http://crbug.com/20555
TEST=Tearing off a tab with an open infobar should not show a blank transparent space. After tearing off a tab, both find in page and fullscreen should work properly.
Review URL: http://codereview.chromium.org/258012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove the close button outlet (unused)
- add a helper to hide the buttons and resize the text field to use the same.
- if no image, move the text field
- tweak the xib to make it clear the values aren't used
- tweak the xib to remove the NSEveryone image
- make the link text use the control's font so it matches what's in the xib and other infobar modes (if we ever had to tweak it).
- use the GTM helper for autosizing buttons
- reflow how we position the buttons/textfield for the button infobars so it updates the textfield once.
TEST=if you make the window skinny, any infobars that don't have buttons shouldn't reserve space for them. the the plugin crashed info bar shouldn't show a bogus graphic (currently we have none set).
BUG=20535
BUG=19183
Review URL: http://codereview.chromium.org/251075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Encoding menus should have these two capitalized.
BUG=22843
Review URL: http://codereview.chromium.org/251043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get reply if current last last_navigation_time for tab _tracker is great than the input last_navigation_time.
See AutomationProvider::WaitForNavigation, it is handled by IPC_MESSAGE_HANDLER_DELAY_REPLY, which means the message handler need to send the reply message by itself.
According to current WaitForNavigation logic, if current last last_navigation_time for tab _tracker is less than the input last_navigation_time, the replay will be sent by NavigationNotificationObserver. Otherwise, the reply will never be sent.
So if somehow the test machine is slow, the navigation has happened before calling AutomationProvider::WaitForNavigation, the caller will never get reply. That is why TestOverrideEncoding hangs sometimes.
Please refer to http://chrome-svn/viewvc/chrome?view=rev&revision=9585 to see how the logic was changed before.
The problem also happened on other two places.
BUG=23121
TEST=BrowserEncodingTest.TestOverrideEncoding
Review URL: http://codereview.chromium.org/242024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before, too, but now at least it doesn't
cause zombie processes) with an observer that is notified when the user clicks OK/closes the dialog instead of running
a nested message loop and blocking. This fixes bug 20451, where nested message loops were running a confirm dialog and
could cause zombie processes at browser shutdown.
BUG=20451
TEST=None (manual: verify that the confirmation dialog is shown when you try to remove all passwords, and that no zombie is left behind if the browser is closed while the confirmation dialog is showing)
Review URL: http://codereview.chromium.org/243054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GaiaAuthenticator, as it
is never used. This allowed replacing all lock/mutex code with current MessageLoop assertions.
Some temp scaffolding in auth_watcher (e.g creating a message loop for the current pthread),
which will be removed as part of my next trick.
TEST=sync_unit_tests suite, sync_integration_tests suite
BUG=19895
Review URL: http://codereview.chromium.org/251080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
browser_focus_uitest.cc:401: warning: 'unfocused_browser' may be used uninitialized in this function
browser_focus_uitest.cc:400: warning: 'focused_browser' may be used uninitialized in this function
TBR:maruel
Review URL: http://codereview.chromium.org/256050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23268
Review URL: http://codereview.chromium.org/256032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix an off-by-one error in menu rendering if a renderer actually sent us kImpossibleNumberOfPopups.
* Be clearer and stricter about item indexes and sanity checking. Hopefully, this or the previous item fix a crash we saw (no bug filed).
* Add notice support (as much as exists for Windows) to GTK and Mac.
* Make the implementations in the three platforms mirror each other a little more precisely.
* Fix (expected, actual) mis-ordering in Mac unittest.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch
er_host.cc
TBR=darin
TEST=Manually inspected that storage events fired. Will turn on more layout tests in a
subsequent patch.
BUG=19972
Original review URL: http://codereview.chromium.org/223013
Review URL: http://codereview.chromium.org/258010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a 5mb quota to DOM Storage. Most of the details are in an upstream patch (https://bugs.webkit.org/show_bug.cgi?id=29991 ).
BUG=16876
TEST=I added a layout test upstream and it works.
Review URL: http://codereview.chromium.org/255050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves a bunch of methods from glue to the WebKit API.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/246079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
clipboard_util to clipboard_util_win since it's Windows-only. This patch makes
test_shell depend on app as well. There should be no logic change.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/260003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=animations still work: infobar, findbar, download shelf
Review URL: http://codereview.chromium.org/255071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into the gfx namespace.
Combine the PNGEncoder and PNGDecoder. There were separate when we had
different executables for the browser and renderer, and linked the encoder only
in one of them (which saved us some space used by libpng). This hasn't been the
case for years, so combining them (again) makes sense.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/243076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view. This is needed
for system keyboard messages which are generated when the Alt key is pressed in addition to other
keys to function correctly in ChromeFrame.
The TabContentsView implementation for windows does the right thing by specifically checking for keydown
events before processing them as accelerators. The TabContentsView implementation for Linux also treated
keyup messages as accelerators, which is now fixed.
This fixes parts of http://code.google.com/p/chromium/issues/detail?id=22996
Bug=22996
Review URL: http://codereview.chromium.org/255028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27925 0039d316-1c4b-4281-b951-d872f2087c98
|