summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* (1) If you create tabs and manage to resize the window before themaruel@chromium.org2009-01-221-1/+12
| | | | | | | | | | | | | | | | | pending layout occurs, you get truncated tabs (As described in issue 6505). Upon resize therefore we reset the reserved width for tabs. (2) When inserting a tab as the second-to-last tab, the size of tabs was incorrect. This lead to shriking tabs in multiple cases (as described in issue 3258). BUG=6505 BUG=3258 Patch contributed by Itai Danan <idanana@google.com> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8496 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Parse more user script info out of the manifest and expose"aa@chromium.org2009-01-228-424/+216
| | | | | | | | This reverts commit fc3fd1062c06f803775c16d11f742d85d540e415. Review URL: http://codereview.chromium.org/18681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8494 0039d316-1c4b-4281-b951-d872f2087c98
* More scaffolding for back/forward/reload/home, start of WebContentspinkerton@google.com2009-01-223-21/+51
| | | | | | Review URL: http://codereview.chromium.org/18507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8493 0039d316-1c4b-4281-b951-d872f2087c98
* remove the NSToolbar, improve the appearance a little bit. ObjC style member ↵pinkerton@google.com2009-01-222-27/+10
| | | | | | | | names. Review URL: http://codereview.chromium.org/18501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8492 0039d316-1c4b-4281-b951-d872f2087c98
* Change spell check dictionary download URL to now include edgedlsidchat@google.com2009-01-221-1/+1
| | | | | | | BUG=1592281 Review URL: http://codereview.chromium.org/18631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8487 0039d316-1c4b-4281-b951-d872f2087c98
* Parse more user script info out of the manifest and exposeaa@chromium.org2009-01-228-216/+424
| | | | | | | | | | | | | | | | | it on the Extension class. Removed Extension::CopyToValue() because it was only being used in unit tests. Centralize functions for creation of absolute URLs and paths to extension resources in Extension class and move corresponding unit tests. Various other minor nitpickery. Review URL: http://codereview.chromium.org/18352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit tests buildbrettw@chromium.org2009-01-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8481 0039d316-1c4b-4281-b951-d872f2087c98
* Fix messed up include path.brettw@chromium.org2009-01-221-3/+3
| | | | | | Review URL: http://codereview.chromium.org/18512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8479 0039d316-1c4b-4281-b951-d872f2087c98
* More Linux fixing.brettw@chromium.org2009-01-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8475 0039d316-1c4b-4281-b951-d872f2087c98
* More liunx bustage.brettw@chromium.org2009-01-221-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8472 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully fix Mac & Linux build.brettw@chromium.org2009-01-221-5/+5
| | | | | | Review URL: http://codereview.chromium.org/18673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8471 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of browser and into either renderer_host or tab_contents.brettw@chromium.org2009-01-2267-597/+217
| | | | | | | This also fixes a crash in the web contents unit test in a commented-out test and re-enable it. Review URL: http://codereview.chromium.org/18504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8470 0039d316-1c4b-4281-b951-d872f2087c98
* Disables another SSL test as it is causing hangs.sky@google.com2009-01-221-1/+2
| | | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/18665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8461 0039d316-1c4b-4281-b951-d872f2087c98
* Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII("").deanm@chromium.org2009-01-2211-26/+26
| | | | | | Review URL: http://codereview.chromium.org/18499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8454 0039d316-1c4b-4281-b951-d872f2087c98
* The WebContents CL broke unit testscpu@google.com2009-01-221-0/+3
| | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=8416 Blind attempt to fix it. TBR=brettw Review URL: http://codereview.chromium.org/18648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8441 0039d316-1c4b-4281-b951-d872f2087c98
* Move automation specific accessors to their own interface to make their ↵ben@chromium.org2009-01-226-18/+48
| | | | | | | | purpose clear, and make porting easier. Review URL: http://codereview.chromium.org/18481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8435 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move win_util.h to Windows specific blockagl@chromium.org2009-01-221-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/18483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8434 0039d316-1c4b-4281-b951-d872f2087c98
* More speedup of scrolling when many windowed plugins in a page. Scrolling ↵jam@chromium.org2009-01-224-27/+47
| | | | | | | | | | | | is now at parity with single process browsers in my testing. This works by making painting of child windows asynchronous. The key is to send, not post, the custom message. This allows the redraw message to jump the queue and get dispatched before other queued [Windows, IPC] messages, which eliminates painting artifacts. Now that painting is asynchronous, I had to take out the SWP_NOREDRAW flag to DeferWindowPos. While it's slightly faster without it, the visual aritfacts are noticable. Review URL: http://codereview.chromium.org/18637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8432 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Get render_process_host to build.agl@chromium.org2009-01-229-72/+124
| | | | | | | | | | | | This is an adopted CL from Evan. Original: http://codereview.chromium.org/14504 (see original for review comments etc) Review URL: http://codereview.chromium.org/16814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8430 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a timing issue that caused gears to fail to load sometimes.mpcomplete@google.com2009-01-212-7/+5
| | | | | | | | BUG=http://b/issue?id=1559007 BUG=http://code.google.com/p/chromium/issues/detail?id=4219 Review URL: http://codereview.chromium.org/18604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8417 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out the test web contents from the WebContents unit test so that it canbrettw@chromium.org2009-01-2110-389/+454
| | | | | | | | | | be used by other tests. Properly hook up the MockRenderProcessHost so it gets created when initialized by SiteInstances through a factory object. Fix other bugs with the test harness I found when I switched all the WebContents test over to using it. Review URL: http://codereview.chromium.org/18432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8416 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SecondLaunch unit test.evan@chromium.org2009-01-211-1/+2
| | | | | | | | | BUG=6722 Review URL: http://codereview.chromium.org/18472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8410 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 6520 by ensuring that InfoBarClosed is called whenever a tab is ↵tim@chromium.org2009-01-215-27/+12
| | | | | | | | | | | closed or a navigation to a URL that is not supported by the current TabContentsType takes place by invoking it on all InfoBarDelegates from TabContents::Destroy(), which is the best least-common-denominator I've found for doing this work. Alternatively I could have made InfoBarDelegate listen for TAB_CONTENTS_DESTROYED and self-invoke InfoBarClosed but that seemed unorthodox (relatively speaking). This prevents InfoBarDelegates from leaking in these cases. BUG=6520 Review URL: http://codereview.chromium.org/18381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8406 0039d316-1c4b-4281-b951-d872f2087c98
* Disables another flakey interstitial uit test:(sky@google.com2009-01-211-1/+3
| | | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/18634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8392 0039d316-1c4b-4281-b951-d872f2087c98
* Fix p13n build break due to a change in CommandLine class.munjal@chromium.org2009-01-211-1/+2
| | | | | | | | | This was not noticed since this code only builds if CHROME_PERSONALIZATION is defined. Review URL: http://codereview.chromium.org/18618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8391 0039d316-1c4b-4281-b951-d872f2087c98
* add basic command handling for browser window and for where there are no ↵pinkerton@google.com2009-01-216-5/+110
| | | | | | | | windows open. Can now create new browser windows. Review URL: http://codereview.chromium.org/18458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8387 0039d316-1c4b-4281-b951-d872f2087c98
* * Revert "POSIX: Get render_process_host to build."agl@chromium.org2009-01-219-125/+73
| | | | | | | | | * Revert "Build fix: release builds seemed to break" Review URL: http://codereview.chromium.org/18460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8386 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: release builds seemed to breakagl@chromium.org2009-01-211-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/18459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8385 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Get render_process_host to build.agl@chromium.org2009-01-219-73/+124
| | | | | | | | | | | | This is an adopted CL from Evan. Original: http://codereview.chromium.org/14504 (see original for review comments etc) Review URL: http://codereview.chromium.org/16814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8384 0039d316-1c4b-4281-b951-d872f2087c98
* Disables an interstitial test that occassionally fails.sky@google.com2009-01-211-1/+3
| | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/18621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8381 0039d316-1c4b-4281-b951-d872f2087c98
* Get browser window showing using a Browser object and accompanying ↵pinkerton@google.com2009-01-2110-26/+427
| | | | | | | | scaffolding. Adds browser window controller and shim from NSWindow to BrowserWindow. Review URL: http://codereview.chromium.org/18368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8364 0039d316-1c4b-4281-b951-d872f2087c98
* Discard corrupt old logs in UMA uploadjar@chromium.org2009-01-211-6/+11
| | | | | | | | | | | | Detect logs that are unacceptable to the server, and don't retransmit them (it won't help to send them again). bug= 1505736 r=huanr,evanm Review URL: http://codereview.chromium.org/18444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8361 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the scons buildben@chromium.org2009-01-211-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8357 0039d316-1c4b-4281-b951-d872f2087c98
* actually re-enable the testtc@google.com2009-01-211-1/+1
| | | | | | | | TBR=ben Review URL: http://codereview.chromium.org/18441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8355 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation wrappers. Move the methods from AutomationProxy to the ↵stoyan@chromium.org2009-01-216-39/+21
| | | | | | | | appropriate classes. Review URL: http://codereview.chromium.org/18335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8351 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher would happen if you navigate to a page triggering an interstitial ↵jcampan@chromium.org2009-01-211-11/+2
| | | | | | | | | | | | | | | from the new tab page, then press back in the interstitial. The crasher would happen because the navigation controller collects (destroys) the previous tab contents when a navigation is initiated. In this case, when navigating back (by just discarding the non committed entries), it would not be expect that the tab contents would be NULL. It seems we do not need to collect the unused tab contents on NavigateToPendingEntry() since we are collecting any unused TabContents in NavigationController::RendererDidNavigate(). BUG=6408 TEST=From the new page, enter the URL to a malware site (ex: http://ianfette.org), press Back (or close the tab), there should be no crash. Review URL: http://codereview.chromium.org/18433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8350 0039d316-1c4b-4281-b951-d872f2087c98
* Correct icon/title sizing/placement for varying titlebar font sizes. This ↵pkasting@chromium.org2009-01-211-23/+78
| | | | | | | | | | | matches Windows pixel-for-pixel except where we adjust things slightly in restored mode to look better with our frame shape, and in occasional cases where our scaling differs slightly, mainly because the Windows icon caching makes it almost impossible to tell what the "correct" Windows behavior actually is. This depends on my oustanding "fix scaled icon problems" change. BUG=5054 Review URL: http://codereview.chromium.org/18396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some problems with scaled icons. This allows the TabIconView to ↵pkasting@chromium.org2009-01-213-12/+42
| | | | | | | | | automatically scale the throbber and favicon to whatever size the View itself is. Notably, this does NOT change tab_renderer.cc, which _also_ draws favicons -- the former is used by app windows and the latter by standard tabs. Argh! I'm not going to bother unifying these for now even though it'd be nice, since we never scale up our tabs, just our app titlebars. BUG=5054 Review URL: http://codereview.chromium.org/18392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8348 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-2128-132/+130
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a unittest which has never passedagl@chromium.org2009-01-211-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/18437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8346 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs that resulted in misplaced downloads and missingpaulg@google.com2009-01-212-2/+3
| | | | | | | | | | | file names in the download page. BUG=6335 (crbug.com/6335 - "Download location ignored") Review URL: http://codereview.chromium.org/18388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8342 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary unit tests (now we're just using ObserverList).ben@chromium.org2009-01-201-24/+0
| | | | | | | TBR=pinkerton Review URL: http://codereview.chromium.org/18386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8336 0039d316-1c4b-4281-b951-d872f2087c98
* Disables a couple of consistently flakey/hanging tests.sky@google.com2009-01-202-3/+6
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/18384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8334 0039d316-1c4b-4281-b951-d872f2087c98
* Scons updates for about:internets removal.brettw@chromium.org2009-01-201-3/+0
| | | | | | Review URL: http://codereview.chromium.org/18415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8333 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the command updater to not be dependent on views::Button (needed for ↵ben@chromium.org2009-01-2026-781/+535
| | | | | | | | | porting). TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list. Review URL: http://codereview.chromium.org/18343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
* disable WindowSessionEnd which was failing in debugtc@google.com2009-01-201-1/+1
| | | | | | | | | | this seemed to be due to rolling forward the browser window change. TBR=ben Review URL: http://codereview.chromium.org/18429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8324 0039d316-1c4b-4281-b951-d872f2087c98
* Add more production logging to diagnose upload problemjar@chromium.org2009-01-201-27/+29
| | | | | | | | | | | | | | | It appears that some logs get "stuck" trying to be sent, so I've changed a number of DLOG() calls to LOG() calls. I also added a bit of info to the LOG() calls, and made minor edits. bug=1505736 r=evanm Review URL: http://codereview.chromium.org/18354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix purify errors in previous testing patch.brettw@chromium.org2009-01-202-3/+13
| | | | | | Review URL: http://codereview.chromium.org/18409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8293 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "revert r8217 until memory tests are fixed." This re-applies r8217.tc@google.com2009-01-204-56/+8
| | | | | | | | | | | This reverts commit r8245. TBR=ben Review URL: http://codereview.chromium.org/18410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8292 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the about:internets view :(brettw@chromium.org2009-01-206-135/+2
| | | | | | | | This will make it diffitult to remove the tab contents type system and to port, so I'm sadly removing it. Review URL: http://codereview.chromium.org/18408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8283 0039d316-1c4b-4281-b951-d872f2087c98